Jonah Williams
8167e14475
[Impeller] partial repaint for Impeller/iOS. ( flutter/engine#40959 )
...
Implements partial repaint for Impeller.
Fixes https://github.com/flutter/flutter/issues/124526
The new code that manages the damage regions is more or less a copy paste from the existing Skia implementation. Compared to Skia, there are a few differences:
Normally Impeller wants to use the drawable as the resolve texture for the root MSAA pass. Unfortunately this will unconditonally clear that texture. Thus to do a partial repaint, we have to allocate a separate texture to resolve to and then blit into the drawable.
The blit seems to take about 500ns for a full screen on an iPhone 13. That implies that partial repaint is likely not worth doing if the screen is significantly changed. Thus I've added code in compositor_context.cc that computes the percentage of width or height that is part of the dirty rect. Above a threshold of (abitrarily chosen) 70%, we just render as normal. This should mean there is only a very minor hit from performing the diff on screens that are highly changed.
The other special case, is that sometimes we get damage rects that are empty - that is the drawable is already completely up to date with what we want to render. IN that case I shortcircuit all of the impeller code and just present immediately. I previously tried returning without a present but this resulted in Xcode reporting dropped frames. One caveat here is that if you use the XCode frame debugger and attempt to capture a frame where we early present, then it will claim it couldn't capture any command buffers (because we didn't create any).
To facilitate all of this, I added some additonal plumbing so that the impeller surface can get the clip rect from the submit info. Additionally, rather than using a clip rect impeller will translate and then shrink the root surface texture. This reduces memory usage compared to just clippling.
2023-04-26 21:13:03 +00:00
gaaclarke
276fce5441
Updated todo with github issue link ( flutter/engine#41517 )
...
followup from https://github.com/flutter/engine/pull/41490
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-26 13:09:50 -07:00
Jonah Williams
70457cca4f
[Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. ( flutter/engine#41374 )
...
This reduces the cost of uploading the glyph atlas, as we can exploit metal's capabilies to create a texture from a device buffer and share the underlying memory with a linear texture. This also means that subsequent updates don't require uploads or copies either.
From scrolling through wonderous, this shaves off about 0.2 ms (0.6 ms -> 0.4 ms) of fresh atlas construction.
2023-04-26 19:45:05 +00:00
Zachary Anderson
c8c65d837a
Download and use the goma client from cipd ( flutter/engine#41488 )
...
In https://github.com/flutter/flutter/issues/125361 we discovered that a
new version of clang can require updating goma in order for goma to work
properly. This PR adds a dependency on CIPD goma to the DEPS file so
that we can update it for use in local builds when needed. Since CI does
its own management of the goma client and the compiler proxy, and since
goma can only be used by Googlers, the DEPS file download is guarded
behind the `use_cipd_goma` gclient var. To use it one would update the
engine `.gclient` file to be something like:
```
~/flutter/engine/src $ cat ../.gclient
solutions = [
{
"managed": False,
"name": "src/flutter",
"url": "git@github.com:zanderso/engine.git",
"custom_deps": {},
"custom_vars": {
"use_cipd_goma": True,
},
"deps_file": "DEPS",
"safesync_url": "",
},
]
```
I'll update the wiki with these instructions after this PR lands.
2023-04-26 11:30:07 -07:00
godofredoc
ea69f2504d
Migrate Windows AOT Engine to Engine V2. ( flutter/engine#41515 )
...
Both builds are generating artifacts in the same way. This is moving the legacy builder to staging and updating Windows windows_aot_engine build to upload artifacts to prod.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-26 17:56:21 +00:00
Brandon DeRosier
1a2dfa3522
[Impeller] Store the root stencil on iOS ( flutter/engine#41509 )
...
Switch the root RenderPass stencil from transient to device private, add
validation logs, and dry the offscreen stencil setup. Also make the
multisample root stencil setup valid in Vulkan (the attachment
mismatched the texture -- this didn't matter before since we were always
replacing it).
Fixes a bug where the stencil gets erased between root render passes --
this issue was introduced when we removed the root blit on iOS.
2023-04-26 10:51:12 -07:00
Brandon DeRosier
280c4f0e46
[Impeller] iOS/macOS: Only wait for command scheduling prior to present (redux) ( flutter/engine#41501 )
...
Reverts https://github.com/flutter/engine/pull/40895 .
Resolves https://github.com/flutter/flutter/issues/120399 (again).
A bunch of frames get pumped on the main thread _without a transaction_
just before unmerging occurs (I don't know why this happens), and so
checking the current thread to determine whether we need to present with
a transaction or not isn't sufficient. In the prior fix, after the
unmerge, the raster thread would hang for one second while waiting for
the next drawable to get freed up (happens on the second raster thread
frame post-unmerge), and then subsequent presents would just do nothing
for a while, but eventually recover.
`presentsWithTransaction` works whether the `CATransaction` stack is
empty or not, and so the only difference here is that
`presentsWithTransaction` is always turned on and `presentDrawable` is
always avoided (otherwise it tries to present too early and nothing
renders when platform views are present).
2023-04-26 10:50:51 -07:00
gaaclarke
98718ceb9b
[Impeller] removed collisions of dead command pools between tests. ( flutter/engine#41490 )
...
fixes https://github.com/flutter/flutter/issues/125321
Tests coverage from existing tests (see issue).
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-26 10:23:28 -07:00
skia-flutter-autoroll
3dad6c5612
Roll Skia from a0e3fa5aa947 to 3fea88565a83 (3 revisions) ( flutter/engine#41516 )
...
https://skia.googlesource.com/skia.git/+log/a0e3fa5aa947..3fea88565a83
2023-04-26 johnstiles@google.com Improve RP code generation for negation.
2023-04-26 johnstiles@google.com Add immediate-mode bitwise xor.
2023-04-26 johnstiles@google.com Remove bitwise_not SkRP ops.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 17:23:18 +00:00
skia-flutter-autoroll
a1d2863cc5
Roll Skia from 47cfc5a2f0a0 to a0e3fa5aa947 (1 revision) ( flutter/engine#41514 )
...
https://skia.googlesource.com/skia.git/+log/47cfc5a2f0a0..a0e3fa5aa947
2023-04-26 sharaks@google.com Update Skia milestone to 115
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 15:30:18 +00:00
skia-flutter-autoroll
cac896118c
Roll Skia from 5085ba92075b to 47cfc5a2f0a0 (4 revisions) ( flutter/engine#41512 )
...
https://skia.googlesource.com/skia.git/+log/5085ba92075b..47cfc5a2f0a0
2023-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b01372cf570a to 66646c61d508 (3 revisions)
2023-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b58ef53abced to d37c97d18a21 (21 revisions)
2023-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c0e5813a9b77 to 3076b4c0d8ce (4 revisions)
2023-04-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8f39f2978ef8 to dec3646b8299 (14 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 13:10:04 +00:00
Jia Hao
2b0b0a0e78
Log dlopen errors in opt builds ( flutter/engine#41477 )
...
As the Engine uses `dlopen` to find the `libapp.so`, https://github.com/flutter/flutter/issues/59834 can happen which will prevent `dlopen` from finding the binary. In theory this should be mitigated by https://github.com/flutter/engine/pull/9762 , but an internal customer observed errors that could be related.
The additional logging here can help to rule out that hypothesis. For Googlers, see b/276657840 for more details.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-26 08:16:05 +00:00
Dan Field
38c9a9aa6f
Roll vulkan-deps and vs_toolchain ( flutter/engine#41455 )
...
Rolls vulkan-deps to https://chromium.googlesource.com/vulkan-deps/+/40b75117a60b11c42a1fb87bf14c0f49bcdb8b3d
2023-04-26 04:10:11 +00:00
skia-flutter-autoroll
f496b5b47c
Roll Skia from 809bf518d4ab to 22132575fceb (2 revisions) ( flutter/engine#41497 )
...
https://skia.googlesource.com/skia.git/+log/809bf518d4ab..22132575fceb
2023-04-25 johnstiles@google.com Push constant-value scalar/splat-vector variables as literal values.
2023-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a52479099cf2 to b01372cf570a (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-26 01:57:36 +00:00
godofredoc
59d89a96a1
Migrate windows host engine to engine v2. ( flutter/engine#41487 )
...
Windows host engine and windows_engine_host_engine builds are generating the artifacts using gn+ninja. This PR is sending the legacy build to staging and starts uploading the engine v2 artifacts to prod.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-25 23:58:22 +00:00
skia-flutter-autoroll
725b2ffbc6
Roll Skia from f6f0c4b5ee98 to 809bf518d4ab (3 revisions) ( flutter/engine#41494 )
...
https://skia.googlesource.com/skia.git/+log/f6f0c4b5ee98..809bf518d4ab
2023-04-25 johnstiles@google.com Simplify 'push, immediate-op, pop' to just 'immediate-op'.
2023-04-25 johnstiles@google.com Guard against overflow issue in RP approx_pow2.
2023-04-25 kjlubick@google.com Remove unnecessary include of SkEncodedImageFormat
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 23:47:02 +00:00
gaaclarke
c2ebd9ebc2
Made sure not to turn on wide gamut support without impeller. ( flutter/engine#41460 )
...
fixes https://github.com/flutter/flutter/issues/125430
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-25 22:27:21 +00:00
skia-flutter-autoroll
7519b785e3
Roll Skia from 1bed4228ea3b to f6f0c4b5ee98 (7 revisions) ( flutter/engine#41492 )
...
https://skia.googlesource.com/skia.git/+log/1bed4228ea3b..f6f0c4b5ee98
2023-04-25 kjlubick@google.com Replace more SkASSERTs with SkDEBUGFAIL
2023-04-25 jmbetancourt@google.com [skottie] pass slotID to Opacity callback
2023-04-25 johnstiles@google.com Add immediate mode ops to SkRP.
2023-04-25 kjlubick@google.com Move cross-context image to use DeferredFromTextureGenerator
2023-04-25 johnstiles@google.com Remove SkVM-specific command line flags.
2023-04-25 fmalita@chromium.org [skottie] Clean up deprecated ImageAsset API
2023-04-25 johnstiles@google.com Remove line numbers from SkRP dumps.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 21:57:44 +00:00
gaaclarke
185d95a35d
[Impeller] Fixed blit command missing tracking and added mock vulkan for tests ( flutter/engine#41408 )
...
Adds test for https://github.com/flutter/engine/pull/41347 and adds an
extra fix for https://github.com/flutter/flutter/issues/125147 .
Testing this is possible because I've mocked out all of vulkan. We can
expand on this in the future we want to be more robust.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-25 14:45:04 -07:00
godofredoc
fbb3fc3af8
Double zip FlutterMacOS.dSYM.zip. ( flutter/engine#41425 )
...
The flutter tool is expecting FlutterMacOS.dSYM.zip to be double zipped.
Bug: https://github.com/flutter/flutter/issues/124911
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-25 21:02:06 +00:00
Jim Graham
d05d99805f
hide DisplayList::DisposeOps and other lint suggestions ( flutter/engine#41464 )
...
Fixes https://github.com/flutter/flutter/issues/125428
Note that these are lint-type fixes and so there are no tests for them.
2023-04-25 19:46:26 +00:00
Srujan Gaddam
e253aeff60
Remove package:js references and move to dart:js_interop ( flutter/engine#41212 )
...
dart:js_interop and package:js will start conflicting. Eventually, we
want people to only use dart:js_interop, so this CL refactors code to do
that.
Unblocks https://dart-review.googlesource.com/c/sdk/+/294130/8 and
prevents confusing shadowing of dart:js_interop annotations like we do
today.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [Mentioned CL that is unblocked] I listed at least one issue that this
PR fixes in the description above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [Need test-exemption] I added new tests to check the change I am
making, or this PR is [test-exempt].
- [X] All existing and new tests are passing.
2023-04-25 12:20:12 -07:00
林洵锋
2c3afe9b15
[ios] Fix hold and drag spacebar does not move cursor when obscureText is true. ( flutter/engine#40216 )
...
Fixes [flutter/flutter#122139 ](https://github.com/flutter/flutter/issues/122139 ) with flutter pr [flutter/flutter#122383 ](https://github.com/flutter/flutter/pull/122383 )
2023-04-25 17:56:56 +00:00
skia-flutter-autoroll
7e0bed752f
Roll Skia from c44f06399619 to 1bed4228ea3b (1 revision) ( flutter/engine#41482 )
...
https://skia.googlesource.com/skia.git/+log/c44f06399619..1bed4228ea3b
2023-04-25 kjlubick@google.com replace SkASSERT(! with SkDEBUGFAIL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 14:08:21 +00:00
skia-flutter-autoroll
3704fb44e3
Roll Skia from 571074c14049 to 7a0879961df5 (1 revision) ( flutter/engine#41478 )
...
https://skia.googlesource.com/skia.git/+log/571074c14049..7a0879961df5
2023-04-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 83a6fdf2e118 to 8f39f2978ef8 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 10:25:40 +00:00
skia-flutter-autoroll
844941e663
Roll Skia from 9b1b2a5dd899 to 571074c14049 (1 revision) ( flutter/engine#41476 )
...
https://skia.googlesource.com/skia.git/+log/9b1b2a5dd899..571074c14049
2023-04-25 blundell@chromium.org [Dawn] Set stencil state only if using stencil
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 08:37:23 +00:00
skia-flutter-autoroll
1a9bc7dfbb
Roll Fuchsia Linux SDK from 8TJtGsJTpIHk5-Ss5... to xfKYQ2vkoLvxhBHIf... ( flutter/engine#41474 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 07:28:05 +00:00
skia-flutter-autoroll
803a272db0
Roll Skia from 5f4dd36a69f9 to 8822608fcb4d (2 revisions) ( flutter/engine#41469 )
...
https://skia.googlesource.com/skia.git/+log/5f4dd36a69f9..8822608fcb4d
2023-04-24 johnstiles@google.com Reorder struct for better Neon codegen.
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4b61bdad813f to 79949f0f1146 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-25 04:14:09 +00:00
godofredoc
465c5dc0a7
[Cleanup] remove type=local from local test/generators. ( flutter/engine#41465 )
...
The `"type": "local"` property from local test and generators was never used. Removing from configurations.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-25 02:53:06 +00:00
Jonah Williams
78d8124320
Revert "[impeller] convert src over to src for solid color" ( flutter/engine#41466 )
...
Reverts flutter/engine#41351
2023-04-25 00:49:11 +00:00
godofredoc
fe21fedc1e
Remove empty tests properties. ( flutter/engine#41461 )
...
Tests property is optional, empty tests property can be safely removed from the build configurations.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-24 23:03:16 +00:00
skia-flutter-autoroll
fd65498026
Roll Skia from 0ec4c84abd0b to 5f4dd36a69f9 (21 revisions) ( flutter/engine#41462 )
...
https://skia.googlesource.com/skia.git/+log/0ec4c84abd0b..5f4dd36a69f9
2023-04-24 johnstiles@google.com Add release note for SkRP.
2023-04-24 jamesgk@google.com Early-out instead of asserting in make_vk_backend_texture
2023-04-24 istepancar@gmail.com fix(*): fix links in canvaskit readme
2023-04-24 sunnyps@chromium.org graphite: Split backend include sources in build
2023-04-24 johnstiles@google.com Create dedicated SkRP op for matrix-multiply.
2023-04-24 brianosman@google.com (Reland) Always run color space math in full-float
2023-04-24 johnstiles@google.com Use packed contexts for small swizzles in SkRP.
2023-04-24 cmumford@google.com Switch to putting new release notes in //relnotes/
2023-04-24 johnstiles@google.com Eliminate SkVM-specific features from Viewer.
2023-04-24 johnstiles@google.com Rewrite ES2 loop-test conditions that use !=.
2023-04-24 egdaniel@google.com [Graphite] Add support for purgeNotUsedSinced to ResourceCache.
2023-04-24 brianosman@google.com Remove SkXfermode and SkXfermode_opts
2023-04-24 kjlubick@google.com Add minimal viewer build with Bazel.
2023-04-24 michaelludwig@google.com [skif] Cleanup FilterResultTest to prep for color filters
2023-04-24 michaelludwig@google.com [skif] Inline FilterResult::concatTransform() into applyTransform()
2023-04-24 johnstiles@google.com Eliminate SkVM-specific bots.
2023-04-24 brianosman@google.com Remove xfermode support from legacy shader blitter
2023-04-24 johnstiles@google.com Eliminate 'skia_compare_vm_vs_rp' benchmarking code.
2023-04-24 johnstiles@google.com Increase the arena stack size in onFilterColor4f.
2023-04-24 johnstiles@google.com Add a pad_stack op to the RP builder.
2023-04-24 johnstiles@google.com Eliminate SkVM unit tests for debug tracing.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 22:41:17 +00:00
godofredoc
2e49be471e
Reland "Upload windows arm artifacts to production bucket." ( flutter/engine#41409 )
...
Reverts flutter/engine#41372
The duplicated artifacts were removed from Windows Host Engine in https://flutter-review.googlesource.com/c/recipes/+/42340 . After the recipes change lands and is propagated it will be safe to update the `Windows windows_arm_host_engine` build to upload the artifacts to prod.
Bug: https://github.com/flutter/flutter/issues/125262
2023-04-24 21:17:24 +00:00
keyonghan
b896507aea
Add 16.2 runtime to Mac unopt ( flutter/engine#41456 )
...
Fixes: https://github.com/flutter/flutter/issues/124408
2023-04-24 19:55:21 +00:00
skia-flutter-autoroll
526f2abfa6
Roll Skia from 1f84e5060646 to 0ec4c84abd0b (6 revisions) ( flutter/engine#41449 )
...
https://skia.googlesource.com/skia.git/+log/1f84e5060646..0ec4c84abd0b
2023-04-24 kjlubick@google.com Remove SkImageEncoder and SkImage::encodeToData
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 60517cf84231 to 4b61bdad813f (1 revision)
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 77d86c4a7ecc to b58ef53abced (11 revisions)
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 83a6fdf2e118 to fab3b205b6c7
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 003e879fd974 to d2b5bd140525 (14 revisions)
2023-04-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f5a15d80499c to 83a6fdf2e118 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com ,rmistry@google.com ,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-24 13:57:52 +00:00
dependabot[bot]
06b8eef0d8
Bump actions/setup-python from 4.5.0 to 4.6.0 ( flutter/engine#41444 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.5.0 to 4.6.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-python/releases ">actions/setup-python's releases</a>.</em></p>
<blockquote>
<h2>Add allow-prereleases input</h2>
<p>In scope of this release we added a new input (<code>allow-prereleases</code>) to allow <a href="https://redirect.github.com/actions/setup-python/pull/414 ">falling back to pre-release versions of Python when a matching GA version of Python is not available</a></p>
<pre lang="yaml"><code>steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: 3.12
allow-prereleases: true
</code></pre>
<p>Besides, we added such changes as:</p>
<ul>
<li>Fix bug to trim new line for PyPy version: <a href="https://redirect.github.com/actions/setup-python/pull/610 ">actions/setup-python#610</a></li>
<li>Added pip dependency file to generate hash from it: <a href="https://redirect.github.com/actions/setup-python/pull/604 ">actions/setup-python#604</a></li>
<li>Improved error handling for saving and restoring cache: <a href="https://redirect.github.com/actions/setup-python/pull/618 ">actions/setup-python#618</a></li>
<li>Add warning if cache paths are empty: <a href="https://redirect.github.com/actions/setup-python/pull/642 ">actions/setup-python#642</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="57ded4d7d5https://redirect.github.com/actions/setup-python/issues/655 ">#655</a>)</li>
<li><a href="df6abcc733https://redirect.github.com/actions/setup-python/issues/652 ">#652</a>)</li>
<li><a href="7a4f344e33https://redirect.github.com/actions/setup-python/issues/642 ">#642</a>)</li>
<li><a href="d1244c8404https://redirect.github.com/actions/setup-python/issues/641 ">#641</a>)</li>
<li><a href="3091b37310https://redirect.github.com/actions/setup-python/issues/637 ">#637</a>)</li>
<li><a href="dfa76f8d0dhttps://redirect.github.com/actions/setup-python/issues/622 ">#622</a>)</li>
<li><a href="03eb867e3dhttps://redirect.github.com/actions/setup-python/issues/618 ">#618</a>)</li>
<li><a href="b41aaf9f0chttps://redirect.github.com/actions/setup-python/issues/621 ">#621</a> from akv-platform/reusable-workflow</li>
<li><a href="0ffa49cfcaec365b4ebahttps://redirect.github.com/actions/setup-python/issues/617 ">#617</a>)</li>
<li>Additional commits viewable in <a href="d27e3f3d7c...57ded4d7d5https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-python&package-manager=github_actions&previous-version=4.5.0&new-version=4.6.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-04-24 10:13:05 +00:00
skia-flutter-autoroll
f253f78e2a
Roll Fuchsia Linux SDK from I9z-K7N5PdhXN-5SG... to 1RnHwa4NRXqe4iS6H... ( flutter/engine#41428 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-23 06:39:10 +00:00
skia-flutter-autoroll
623c2fd396
Roll Fuchsia Linux SDK from RdOaZ2-aDsn_64hk5... to I9z-K7N5PdhXN-5SG... ( flutter/engine#41424 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 16:43:38 +00:00
skia-flutter-autoroll
48672abb9c
Roll Dart SDK from be6db2b60a41 to fd4797c1464b (2 revisions) ( flutter/engine#41422 )
...
https://dart.googlesource.com/sdk.git/+log/be6db2b60a41..fd4797c1464b
2023-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-34.0.dev
2023-04-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-33.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com ,chinmaygarde@google.com ,dart-vm-team@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 15:33:04 +00:00
skia-flutter-autoroll
b8244e7e08
Roll Skia from 9912500bcca3 to b9c90858cdd8 (2 revisions) ( flutter/engine#41421 )
...
https://skia.googlesource.com/skia.git/+log/9912500bcca3..b9c90858cdd8
2023-04-22 johnstiles@google.com Preserve SkRP execution masks when calling to/fromLinearSrgb.
2023-04-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 172c51ea9b08 to 60517cf84231 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 15:31:21 +00:00
skia-flutter-autoroll
a49c2876c9
Roll Skia from aa592c60846d to 36a6690cd1f1 (11 revisions) ( flutter/engine#41413 )
...
https://skia.googlesource.com/skia.git/+log/aa592c60846d..36a6690cd1f1
2023-04-21 johnstiles@google.com Ignore SkVM-related flags when SK_ENABLE_SKVM is not defined.
2023-04-21 johnstiles@google.com Fix lifetime issue with deferred uniforms in SkRP.
2023-04-21 brianosman@google.com Fully remove legacy sprite blitters for everything but SrcOver
2023-04-21 johnstiles@google.com Revert "Disable SkVM by default."
2023-04-21 johnstiles@google.com Disable SkVM by default.
2023-04-21 jvanverth@google.com [graphite] Still more steps to get dm running with Vulkan
2023-04-21 johnstiles@google.com Simplify shuffle instruction-encoding in RP builder.
2023-04-21 rmistry@google.com Update "directly ping rmistry@" documentation
2023-04-21 johnstiles@google.com Move #ifdef guards to fix Chrome roll.
2023-04-21 fmalita@chromium.org [skottie] Plumb new text direction property
2023-04-21 blundell@chromium.org [Graphite] Return null when color type not found in DawnCaps.cpp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-22 01:26:25 +00:00
skia-flutter-autoroll
46b36722ee
Roll Fuchsia Linux SDK from Edv0I0o8GQ7c0z8XK... to RdOaZ2-aDsn_64hk5... ( flutter/engine#41407 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 23:29:05 +00:00
Jason Simmons
6f5ee7f984
[Impeller] Add a CommandBuffer::WaitUntilScheduled API ( flutter/engine#41303 )
...
This can be used by IO thread operations such as image decoding to ensure that the results of GPU commands become visible to the raster thread.
2023-04-21 19:08:04 +00:00
gaaclarke
b6818a0773
[Impeller] Turned off the TextRotated golden test again ( flutter/engine#41399 )
...
We previously turned this test to `ignore` to see if we could get it to stabilize by accepting the variants and it doesn't seem to have worked. I'm going to turn it off again.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-21 18:26:10 +00:00
skia-flutter-autoroll
041e2f267d
Roll Skia from 5754b81988b8 to aa592c60846d (11 revisions) ( flutter/engine#41398 )
...
https://skia.googlesource.com/skia.git/+log/5754b81988b8..aa592c60846d
2023-04-21 skia-autoroll@skia-public.iam.gserviceaccount.com (Manual) Roll Dawn from 9e9c4560752a to 003e879fd974 (22 revisions)
2023-04-21 johnstiles@google.com Eliminate redundant register/stack exchanges.
2023-04-21 ccameron@chromium.org SkJpeg: Update gainmap encode and decode to reflect spec changes
2023-04-21 johnstiles@google.com Wrap SkVM with #ifdef SK_ENABLE_SKVM.
2023-04-21 johnstiles@google.com Wrap remaining usage of SkVM with #ifdef SK_ENABLE_SKVM.
2023-04-21 johnstiles@google.com Wrap SkSLVMCodeGenerator with #ifdef SK_ENABLE_SKVM.
2023-04-21 johnstiles@google.com Wrap SkColorFilter/Blender::onProgram calls with #ifdef SK_ENABLE_SKVM.
2023-04-21 johnstiles@google.com Reland "Wrap SkShader::program calls with #ifdef SK_ENABLE_SKVM."
2023-04-21 kjlubick@google.com Expose SkPixmapUtils
2023-04-21 kjlubick@google.com Move most of the Ganesh code out of SkImage_Base and SkImage_Lazy
2023-04-21 michaelludwig@google.com Fix anisotropic subset check in GrTextureEffect
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com ,jmbetancourt@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 17:48:45 +00:00
gaaclarke
3d7eeccb55
[impeller] fixed flake where blit wasn't tracking its texture ( flutter/engine#41347 )
...
fixes https://github.com/flutter/flutter/issues/125147
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-21 10:45:26 -07:00
Prashant Andoriya
238f79d114
removing the check_gn_format.py file from ci/ ( flutter/engine#41397 )
...
Delete obsolete empty script.
fixes: flutter/flutter#100741
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
- [+] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [+] I signed the [CLA].
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-21 17:26:34 +00:00
David Iglesias
dfd9ef5e60
[web] Fix HashUrlStrategy.addPopStateListener ( flutter/engine#41384 )
...
During a JS-interop refactor, we introduced a small bug in the `addPopStateListener` method of the `HashUrlStrategy` object (web).
This wasn't caught before because the existing tests were mocking the refactored code.
## Issues
Fixes: https://github.com/flutter/flutter/issues/125228
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-04-21 17:26:31 +00:00
Brandon DeRosier
549dd82f2f
[Impeller] Fix division by zero for transparent shadows ( flutter/engine#41391 )
...
A division by zero happens if the shadow color is fully transparent, and
the NaNs are getting assigned to the RGB values of the paint color being
handed to the rrect shadow draw. This doesn't cause a problem when wide
gamut is off because NaN output ends up being interpreted as zero (thus
making the shadow output fully transparent black, which happens to be
the expected and correct result). However, when a wide gamut attachment
is present, the NaN output ends up being interpreted as a negative
value.
Reproduction app:
```dart
import 'package:flutter/material.dart';
void main() => runApp(const GeneralDialogApp());
class EvilPainter extends CustomPainter {
@override
void paint(Canvas canvas, Size size) {
final Rect rect = Offset.zero & size;
canvas.drawPaint(Paint()..color = Colors.white);
canvas.saveLayer(null, Paint()..blendMode = BlendMode.srcOver);
canvas.drawShadow(Path()..addRect(Rect.fromLTRB(100, 100, 300, 300)),
Colors.black54, 15, false);
canvas.drawShadow(Path()..addRect(Rect.fromLTRB(100, 100, 300, 300)),
Colors.black54, 15, false);
canvas.drawShadow(Path()..addRect(Rect.fromLTRB(100, 100, 300, 300)),
Colors.transparent, 15, false);
canvas.restore();
}
@override
bool shouldRepaint(EvilPainter oldDelegate) => false;
@override
bool shouldRebuildSemantics(EvilPainter oldDelegate) => false;
}
class GeneralDialogApp extends StatelessWidget {
const GeneralDialogApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
restorationScopeId: 'app',
home: CustomPaint(painter: EvilPainter()),
);
}
}
```
Before:
After:
2023-04-21 08:58:05 -07:00
skia-flutter-autoroll
6df3a85712
Roll Fuchsia Linux SDK from PqBDstaESE_l77k1e... to Edv0I0o8GQ7c0z8XK... ( flutter/engine#41393 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-21 09:21:09 +00:00
