From ef71d9d956bc11378142d62e4d35b4eb3cbe037b Mon Sep 17 00:00:00 2001 From: Ian Hickson Date: Sun, 12 Aug 2018 00:16:43 -0700 Subject: [PATCH] Increase timeouts because some CI systems are REALLY SLOW. (#20396) --- dev/automated_tests/test_smoke_test/timeout_pass_test.dart | 4 ++-- packages/flutter_test/lib/src/binding.dart | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dev/automated_tests/test_smoke_test/timeout_pass_test.dart b/dev/automated_tests/test_smoke_test/timeout_pass_test.dart index f161a38ac3..fa50ba70fd 100644 --- a/dev/automated_tests/test_smoke_test/timeout_pass_test.dart +++ b/dev/automated_tests/test_smoke_test/timeout_pass_test.dart @@ -7,7 +7,7 @@ import 'package:flutter_test/flutter_test.dart'; void main() { testWidgets('flutter_test timeout logic - addTime - positive', (WidgetTester tester) async { await tester.runAsync(() async { - await new Future.delayed(const Duration(milliseconds: 3500)); - }, additionalTime: const Duration(milliseconds: 2000)); + await new Future.delayed(const Duration(milliseconds: 2500)); // must be longer than default timeout. + }, additionalTime: const Duration(milliseconds: 2000)); // default timeout is 2s, so this makes it 4s. }); } diff --git a/packages/flutter_test/lib/src/binding.dart b/packages/flutter_test/lib/src/binding.dart index 8f2547762e..60415608ce 100644 --- a/packages/flutter_test/lib/src/binding.dart +++ b/packages/flutter_test/lib/src/binding.dart @@ -695,7 +695,7 @@ class AutomatedTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding { _currentFakeAsync.elapse(duration); _phase = newPhase; if (hasScheduledFrame) { - addTime(const Duration(milliseconds: 100)); + addTime(const Duration(milliseconds: 500)); _currentFakeAsync.flushMicrotasks(); handleBeginFrame(new Duration( milliseconds: _clock.now().millisecondsSinceEpoch, @@ -710,7 +710,7 @@ class AutomatedTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding { @override Future runAsync(Future callback(), { - Duration additionalTime = const Duration(milliseconds: 250), + Duration additionalTime = const Duration(milliseconds: 1000), }) { assert(additionalTime != null); assert(() {