From dc8f103ca845bc5657a816252ebbdc68a5a2b32e Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Mon, 31 Jul 2017 16:18:27 -0700 Subject: [PATCH] Check for an empty selection in deleteSurroundingText (flutter/engine#3938) Fixes https://github.com/flutter/flutter/issues/11437 --- .../io/flutter/plugin/editing/InputConnectionAdaptor.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/engine/src/flutter/shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java b/engine/src/flutter/shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java index a70e1e0cfc..4f2088fdf7 100644 --- a/engine/src/flutter/shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java +++ b/engine/src/flutter/shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java @@ -90,6 +90,10 @@ class InputConnectionAdaptor extends BaseInputConnection { @Override public boolean deleteSurroundingText(int beforeLength, int afterLength) { + if (Selection.getSelectionStart(mEditable) == -1 || + Selection.getSelectionStart(mEditable) == -1) + return true; + boolean result = super.deleteSurroundingText(beforeLength, afterLength); updateEditingState(); return result;