forked from firka/flutter
Remove redundant useMaterial3: true (#163376)
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> This PR removes redundant useMaterial3: true as described in https://github.com/flutter/flutter/issues/162818 *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* - https://github.com/flutter/flutter/issues/162818 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
This commit is contained in:
@@ -23,7 +23,7 @@ class ComplexLayoutAppState extends State<ComplexLayoutApp> {
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
return MaterialApp(
|
||||
theme: lightTheme ? ThemeData.light() : ThemeData.dark(),
|
||||
theme: lightTheme ? ThemeData() : ThemeData.dark(),
|
||||
title: 'Advanced Layout',
|
||||
home:
|
||||
scrollMode == ScrollMode.complex
|
||||
|
||||
@@ -20,11 +20,7 @@ class PlatformViewApp extends StatefulWidget {
|
||||
class PlatformViewAppState extends State<PlatformViewApp> {
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
return MaterialApp(
|
||||
theme: ThemeData.light(),
|
||||
title: 'Advanced Layout',
|
||||
home: const PlatformViewLayout(),
|
||||
);
|
||||
return const MaterialApp(title: 'Advanced Layout', home: PlatformViewLayout());
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -40,7 +40,6 @@ class PlatformViewAppState extends State<PlatformViewApp> {
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
return MaterialApp(
|
||||
theme: ThemeData.light(),
|
||||
title: 'Advanced Layout',
|
||||
home: Scaffold(
|
||||
appBar: AppBar(title: const Text('Platform View Ad Banners')),
|
||||
|
||||
@@ -44,7 +44,6 @@ class PlatformViewAppState extends State<PlatformViewApp> {
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
return MaterialApp(
|
||||
theme: ThemeData.light(),
|
||||
title: 'Advanced Layout',
|
||||
home: Scaffold(
|
||||
appBar: AppBar(title: const Text('Platform View Bottom Ad Banner')),
|
||||
|
||||
@@ -22,11 +22,7 @@ class PlatformViewApp extends StatefulWidget {
|
||||
class PlatformViewAppState extends State<PlatformViewApp> {
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
return MaterialApp(
|
||||
theme: ThemeData.light(),
|
||||
title: 'Advanced Layout',
|
||||
home: const PlatformViewLayout(),
|
||||
);
|
||||
return const MaterialApp(title: 'Advanced Layout', home: PlatformViewLayout());
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -20,11 +20,7 @@ class PlatformViewApp extends StatefulWidget {
|
||||
class PlatformViewAppState extends State<PlatformViewApp> {
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
return MaterialApp(
|
||||
theme: ThemeData.light(),
|
||||
title: 'Advanced Layout',
|
||||
home: const PlatformViewLayout(),
|
||||
);
|
||||
return const MaterialApp(title: 'Advanced Layout', home: PlatformViewLayout());
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -24,11 +24,7 @@ class PlatformViewApp extends StatefulWidget {
|
||||
class PlatformViewAppState extends State<PlatformViewApp> {
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
return MaterialApp(
|
||||
theme: ThemeData.light(),
|
||||
title: 'Advanced Layout',
|
||||
home: const PlatformViewLayout(),
|
||||
);
|
||||
return const MaterialApp(title: 'Advanced Layout', home: PlatformViewLayout());
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -176,7 +176,7 @@ over water meant for the whole central valley of California? The story will shoc
|
||||
final ThemeData _fortnightlyTheme = _buildFortnightlyTheme();
|
||||
|
||||
ThemeData _buildFortnightlyTheme() {
|
||||
final ThemeData base = ThemeData.light();
|
||||
final ThemeData base = ThemeData();
|
||||
return base.copyWith(
|
||||
primaryTextTheme: _buildTextTheme(base.primaryTextTheme),
|
||||
scaffoldBackgroundColor: Colors.white,
|
||||
|
||||
@@ -81,7 +81,7 @@ IconThemeData _customIconTheme(IconThemeData original) {
|
||||
}
|
||||
|
||||
ThemeData _buildShrineTheme() {
|
||||
final ThemeData base = ThemeData.light();
|
||||
final ThemeData base = ThemeData();
|
||||
return base.copyWith(
|
||||
colorScheme: kShrineColorScheme,
|
||||
primaryColor: kShrinePink100,
|
||||
|
||||
@@ -15,7 +15,7 @@ IconThemeData _customIconTheme(IconThemeData original, Color color) {
|
||||
}
|
||||
|
||||
ThemeData _buildCraneTheme() {
|
||||
final ThemeData base = ThemeData.light();
|
||||
final ThemeData base = ThemeData();
|
||||
|
||||
return base.copyWith(
|
||||
colorScheme: const ColorScheme.light().copyWith(
|
||||
|
||||
@@ -509,7 +509,7 @@ List<Widget> buildVideoPreviewItems(BuildContext context) {
|
||||
}
|
||||
|
||||
ThemeData buildTheme(BuildContext context) {
|
||||
final TextTheme lightTextTheme = ThemeData.light().textTheme;
|
||||
final TextTheme lightTextTheme = ThemeData().textTheme;
|
||||
return ThemeData(
|
||||
scaffoldBackgroundColor: Colors.white,
|
||||
appBarTheme: AppBarTheme(
|
||||
|
||||
@@ -150,7 +150,7 @@ class _RestorableEmailState extends RestorableListenable<EmailStore> {
|
||||
}
|
||||
|
||||
ThemeData _buildReplyLightTheme(BuildContext context) {
|
||||
final ThemeData base = ThemeData.light();
|
||||
final ThemeData base = ThemeData();
|
||||
return base.copyWith(
|
||||
bottomAppBarTheme: const BottomAppBarTheme(color: ReplyColors.blue700),
|
||||
bottomSheetTheme: BottomSheetThemeData(
|
||||
|
||||
@@ -21,7 +21,7 @@ IconThemeData _customIconTheme(IconThemeData original) {
|
||||
}
|
||||
|
||||
ThemeData _buildShrineTheme() {
|
||||
final ThemeData base = ThemeData.light();
|
||||
final ThemeData base = ThemeData();
|
||||
return base.copyWith(
|
||||
appBarTheme: const AppBarTheme(systemOverlayStyle: SystemUiOverlayStyle.dark, elevation: 0),
|
||||
scaffoldBackgroundColor: shrineBackgroundWhite,
|
||||
|
||||
Reference in New Issue
Block a user