From cbe269808b8ab073ace3a1e4e6a1f0e46998e197 Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Thu, 16 Jan 2025 13:52:18 -0800 Subject: [PATCH] Enable duplicate `linux_host_engine_test`. (#161613) Towards https://github.com/flutter/flutter/issues/161406. * Enables (on presubmit), and adds a missing GN target. * Removes tests from the `linux_host_engine` build. --- engine/src/flutter/.ci.yaml | 2 -- .../ci/builders/linux_host_engine_test.json | 30 ++++++++++++++++--- 2 files changed, 26 insertions(+), 6 deletions(-) diff --git a/engine/src/flutter/.ci.yaml b/engine/src/flutter/.ci.yaml index 7879c56776..63d336cda8 100644 --- a/engine/src/flutter/.ci.yaml +++ b/engine/src/flutter/.ci.yaml @@ -321,8 +321,6 @@ targets: - name: Linux linux_host_engine_test recipe: engine_v2/engine_v2 - # TODO(matanlurey): https://github.com/flutter/flutter/issues/161406. - bringup: true timeout: 120 properties: config_name: linux_host_engine_test diff --git a/engine/src/flutter/ci/builders/linux_host_engine_test.json b/engine/src/flutter/ci/builders/linux_host_engine_test.json index 9d36f79bdd..779e569cd3 100644 --- a/engine/src/flutter/ci/builders/linux_host_engine_test.json +++ b/engine/src/flutter/ci/builders/linux_host_engine_test.json @@ -29,7 +29,10 @@ "ninja": { "config": "ci/host_debug_test", "targets": [ - "flutter:unittests" + "flutter:unittests", + "flutter/build/dart:copy_dart_sdk", + "flutter/shell/testing", + "flutter/tools/path_ops" ] }, "tests": [ @@ -73,9 +76,26 @@ "ninja": { "config": "ci/host_profile_test", "targets": [ - "flutter:unittests" + "flutter:unittests", + "flutter/build/dart:copy_dart_sdk", + "flutter/shell/testing", + "flutter/tools/path_ops" ] - } + }, + "tests": [ + { + "language": "python3", + "name": "Host Tests for host_profile", + "script": "flutter/testing/run_tests.py", + "parameters": [ + "--variant", + "ci/host_profile_test", + "--type", + "dart,dart-host,engine", + "--engine-capture-core-dump" + ] + } + ] }, { "drone_dimensions": [ @@ -109,7 +129,7 @@ "config": "ci/host_release_test", "targets": [ "flutter:unittests", - "flutter/build/archives:flutter_patched_sdk", + "flutter/build/dart:copy_dart_sdk", "flutter/display_list:display_list_benchmarks", "flutter/display_list:display_list_builder_benchmarks", "flutter/display_list:display_list_region_benchmarks", @@ -118,6 +138,8 @@ "flutter/impeller/geometry:geometry_benchmarks", "flutter/lib/ui:ui_benchmarks", "flutter/shell/common:shell_benchmarks", + "flutter/shell/testing", + "flutter/tools/path_ops", "flutter/third_party/txt:txt_benchmarks" ] },