Remove outdated ignores (#162773)

Powered by the new and amazing `unnecessary_ignore` lint.

We're not enabling this lint by default because being able to
temporarily use ignores that don't ignore anything is a powerful tool to
enable migrations. We should turn this lint on locally periodically,
though, and clean up all outdated ignores.

dev/a11y_assessments/test/home_page_test.dart

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: avoid_dynamic_calls
-
 import 'package:a11y_assessments/main.dart';
 import 'package:a11y_assessments/use_cases/action_chip.dart';
 import 'package:a11y_assessments/use_cases/auto_complete.dart';

dev/devicelab/bin/tasks/build_android_host_app_with_module_aar.dart

@@ -437,7 +437,6 @@ class ModuleTest {
 Future<void> main() async {
   await task(
     combine(<TaskFunction>[
-      // ignore: avoid_redundant_argument_values
       ModuleTest(gradleVersion: '8.4').call,
       ModuleTest(gradleVersion: '8.4-rc-3').call,
     ]),

dev/devicelab/bin/tasks/build_android_host_app_with_module_source.dart

@@ -407,10 +407,5 @@ class ModuleTest {
 }
 
 Future<void> main() async {
-  await task(
-    combine(<TaskFunction>[
-      // ignore: avoid_redundant_argument_values
-      ModuleTest(gradleVersion: '8.7').call,
-    ]),
-  );
+  await task(combine(<TaskFunction>[ModuleTest(gradleVersion: '8.7').call]));
 }

dev/integration_tests/display_cutout_rotation/test_driver/display_cutout_test_test.dart

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: avoid_print
-
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';

dev/integration_tests/link_hook/lib/link_hook_bindings_generated.dart

@@ -2,10 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// ignore_for_file: always_specify_types
-// ignore_for_file: camel_case_types
-// ignore_for_file: non_constant_identifier_names
-
 // AUTO GENERATED FILE, DO NOT EDIT.
 //
 // Generated by `package:ffigen`.

dev/integration_tests/new_gallery/lib/data/demos.dart

@@ -1036,11 +1036,7 @@ class Demos {
             description: localizations.demoCupertinoPickerDescription,
             documentationUrl: '$_docsBaseUrl/cupertino/CupertinoDatePicker-class.html',
             buildRoute:
-                (_) => DeferredWidget(
-                  cupertinoLoader,
-                  // ignore: prefer_const_constructors
-                  () => cupertino_demos.CupertinoPickerDemo(),
-                ),
+                (_) => DeferredWidget(cupertinoLoader, () => cupertino_demos.CupertinoPickerDemo()),
           ),
         ],
         category: GalleryDemoCategory.cupertino,
@@ -1056,11 +1052,8 @@ class Demos {
             description: localizations.demoCupertinoScrollbarDescription,
             documentationUrl: '$_docsBaseUrl/cupertino/CupertinoScrollbar-class.html',
             buildRoute:
-                (_) => DeferredWidget(
-                  cupertinoLoader,
-                  // ignore: prefer_const_constructors
-                  () => cupertino_demos.CupertinoScrollbarDemo(),
-                ),
+                (_) =>
+                    DeferredWidget(cupertinoLoader, () => cupertino_demos.CupertinoScrollbarDemo()),
           ),
         ],
         category: GalleryDemoCategory.cupertino,

dev/integration_tests/new_gallery/lib/routes.dart

@@ -55,28 +55,20 @@ class RouteConfiguration {
     ),
     Path(
       r'^' + rally_routes.homeRoute,
-      (BuildContext context, String? match) => StudyWrapper(
-        study: DeferredWidget(
-          rally.loadLibrary,
-          () => rally.RallyApp(),
-        ), // ignore: prefer_const_constructors
-      ),
+      (BuildContext context, String? match) =>
+          StudyWrapper(study: DeferredWidget(rally.loadLibrary, () => rally.RallyApp())),
     ),
     Path(
       r'^' + shrine_routes.homeRoute,
-      (BuildContext context, String? match) => StudyWrapper(
-        study: DeferredWidget(
-          shrine.loadLibrary,
-          () => shrine.ShrineApp(),
-        ), // ignore: prefer_const_constructors
-      ),
+      (BuildContext context, String? match) =>
+          StudyWrapper(study: DeferredWidget(shrine.loadLibrary, () => shrine.ShrineApp())),
     ),
     Path(
       r'^' + crane_routes.defaultRoute,
       (BuildContext context, String? match) => StudyWrapper(
         study: DeferredWidget(
           crane.loadLibrary,
-          () => crane.CraneApp(), // ignore: prefer_const_constructors
+          () => crane.CraneApp(),
           placeholder: const DeferredLoadingPlaceholder(name: 'Crane'),
         ),
       ),
@@ -84,16 +76,11 @@ class RouteConfiguration {
     Path(
       r'^' + fortnightly_routes.defaultRoute,
       (BuildContext context, String? match) => StudyWrapper(
-        study: DeferredWidget(
-          fortnightly.loadLibrary,
-          // ignore: prefer_const_constructors
-          () => fortnightly.FortnightlyApp(),
-        ),
+        study: DeferredWidget(fortnightly.loadLibrary, () => fortnightly.FortnightlyApp()),
       ),
     ),
     Path(
       r'^' + reply_routes.homeRoute,
-      // ignore: prefer_const_constructors
       (BuildContext context, String? match) =>
           const StudyWrapper(study: reply.ReplyApp(), hasBottomNavBar: true),
     ),

dev/snippets/lib/src/util.dart

@@ -263,7 +263,6 @@ SampleStats getSampleStats(SourceElement element) {
 
 /// Exit the app with a message to stderr.
 /// Can be overridden by tests to avoid exits.
-// ignore: prefer_function_declarations_over_variables
 void Function(String message) errorExit = (String message) {
   io.stderr.writeln(message);
   io.exit(1);