From c2e95e79be99510a5ba1b4e335e1cf45989e4e0b Mon Sep 17 00:00:00 2001 From: Victoria Ashworth <15619084+vashworth@users.noreply.github.com> Date: Fri, 10 Nov 2023 07:00:01 -0600 Subject: [PATCH] Temporarily disable test UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays (flutter/engine#47883) `UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays` seems to fail pretty flakily on macOS 13.6.1. Temporarily disabling until we can find a solution (https://github.com/flutter/flutter/issues/138193). [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style --- engine/src/flutter/testing/scenario_app/run_ios_tests.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/engine/src/flutter/testing/scenario_app/run_ios_tests.sh b/engine/src/flutter/testing/scenario_app/run_ios_tests.sh index 772ea3b962..8ac15c6db1 100755 --- a/engine/src/flutter/testing/scenario_app/run_ios_tests.sh +++ b/engine/src/flutter/testing/scenario_app/run_ios_tests.sh @@ -61,12 +61,15 @@ zip_and_upload_xcresult_to_luci () { echo "Running simulator tests with Skia" echo "" +# TODO(vashworth): Stop skipping testMultiplePlatformViewsWithOverlays once +# https://github.com/flutter/flutter/issues/138193 is resolved if set -o pipefail && xcodebuild -sdk iphonesimulator \ -scheme Scenarios \ -resultBundlePath "$RESULT_BUNDLE_PATH/ios_scenario.xcresult" \ -destination 'platform=iOS Simulator,OS=16.2,name=iPhone SE (3rd generation)' \ clean test \ - FLUTTER_ENGINE="$FLUTTER_ENGINE"; then + FLUTTER_ENGINE="$FLUTTER_ENGINE" \ + -skip-testing ScenariosUITests/UnobstructedPlatformViewTests/testMultiplePlatformViewsWithOverlays; then echo "test success." else echo "test failed."