forked from firka/flutter
Revert "Add set semantics enabled API and wire iOS a11y bridge (#1612… (#165901)
…65)"
This reverts commit 26037dff87.
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
PR causes internal test failures
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
@@ -28,7 +28,6 @@ mixin SemanticsBinding on BindingBase {
|
||||
..onSemanticsActionEvent = _handleSemanticsActionEvent
|
||||
..onAccessibilityFeaturesChanged = handleAccessibilityFeaturesChanged;
|
||||
_handleSemanticsEnabledChanged();
|
||||
addSemanticsEnabledListener(_handleFrameworkSemanticsEnabledChanged);
|
||||
}
|
||||
|
||||
/// The current [SemanticsBinding], if one has been created.
|
||||
@@ -155,10 +154,6 @@ mixin SemanticsBinding on BindingBase {
|
||||
performSemanticsAction(decodedAction);
|
||||
}
|
||||
|
||||
void _handleFrameworkSemanticsEnabledChanged() {
|
||||
platformDispatcher.setSemanticsTreeEnabled(semanticsEnabled);
|
||||
}
|
||||
|
||||
/// Called whenever the platform requests an action to be performed on a
|
||||
/// [SemanticsNode].
|
||||
///
|
||||
|
||||
@@ -1,35 +0,0 @@
|
||||
// Copyright 2014 The Flutter Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style license that can be
|
||||
// found in the LICENSE file.
|
||||
|
||||
import 'dart:ui';
|
||||
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
|
||||
void main() {
|
||||
test('SemanticsHandle ensureSemantics calls setSemanticsTreeEnabled', () async {
|
||||
final SemanticsTestBinding binding = SemanticsTestBinding();
|
||||
expect(binding.platformDispatcher.semanticsTreeEnabled, isFalse);
|
||||
final SemanticsHandle handle = binding.ensureSemantics();
|
||||
expect(binding.platformDispatcher.semanticsTreeEnabled, isTrue);
|
||||
handle.dispose();
|
||||
expect(binding.platformDispatcher.semanticsTreeEnabled, isFalse);
|
||||
});
|
||||
}
|
||||
|
||||
class SemanticsTestBinding extends AutomatedTestWidgetsFlutterBinding {
|
||||
@override
|
||||
TestPlatformDispatcherSpy get platformDispatcher => _platformDispatcherSpy;
|
||||
static final TestPlatformDispatcherSpy _platformDispatcherSpy = TestPlatformDispatcherSpy(
|
||||
platformDispatcher: PlatformDispatcher.instance,
|
||||
);
|
||||
}
|
||||
|
||||
class TestPlatformDispatcherSpy extends TestPlatformDispatcher {
|
||||
TestPlatformDispatcherSpy({required super.platformDispatcher});
|
||||
bool semanticsTreeEnabled = false;
|
||||
@override
|
||||
void setSemanticsTreeEnabled(bool enabled) {
|
||||
semanticsTreeEnabled = enabled;
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user