From b6303c5d69d3c469ffe4c4e80b047af49dd5e587 Mon Sep 17 00:00:00 2001 From: Elliott Sprehn Date: Wed, 26 Nov 2014 13:54:14 -0500 Subject: [PATCH] Only allow one shadowRoot. R=ojan@chromium.org Review URL: https://codereview.chromium.org/759663003 --- engine/src/flutter/benchmarks/dom/creation.sky | 2 +- engine/src/flutter/tests/dom/appendChild.sky | 2 +- engine/src/flutter/tests/dom/replaceChild.sky | 2 +- engine/src/flutter/tests/mutation-observer/shadow-dom.sky | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/engine/src/flutter/benchmarks/dom/creation.sky b/engine/src/flutter/benchmarks/dom/creation.sky index 71c9de2373..0f05fe9df8 100644 --- a/engine/src/flutter/benchmarks/dom/creation.sky +++ b/engine/src/flutter/benchmarks/dom/creation.sky @@ -14,7 +14,7 @@ WidgetPrototype.createdCallback = function() { this.wasAttached = false; this.wasDetached = false; this.attrsChanged = []; - this.createShadowRoot(); + this.ensureShadowRoot(); }; WidgetPrototype.attachedCallback = function() { diff --git a/engine/src/flutter/tests/dom/appendChild.sky b/engine/src/flutter/tests/dom/appendChild.sky index 60da8036d7..e9025c9beb 100644 --- a/engine/src/flutter/tests/dom/appendChild.sky +++ b/engine/src/flutter/tests/dom/appendChild.sky @@ -53,7 +53,7 @@ describe("appendChild", function() { it("should throw when inserting a tree scope", function() { var parent = document.createElement("div"); var doc = new Document(); - var shadowRoot = document.createElement("span").createShadowRoot(); + var shadowRoot = document.createElement("span").ensureShadowRoot(); assert.throws(function() { parent.appendChild(doc); }); diff --git a/engine/src/flutter/tests/dom/replaceChild.sky b/engine/src/flutter/tests/dom/replaceChild.sky index 17cc7ad7bb..bfa1d24262 100644 --- a/engine/src/flutter/tests/dom/replaceChild.sky +++ b/engine/src/flutter/tests/dom/replaceChild.sky @@ -67,7 +67,7 @@ describe("replaceChild", function() { it("should throw when inserting a tree scope", function() { var parent = document.createElement("div"); var doc = new Document(); - var shadowRoot = document.createElement("span").createShadowRoot(); + var shadowRoot = document.createElement("span").ensureShadowRoot(); assert.throws(function() { parent.replaceChild(doc); }); diff --git a/engine/src/flutter/tests/mutation-observer/shadow-dom.sky b/engine/src/flutter/tests/mutation-observer/shadow-dom.sky index 43a20f6ba2..f2d1f49b28 100644 --- a/engine/src/flutter/tests/mutation-observer/shadow-dom.sky +++ b/engine/src/flutter/tests/mutation-observer/shadow-dom.sky @@ -13,7 +13,7 @@ describe('MutationObservers', function() { } var range = document.getElementById('range'); - var shadowRoot = range.createShadowRoot(); + var shadowRoot = range.ensureShadowRoot(); shadowRoot.appendChild(document.createElement('div')); var observer = new MutationObserver(function() { });