From 9c791f465e184e32a007893e474f21402accaac3 Mon Sep 17 00:00:00 2001 From: Victoria Ashworth <15619084+vashworth@users.noreply.github.com> Date: Fri, 13 Oct 2023 12:12:02 -0500 Subject: [PATCH] Remove bringup from tests and move some back to presubmit. Reorganize TESTOWNERS. (#136498) We renamed a few tests and therefore had to run them in bringup first (https://github.com/flutter/flutter/pull/136463). This removes bringup and moves some of them back to presubmit. Also, reorganize TESTOWNERS since they're running on hostonly now. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --- .ci.yaml | 18 ++++++++---------- TESTOWNERS | 8 ++++---- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/.ci.yaml b/.ci.yaml index 49d1959074..5cc878fbf7 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -2947,7 +2947,7 @@ targets: - name: Mac_arm64 build_ios_framework_module_test recipe: devicelab/devicelab_drone - bringup: true + presubmit: false timeout: 60 properties: dependencies: >- @@ -3397,7 +3397,7 @@ targets: - name: Mac_arm64 plugin_lint_mac recipe: devicelab/devicelab_drone - bringup: true + presubmit: false timeout: 60 properties: dependencies: >- @@ -3977,7 +3977,6 @@ targets: - name: Mac_x64 hot_mode_dev_cycle_macos_target__benchmark recipe: devicelab/devicelab_drone - bringup: true timeout: 60 properties: dependencies: >- @@ -3993,7 +3992,7 @@ targets: - name: Mac_arm64 hot_mode_dev_cycle_macos_target__benchmark recipe: devicelab/devicelab_drone - bringup: true + presubmit: false timeout: 60 properties: dependencies: >- @@ -4138,7 +4137,7 @@ targets: - name: Mac_x64 macos_chrome_dev_mode recipe: devicelab/devicelab_drone - bringup: true + presubmit: false timeout: 60 properties: dependencies: >- @@ -4151,7 +4150,7 @@ targets: - name: Mac_arm64 macos_chrome_dev_mode recipe: devicelab/devicelab_drone - bringup: true + presubmit: false timeout: 60 properties: dependencies: >- @@ -4188,7 +4187,7 @@ targets: - name: Mac native_assets_ios_simulator recipe: devicelab/devicelab_drone - bringup: true + presubmit: false timeout: 60 properties: dependencies: >- @@ -4336,7 +4335,7 @@ targets: - name: Mac_x64 hot_mode_dev_cycle_ios_simulator recipe: devicelab/devicelab_drone - bringup: true + presubmit: false timeout: 60 properties: dependencies: >- @@ -4465,7 +4464,6 @@ targets: - name: Mac_arm64 run_debug_test_macos recipe: devicelab/devicelab_drone - bringup: true timeout: 60 properties: dependencies: >- @@ -4501,7 +4499,7 @@ targets: - name: Mac_arm64 run_release_test_macos recipe: devicelab/devicelab_drone - bringup: true + presubmit: false timeout: 60 properties: dependencies: >- diff --git a/TESTOWNERS b/TESTOWNERS index 8090c06b1f..51705091ca 100644 --- a/TESTOWNERS +++ b/TESTOWNERS @@ -183,8 +183,6 @@ /dev/devicelab/bin/tasks/fullscreen_textfield_perf_ios__e2e_summary.dart @cyanglaz @flutter/engine /dev/devicelab/bin/tasks/hello_world_ios__compile.dart @vashworth @flutter/engine /dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios__benchmark.dart @cyanglaz @flutter/tool -/dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios_simulator.dart @cyanglaz @flutter/tool -/dev/devicelab/bin/tasks/hot_mode_dev_cycle_macos_target__benchmark.dart @cbracken @flutter/tool /dev/devicelab/bin/tasks/imagefiltered_transform_animation_perf_ios__timeline_summary.dart @cyanglaz @flutter/engine /dev/devicelab/bin/tasks/integration_test_test_ios.dart @cyanglaz @flutter/engine /dev/devicelab/bin/tasks/integration_ui_ios_driver.dart @cyanglaz @flutter/tool @@ -199,10 +197,8 @@ /dev/devicelab/bin/tasks/ios_picture_cache_complexity_scoring_perf__timeline_summary.dart @flar @flutter/engine /dev/devicelab/bin/tasks/ios_platform_view_tests.dart @stuartmorgan @flutter/plugin /dev/devicelab/bin/tasks/large_image_changer_perf_ios.dart @zanderso @flutter/engine -/dev/devicelab/bin/tasks/macos_chrome_dev_mode.dart @zanderso @flutter/tool /dev/devicelab/bin/tasks/microbenchmarks_ios.dart @cyanglaz @flutter/engine /dev/devicelab/bin/tasks/microbenchmarks_ios_xcode_debug.dart @vashworth @flutter/engine -/dev/devicelab/bin/tasks/native_assets_ios_simulator.dart @dacoharkes @flutter/ios /dev/devicelab/bin/tasks/native_assets_ios.dart @dacoharkes @flutter/ios /dev/devicelab/bin/tasks/native_platform_view_ui_tests_ios.dart @hellohuanlin @flutter/ios /dev/devicelab/bin/tasks/new_gallery_ios__transition_perf.dart @zanderso @flutter/engine @@ -261,12 +257,16 @@ /dev/devicelab/bin/tasks/gradle_plugin_light_apk_test.dart @stuartmorgan @flutter/plugin /dev/devicelab/bin/tasks/hello_world_macos__compile.dart @cbracken @flutter/desktop /dev/devicelab/bin/tasks/hello_world_win_desktop__compile.dart @yaakovschectman @flutter/desktop +/dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios_simulator.dart @cyanglaz @flutter/tool +/dev/devicelab/bin/tasks/hot_mode_dev_cycle_macos_target__benchmark.dart @cbracken @flutter/tool /dev/devicelab/bin/tasks/hot_mode_dev_cycle_win_target__benchmark.dart @cbracken @flutter/desktop /dev/devicelab/bin/tasks/integration_ui_test_test_macos.dart @cbracken @flutter/desktop +/dev/devicelab/bin/tasks/macos_chrome_dev_mode.dart @zanderso @flutter/tool /dev/devicelab/bin/tasks/module_custom_host_app_name_test.dart @zanderso @flutter/tool /dev/devicelab/bin/tasks/module_host_with_custom_build_test.dart @zanderso @flutter/tool /dev/devicelab/bin/tasks/module_test.dart @zanderso @flutter/tool /dev/devicelab/bin/tasks/module_test_ios.dart @vashworth @flutter/tool +/dev/devicelab/bin/tasks/native_assets_ios_simulator.dart @dacoharkes @flutter/ios /dev/devicelab/bin/tasks/native_ui_tests_macos.dart @cbracken @flutter/desktop /dev/devicelab/bin/tasks/platform_channel_sample_test_macos.dart @cbracken @flutter/desktop /dev/devicelab/bin/tasks/platform_channel_sample_test_windows.dart @cbracken @flutter/desktop