From 990ae10e5bc8d2e35bb2e1bd7ad23d74df89d3dc Mon Sep 17 00:00:00 2001
From: Matan Lurey <matanlurey@users.noreply.github.com>
Date: Thu, 16 Nov 2023 11:05:02 -0800
Subject: [PATCH] Disable the `runIfNot` clauses in `.ci.yaml`, as they are
 unsafe. (flutter/engine#48132)

See https://github.com/flutter/flutter/issues/138559.

I'll assign this as an infra bug after merging.

/cc @zanderso @dnfield for FYI.
---
 engine/src/flutter/.ci.yaml | 68 ++++++++++++++++++++-----------------
 1 file changed, 36 insertions(+), 32 deletions(-)

diff --git a/engine/src/flutter/.ci.yaml b/engine/src/flutter/.ci.yaml
index cb313b499c..9a4eac1bd1 100644
--- a/engine/src/flutter/.ci.yaml
+++ b/engine/src/flutter/.ci.yaml
@@ -174,14 +174,15 @@ targets:
       # ensure files from pre-production Fuchsia SDK tests are purged from cache
       clobber: "true"
     timeout: 90
-    runIfNot:
-      - lib/web_ui/**
-      - shell/platform/android/**
-      - shell/platform/darwin/**
-      - shell/platform/glfw/**
-      - shell/platform/linux/**
-      - shell/platform/windows/**
-      - web_sdk/**
+    # TODO(https://github.com/flutter/flutter/issues/138559): Re-enable/delete.
+    # runIfNot:
+    #   - lib/web_ui/**
+    #   - shell/platform/android/**
+    #   - shell/platform/darwin/**
+    #   - shell/platform/glfw/**
+    #   - shell/platform/linux/**
+    #   - shell/platform/windows/**
+    #   - web_sdk/**
 
   - name: Linux Fuchsia FEMU
     recipe: engine/femu_test
@@ -194,14 +195,15 @@ targets:
       emulator_arch: "x64"
       enable_cso: "true"
     timeout: 60
-    runIfNot:
-      - lib/web_ui/**
-      - shell/platform/android/**
-      - shell/platform/darwin/**
-      - shell/platform/glfw/**
-      - shell/platform/linux/**
-      - shell/platform/windows/**
-      - web_sdk/**
+    # TODO(https://github.com/flutter/flutter/issues/138559): Re-enable/delete.
+    # runIfNot:
+    #   - lib/web_ui/**
+    #   - shell/platform/android/**
+    #   - shell/platform/darwin/**
+    #   - shell/platform/glfw/**
+    #   - shell/platform/linux/**
+    #   - shell/platform/windows/**
+    #   - web_sdk/**
 
   - name: Linux Fuchsia arm64 FEMU
     recipe: engine/femu_test
@@ -214,14 +216,15 @@ targets:
       enable_cso: "true"
     timeout: 60
     bringup: true
-    runIfNot:
-      - lib/web_ui/**
-      - shell/platform/android/**
-      - shell/platform/darwin/**
-      - shell/platform/glfw/**
-      - shell/platform/linux/**
-      - shell/platform/windows/**
-      - web_sdk/**
+    # TODO(https://github.com/flutter/flutter/issues/138559): Re-enable/delete.
+    # runIfNot:
+    #   - lib/web_ui/**
+    #   - shell/platform/android/**
+    #   - shell/platform/darwin/**
+    #   - shell/platform/glfw/**
+    #   - shell/platform/linux/**
+    #   - shell/platform/windows/**
+    #   - web_sdk/**
 
   - name: Linux linux_fuchsia
     recipe: engine_v2/engine_v2
@@ -231,14 +234,15 @@ targets:
       config_name: linux_fuchsia
     drone_dimensions:
       - os=Linux
-    runIfNot:
-      - lib/web_ui/**
-      - shell/platform/android/**
-      - shell/platform/darwin/**
-      - shell/platform/glfw/**
-      - shell/platform/linux/**
-      - shell/platform/windows/**
-      - web_sdk/**
+    # TODO(https://github.com/flutter/flutter/issues/138559): Re-enable/delete.
+    # runIfNot:
+    #   - lib/web_ui/**
+    #   - shell/platform/android/**
+    #   - shell/platform/darwin/**
+    #   - shell/platform/glfw/**
+    #   - shell/platform/linux/**
+    #   - shell/platform/windows/**
+    #   - web_sdk/**
 
   - name: Linux Framework Smoke Tests
     recipe: engine/framework_smoke