From 923eb765f04509e414e837eb741d2e52c4c0698c Mon Sep 17 00:00:00 2001
From: Michael Goderbauer <goderbauer@google.com>
Date: Tue, 22 Sep 2020 12:57:13 -0700
Subject: [PATCH] Bump dartdoc to 0.34.0 (#66048)

---
 dartdoc_options.yaml | 3 +++
 dev/bots/docs.sh     | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/dartdoc_options.yaml b/dartdoc_options.yaml
index a9aaf208fc..822f9e87ee 100644
--- a/dartdoc_options.yaml
+++ b/dartdoc_options.yaml
@@ -16,6 +16,7 @@ dartdoc:
     # Default errors of dartdoc:
     - duplicate-file
     - invalid-parameter
+    - no-defining-library-found
     - tool-error
     - unresolved-export
     # Warnings that are elevated to errors:
@@ -23,6 +24,7 @@ dartdoc:
     - ambiguous-reexport
     - broken-link
     - category-order-gives-missing-package-name
+    - deprecated
     - ignored-canonical-for
     - missing-from-search-index
     - no-canonical-found
@@ -30,6 +32,7 @@ dartdoc:
     - not-implemented
     - orphaned-file
     - reexported-private-api-across-packages
+    # - unknown-directive  # Disabled due to https://github.com/dart-lang/dartdoc/issues/2353
     - unknown-file
     - unknown-macro
     - unresolved-doc-reference
diff --git a/dev/bots/docs.sh b/dev/bots/docs.sh
index 5fca152090..010ba6a8ef 100755
--- a/dev/bots/docs.sh
+++ b/dev/bots/docs.sh
@@ -37,7 +37,9 @@ function script_location() {
 
 function generate_docs() {
     # Install and activate dartdoc.
-    "$PUB" global activate dartdoc 0.32.4
+    # NOTE: When updating to a new dartdoc version, please also update
+    # `dartdoc_options.yaml` to include newly introduced error and warning types.
+    "$PUB" global activate dartdoc 0.34.0
 
     # This script generates a unified doc set, and creates
     # a custom index.html, placing everything into dev/docs/doc.