From 7dd82813f2e13beeef35b7fa558f1a404a0495d8 Mon Sep 17 00:00:00 2001 From: Danny Tuppeny Date: Wed, 19 Sep 2018 17:47:06 +0100 Subject: [PATCH] Remove -j1 to run tools tests concurrently (#22038) Fixes #21113. --- dev/bots/test.dart | 5 ----- packages/flutter_tools/README.md | 2 +- packages/flutter_tools/test/integration/README.md | 5 ++--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/dev/bots/test.dart b/dev/bots/test.dart index 32e083ae47..a3cf5d1d5f 100644 --- a/dev/bots/test.dart +++ b/dev/bots/test.dart @@ -144,7 +144,6 @@ Future _runToolTests() async { await _pubRunTest( path.join(flutterRoot, 'packages', 'flutter_tools'), enableFlutterToolAsserts: true, - runConcurrently: false, ); print('${bold}DONE: All tests successful.$reset'); @@ -197,13 +196,9 @@ Future _runCoverage() async { Future _pubRunTest( String workingDirectory, { String testPath, - bool runConcurrently = true, bool enableFlutterToolAsserts = false }) { final List args = ['run', 'test', '-rcompact']; - if (!runConcurrently) { - args.add('-j1'); - } if (!hasColor) args.add('--no-color'); if (testPath != null) diff --git a/packages/flutter_tools/README.md b/packages/flutter_tools/README.md index 448faeca69..b6d65438ad 100644 --- a/packages/flutter_tools/README.md +++ b/packages/flutter_tools/README.md @@ -6,5 +6,5 @@ To run the tests, ensure that no devices are connected, then navigate to `flutter_tools` and execute: ```shell -../../bin/cache/dart-sdk/bin/pub run test -j1 +../../bin/cache/dart-sdk/bin/pub run test ``` diff --git a/packages/flutter_tools/test/integration/README.md b/packages/flutter_tools/test/integration/README.md index 08e24e2e17..52c5a2afab 100644 --- a/packages/flutter_tools/test/integration/README.md +++ b/packages/flutter_tools/test/integration/README.md @@ -4,9 +4,8 @@ These tests are not hermetic, and use actual Flutter SDK. While they don't require actual devices, they run `flutter_tester` to test Dart VM and Flutter integration. -Some of these tests change the current directory for the process, -so only one test can be run at a time. Use this command to run: +Use this command to run: ```shell -../../bin/cache/dart-sdk/bin/pub run test -j1 +../../bin/cache/dart-sdk/bin/pub run test ```