From 7ce7206df77681f033dba494c677cfc476989183 Mon Sep 17 00:00:00 2001
From: Hixie <github.com@spam.hixie.ch>
Date: Tue, 6 Jan 2015 13:23:04 -0800
Subject: [PATCH] Specs: registerElement(registerElement(...)) failed to work
 as expected

Review URL: https://codereview.chromium.org/836153005
---
 .../flutter/examples/calculator/buttons.sky   | 24 +++++++++----------
 .../examples/htmlish/framework/element.sky    | 18 +++++++-------
 engine/src/flutter/examples/radio.sky         | 24 +++++++++----------
 3 files changed, 32 insertions(+), 34 deletions(-)

diff --git a/engine/src/flutter/examples/calculator/buttons.sky b/engine/src/flutter/examples/calculator/buttons.sky
index 1b758d811c..29c59c35e4 100644
--- a/engine/src/flutter/examples/calculator/buttons.sky
+++ b/engine/src/flutter/examples/calculator/buttons.sky
@@ -55,25 +55,25 @@ SKY MODULE - button widgets for calculator
 
 <script>
  module.exports = {
-   ThreeDButtonElement: module.registerElement({
-     tagName: 'graybutton',
-     shadow: true,
-     constructor: class extends AbstractButton {
+   ThreeDButtonElement: module.registerElement(
+     class extends AbstractButton {
+       static get tagName() { return 'graybutton'; }
+       static get shadow() { return true; }
        constructor (module) {
          super(module);
          this.shadowRoot.append(module.document.findId('threed-button-shadow-tree').cloneNode(true));
        }
-     },
-   }),
-   FlatButtonElement: module.registerElement({
-     tagName: 'graybutton',
-     shadow: true,
-     constructor: class extends AbstractButton {
+     }
+   ),
+   FlatButtonElement: module.registerElement(
+     class extends AbstractButton {
+       static get tagName() { return 'flatbutton'; }
+       static get shadow() { return true; }
        constructor (module) {
          super(module);
          this.shadowRoot.append(module.document.findId('flat-shadow-tree').cloneNode(true));
        }
-     },
-   }),
+     }
+   ),
  };
 </script>
diff --git a/engine/src/flutter/examples/htmlish/framework/element.sky b/engine/src/flutter/examples/htmlish/framework/element.sky
index 89b4c2d0f7..d2c1d1c127 100644
--- a/engine/src/flutter/examples/htmlish/framework/element.sky
+++ b/engine/src/flutter/examples/htmlish/framework/element.sky
@@ -19,9 +19,9 @@ SKY MODULE - defines an <element> element
 -->
 
 <script>
- module.exports.Element = sky.registerElement({
-   tagName: 'element',
-   constructor: class extends Element {
+ module.exports.Element = sky.registerElement(
+   class extends Element {
+     static get tagName() { return 'element'; }
      constructor (module) {
        super();
        this.state = 'loading';
@@ -58,15 +58,13 @@ SKY MODULE - defines an <element> element
          constructor.prototype = this.definedPrototype;
        else
          constructor.prototype = sky.Element;
-       this.module.exports[constructorName] = this.registerElement({
-         tagName: this.getAttribute('name'),
-         shadow: style || template,
-         constructor: constructor,
-       });
+       constructor.tagName = this.getAttribute('name');
+       constructor.shadow = style || template;
+       this.module.exports[constructorName] = this.registerElement(constructor);
        delete this.definedPrototype;
        delete this.module;
        this.state = 'loaded';
      }
-   },
- });
+   }
+ );
 </script>
diff --git a/engine/src/flutter/examples/radio.sky b/engine/src/flutter/examples/radio.sky
index 6c6d29f777..02c1f6a28e 100644
--- a/engine/src/flutter/examples/radio.sky
+++ b/engine/src/flutter/examples/radio.sky
@@ -9,10 +9,10 @@ SKY MODULE - radio button and radio button group
  </style>
 </template>
 <script>
- module.exports.RadioElement = module.registerElement({
-   tagName: 'radio',
-   shadow: true,
-   constructor: class extends Element {
+ module.exports.RadioElement = module.registerElement(
+   class extends Element {
+     static get tagName() { return 'radio'; }
+     static get shadow() { return true; }
      constructor (module) {
        super(module);
        this.addEventListener('click', (event) => this.checked = true);
@@ -38,8 +38,8 @@ SKY MODULE - radio button and radio button group
          if (this.parentNode instanceof module.exports.RadioGroupElement)
            this.parentNode.setChecked(this);
      }
-   },
- });
+   }
+ );
 </script>
 
 <!-- <radiogroup> -->
@@ -49,10 +49,10 @@ SKY MODULE - radio button and radio button group
  </style>
 </template>
 <script>
- module.exports.RadioGroupElement = module.registerElement{
-   tagName: 'radiogroup',
-   shadow: true,
-   constructor: (class extends Element {
+ module.exports.RadioGroupElement = module.registerElement(
+   class extends Element {
+     static get tagName() { return 'radiogroup'; }
+     static get shadow() { return true; }
      constructor (module) {
        super(module);
        this.shadowRoot.append(module.document.findId('radiogroup-shadow').content.cloneNode(true));
@@ -81,6 +81,6 @@ SKY MODULE - radio button and radio button group
            if (child != radio)
              child.checked = false;
      }
-   },
- });
+   }
+ );
 </script>