From 6da29df7eed580f4d173cd6efce27ccc3fffd18b Mon Sep 17 00:00:00 2001
From: Jonah Williams <jonahwilliams@google.com>
Date: Thu, 16 Nov 2023 15:15:00 -0800
Subject: [PATCH] [Impeller] Clang tidy even more (flutter/engine#48102)

Also removes alot of includes of fml macros, which I know is always safe to remove.
---
 engine/src/flutter/impeller/aiks/image.h                    | 2 +-
 engine/src/flutter/impeller/archivist/archive.cc            | 3 ---
 engine/src/flutter/impeller/archivist/archive.h             | 6 ++----
 engine/src/flutter/impeller/archivist/archive_database.h    | 3 +--
 engine/src/flutter/impeller/archivist/archive_location.h    | 1 -
 engine/src/flutter/impeller/archivist/archive_statement.h   | 1 -
 engine/src/flutter/impeller/archivist/archive_transaction.h | 2 --
 engine/src/flutter/impeller/archivist/archive_vector.h      | 3 +--
 engine/src/flutter/impeller/base/validation.h               | 2 --
 engine/src/flutter/impeller/compiler/compiler_backend.h     | 2 +-
 engine/src/flutter/impeller/compiler/includer.h             | 1 -
 engine/src/flutter/impeller/compiler/logger.h               | 3 +--
 engine/src/flutter/impeller/compiler/source_options.h       | 1 -
 engine/src/flutter/impeller/compiler/spirv_compiler.h       | 1 -
 engine/src/flutter/impeller/compiler/spirv_sksl.h           | 1 -
 engine/src/flutter/impeller/compiler/switches.h             | 2 --
 engine/src/flutter/impeller/compiler/utilities.h            | 2 --
 engine/src/flutter/impeller/core/allocator.h                | 3 ---
 engine/src/flutter/impeller/core/buffer_view.h              | 1 -
 engine/src/flutter/impeller/core/device_buffer.h            | 1 -
 engine/src/flutter/impeller/core/formats.h                  | 1 -
 engine/src/flutter/impeller/core/host_buffer.h              | 1 -
 engine/src/flutter/impeller/core/resource_binder.h          | 1 -
 engine/src/flutter/impeller/core/sampler.h                  | 1 -
 engine/src/flutter/impeller/core/sampler_descriptor.h       | 1 -
 engine/src/flutter/impeller/core/texture_descriptor.h       | 3 ---
 engine/src/flutter/impeller/core/vertex_buffer.h            | 2 +-
 engine/src/flutter/impeller/display_list/dl_dispatcher.h    | 1 -
 .../src/flutter/impeller/display_list/dl_image_impeller.h   | 1 -
 engine/src/flutter/impeller/display_list/dl_playground.h    | 1 -
 .../flutter/impeller/display_list/nine_patch_converter.h    | 2 --
 .../flutter/impeller/renderer/backend/metal/formats_mtl.h   | 1 +
 engine/src/flutter/impeller/scene/node.cc                   | 1 +
 33 files changed, 10 insertions(+), 48 deletions(-)

diff --git a/engine/src/flutter/impeller/aiks/image.h b/engine/src/flutter/impeller/aiks/image.h
index 093d74af9c..4011137b40 100644
--- a/engine/src/flutter/impeller/aiks/image.h
+++ b/engine/src/flutter/impeller/aiks/image.h
@@ -13,7 +13,7 @@ namespace impeller {
 
 class Image {
  public:
-  Image(std::shared_ptr<Texture> texture);
+  explicit Image(std::shared_ptr<Texture> texture);
 
   ~Image();
 
diff --git a/engine/src/flutter/impeller/archivist/archive.cc b/engine/src/flutter/impeller/archivist/archive.cc
index 022b30de51..1179da2f2f 100644
--- a/engine/src/flutter/impeller/archivist/archive.cc
+++ b/engine/src/flutter/impeller/archivist/archive.cc
@@ -4,13 +4,10 @@
 
 #include "impeller/archivist/archive.h"
 
-#include <iterator>
-
 #include "flutter/fml/logging.h"
 #include "impeller/archivist/archive_class_registration.h"
 #include "impeller/archivist/archive_database.h"
 #include "impeller/archivist/archive_location.h"
-#include "impeller/base/validation.h"
 
 namespace impeller {
 
diff --git a/engine/src/flutter/impeller/archivist/archive.h b/engine/src/flutter/impeller/archivist/archive.h
index a232bf4c54..33c3f66988 100644
--- a/engine/src/flutter/impeller/archivist/archive.h
+++ b/engine/src/flutter/impeller/archivist/archive.h
@@ -9,9 +9,7 @@
 #include <optional>
 #include <string>
 #include <type_traits>
-#include <vector>
 
-#include "flutter/fml/macros.h"
 #include "impeller/archivist/archivable.h"
 
 namespace impeller {
@@ -21,7 +19,7 @@ class ArchiveDatabase;
 
 class Archive {
  public:
-  Archive(const std::string& path);
+  explicit Archive(const std::string& path);
 
   ~Archive();
 
@@ -45,7 +43,7 @@ class Archive {
 
   template <class T,
             class = std::enable_if_t<std::is_base_of<Archivable, T>::value>>
-  [[nodiscard]] size_t Read(UnarchiveStep stepper) {
+  [[nodiscard]] size_t Read(const UnarchiveStep& stepper) {
     const ArchiveDef& def = T::kArchiveDefinition;
     return UnarchiveInstances(def, stepper);
   }
diff --git a/engine/src/flutter/impeller/archivist/archive_database.h b/engine/src/flutter/impeller/archivist/archive_database.h
index 57696313c7..e8376fc370 100644
--- a/engine/src/flutter/impeller/archivist/archive_database.h
+++ b/engine/src/flutter/impeller/archivist/archive_database.h
@@ -8,7 +8,6 @@
 #include <memory>
 #include <string>
 
-#include "flutter/fml/macros.h"
 #include "impeller/archivist/archive_transaction.h"
 
 namespace impeller {
@@ -22,7 +21,7 @@ struct ArchiveDef;
 ///
 class ArchiveDatabase {
  public:
-  ArchiveDatabase(const std::string& filename);
+  explicit ArchiveDatabase(const std::string& filename);
 
   ~ArchiveDatabase();
 
diff --git a/engine/src/flutter/impeller/archivist/archive_location.h b/engine/src/flutter/impeller/archivist/archive_location.h
index 3caf3f1d8b..6b773274ad 100644
--- a/engine/src/flutter/impeller/archivist/archive_location.h
+++ b/engine/src/flutter/impeller/archivist/archive_location.h
@@ -7,7 +7,6 @@
 #include <optional>
 #include <type_traits>
 
-#include "flutter/fml/macros.h"
 #include "impeller/archivist/archivable.h"
 #include "impeller/archivist/archive.h"
 #include "impeller/base/allocation.h"
diff --git a/engine/src/flutter/impeller/archivist/archive_statement.h b/engine/src/flutter/impeller/archivist/archive_statement.h
index 69c746c234..a5de60f865 100644
--- a/engine/src/flutter/impeller/archivist/archive_statement.h
+++ b/engine/src/flutter/impeller/archivist/archive_statement.h
@@ -7,7 +7,6 @@
 #include <memory>
 #include <type_traits>
 
-#include "flutter/fml/macros.h"
 #include "impeller/base/allocation.h"
 
 namespace impeller {
diff --git a/engine/src/flutter/impeller/archivist/archive_transaction.h b/engine/src/flutter/impeller/archivist/archive_transaction.h
index 8e4d995d06..671074cb15 100644
--- a/engine/src/flutter/impeller/archivist/archive_transaction.h
+++ b/engine/src/flutter/impeller/archivist/archive_transaction.h
@@ -5,8 +5,6 @@
 
 #include <cstdint>
 
-#include "flutter/fml/macros.h"
-
 namespace impeller {
 
 class ArchiveStatement;
diff --git a/engine/src/flutter/impeller/archivist/archive_vector.h b/engine/src/flutter/impeller/archivist/archive_vector.h
index e99e39d362..2db657a683 100644
--- a/engine/src/flutter/impeller/archivist/archive_vector.h
+++ b/engine/src/flutter/impeller/archivist/archive_vector.h
@@ -4,7 +4,6 @@
 
 #pragma once
 
-#include "flutter/fml/macros.h"
 #include "impeller/archivist/archive.h"
 
 namespace impeller {
@@ -28,7 +27,7 @@ class ArchiveVector : public Archivable {
 
   ArchiveVector();
 
-  ArchiveVector(std::vector<int64_t> keys);
+  explicit ArchiveVector(std::vector<int64_t> keys);
 
   ArchiveVector(const ArchiveVector&) = delete;
 
diff --git a/engine/src/flutter/impeller/base/validation.h b/engine/src/flutter/impeller/base/validation.h
index eb8bd8adb6..1e7671adaa 100644
--- a/engine/src/flutter/impeller/base/validation.h
+++ b/engine/src/flutter/impeller/base/validation.h
@@ -12,8 +12,6 @@
 
 #include <sstream>
 
-#include "flutter/fml/macros.h"
-
 namespace impeller {
 
 class ValidationLog {
diff --git a/engine/src/flutter/impeller/compiler/compiler_backend.h b/engine/src/flutter/impeller/compiler/compiler_backend.h
index e06ec4ccfc..ea27801439 100644
--- a/engine/src/flutter/impeller/compiler/compiler_backend.h
+++ b/engine/src/flutter/impeller/compiler/compiler_backend.h
@@ -47,7 +47,7 @@ struct CompilerBackend {
 
   spirv_cross::Compiler* GetCompiler();
 
-  operator bool() const;
+  explicit operator bool() const;
 
   enum class ExtendedResourceIndex {
     kPrimary,
diff --git a/engine/src/flutter/impeller/compiler/includer.h b/engine/src/flutter/impeller/compiler/includer.h
index baeddb440b..a3af915317 100644
--- a/engine/src/flutter/impeller/compiler/includer.h
+++ b/engine/src/flutter/impeller/compiler/includer.h
@@ -6,7 +6,6 @@
 
 #include <string>
 
-#include "flutter/fml/macros.h"
 #include "flutter/fml/mapping.h"
 #include "impeller/compiler/include_dir.h"
 #include "shaderc/shaderc.hpp"
diff --git a/engine/src/flutter/impeller/compiler/logger.h b/engine/src/flutter/impeller/compiler/logger.h
index 0c478b75d0..d96de575ba 100644
--- a/engine/src/flutter/impeller/compiler/logger.h
+++ b/engine/src/flutter/impeller/compiler/logger.h
@@ -8,14 +8,13 @@
 #include <string>
 
 #include "flutter/fml/logging.h"
-#include "flutter/fml/macros.h"
 
 namespace impeller {
 namespace compiler {
 
 class AutoLogger {
  public:
-  AutoLogger(std::stringstream& logger) : logger_(logger) {}
+  explicit AutoLogger(std::stringstream& logger) : logger_(logger) {}
 
   ~AutoLogger() {
     logger_ << std::endl;
diff --git a/engine/src/flutter/impeller/compiler/source_options.h b/engine/src/flutter/impeller/compiler/source_options.h
index 8a740c69a2..5c9983284d 100644
--- a/engine/src/flutter/impeller/compiler/source_options.h
+++ b/engine/src/flutter/impeller/compiler/source_options.h
@@ -9,7 +9,6 @@
 #include <string>
 #include <vector>
 
-#include "flutter/fml/macros.h"
 #include "flutter/fml/unique_fd.h"
 #include "impeller/compiler/include_dir.h"
 #include "impeller/compiler/types.h"
diff --git a/engine/src/flutter/impeller/compiler/spirv_compiler.h b/engine/src/flutter/impeller/compiler/spirv_compiler.h
index 6935f4a0fa..c688cd2b46 100644
--- a/engine/src/flutter/impeller/compiler/spirv_compiler.h
+++ b/engine/src/flutter/impeller/compiler/spirv_compiler.h
@@ -7,7 +7,6 @@
 #include <cstdint>
 #include <vector>
 
-#include "flutter/fml/macros.h"
 #include "flutter/fml/mapping.h"
 #include "impeller/compiler/includer.h"
 #include "impeller/compiler/source_options.h"
diff --git a/engine/src/flutter/impeller/compiler/spirv_sksl.h b/engine/src/flutter/impeller/compiler/spirv_sksl.h
index 7df5a76c84..8e4879d02e 100644
--- a/engine/src/flutter/impeller/compiler/spirv_sksl.h
+++ b/engine/src/flutter/impeller/compiler/spirv_sksl.h
@@ -10,7 +10,6 @@
 #include <variant>
 
 #include "flutter/fml/logging.h"
-#include "flutter/fml/macros.h"
 #include "spirv_glsl.hpp"
 
 namespace impeller {
diff --git a/engine/src/flutter/impeller/compiler/switches.h b/engine/src/flutter/impeller/compiler/switches.h
index c1911359c6..c159f1a9cc 100644
--- a/engine/src/flutter/impeller/compiler/switches.h
+++ b/engine/src/flutter/impeller/compiler/switches.h
@@ -9,9 +9,7 @@
 #include <memory>
 
 #include "flutter/fml/command_line.h"
-#include "flutter/fml/macros.h"
 #include "flutter/fml/unique_fd.h"
-#include "impeller/compiler/compiler.h"
 #include "impeller/compiler/include_dir.h"
 #include "impeller/compiler/types.h"
 
diff --git a/engine/src/flutter/impeller/compiler/utilities.h b/engine/src/flutter/impeller/compiler/utilities.h
index 4c11078883..d1d27436ac 100644
--- a/engine/src/flutter/impeller/compiler/utilities.h
+++ b/engine/src/flutter/impeller/compiler/utilities.h
@@ -8,8 +8,6 @@
 #include <string>
 #include <string_view>
 
-#include "flutter/fml/macros.h"
-
 namespace impeller {
 namespace compiler {
 
diff --git a/engine/src/flutter/impeller/core/allocator.h b/engine/src/flutter/impeller/core/allocator.h
index d43696b130..5c4c02b78f 100644
--- a/engine/src/flutter/impeller/core/allocator.h
+++ b/engine/src/flutter/impeller/core/allocator.h
@@ -4,9 +4,6 @@
 
 #pragma once
 
-#include <string>
-
-#include "flutter/fml/macros.h"
 #include "flutter/fml/mapping.h"
 #include "impeller/core/device_buffer_descriptor.h"
 #include "impeller/core/texture.h"
diff --git a/engine/src/flutter/impeller/core/buffer_view.h b/engine/src/flutter/impeller/core/buffer_view.h
index 12c888b399..1a272a8b29 100644
--- a/engine/src/flutter/impeller/core/buffer_view.h
+++ b/engine/src/flutter/impeller/core/buffer_view.h
@@ -4,7 +4,6 @@
 
 #pragma once
 
-#include "flutter/fml/macros.h"
 #include "impeller/core/buffer.h"
 #include "impeller/core/range.h"
 
diff --git a/engine/src/flutter/impeller/core/device_buffer.h b/engine/src/flutter/impeller/core/device_buffer.h
index 9b1f594983..ac0d454df2 100644
--- a/engine/src/flutter/impeller/core/device_buffer.h
+++ b/engine/src/flutter/impeller/core/device_buffer.h
@@ -7,7 +7,6 @@
 #include <memory>
 #include <string>
 
-#include "flutter/fml/macros.h"
 #include "impeller/core/allocator.h"
 #include "impeller/core/buffer.h"
 #include "impeller/core/buffer_view.h"
diff --git a/engine/src/flutter/impeller/core/formats.h b/engine/src/flutter/impeller/core/formats.h
index 0e8d0d7d86..fbf1a36321 100644
--- a/engine/src/flutter/impeller/core/formats.h
+++ b/engine/src/flutter/impeller/core/formats.h
@@ -12,7 +12,6 @@
 
 #include "flutter/fml/hash_combine.h"
 #include "flutter/fml/logging.h"
-#include "flutter/fml/macros.h"
 #include "impeller/geometry/color.h"
 #include "impeller/geometry/rect.h"
 #include "impeller/geometry/scalar.h"
diff --git a/engine/src/flutter/impeller/core/host_buffer.h b/engine/src/flutter/impeller/core/host_buffer.h
index 9913b8ff46..74997ebbe5 100644
--- a/engine/src/flutter/impeller/core/host_buffer.h
+++ b/engine/src/flutter/impeller/core/host_buffer.h
@@ -9,7 +9,6 @@
 #include <string>
 #include <type_traits>
 
-#include "flutter/fml/macros.h"
 #include "impeller/base/allocation.h"
 #include "impeller/core/buffer.h"
 #include "impeller/core/buffer_view.h"
diff --git a/engine/src/flutter/impeller/core/resource_binder.h b/engine/src/flutter/impeller/core/resource_binder.h
index a88e75649d..1afe75b861 100644
--- a/engine/src/flutter/impeller/core/resource_binder.h
+++ b/engine/src/flutter/impeller/core/resource_binder.h
@@ -10,7 +10,6 @@
 #include <string>
 
 #include "flutter/fml/logging.h"
-#include "flutter/fml/macros.h"
 #include "impeller/core/buffer_view.h"
 #include "impeller/core/formats.h"
 #include "impeller/core/sampler.h"
diff --git a/engine/src/flutter/impeller/core/sampler.h b/engine/src/flutter/impeller/core/sampler.h
index 8337997326..5792aaacbc 100644
--- a/engine/src/flutter/impeller/core/sampler.h
+++ b/engine/src/flutter/impeller/core/sampler.h
@@ -4,7 +4,6 @@
 
 #pragma once
 
-#include "flutter/fml/macros.h"
 #include "impeller/core/sampler_descriptor.h"
 
 namespace impeller {
diff --git a/engine/src/flutter/impeller/core/sampler_descriptor.h b/engine/src/flutter/impeller/core/sampler_descriptor.h
index b9292cff94..197e373f9a 100644
--- a/engine/src/flutter/impeller/core/sampler_descriptor.h
+++ b/engine/src/flutter/impeller/core/sampler_descriptor.h
@@ -6,7 +6,6 @@
 
 #include <unordered_map>
 
-#include "flutter/fml/macros.h"
 #include "impeller/base/comparable.h"
 #include "impeller/core/formats.h"
 
diff --git a/engine/src/flutter/impeller/core/texture_descriptor.h b/engine/src/flutter/impeller/core/texture_descriptor.h
index aa1b574bf2..e168895c67 100644
--- a/engine/src/flutter/impeller/core/texture_descriptor.h
+++ b/engine/src/flutter/impeller/core/texture_descriptor.h
@@ -4,11 +4,8 @@
 
 #pragma once
 
-#include <optional>
-
 #include "impeller/core/formats.h"
 #include "impeller/geometry/size.h"
-#include "impeller/image/decompressed_image.h"
 
 namespace impeller {
 
diff --git a/engine/src/flutter/impeller/core/vertex_buffer.h b/engine/src/flutter/impeller/core/vertex_buffer.h
index 1c62fc8b3b..5ef934f4b8 100644
--- a/engine/src/flutter/impeller/core/vertex_buffer.h
+++ b/engine/src/flutter/impeller/core/vertex_buffer.h
@@ -17,7 +17,7 @@ struct VertexBuffer {
   size_t vertex_count = 0u;
   IndexType index_type = IndexType::kUnknown;
 
-  constexpr operator bool() const {
+  constexpr explicit operator bool() const {
     return static_cast<bool>(vertex_buffer) &&
            (index_type == IndexType::kNone || static_cast<bool>(index_buffer));
   }
diff --git a/engine/src/flutter/impeller/display_list/dl_dispatcher.h b/engine/src/flutter/impeller/display_list/dl_dispatcher.h
index 9e604dd4ac..10ed7fc610 100644
--- a/engine/src/flutter/impeller/display_list/dl_dispatcher.h
+++ b/engine/src/flutter/impeller/display_list/dl_dispatcher.h
@@ -5,7 +5,6 @@
 #pragma once
 
 #include "flutter/display_list/dl_op_receiver.h"
-#include "flutter/fml/macros.h"
 #include "impeller/aiks/canvas_type.h"
 #include "impeller/aiks/paint.h"
 
diff --git a/engine/src/flutter/impeller/display_list/dl_image_impeller.h b/engine/src/flutter/impeller/display_list/dl_image_impeller.h
index 7f590b6547..8f9e51443b 100644
--- a/engine/src/flutter/impeller/display_list/dl_image_impeller.h
+++ b/engine/src/flutter/impeller/display_list/dl_image_impeller.h
@@ -5,7 +5,6 @@
 #pragma once
 
 #include "flutter/display_list/image/dl_image.h"
-#include "flutter/fml/macros.h"
 #include "impeller/core/texture.h"
 
 namespace impeller {
diff --git a/engine/src/flutter/impeller/display_list/dl_playground.h b/engine/src/flutter/impeller/display_list/dl_playground.h
index 476b77b8be..7b47c36437 100644
--- a/engine/src/flutter/impeller/display_list/dl_playground.h
+++ b/engine/src/flutter/impeller/display_list/dl_playground.h
@@ -6,7 +6,6 @@
 
 #include "flutter/display_list/display_list.h"
 #include "flutter/display_list/dl_builder.h"
-#include "flutter/fml/macros.h"
 #include "impeller/playground/playground_test.h"
 #include "third_party/skia/include/core/SkFont.h"
 
diff --git a/engine/src/flutter/impeller/display_list/nine_patch_converter.h b/engine/src/flutter/impeller/display_list/nine_patch_converter.h
index 45caf719df..44afe97d2f 100644
--- a/engine/src/flutter/impeller/display_list/nine_patch_converter.h
+++ b/engine/src/flutter/impeller/display_list/nine_patch_converter.h
@@ -6,12 +6,10 @@
 
 #include <memory>
 
-#include "flutter/fml/macros.h"
 #include "impeller/aiks/canvas_type.h"
 #include "impeller/aiks/image.h"
 #include "impeller/aiks/paint.h"
 #include "impeller/core/sampler_descriptor.h"
-#include "impeller/geometry/path.h"
 
 namespace impeller {
 
diff --git a/engine/src/flutter/impeller/renderer/backend/metal/formats_mtl.h b/engine/src/flutter/impeller/renderer/backend/metal/formats_mtl.h
index 06738ea1b6..95212ce7d6 100644
--- a/engine/src/flutter/impeller/renderer/backend/metal/formats_mtl.h
+++ b/engine/src/flutter/impeller/renderer/backend/metal/formats_mtl.h
@@ -8,6 +8,7 @@
 
 #include <optional>
 
+#include "flutter/fml/build_config.h"
 #include "flutter/fml/macros.h"
 #include "impeller/base/validation.h"
 #include "impeller/core/formats.h"
diff --git a/engine/src/flutter/impeller/scene/node.cc b/engine/src/flutter/impeller/scene/node.cc
index 8f1da38f1e..77c090f135 100644
--- a/engine/src/flutter/impeller/scene/node.cc
+++ b/engine/src/flutter/impeller/scene/node.cc
@@ -14,6 +14,7 @@
 #include "impeller/base/thread.h"
 #include "impeller/base/validation.h"
 #include "impeller/geometry/matrix.h"
+#include "impeller/image/decompressed_image.h"
 #include "impeller/scene/animation/animation_player.h"
 #include "impeller/scene/importer/conversions.h"
 #include "impeller/scene/importer/scene_flatbuffers.h"