From 672ca7c24ec02b46c93ea862bd035973cf410c2a Mon Sep 17 00:00:00 2001
From: Jonah Williams <jonahwilliams@google.com>
Date: Fri, 14 Jul 2023 11:43:02 -0700
Subject: [PATCH] [Impeller] remove requests for dedicated allocations.
 (flutter/engine#43686)

This change never improved performance (in fact I think it regressed it slightly), so lets revert it and see if things change.
---
 .../renderer/backend/vulkan/allocator_vk.cc         | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/engine/src/flutter/impeller/renderer/backend/vulkan/allocator_vk.cc b/engine/src/flutter/impeller/renderer/backend/vulkan/allocator_vk.cc
index 3adce1b424..34191ba66b 100644
--- a/engine/src/flutter/impeller/renderer/backend/vulkan/allocator_vk.cc
+++ b/engine/src/flutter/impeller/renderer/backend/vulkan/allocator_vk.cc
@@ -11,7 +11,6 @@
 #include "impeller/core/formats.h"
 #include "impeller/renderer/backend/vulkan/device_buffer_vk.h"
 #include "impeller/renderer/backend/vulkan/formats_vk.h"
-#include "impeller/renderer/backend/vulkan/limits_vk.h"
 #include "impeller/renderer/backend/vulkan/texture_vk.h"
 
 namespace impeller {
@@ -264,19 +263,12 @@ ToVKTextureMemoryPropertyFlags(StorageMode mode,
   FML_UNREACHABLE();
 }
 
-static VmaAllocationCreateFlags ToVmaAllocationCreateFlags(StorageMode mode,
-                                                           size_t size) {
+static VmaAllocationCreateFlags ToVmaAllocationCreateFlags(StorageMode mode) {
   VmaAllocationCreateFlags flags = 0;
   switch (mode) {
     case StorageMode::kHostVisible:
-      if (size >= kImageSizeThresholdForDedicatedMemoryAllocation) {
-        flags |= VMA_ALLOCATION_CREATE_DEDICATED_MEMORY_BIT;
-      }
       return flags;
     case StorageMode::kDevicePrivate:
-      if (size >= kImageSizeThresholdForDedicatedMemoryAllocation) {
-        flags |= VMA_ALLOCATION_CREATE_DEDICATED_MEMORY_BIT;
-      }
       return flags;
     case StorageMode::kDeviceTransient:
       return flags;
@@ -318,8 +310,7 @@ class AllocatedTextureSourceVK final : public TextureSourceVK {
     alloc_nfo.preferredFlags =
         static_cast<VkMemoryPropertyFlags>(ToVKTextureMemoryPropertyFlags(
             desc.storage_mode, supports_memoryless_textures));
-    alloc_nfo.flags = ToVmaAllocationCreateFlags(
-        desc.storage_mode, desc.GetByteSizeOfBaseMipLevel());
+    alloc_nfo.flags = ToVmaAllocationCreateFlags(desc.storage_mode);
 
     auto create_info_native =
         static_cast<vk::ImageCreateInfo::NativeType>(image_info);