From 661f53ddd47d9d5e1e9712aa0db9cc00d00ede2a Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Wed, 2 Oct 2024 16:23:47 -0700 Subject: [PATCH] Add back main() methods to benchmark benches. (#156083) Dart performance suite needs this since it builds and launches those flutter benchmarks independently Cf. https://github.com/flutter/flutter/pull/154446 --- .../lib/geometry/matrix_utils_transform_bench.dart | 7 +++++++ .../microbenchmarks/lib/geometry/rrect_contains_bench.dart | 7 +++++++ .../lib/gestures/gesture_detector_bench.dart | 7 +++++++ .../lib/gestures/velocity_tracker_bench.dart | 7 +++++++ .../microbenchmarks/lib/language/sync_star_bench.dart | 7 +++++++ .../lib/language/sync_star_semantics_bench.dart | 7 +++++++ .../microbenchmarks/lib/stocks/animation_bench.dart | 7 +++++++ dev/benchmarks/microbenchmarks/lib/stocks/build_bench.dart | 7 +++++++ .../microbenchmarks/lib/stocks/layout_bench.dart | 7 +++++++ 9 files changed, 63 insertions(+) diff --git a/dev/benchmarks/microbenchmarks/lib/geometry/matrix_utils_transform_bench.dart b/dev/benchmarks/microbenchmarks/lib/geometry/matrix_utils_transform_bench.dart index b0096369d7..5f171021fd 100644 --- a/dev/benchmarks/microbenchmarks/lib/geometry/matrix_utils_transform_bench.dart +++ b/dev/benchmarks/microbenchmarks/lib/geometry/matrix_utils_transform_bench.dart @@ -136,3 +136,10 @@ Future execute() async { ); printer.printToStdout(); } + +// +// Note that the benchmark is normally run by benchmark_collection.dart. +// +Future main() async { + return execute(); +} diff --git a/dev/benchmarks/microbenchmarks/lib/geometry/rrect_contains_bench.dart b/dev/benchmarks/microbenchmarks/lib/geometry/rrect_contains_bench.dart index de7429de64..5e344ecc33 100644 --- a/dev/benchmarks/microbenchmarks/lib/geometry/rrect_contains_bench.dart +++ b/dev/benchmarks/microbenchmarks/lib/geometry/rrect_contains_bench.dart @@ -28,3 +28,10 @@ Future execute() async { ); printer.printToStdout(); } + +// +// Note that the benchmark is normally run by benchmark_collection.dart. +// +Future main() async { + return execute(); +} diff --git a/dev/benchmarks/microbenchmarks/lib/gestures/gesture_detector_bench.dart b/dev/benchmarks/microbenchmarks/lib/gestures/gesture_detector_bench.dart index 6ee61e3afe..7b89a35e7a 100644 --- a/dev/benchmarks/microbenchmarks/lib/gestures/gesture_detector_bench.dart +++ b/dev/benchmarks/microbenchmarks/lib/gestures/gesture_detector_bench.dart @@ -49,3 +49,10 @@ Future execute() async { ); printer.printToStdout(); } + +// +// Note that the benchmark is normally run by benchmark_collection.dart. +// +Future main() async { + return execute(); +} diff --git a/dev/benchmarks/microbenchmarks/lib/gestures/velocity_tracker_bench.dart b/dev/benchmarks/microbenchmarks/lib/gestures/velocity_tracker_bench.dart index 996c306c25..873e1f5c1c 100644 --- a/dev/benchmarks/microbenchmarks/lib/gestures/velocity_tracker_bench.dart +++ b/dev/benchmarks/microbenchmarks/lib/gestures/velocity_tracker_bench.dart @@ -57,3 +57,10 @@ Future execute() async { printer.printToStdout(); } + +// +// Note that the benchmark is normally run by benchmark_collection.dart. +// +Future main() async { + return execute(); +} diff --git a/dev/benchmarks/microbenchmarks/lib/language/sync_star_bench.dart b/dev/benchmarks/microbenchmarks/lib/language/sync_star_bench.dart index 41123e8e90..b062e78e35 100644 --- a/dev/benchmarks/microbenchmarks/lib/language/sync_star_bench.dart +++ b/dev/benchmarks/microbenchmarks/lib/language/sync_star_bench.dart @@ -89,3 +89,10 @@ int sumIterable(Iterable values) { } return result; } + +// +// Note that the benchmark is normally run by benchmark_collection.dart. +// +Future main() async { + return execute(); +} diff --git a/dev/benchmarks/microbenchmarks/lib/language/sync_star_semantics_bench.dart b/dev/benchmarks/microbenchmarks/lib/language/sync_star_semantics_bench.dart index 993d98b9b2..4f0553f649 100644 --- a/dev/benchmarks/microbenchmarks/lib/language/sync_star_semantics_bench.dart +++ b/dev/benchmarks/microbenchmarks/lib/language/sync_star_semantics_bench.dart @@ -117,3 +117,10 @@ Iterable combineSemanticsInfoList(List main() async { + return execute(); +} diff --git a/dev/benchmarks/microbenchmarks/lib/stocks/animation_bench.dart b/dev/benchmarks/microbenchmarks/lib/stocks/animation_bench.dart index ee5498019a..a1e1438c5a 100644 --- a/dev/benchmarks/microbenchmarks/lib/stocks/animation_bench.dart +++ b/dev/benchmarks/microbenchmarks/lib/stocks/animation_bench.dart @@ -90,3 +90,10 @@ Future execute(BenchmarkingBinding binding) async { } printer.printToStdout(); } + +// +// Note that the benchmark is normally run by benchmark_collection.dart. +// +Future main() async { + return execute(BenchmarkingBinding()); +} diff --git a/dev/benchmarks/microbenchmarks/lib/stocks/build_bench.dart b/dev/benchmarks/microbenchmarks/lib/stocks/build_bench.dart index d8224411ec..61ad4e4843 100644 --- a/dev/benchmarks/microbenchmarks/lib/stocks/build_bench.dart +++ b/dev/benchmarks/microbenchmarks/lib/stocks/build_bench.dart @@ -65,3 +65,10 @@ Future execute() async { ); printer.printToStdout(); } + +// +// Note that the benchmark is normally run by benchmark_collection.dart. +// +Future main() async { + return execute(); +} diff --git a/dev/benchmarks/microbenchmarks/lib/stocks/layout_bench.dart b/dev/benchmarks/microbenchmarks/lib/stocks/layout_bench.dart index e638ff7382..2ef7497163 100644 --- a/dev/benchmarks/microbenchmarks/lib/stocks/layout_bench.dart +++ b/dev/benchmarks/microbenchmarks/lib/stocks/layout_bench.dart @@ -60,3 +60,10 @@ Future execute() async { ); printer.printToStdout(); } + +// +// Note that the benchmark is normally run by benchmark_collection.dart. +// +Future main() async { + return execute(); +}