From 5aaac71f98c5fa0640c675ca1f1b90caaac1dbc2 Mon Sep 17 00:00:00 2001 From: liyuqian Date: Wed, 18 Sep 2019 10:25:14 -0700 Subject: [PATCH] Wait for first frame in driver tests (#40617) The transition_perf test is no longer flaky. --- .../complex_layout/test_driver/scroll_perf_test.dart | 3 +-- examples/flutter_gallery/test_driver/scroll_perf_test.dart | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/dev/benchmarks/complex_layout/test_driver/scroll_perf_test.dart b/dev/benchmarks/complex_layout/test_driver/scroll_perf_test.dart index e26ae3476d..ab46a27f4f 100644 --- a/dev/benchmarks/complex_layout/test_driver/scroll_perf_test.dart +++ b/dev/benchmarks/complex_layout/test_driver/scroll_perf_test.dart @@ -14,8 +14,7 @@ void main() { setUpAll(() async { driver = await FlutterDriver.connect(); - // TODO(liyuqian): enable the following once it's proved to be non-flaky by transition_perf_test.dart. - // await driver.waitUntilFirstFrameRasterized(); + await driver.waitUntilFirstFrameRasterized(); }); tearDownAll(() async { diff --git a/examples/flutter_gallery/test_driver/scroll_perf_test.dart b/examples/flutter_gallery/test_driver/scroll_perf_test.dart index e2a43027ad..c1cdc34a6e 100644 --- a/examples/flutter_gallery/test_driver/scroll_perf_test.dart +++ b/examples/flutter_gallery/test_driver/scroll_perf_test.dart @@ -14,8 +14,7 @@ void main() { setUpAll(() async { driver = await FlutterDriver.connect(); - // TODO(liyuqian): enable the following once it's proved to be non-flaky by transition_perf_test.dart. - // await driver.waitUntilFirstFrameRasterized(); + await driver.waitUntilFirstFrameRasterized(); }); tearDownAll(() async {