From 47640aa0e0b8a8700a93a20922ea5a9e72a74f52 Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Thu, 20 Feb 2025 07:38:55 -0800 Subject: [PATCH] It is now safe to call `getBuildMode().release` (#163712) ... because this function is no longer called in a context where it _isn't_ safe. Yay! --- .../lib/src/runner/flutter_command.dart | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/packages/flutter_tools/lib/src/runner/flutter_command.dart b/packages/flutter_tools/lib/src/runner/flutter_command.dart index 130cc3741d..868e8fe225 100644 --- a/packages/flutter_tools/lib/src/runner/flutter_command.dart +++ b/packages/flutter_tools/lib/src/runner/flutter_command.dart @@ -1963,17 +1963,9 @@ Run 'flutter -h' (or 'flutter -h') for available flutter commands and return; } + releaseMode ??= getBuildMode().isRelease; await project.regeneratePlatformSpecificTooling( - // TODO(matanlurey): Move this up, i.e. releaseMode ??= getBuildMode().release. - // - // As it stands, this is a breaking change until https://github.com/flutter/flutter/issues/162704 is - // implemented, as the build_ios_framework command (and similar) will start querying - // for getBuildMode(), causing an error (meta-build commands like build ios-framework do not have - // a single build mode). Once ios-framework and macos-framework are migrated, then this can be - // cleaned up. - releaseMode: - featureFlags.isExplicitPackageDependenciesEnabled && - (releaseMode ?? getBuildMode().isRelease), + releaseMode: featureFlags.isExplicitPackageDependenciesEnabled && releaseMode, ); }