From 3bb5bf4d4309966270e8f06f4407e5239986b61e Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Mon, 3 Mar 2025 10:03:11 -0800 Subject: [PATCH] Run run_debug_test_android and run_release_test in prod (#164231) `run_debug_test_android` and `run_release_test` were both consistently failing because of stray stderr logging that Xcode simctl (simulator command line tool) wasn't installed. https://github.com/flutter/flutter/pull/163895 removed that logging, and these tests are now passing: https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_mokey%20run_debug_test_android/1373/overview https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_mokey%20run_release_test/3467/overview They were originally marked bringup because they were flaky (like 10%) but while in bringup went to 100% failure due to the Xcode install issue. It looks like they really weren't flaky any more before the Xcode install issues, but erroneously the flaky issue was closed but the test wasn't marked unflaky https://github.com/flutter/flutter/issues/153830#issuecomment-2314768260. Moving out of bringup. Fixes https://github.com/flutter/flutter/issues/161655 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --- .ci.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.ci.yaml b/.ci.yaml index e2a55b8435..dfd56181b9 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -4683,7 +4683,6 @@ targets: # mac mokey test - name: Mac_mokey run_debug_test_android - bringup: true # Flaky https://github.com/flutter/flutter/issues/161655 recipe: devicelab/devicelab_drone presubmit: false runIf: @@ -4714,7 +4713,6 @@ targets: # mac mokey test - name: Mac_mokey run_release_test - bringup: true # Flaky https://github.com/flutter/flutter/issues/153830 recipe: devicelab/devicelab_drone presubmit: false runIf: