forked from firka/flutter
Reverts "Write an identical value to bin/cache/engine.stamp to prepare for migration (#164317)" (#164396)
<!-- start_original_pr_link --> Reverts: flutter/flutter#164317 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: matanlurey <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: `bin/cache` does not exist on a fresh checkout, and `echo bin/cache/...` will fail as a result. This blocked the google3 roll, but would also break new checkouts of Flutter, for regular users/contributors. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: matanlurey <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {jtmcdole} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Towards https://github.com/flutter/flutter/issues/164315. This PR just writes `bin/cache/engine.stamp` identically to how `bin/internal/engine.version` would otherwise be written, with a caveat that _if_ `engine.version` is tracked, it is now _copied_ to `bin/cache/engine.stamp`. After this lands, I'll send PRs to update tooling that looks for `engine.version` and give a heads up to the larger team (i.e. Dart HH bot or whomever we will break by doing this). <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
This commit is contained in:
5
.gitignore
vendored
5
.gitignore
vendored
@@ -1,6 +1,9 @@
|
||||
# Do not remove or rename entries in this file, only add new ones
|
||||
# See https://github.com/flutter/flutter/issues/128635 for more context.
|
||||
|
||||
# This is dynamic in a monorepo
|
||||
bin/internal/engine.version
|
||||
|
||||
# Miscellaneous
|
||||
*.class
|
||||
*.lock
|
||||
@@ -30,8 +33,6 @@
|
||||
/bin/cache/
|
||||
/bin/internal/bootstrap.bat
|
||||
/bin/internal/bootstrap.sh
|
||||
/bin/internal/engine.realm
|
||||
/bin/internal/engine.version
|
||||
/bin/mingit/
|
||||
/dev/benchmarks/mega_gallery/
|
||||
/dev/bots/.recipe_deps
|
||||
|
||||
Reference in New Issue
Block a user