forked from firka/flutter
[reland] delete FlutterCommand.usageValues (#162550)
Relands https://github.com/flutter/flutter/pull/162468 The original PR broke g3 postsubmit, because there was an override of `FlutterCommand.usageValues`. This was since deleted. ## Original PR description toward https://github.com/flutter/flutter/issues/150575. More simple deletes. <details> <summary> Pre-launch checklist </summary> - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. </details> <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
@@ -627,7 +627,6 @@ end
|
||||
swiftHostApp,
|
||||
);
|
||||
|
||||
final File swiftAnalyticsOutputFile = File(path.join(tempDir.path, 'analytics-swift.log'));
|
||||
final Directory swiftBuildDirectory = Directory(path.join(tempDir.path, 'build-swift'));
|
||||
|
||||
await inDirectory(swiftHostApp, () async {
|
||||
@@ -652,9 +651,7 @@ end
|
||||
'BUILD_DIR=${swiftBuildDirectory.path}',
|
||||
'COMPILER_INDEX_STORE_ENABLE=NO',
|
||||
],
|
||||
environment: <String, String>{
|
||||
'FLUTTER_ANALYTICS_LOG_FILE': swiftAnalyticsOutputFile.path,
|
||||
},
|
||||
environment: <String, String>{'FLUTTER_SUPPRESS_ANALYTICS': 'true'},
|
||||
);
|
||||
});
|
||||
|
||||
@@ -665,16 +662,6 @@ end
|
||||
return TaskResult.failure('Failed to build existing Swift app .app');
|
||||
}
|
||||
|
||||
final String swiftAnalyticsOutput = swiftAnalyticsOutputFile.readAsStringSync();
|
||||
if (!swiftAnalyticsOutput.contains('cd24: ios') ||
|
||||
!swiftAnalyticsOutput.contains('cd25: true') ||
|
||||
!swiftAnalyticsOutput.contains('viewName: assemble')) {
|
||||
return TaskResult.failure(
|
||||
'Building outer Swift app produced the following analytics: "$swiftAnalyticsOutput" '
|
||||
'but not the expected strings: "cd24: ios", "cd25: true", "viewName: assemble"',
|
||||
);
|
||||
}
|
||||
|
||||
return TaskResult.success(null);
|
||||
} catch (e) {
|
||||
return TaskResult.failure(e.toString());
|
||||
|
||||
Reference in New Issue
Block a user