diff --git a/packages/flutter_tools/lib/src/protocol_discovery.dart b/packages/flutter_tools/lib/src/protocol_discovery.dart index 3d1bc3dd2d..bdcbb4501f 100644 --- a/packages/flutter_tools/lib/src/protocol_discovery.dart +++ b/packages/flutter_tools/lib/src/protocol_discovery.dart @@ -234,6 +234,7 @@ StreamTransformer _throttle({ S latestLine; int lastExecution; Future throttleFuture; + bool done = false; return StreamTransformer .fromHandlers( @@ -249,14 +250,20 @@ StreamTransformer _throttle({ final int nextExecutionTime = isFirstMessage || remainingTime > waitDuration.inMilliseconds ? 0 : waitDuration.inMilliseconds - remainingTime; - throttleFuture ??= Future .delayed(Duration(milliseconds: nextExecutionTime)) .whenComplete(() { + if (done) { + return; + } sink.add(latestLine); throttleFuture = null; lastExecution = DateTime.now().millisecondsSinceEpoch; }); + }, + handleDone: (EventSink sink) { + done = true; + sink.close(); } ); } diff --git a/packages/flutter_tools/test/general.shard/protocol_discovery_test.dart b/packages/flutter_tools/test/general.shard/protocol_discovery_test.dart index a833521054..0868df3049 100644 --- a/packages/flutter_tools/test/general.shard/protocol_discovery_test.dart +++ b/packages/flutter_tools/test/general.shard/protocol_discovery_test.dart @@ -195,6 +195,18 @@ void main() { expect('$uri', 'http://127.0.0.1:12345/PTwjm8Ii8qg=/'); }); + testUsingContext('protocol discovery does not crash if the log reader is closed while delaying', () async { + initialize(devicePort: 12346, throttleDuration: const Duration(milliseconds: 10)); + final Future> results = discoverer.uris.toList(); + logReader.addLine('I/flutter : Observatory listening on http://127.0.0.1:12346/PTwjm8Ii8qg=/'); + logReader.addLine('I/flutter : Observatory listening on http://127.0.0.1:12346/PTwjm8Ii8qg=/'); + await logReader.dispose(); + + // Give time for throttle to finish. + await Future.delayed(const Duration(milliseconds: 11)); + expect(await results, isEmpty); + }); + testUsingContext('uris in the stream are throttled', () async { const Duration kThrottleDuration = Duration(milliseconds: 10);