From 1cf617812b7a063acb02e98ed0501dc64b0554fb Mon Sep 17 00:00:00 2001 From: Andrew Kolos Date: Wed, 5 Jun 2024 13:54:53 -0700 Subject: [PATCH] [flutter_tools] Remove additional listener on VM service that simply logged incoming messages (#149756) In service of #146879. In summary, a bunch of `printTrace` calls were added to try to troubleshoot this flake, but the flake has stopped happening. This PR more-or-less reverts https://github.com/flutter/flutter/pull/148596, since this was the only change that could have _theoretically_ (somehow maybe) stopped the flake. I'll consider reverting the rest of the `printTrace` calls if the flake does not reappear after this PR lands. --- packages/flutter_tools/lib/src/vmservice.dart | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/packages/flutter_tools/lib/src/vmservice.dart b/packages/flutter_tools/lib/src/vmservice.dart index 5e6b1528ae..72d61a8f6d 100644 --- a/packages/flutter_tools/lib/src/vmservice.dart +++ b/packages/flutter_tools/lib/src/vmservice.dart @@ -582,20 +582,6 @@ class FlutterVmService { // Do nothing, since the tool is already subscribed. } - // TODO(andrewkolos): this is to assist in troubleshooting https://github.com/flutter/flutter/issues/146879 - // and should be reverted once this issue is resolved. - unawaited(service.onReceive.firstWhere((String message) { - _logger.printTrace('runInView VM service onReceive listener received "$message"'); - final dynamic messageAsJson = jsonDecode(message); - // ignore: avoid_dynamic_calls -- Temporary code. - final dynamic messageKind = messageAsJson['params']?['event']?['kind']; - if (messageKind == 'IsolateRunnable') { - _logger.printTrace('Received IsolateRunnable event from onReceive.'); - return true; - } - return false; - })); - final Future onRunnable = service.onIsolateEvent.firstWhere((vm_service.Event event) { _logger.printTrace('runInView VM service onIsolateEvent listener received $event'); return event.kind == vm_service.EventKind.kIsolateRunnable;