From 1731a16d81d39237171d42a979c71b2afac82406 Mon Sep 17 00:00:00 2001 From: Mikkel Nygaard Ravn Date: Thu, 29 Jun 2017 09:48:01 +0200 Subject: [PATCH] Make consistent use of gradle wrapper (#10993) --- .../complex_layout/android/.gitignore | 2 +- .../complex_layout/android/app/build.gradle | 4 ++ .../android/app/src/main/AndroidManifest.xml | 5 +- .../complex_layout/android/build.gradle | 10 ++-- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ .../microbenchmarks/android/.gitignore | 2 +- .../microbenchmarks/android/app/build.gradle | 4 ++ .../android/app/src/main/AndroidManifest.xml | 5 +- .../microbenchmarks/android/build.gradle | 10 ++-- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ .../channels/android/.gitignore | 2 +- .../channels/android/app/build.gradle | 4 ++ .../android/app/src/main/AndroidManifest.xml | 6 +- .../channels/android/build.gradle | 9 ++- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ dev/integration_tests/ui/android/.gitignore | 2 +- .../ui/android/app/build.gradle | 4 ++ .../android/app/src/main/AndroidManifest.xml | 6 +- dev/integration_tests/ui/android/build.gradle | 9 ++- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ dev/manual_tests/android/.gitignore | 2 +- .../android/app/src/main/AndroidManifest.xml | 6 +- dev/manual_tests/android/build.gradle | 9 ++- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ examples/README.md | 9 +++ examples/catalog/android/.gitignore | 4 +- examples/catalog/android/app/build.gradle | 5 ++ .../android/app/src/main/AndroidManifest.xml | 6 +- examples/catalog/android/build.gradle | 9 ++- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ examples/flutter_gallery/android/.gitignore | 4 +- .../flutter_gallery/android/app/build.gradle | 8 ++- .../android/app/src/main/AndroidManifest.xml | 6 +- examples/flutter_gallery/android/build.gradle | 9 ++- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ examples/flutter_view/android/.gitignore | 4 +- .../flutter_view/android/app/build.gradle | 5 ++ .../android/app/src/main/AndroidManifest.xml | 6 +- examples/flutter_view/android/build.gradle | 9 ++- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ examples/hello_world/android/.gitignore | 4 +- examples/hello_world/android/app/build.gradle | 8 ++- .../android/app/src/main/AndroidManifest.xml | 6 +- examples/hello_world/android/build.gradle | 9 ++- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ examples/layers/android/.gitignore | 4 +- examples/layers/android/app/build.gradle | 5 ++ .../android/app/src/main/AndroidManifest.xml | 6 +- examples/layers/android/build.gradle | 10 ++-- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ examples/platform_channel/android/.gitignore | 4 +- .../platform_channel/android/app/build.gradle | 6 +- .../android/app/src/main/AndroidManifest.xml | 6 +- .../platform_channel/android/build.gradle | 9 ++- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ examples/platform_view/android/.gitignore | 4 +- .../platform_view/android/app/build.gradle | 8 ++- .../android/app/src/main/AndroidManifest.xml | 8 +-- examples/platform_view/android/build.gradle | 9 ++- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ examples/stocks/android/.gitignore | 4 +- examples/stocks/android/app/build.gradle | 6 +- .../android/app/src/main/AndroidManifest.xml | 6 +- examples/stocks/android/build.gradle | 9 ++- .../gradle/wrapper/gradle-wrapper.properties | 6 ++ .../lib/src/android/android_studio.dart | 60 +------------------ .../src/android/android_studio_validator.dart | 59 ------------------ .../flutter_tools/lib/src/android/gradle.dart | 34 ++++++----- .../android-java.tmpl/app/build.gradle.tmpl | 7 ++- .../create/android-java.tmpl/build.gradle | 3 + .../android-kotlin.tmpl/app/build.gradle.tmpl | 7 ++- .../create/android-kotlin.tmpl/build.gradle | 3 + .../app/src/main/AndroidManifest.xml.tmpl | 6 +- .../android-java.tmpl/build.gradle.tmpl | 7 +++ .../android-kotlin.tmpl/build.gradle.tmpl | 7 +++ .../src/main/AndroidManifest.xml.tmpl | 6 +- 76 files changed, 292 insertions(+), 301 deletions(-) create mode 100644 dev/benchmarks/complex_layout/android/gradle/wrapper/gradle-wrapper.properties create mode 100644 dev/benchmarks/microbenchmarks/android/gradle/wrapper/gradle-wrapper.properties create mode 100755 dev/integration_tests/channels/android/gradle/wrapper/gradle-wrapper.properties create mode 100644 dev/integration_tests/ui/android/gradle/wrapper/gradle-wrapper.properties create mode 100755 dev/manual_tests/android/gradle/wrapper/gradle-wrapper.properties create mode 100644 examples/catalog/android/gradle/wrapper/gradle-wrapper.properties create mode 100644 examples/flutter_gallery/android/gradle/wrapper/gradle-wrapper.properties create mode 100644 examples/flutter_view/android/gradle/wrapper/gradle-wrapper.properties create mode 100644 examples/hello_world/android/gradle/wrapper/gradle-wrapper.properties create mode 100644 examples/layers/android/gradle/wrapper/gradle-wrapper.properties create mode 100644 examples/platform_channel/android/gradle/wrapper/gradle-wrapper.properties create mode 100644 examples/platform_view/android/gradle/wrapper/gradle-wrapper.properties create mode 100755 examples/stocks/android/gradle/wrapper/gradle-wrapper.properties diff --git a/dev/benchmarks/complex_layout/android/.gitignore b/dev/benchmarks/complex_layout/android/.gitignore index 1fd9325cac..3caaa44678 100644 --- a/dev/benchmarks/complex_layout/android/.gitignore +++ b/dev/benchmarks/complex_layout/android/.gitignore @@ -8,6 +8,6 @@ /captures GeneratedPluginRegistrant.java -/gradle +gradle-wrapper.jar /gradlew /gradlew.bat diff --git a/dev/benchmarks/complex_layout/android/app/build.gradle b/dev/benchmarks/complex_layout/android/app/build.gradle index 1e4b757467..9506616829 100644 --- a/dev/benchmarks/complex_layout/android/app/build.gradle +++ b/dev/benchmarks/complex_layout/android/app/build.gradle @@ -23,6 +23,10 @@ android { } defaultConfig { + minSdkVersion 16 + targetSdkVersion 25 + versionCode 1 + versionName "0.0.1" testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner" } diff --git a/dev/benchmarks/complex_layout/android/app/src/main/AndroidManifest.xml b/dev/benchmarks/complex_layout/android/app/src/main/AndroidManifest.xml index df92d8b27c..c93aafaa4d 100644 --- a/dev/benchmarks/complex_layout/android/app/src/main/AndroidManifest.xml +++ b/dev/benchmarks/complex_layout/android/app/src/main/AndroidManifest.xml @@ -1,9 +1,6 @@ + package="com.yourcompany.complexLayout"> - diff --git a/dev/benchmarks/complex_layout/android/build.gradle b/dev/benchmarks/complex_layout/android/build.gradle index 14662e4330..77cbd09140 100644 --- a/dev/benchmarks/complex_layout/android/build.gradle +++ b/dev/benchmarks/complex_layout/android/build.gradle @@ -1,10 +1,13 @@ buildscript { repositories { jcenter() + maven { + url "https://maven.google.com" + } } dependencies { - classpath 'com.android.tools.build:gradle:2.2.3' + classpath 'com.android.tools.build:gradle:2.3.3' } } @@ -20,12 +23,9 @@ allprojects { rootProject.buildDir = '../build' subprojects { project.buildDir = "${rootProject.buildDir}/${project.name}" + project.evaluationDependsOn(':app') } task clean(type: Delete) { delete rootProject.buildDir } - -task wrapper(type: Wrapper) { - gradleVersion = '2.14.1' -} diff --git a/dev/benchmarks/complex_layout/android/gradle/wrapper/gradle-wrapper.properties b/dev/benchmarks/complex_layout/android/gradle/wrapper/gradle-wrapper.properties new file mode 100644 index 0000000000..45e7f14e95 --- /dev/null +++ b/dev/benchmarks/complex_layout/android/gradle/wrapper/gradle-wrapper.properties @@ -0,0 +1,6 @@ +#Fri Jun 23 08:50:38 CEST 2017 +distributionBase=GRADLE_USER_HOME +distributionPath=wrapper/dists +zipStoreBase=GRADLE_USER_HOME +zipStorePath=wrapper/dists +distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip diff --git a/dev/benchmarks/microbenchmarks/android/.gitignore b/dev/benchmarks/microbenchmarks/android/.gitignore index 1fd9325cac..3caaa44678 100644 --- a/dev/benchmarks/microbenchmarks/android/.gitignore +++ b/dev/benchmarks/microbenchmarks/android/.gitignore @@ -8,6 +8,6 @@ /captures GeneratedPluginRegistrant.java -/gradle +gradle-wrapper.jar /gradlew /gradlew.bat diff --git a/dev/benchmarks/microbenchmarks/android/app/build.gradle b/dev/benchmarks/microbenchmarks/android/app/build.gradle index 7ecba369c4..16c4a2a4ca 100644 --- a/dev/benchmarks/microbenchmarks/android/app/build.gradle +++ b/dev/benchmarks/microbenchmarks/android/app/build.gradle @@ -23,6 +23,10 @@ android { } defaultConfig { + minSdkVersion 16 + targetSdkVersion 25 + versionCode 1 + versionName "0.0.1" testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner" } diff --git a/dev/benchmarks/microbenchmarks/android/app/src/main/AndroidManifest.xml b/dev/benchmarks/microbenchmarks/android/app/src/main/AndroidManifest.xml index 446489e813..1c10c5a4b1 100644 --- a/dev/benchmarks/microbenchmarks/android/app/src/main/AndroidManifest.xml +++ b/dev/benchmarks/microbenchmarks/android/app/src/main/AndroidManifest.xml @@ -1,9 +1,6 @@ + package="com.yourcompany.microbenchmarks"> - diff --git a/dev/benchmarks/microbenchmarks/android/build.gradle b/dev/benchmarks/microbenchmarks/android/build.gradle index 14662e4330..77cbd09140 100644 --- a/dev/benchmarks/microbenchmarks/android/build.gradle +++ b/dev/benchmarks/microbenchmarks/android/build.gradle @@ -1,10 +1,13 @@ buildscript { repositories { jcenter() + maven { + url "https://maven.google.com" + } } dependencies { - classpath 'com.android.tools.build:gradle:2.2.3' + classpath 'com.android.tools.build:gradle:2.3.3' } } @@ -20,12 +23,9 @@ allprojects { rootProject.buildDir = '../build' subprojects { project.buildDir = "${rootProject.buildDir}/${project.name}" + project.evaluationDependsOn(':app') } task clean(type: Delete) { delete rootProject.buildDir } - -task wrapper(type: Wrapper) { - gradleVersion = '2.14.1' -} diff --git a/dev/benchmarks/microbenchmarks/android/gradle/wrapper/gradle-wrapper.properties b/dev/benchmarks/microbenchmarks/android/gradle/wrapper/gradle-wrapper.properties new file mode 100644 index 0000000000..45e7f14e95 --- /dev/null +++ b/dev/benchmarks/microbenchmarks/android/gradle/wrapper/gradle-wrapper.properties @@ -0,0 +1,6 @@ +#Fri Jun 23 08:50:38 CEST 2017 +distributionBase=GRADLE_USER_HOME +distributionPath=wrapper/dists +zipStoreBase=GRADLE_USER_HOME +zipStorePath=wrapper/dists +distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip diff --git a/dev/integration_tests/channels/android/.gitignore b/dev/integration_tests/channels/android/.gitignore index 1fd9325cac..3caaa44678 100644 --- a/dev/integration_tests/channels/android/.gitignore +++ b/dev/integration_tests/channels/android/.gitignore @@ -8,6 +8,6 @@ /captures GeneratedPluginRegistrant.java -/gradle +gradle-wrapper.jar /gradlew /gradlew.bat diff --git a/dev/integration_tests/channels/android/app/build.gradle b/dev/integration_tests/channels/android/app/build.gradle index 4b058ea69c..40c3dca5d4 100644 --- a/dev/integration_tests/channels/android/app/build.gradle +++ b/dev/integration_tests/channels/android/app/build.gradle @@ -23,6 +23,10 @@ android { } defaultConfig { + minSdkVersion 16 + targetSdkVersion 25 + versionCode 1 + versionName "0.0.1" testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner" } diff --git a/dev/integration_tests/channels/android/app/src/main/AndroidManifest.xml b/dev/integration_tests/channels/android/app/src/main/AndroidManifest.xml index b63cc17387..199e25e11e 100644 --- a/dev/integration_tests/channels/android/app/src/main/AndroidManifest.xml +++ b/dev/integration_tests/channels/android/app/src/main/AndroidManifest.xml @@ -1,9 +1,5 @@ - - + package="com.yourcompany.channels"> - - + package="com.yourcompany.integration_ui"> - - + package="io.flutter.examples.manual_tests"> - - + package="io.flutter.examples.gallery"> - - + package="io.flutter.examples.hello_world"> - - + package="io.flutter.examples.stocks">