From 096439b41775461d74c949ecb3de77f5c72fdb3e Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Mon, 22 Apr 2019 16:21:17 -0700 Subject: [PATCH] add ignorable track-widget-creation flag to build and remove --track-widget-creation from xcode backend aot build aot (#31399) --- packages/flutter_tools/bin/xcode_backend.sh | 3 +-- packages/flutter_tools/lib/src/commands/build_aot.dart | 6 ++++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/flutter_tools/bin/xcode_backend.sh b/packages/flutter_tools/bin/xcode_backend.sh index f8f3a2fb89..b3d553b1f6 100755 --- a/packages/flutter_tools/bin/xcode_backend.sh +++ b/packages/flutter_tools/bin/xcode_backend.sh @@ -183,8 +183,7 @@ BuildApp() { --${build_mode} \ --ios-arch="${archs}" \ ${flutter_engine_flag} \ - ${local_engine_flag} \ - ${track_widget_creation_flag} + ${local_engine_flag} if [[ $? -ne 0 ]]; then EchoError "Failed to build ${project_path}." diff --git a/packages/flutter_tools/lib/src/commands/build_aot.dart b/packages/flutter_tools/lib/src/commands/build_aot.dart index ea32069960..246ab6abd8 100644 --- a/packages/flutter_tools/lib/src/commands/build_aot.dart +++ b/packages/flutter_tools/lib/src/commands/build_aot.dart @@ -38,6 +38,12 @@ class BuildAotCommand extends BuildSubCommand with TargetPlatformBasedDevelopmen defaultsTo: false, help: 'Report timing information about build steps in machine readable form,', ) + // track-widget-creation is exposed as a flag here but ignored to deal with build + // invalidation issues - there are no plans to support it for AOT mode. + ..addFlag('track-widget-creation', + defaultsTo: false, + hide: true, + ) ..addMultiOption('ios-arch', splitCommas: true, defaultsTo: defaultIOSArchs.map(getNameForIOSArch),