From 0686c96cc55e3ebd97a7faf4a75ba4b9728e03ed Mon Sep 17 00:00:00 2001 From: Adam Barth Date: Mon, 3 Nov 2014 19:05:48 -0800 Subject: [PATCH] Don't GC message pipes that have an in-flight request In mojom, there's a notion of a request/response pair. This CL teaches the JS bindings not to GC a message pipe after a request has been issued but before the response has been received. R=hansmuller@chromium.org Review URL: https://codereview.chromium.org/696373003 --- engine/src/flutter/examples/file-browser.sky | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/src/flutter/examples/file-browser.sky b/engine/src/flutter/examples/file-browser.sky index 6d02f84839..43c1267b30 100644 --- a/engine/src/flutter/examples/file-browser.sky +++ b/engine/src/flutter/examples/file-browser.sky @@ -28,7 +28,7 @@ SkyElement({ directories: [], attached: function() { this.url = this.ownerDocument.URL; - var xhr = this.xhr_ = new XMLHttpRequest(); + var xhr = new XMLHttpRequest(); xhr.open('GET', this.url + '?format=json'); xhr.onload = (function() { var listing = JSON.parse(xhr.responseText);