From 0497235c2016bec8c86c2fb643baf2b52baca074 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Thu, 12 Dec 2019 19:05:48 -0800 Subject: [PATCH] [flutter_tool] experimental resident web runner is not debuggable (#46916) --- .../lib/src/build_runner/resident_web_runner.dart | 3 +++ .../test/general.shard/resident_web_runner_test.dart | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart b/packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart index 218bc0c942..8c2875634f 100644 --- a/packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart +++ b/packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart @@ -360,6 +360,9 @@ class _ExperimentalResidentWebRunner extends ResidentWebRunner { dartDefines: dartDefines, ); + @override + bool get debuggingEnabled => false; + @override Future run({ Completer connectionInfoCompleter, diff --git a/packages/flutter_tools/test/general.shard/resident_web_runner_test.dart b/packages/flutter_tools/test/general.shard/resident_web_runner_test.dart index 405e43899b..9633014017 100644 --- a/packages/flutter_tools/test/general.shard/resident_web_runner_test.dart +++ b/packages/flutter_tools/test/general.shard/resident_web_runner_test.dart @@ -486,6 +486,12 @@ void main() { FeatureFlags: () => TestFeatureFlags(isWebIncrementalCompilerEnabled: true), })); + test('experimental resident runner is not debuggable', () => testbed.run(() { + expect(residentWebRunner.debuggingEnabled, false); + }, overrides: { + FeatureFlags: () => TestFeatureFlags(isWebIncrementalCompilerEnabled: true), + })); + test('Can hot restart after attaching', () => testbed.run(() async { _setupMocks(); final Completer connectionInfoCompleter = Completer();