Alex Wallen
29524c3c79
Remove single view assumptions from window.dart (flutter/engine#38453)
* Refactor `window.dart`
* Remove single window assumption from platform dispatcher
* Expose viewId
* Remove FlutterWindow from web_ui
* Refactor EngineFlutterWindow to inherit from FlutterView
* Rename window property
* Undo Iterable -> Map conversion
* Add window and deprecate it so that the change isn't breaking
* Name resolution
* Revisions
* Doc changes
* Refactor deprecation message
* Newline
* Expose getViewById, hide map interface
* Fix compilaiton errors
* Introduce addView API
* Change deprecation message
* Update lib/ui/window.dart
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
* Take greg's todos
* Add mutual exclusion assertion
* Fix trailing whitespace lint
* Use only one property to store backing view
* Add doc comment to view
* Document view and window parameters in the constructor of ViewConfiguration
* Sync web api
* Refactor assertion
* Improve deprecation message
* Improve window documentation
* Assert one of window/view is null in copyWith ViewConfiguration
* Remove EngineFlutterWindowView
* Make dartdoc happy
* Refactor copyWith()
* Change to internal map implementation
* final private refactor
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
* Deprecate window parameter in copyWith
* Repl Window w/ View
* Add tests for viewConfiguration
* Make test descriptions better
* Add ViewConfiguration initialization with window tests
* Update lib/web_ui/lib/src/engine/window.dart
Co-authored-by: David Iglesias <ditman@gmail.com>
* Refactor TODO message
* Add expectation :)
* Fix viewId in window.dart
* Remove double deprecation access
* punctuation
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
* Add kSingletonWindowID const
Co-authored-by: a-wallen <stephenwallen@google.com>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: David Iglesias <ditman@gmail.com>