Commit Graph

20406 Commits

Author SHA1 Message Date
skia-flutter-autoroll
fee55485ce Roll Skia from 38cdadb76f51 to d16a6bdb9542 (3 revisions) (flutter/engine#37957)
https://skia.googlesource.com/skia.git/+log/38cdadb76f51..d16a6bdb9542

2022-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 84191ee7ff74 to 16963ad73ee7 (9 revisions)
2022-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 35247a4df408 to 000b3bfa32ca (5 revisions)
2022-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 541bd5946857 to 26c653c9a2fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-29 08:34:13 +00:00
skia-flutter-autoroll
693725d457 Roll Skia from ddddafb88280 to 38cdadb76f51 (3 revisions) (flutter/engine#37956)
https://skia.googlesource.com/skia.git/+log/ddddafb88280..38cdadb76f51

2022-11-29 armansito@google.com [graphite] Add explicit includes for Buffer.h
2022-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e4040f7ac260 to a53d2e8e6f8e (11 revisions)
2022-11-28 johnstiles@google.com Remove Builder code which counts the number of value slots.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-29 06:30:22 +00:00
Jonah Williams
d47ae7db73 [impellerc] speculative fix for include errors with impellerc shader lib (flutter/engine#37939)
* [impellerc] specualtive fix for include errors

* ++

* ++
2022-11-29 02:24:04 +00:00
Chinmay Garde
55fa35bcc8 [Impeller] Cleanup shader generation and specify min macOS version. (flutter/engine#37952)
* [Impeller] Cleanup shader generation and specify min macOS version.

We used to add workarounds for https://github.com/flutter/flutter/issues/106066.

However, that issue has been resolved. But the workarounds made it so that unopt
local engine builds would build inconsistent shaders. Also, the mac builds would
specify the iOS as well mac shader standards to the compiler. The mac target
also never got a min OS version.

The script has been cleaned up for readability.

* Format.
2022-11-29 02:08:16 +00:00
skia-flutter-autoroll
2e50ceb06d Roll Skia from 4a4cfedd1c20 to ddddafb88280 (2 revisions) (flutter/engine#37947)
https://skia.googlesource.com/skia.git/+log/4a4cfedd1c20..ddddafb88280

2022-11-28 kjlubick@google.com [includes] Fix GrCaps issue with GrAHardwareBuffer...
2022-11-28 kjlubick@google.com [infra] Remove executable bit from tasks.json

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-28 23:05:16 +00:00
Erik
94c88a9253 [fuchsia] arm64 Dart runner (flutter/engine#37399)
- Fuchsia FEMU tests now run using `ffx`
- There is now a Fuchsia arm64 FEMU builder to allow tests to run on an arm64 emulator
2022-11-28 17:39:50 -05:00
skia-flutter-autoroll
a7ef064482 Roll ICU from da0744861976 to 1b7d391f0528 (4 revisions) (flutter/engine#37945)
da07448619..1b7d391f05

2022-11-18 ftang@chromium.org Fix win64_msvc compiling issue
2022-11-16 jason.erb.chromium@gmail.com Fix asm_to_inline_asm.py for Python 3
2022-11-08 ftang@chromium.org Update to 72-1
2022-10-21 gulfem@google.com Revert "[build] Suppress -Wenum-constexpr-conversion"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter-engine
Please CC kaushikiska@google.com,fmil@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-28 14:02:57 -08:00
skia-flutter-autoroll
c3a3572e68 Roll Skia from 6f65f0631e5a to 4a4cfedd1c20 (6 revisions) (flutter/engine#37942)
https://skia.googlesource.com/skia.git/+log/6f65f0631e5a..4a4cfedd1c20

2022-11-28 kjlubick@google.com [bazel] Use same expat_config.h as GN rules
2022-11-28 armansito@google.com [graphite][compute] Use BindBufferInfo for ComputePassTask buffer bindings
2022-11-28 kjlubick@google.com Add docs about suppressed function cast warning
2022-11-28 herb@google.com Try making pop_back_n faster
2022-11-28 kjlubick@google.com [includes] Remove link between SkImage_Base.h -> GrBackendSurface.h
2022-11-28 kjlubick@google.com [infra] Run CheckGeneratedFiles job if any .gni file is changed

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-28 20:53:08 +00:00
htoor3
8b7d1f9d50 Ignore keydown event for tab during IME composition (flutter/engine#37753)
* Stop propagation to prevent additional tab keydown during composition

* Intercept keydown in raw_keyboard, add tests

* Fix dart errors

* Fix dart issue

* Refactor

* Move comment
2022-11-28 13:35:16 -06:00
skia-flutter-autoroll
923dd351ee Roll Skia from 3ab92e777da1 to 6f65f0631e5a (3 revisions) (flutter/engine#37941)
https://skia.googlesource.com/skia.git/+log/3ab92e777da1..6f65f0631e5a

2022-11-28 kjlubick@google.com Fix compile scripts which use ninja
2022-11-28 brianosman@google.com Gradients: Rename confusing fields
2022-11-28 johnstiles@google.com Add support for splat-constructors.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-28 19:26:12 +00:00
skia-flutter-autoroll
ea880a5388 Roll Skia from 556e08aa5354 to 3ab92e777da1 (1 revision) (flutter/engine#37936)
https://skia.googlesource.com/skia.git/+log/556e08aa5354..3ab92e777da1

2022-11-28 kjlubick@google.com Remove INHERITED from SkImage_Base.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-28 16:39:58 +00:00
skia-flutter-autoroll
52cafbe00b Roll Skia from 9d3726a26123 to 556e08aa5354 (1 revision) (flutter/engine#37933)
https://skia.googlesource.com/skia.git/+log/9d3726a26123..556e08aa5354

2022-11-28 kjlubick@google.com [bazel] More support for Vulkan builds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-28 15:16:25 +00:00
skia-flutter-autoroll
6da7cc723b Roll Skia from f0a2e2a08ee7 to 9d3726a26123 (2 revisions) (flutter/engine#37929)
https://skia.googlesource.com/skia.git/+log/f0a2e2a08ee7..9d3726a26123

2022-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 34cc81bb5351 to 541bd5946857
2022-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f58d2966491e to 34cc81bb5351 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-28 07:33:36 +00:00
skia-flutter-autoroll
e85a3d4e96 Roll Skia from 79f890c4ba92 to f0a2e2a08ee7 (1 revision) (flutter/engine#37928)
https://skia.googlesource.com/skia.git/+log/79f890c4ba92..f0a2e2a08ee7

2022-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 8243aeda757f to 84191ee7ff74 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-28 06:08:26 +00:00
skia-flutter-autoroll
c3bfb731b1 Roll Skia from 2618d380def4 to 79f890c4ba92 (1 revision) (flutter/engine#37921)
https://skia.googlesource.com/skia.git/+log/2618d380def4..79f890c4ba92

2022-11-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kaushikiska@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-27 11:39:24 +00:00
skia-flutter-autoroll
88bdce9555 Roll Skia from a01af64f5cec to 2618d380def4 (4 revisions) (flutter/engine#37907)
https://skia.googlesource.com/skia.git/+log/a01af64f5cec..2618d380def4

2022-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from f58d2966491e to a1a547bec450
2022-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 541cdcbf094f to 35247a4df408 (2 revisions)
2022-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from be34d55f8744 to f58d2966491e (1 revision)
2022-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ff2b5e441cc7 to 8243aeda757f (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jmbetancourt@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-25 13:25:21 +00:00
skia-flutter-autoroll
77253fe115 Roll Skia from f45e40d01dac to a01af64f5cec (1 revision) (flutter/engine#37896)
https://skia.googlesource.com/skia.git/+log/f45e40d01dac..a01af64f5cec

2022-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 46af29f17d19 to e4040f7ac260 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jmbetancourt@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-24 14:45:32 +00:00
skia-flutter-autoroll
40ce8282f7 Roll Skia from 665ae344c8ec to f45e40d01dac (4 revisions) (flutter/engine#37888)
https://skia.googlesource.com/skia.git/+log/665ae344c8ec..f45e40d01dac

2022-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from be34d55f8744 to f58d2966491e
2022-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 27727e501aee to 541cdcbf094f (13 revisions)
2022-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 20e090196af1 to be34d55f8744 (5 revisions)
2022-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from c7e156fb7b8f to ff2b5e441cc7 (27 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jmbetancourt@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-24 07:02:22 +00:00
Emircan Uysaler
8a3da8a9d5 [flatland] Update bug numbers. (flutter/engine#37880) 2022-11-23 16:14:48 -08:00
ColdPaleLight
57e527c227 [Impeller] Implement 'ui.decodeImageFromPixels' (flutter/engine#37866) 2022-11-23 23:37:53 +00:00
skia-flutter-autoroll
871bc546bb Roll Skia from c098e3c5d932 to e3c0b382b072 (12 revisions) (flutter/engine#37875)
https://skia.googlesource.com/skia.git/+log/c098e3c5d932..e3c0b382b072

2022-11-23 bungeman@google.com Move expat LICENSE file up to third_party/expat
2022-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bd2c589d0d34 to 46af29f17d19 (1 revision)
2022-11-23 bungeman@google.com Roll Expat from a28238bd to 441f98d0 (351 commits)
2022-11-23 bungeman@google.com Add roll script for expat
2022-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 20e090196af1 to e8d7a0b58143
2022-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 356b2a590e11 to 27727e501aee (13 revisions)
2022-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8d5d6fd45a13 to 20e090196af1 (2 revisions)
2022-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from edbeeee285d8 to c7e156fb7b8f (27 revisions)
2022-11-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 96f4fdc41b84 to bd2c589d0d34 (5 revisions)
2022-11-22 armansito@google.com [sksl] Support all compute stage inputs
2022-11-22 armansito@google.com [sksl] Reduce memory-order constraints of workgroupBarrier()
2022-11-22 brianosman@google.com Simplify the SkColor4fXformer signature

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jmbetancourt@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-23 21:32:58 +00:00
nbayati
8f64229bc0 Call focus on input after detecting a tap (flutter/engine#37863)
* fix tap detection and call focus

* addressed comments
2022-11-23 12:59:45 -08:00
sealesj
4220be6c72 Vulnerability Scanning on Third Party Deps (flutter/engine#36506)
* initial flatten deps scan

* move 3rd party scan to separate action

* allow fork to run

* install requests

* use packages

* pip install

* rename

* conditional vuln report

* trailing whitespace

* trailing whitespace

* detailed print

* add testing file

* add upload test sarif

* results sarif

* move sarif

* upload modified sarif

* test flow

* test with results.sarif

* formatting

* test naming convention

* description with text in artifactLocation

* don't use locations

* use template sarif

* just use template

* add one field mod

* add another field mod

* use actual osvReport

* add field

* add field

* test

* no information uri

* no information uri

* add name

* template NA data for results

* back to minimal template

* dynamic rules

* template update

* no results

* only use template

* test

* new test

* new test

* add back locations

* descriptive fields

* test

* use package name

* variable commit hash

* add chromium accessibility readme support

* use batch query test

* clean up

* use variables for sarif template

* initial automating ancestor commit

* allow for workflow on testing

* install gitpython in workflow

* wrap in try

* expand try

* check commit is not none

* quiet clone

* fix commit newline

* proper print for failed deps

* remove gitpython

* remove import

* fix origin source

* remove .dart from dep names

* update dep

* typo

* update

* clone into controlled name repo now

* fix github upstream clone url

* test CVE finding

* use templated rule and result

* typo

* remove test CVE

* add link straight to OSV DB

* comments

* use os mkdir

* check time of pinned commit

* quiet git

* print osv api query results if vulns found

* move upstream mapping into DEPS file

* add testing for DEPS file

* add khronos exception

* add basic ancestor commit test

* no vulns message

* do not produce empty sarif

* add yaml

* remove unused python dep

* no change?

* no more print, causing recipe issues

* string test

* string test

* no more fstrings

* convert to .format

* syntax

* remove unused dep

* test

* switch test script

* no encoding

* add back test

* typo

* remove scan flat deps tests again

* update

* fix tests

* typo

* newline

* use checkout dir

* prefix

* update to use prefix

* lint

* runhook attempt

* lint

* lint

* lint

* lint

* no license blurb

* cleanup

* enable for main

* do not raise error

* run on branch

* data indentation

* check file existence

* workflow updates

* add push for testing

* syntax

* workflow test

* test github action

* syntax

* allow empty report

* update cron

* pin hash

* newline

* sort by key with prefix omitted

* alphabetize, copyright header

* pylint tests

* lint

* lint

* trailing whitespace?

* lint

* update

* get error types

* allow test

* use output

* only main branch

* licenses check

* results.sarif

* revert

* license updates

* add upstream

* replace Requests library with urllib, remove pylint wrapper

* lint

* undo license

* clone test nit

* isinstance

* DEPS formatting

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

* use subprocess.check_output

* lint

* lint

* review syntax from comments

* remove line

* more description in error

* lint

* fix checkout path

* remove duplicate eval

* lint

* lint

* lint

* clone-test mkdir and cleanup

* use shutil.rmtree for non-empty dir

* lint

* linting

* linting

* var name

* Update ci/deps_parser_tests.py

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

* Update ci/deps_parser_tests.py

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

* more description

* lint

* refactor deps file parsing

* early return

* lint

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2022-11-23 15:07:43 -05:00
Mouad Debbar
e75803bfcf [web] Use generic variable name for trusted url (flutter/engine#37872) 2022-11-23 20:06:22 +00:00
Kaushik Iska
8a89a5e4a8 [Impeller] Add fenced command buffer that waits on-submit (flutter/engine#37750)
* [Impeller] Add fenced command buffer that waits on-submit

this isn't ideal for performance long term but aligns well with what
the other backends do. This also lets us remove the dependence on frame
numbers for renderpasses setting up for implementing MSAA.

* fix licenses
2022-11-23 19:47:18 +00:00
Srujan Gaddam
4cfd8884fe Fix DomProgressEvent constructor (flutter/engine#37849)
DomProgressEvent should have a non-synthetic constructor that accepts
a String to match the MDN definition:
https://developer.mozilla.org/en-US/docs/Web/API/ProgressEvent/ProgressEvent.
It should also have a JS name that points to ProgressEvent. Lastly,
image_golden_test is modified to use the parameter values from before the
static interop migration:
9276dc1ff1/lib/web_ui/test/canvaskit/image_golden_test.dart
2022-11-23 08:03:32 -08:00
skia-flutter-autoroll
dcc64fed39 Roll Fuchsia Linux SDK from 5Xd8MJTM-pWPWCgUa... to NlJGkMbtZqQ6_BCpu... (flutter/engine#37861)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-23 04:49:22 +00:00
Loïc Sharma
b9a416eb8d [Windows] Refactor PlatformHandler's tests (flutter/engine#37820)
* Start

* Add missing line

* Order

* Clean up includes

* Feedback

* Tweak
2022-11-22 23:41:42 +00:00
ColdPaleLight
9b336c2674 [Impeller] Set color attachment pixel format to RGBA on OpenGLES backend (flutter/engine#37843) 2022-11-22 23:40:15 +00:00
Jenn Magder
61cff10cc5 Turn on objc-* clang-tidy checks (flutter/engine#37813)
* Turn on objc-* clang-tidy checks

* turn off objc-nsinvocation-argument-lifetime
2022-11-22 23:08:08 +00:00
Jenn Magder
65bd5bafe9 Turn on darwin-* clang-tidy checks (flutter/engine#37814) 2022-11-22 23:08:06 +00:00
Jonah Williams
bc5766a92b fix docs analysis error on setImageSampler (flutter/engine#37852) 2022-11-22 14:30:50 -08:00
gaaclarke
633e238909 Made platform message responses threadsafe for macos. (flutter/engine#37607) 2022-11-22 22:22:04 +00:00
skia-flutter-autoroll
d6d2b099fc Roll Skia from 3bd2fe46f6d2 to c098e3c5d932 (2 revisions) (flutter/engine#37851)
https://skia.googlesource.com/skia.git/+log/3bd2fe46f6d2..c098e3c5d932

2022-11-22 brianosman@google.com Fix incorrect comments on SkGradientShader factories
2022-11-22 jcgregorio@google.com Add Pixel7 jobs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jmbetancourt@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-22 22:17:58 +00:00
Emircan Uysaler
326622e3f1 Set nested clip nodes (flutter/engine#37850) 2022-11-22 17:07:36 -05:00
cfontas
02f77a716e fix pixel ratio (flutter/engine#37268) 2022-11-22 16:32:20 -05:00
alanwutang11
f41f2ef1f6 change cloneImageElement() to return clone every time (flutter/engine#37811) 2022-11-22 13:13:18 -08:00
skia-flutter-autoroll
5ab4c97975 Roll Skia from 3b2d9e4bf668 to 3bd2fe46f6d2 (2 revisions) (flutter/engine#37848)
https://skia.googlesource.com/skia.git/+log/3b2d9e4bf668..3bd2fe46f6d2

2022-11-22 armansito@google.com [sksl] "workgroup" instead of "threadgroup"
2022-11-22 penghuang@chromium.org [graphite] Refactor DrawBufferManager to share code for allocating buffers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jmbetancourt@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-22 20:15:05 +00:00
Jonah Williams
7c3b0e3a52 [Impeller] make VerticesGeometry delegate to the DL class (flutter/engine#37835)
* [Impeller] make VerticesGeometry delegate to the DL class

* ++

* ++

* licenses

* ++
2022-11-22 20:11:23 +00:00
Brandon DeRosier
df3230a307 Remove setSampler from FragmentShader (flutter/engine#37839) 2022-11-22 11:26:17 -08:00
Mouad Debbar
9d9401970f [web] Move unicode properties to third_party (flutter/engine#37440)
* [web] Move unicode properties to third_party

* license

* fix license check

* attempt to fix license golden

* more license fixes

* even more license fixes

* add check mode and readme file

* fix licenses + add web_unicode.dart

* build web_unicode as an sdk library

* remove unnecessary variable

* minor fix in license golden

* tool signature
2022-11-22 18:47:11 +00:00
joshualitt
85265a3cf5 Reland "[web] Avoid returning int from js interop classes." (flutter/engine#37627) 2022-11-22 10:37:59 -08:00
Jonah Williams
6438d12a32 [Impeller] opt float/sampler into relaxed precision for gles (flutter/engine#37828)
* [Impeller] opt float/sampler into relaxed precision for gles

* re-arrange define
2022-11-22 18:27:31 +00:00
skia-flutter-autoroll
82c9c227ad Roll Skia from 0dec6d1823b3 to 3b2d9e4bf668 (1 revision) (flutter/engine#37845)
https://skia.googlesource.com/skia.git/+log/0dec6d1823b3..3b2d9e4bf668

2022-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4802bf762104 to 96f4fdc41b84 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jmbetancourt@google.com,kaushikiska@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-22 16:11:24 +00:00
skia-flutter-autoroll
c5026de559 Roll Fuchsia Linux SDK from xBfEjlXUsix6Wka-i... to 5Xd8MJTM-pWPWCgUa... (flutter/engine#37840)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-22 11:34:16 +00:00
skia-flutter-autoroll
163c379fc1 Roll Skia from 94c63addc990 to 0dec6d1823b3 (4 revisions) (flutter/engine#37836)
https://skia.googlesource.com/skia.git/+log/94c63addc990..0dec6d1823b3

2022-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 8d5d6fd45a13 to 2417a7bed7ee
2022-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0c0bbcf5889a to 356b2a590e11 (4 revisions)
2022-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from abac90684d1d to 8d5d6fd45a13 (2 revisions)
2022-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 228f75589550 to edbeeee285d8 (22 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,jmbetancourt@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-22 07:28:14 +00:00
skia-flutter-autoroll
05d3ced8ec Roll Skia from 550fd51bd254 to 94c63addc990 (1 revision) (flutter/engine#37834)
https://skia.googlesource.com/skia.git/+log/550fd51bd254..94c63addc990

2022-11-22 armansito@google.com [graphite] Dynamically determine uniform buffer layout requirements

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,jmbetancourt@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-22 06:02:32 +00:00
Zachary Anderson
ea0cebcf28 Revert "[impeller] Remove declare_undefined_values (#37829)" (flutter/engine#37831)
This reverts commit 986101452a.
2022-11-22 05:07:04 +00:00
skia-flutter-autoroll
8e58ac3f0f Roll Skia from 57b4252cf211 to 550fd51bd254 (3 revisions) (flutter/engine#37830)
https://skia.googlesource.com/skia.git/+log/57b4252cf211..550fd51bd254

2022-11-21 johnstiles@google.com Add dedicated zero_slots_unmasked op.
2022-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a3f4f653c783 to 4802bf762104 (4 revisions)
2022-11-21 jvanverth@google.com [graphite] Change Metal copy routines' labels to match the routine name

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,jmbetancourt@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2022-11-22 04:36:05 +00:00
Brandon DeRosier
a640b398e2 Add setImageSampler (for replacing setSampler) (flutter/engine#37821)
* Add setImageSampler (for replacing setSampler)

* Includes

* Remove deprecation tag, just in case there are roll problems

* Remove comment

* Fix comment

* Add setImageSampler for canvaskit

* Remove arg

* Fix conversion

* Float64List

* final...

* Pass along the engine handle
2022-11-22 04:24:14 +00:00