Commit Graph

110 Commits

Author SHA1 Message Date
Alexandre Ardhuin
0fb84e96c7 Prefer void to null (#22977)
* Future<void> main

* Future<void>.delayed

* prefer_void_to_Null

* address review comments
2018-10-16 22:03:06 +02:00
matthew-carroll
04a26778c5 Revert "Reversion for roll (#22984)" (#23029)
This reverts commit 80f80ab08c.
2018-10-12 16:31:34 -07:00
matthew-carroll
80f80ab08c Reversion for roll (#22984)
For G3 Roll:

* Revert "MaterialButton must honor its minWidth and height parameters (#22919)"

This reverts commit a02332335a.

* Revert "Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)"

This reverts commit 655bf6a290.

* Revert "ButtonTheme.of().colorScheme defers to Theme (#22880)"

This reverts commit a590940e45.

* Revert "Bring TextTheme into alignment with the current Material spec (#22330)"

This reverts commit 8bfb4b3ee5.

* Revert "Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)"

This reverts commit eea3465ae7.

* Manual adjustments to fix reversion issues.
2018-10-11 18:17:46 -07:00
Jonah Williams
313059cdb6 Add labeled tappable target guideline and gallery tests (#22824) 2018-10-11 15:05:10 -07:00
Jonah Williams
cdf1cec902 add ability to match child semantics data (#22001) 2018-10-05 17:44:26 -07:00
Jonah Williams
cfc73590b7 Adds more time to contrast tests (#22681) 2018-10-04 15:56:52 -07:00
Hans Muller
eea3465ae7 Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)
Introduce an overall material "color scheme" and to make it possible to redefine how a component's visual properties bind to the color scheme and to the existing material Theme.
2018-10-02 14:50:43 -07:00
mockturtl
13684e4f8e use RadioListTile in expansion panels demo (#20240)
* use RadioListTile in expansion panels demo

Fixes #6048.
- expose `_Location`
- appease analyzer
2018-10-02 11:15:17 -07:00
Hans Muller
6c00bf98ee Fix overscroll_demo in the a11y contrast test (#22276) 2018-09-25 14:38:25 -07:00
Dan Field
ea5435c2ef Widgets app refactor (#22269)
* Refactor of cupertino/material/widgets app

* update docs 

* Update tests for const
2018-09-25 13:57:12 -04:00
Dan Field
a52bd81560 Revert "Refactor of cupertino/material/widgets app (#22161)" (#22249)
This reverts commit 61cf946ba8.
2018-09-25 00:25:50 -04:00
Dan Field
61cf946ba8 Refactor of cupertino/material/widgets app (#22161)
* Make CupertinoApp and MaterialApp both use WidgetsApp for Navigator

* Make CupertinoApp and MaterialApp const constructors

* Make WidgetsApp routes aware

* Update tests
2018-09-24 23:55:03 -04:00
Hans Muller
2d0af0aa48 Gallery accessibility test: check default themes, gallery themes (#22141) 2018-09-24 10:41:30 -07:00
Jonah Williams
e9e2ca160d Don't use dense dropdown buttons in the Gallery date/time picker demo (#21693) 2018-09-12 14:15:28 -07:00
Alexandre Ardhuin
d927c93310 Unnecessary new (#20138)
* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests
2018-09-12 08:29:29 +02:00
Jonah Williams
fa0a857d02 Add material tap target size and text contrast test to gallery (#21581) 2018-09-11 08:27:32 -07:00
TL Lee
e2f3b3d6f2 Feature pesto new recipes (#19415)
<img width="273" alt="pesto_before" src="https://user-images.githubusercontent.com/13839358/43009716-64b6d726-8c0c-11e8-989a-13eaff72ccee.png">
<img width="273" alt="pesto_after" src="https://user-images.githubusercontent.com/13839358/43009717-66074a34-8c0c-11e8-92ae-f5fb4074f43a.png">
2018-08-17 17:58:25 -04:00
Ian Hickson
686d8f8a22 Shim package:test to avoid matcher issues (#20602)
* Upgrade everything except matcher.
* Roll matcher (and test)
* Adjust tests that depend on flutter:test directly to depend on a shim
* Require use of package:test shim and remove other references to package:test
2018-08-14 20:33:58 -07:00
Ian Hickson
93b0265199 Fix flutter_gallery_instrumentation_test (#20361)
Somehow I forgot to say "super.tap()" when calling "tap()" on the new
superclass, so it was just recursing infinitely but ended up actually
crashing on the first reuse of the finder.

The error was previously swallowed, I made this print it instead.
2018-08-09 16:57:41 -07:00
Ian Hickson
872e88cec7 Reduce noise on the memory benchmarks (#19630) (#20163)
- Check memory usage in release builds, not profile.
- Use multiple runs and average the results.
2018-08-06 12:46:51 -07:00
Jonah Williams
ddd7e4ead1 improve semantics of chip demo (#20121) 2018-08-03 21:10:33 -07:00
Ian Hickson
a2ca14d71e Revert "Reduce noise on the memory benchmarks" (#20158)
* Revert "Add pub cache, artifacts, pkgs to Cirrus cache (#20080)"

This reverts commit 07e93b385c.

* Revert "Reduce noise on the memory benchmarks (#19630)"

This reverts commit 8eb5cb7dc0.
2018-08-02 13:56:44 -07:00
Ian Hickson
8eb5cb7dc0 Reduce noise on the memory benchmarks (#19630)
- Check memory usage in release builds, not profile.
- Use multiple runs and average the results.
2018-08-02 12:22:15 -07:00
Alexandre Ardhuin
eda03e2586 re-re-enable lint unnecessary_const (#20103) 2018-08-02 12:02:32 +02:00
Todd Volkert
00aac68e2d Revert flutter/flutter#19592 (#19861)
It was causing problems rolling Flutter into Fuchsia
2018-07-27 08:44:39 -07:00
Alexandre Ardhuin
27018359d2 re-enable lint unnecessary_const (#19592)
* re-enable lint unnecessary_const

* remove trailling whitespaces

* remove unnecessary const (after merge)
2018-07-23 08:31:48 +02:00
Ian Hickson
f630f90d6d Revert "enable lint unnecessary_const (#19342)" (#19423)
This reverts commit cc1cf13eec.
2018-07-16 13:30:27 -07:00
Alexandre Ardhuin
cc1cf13eec enable lint unnecessary_const (#19342) 2018-07-16 21:43:48 +02:00
Michael Goderbauer
409007827b Keep TextFields visible when keyboard comes up (#18291)
Fixes #10826.

Also in this PR: If you focus a text field, scroll it out of view and then start typing it will scroll back into view.
2018-06-15 10:11:10 -07:00
Alexandre Ardhuin
09276bea25 enable lint prefer_equal_for_default_values (#18156) 2018-06-05 08:50:40 +02:00
Ian Hickson
e3427550e9 Be less verbose in the logs. (#17401)
Now that we have thousands of tests, it doesn't make sense to display a separate line for each test. The result is just megabytes of logs that you have to scrub through to find error messages.
2018-06-04 15:22:19 -07:00
Hans Muller
580c844c2f Added GalleryApp testMode (#17640) 2018-05-16 11:42:39 -07:00
Hans Muller
eee986b076 Gallery cosmetic updates (#17310) 2018-05-07 09:25:50 -07:00
Todd Volkert
65079ad5f2 Add Flutter-repo-specific golden comparator (#17205)
In order to avoid checking binaries into flutter/flutter,
this comparator can be used to retrieve golden files from
a sibling flutter/goldens repository.

https://github.com/flutter/flutter/issues/16859
2018-05-03 07:39:41 -07:00
xster
709b0cb285 Accessibility fixes for new gallery (#16973) 2018-04-30 17:19:00 -07:00
Hans Muller
5c2259d505 Cross fade gallery UI front layer (#17064) 2018-04-30 08:23:11 -07:00
Hans Muller
bf3bd7667f New Gallery UI reprise (#17031) 2018-04-27 08:11:20 -07:00
Hans Muller
38d5d46127 Revert "New Flutter Gallery UI" (#16984)
* Revert "New Flutter Gallery UI (#16936)"

This reverts commit 7038597b02.
2018-04-25 18:41:07 -07:00
Hans Muller
7038597b02 New Flutter Gallery UI (#16936)
A new front-end for the Flutter Gallery example.
2018-04-25 14:15:34 -07:00
Hans Muller
cdb82fce92 Put the backdrop demo controls on the right (#16902) 2018-04-23 17:19:39 -07:00
Hans Muller
a0099a9016 Make gallery tests more robust (#15957) 2018-03-27 13:39:30 -07:00
xster
feadfd2e40 Cupertino pull to refresh part 1: sliver and a simple indicator widget builder (#15324)
* Gallery scaffolding

* Started RenderSliver

* demo and initial hookup

* Cleaned up demo more and scaffolding basic sliver->widget communication structure.

* works

* states and default indicator building works

* start adding docs

* added an alignment setting optimized the sliver relayout mechanism

* tested a default bottom aligned sized indicator

* Added a bunch of tests

* more fixes and more tests

* Finished the tests

* Add docs

* Add more doc diffing wrt material pull to refresh

* Mention nav bar synergy

* add more asserts

* review 1

* Fix mockito 2 / dart 2 / strong typed tests

* review

* Remove the vscode config

* review
2018-03-21 17:27:58 -07:00
xster
33fea5c19a Remove the 'demo' wording from gallery (#15640) 2018-03-19 17:03:56 -07:00
Hans Muller
c599662903 Added a Backdrop demo to the Gallery (#15579) 2018-03-15 17:52:09 -07:00
Hans Muller
b6cca3923a Updated the gallery text fields demo (#15362) 2018-03-14 14:42:45 -07:00
Danny Tuppeny
ae9fdefa4f Fix example code just showing endless spinner when deployed from Windows (#14878)
* If example code is not found, render a message instead of an endless spinner
* Trim codeTags to avoid lookup issues with windows carriage returns
* Trim \r on Windows off the end of code blocks so they're consistently \n
* Add a test to ensure sample code parses if built on Windows
* Add a comment about why we trimRight()

Fixes #14820.
2018-02-28 20:39:48 +00:00
Alexandre Ardhuin
c02b6a8bcf some whitespace cleanup (#14443) 2018-02-02 23:27:29 +01:00
Ian Hickson
c12d120bbf Provide a way to override global InheritedWidgets (#14348)
For example, so that the gallery can override the media query globally.
2018-02-01 23:12:52 -08:00
Alexandre Ardhuin
841d5d7bd5 prefer_const_declarations on local variables (#14358) 2018-02-01 07:51:26 +01:00
xster
82ddabd32a Fastlane instructives for tool publishing the Gallery (#14347)
* first round fastlane working on Android

* clean up and start ios

* Partial iOS

* Got a fastfile that works on iOS

* Finalize Android push instructions

* Finalize instructions for iOS

* Extra cleanup and optipng

* Disable readme autogen and add a default readme
2018-01-31 11:21:37 -08:00