firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
32,182 Commits 1 Branch 0 Tags
fa02835346229b39748cd0eb8c9824816bcfe861
Commit Graph

24417 Commits

Author SHA1 Message Date
Jason Simmons
fa02835346 [Impeller] Use a weak pointer factory in GPUSurfaceGLImpeller that supports the raster thread merger (flutter/engine#47081) 
This is required for platform view scenarios that merge the raster task runner into the platform thread.
 2023-10-19 20:22:04 +00:00
skia-flutter-autoroll
448d15dd85 Roll Dart SDK from ea86103e06b1 to f71ddbe0a500 (1 revision) (flutter/engine#47124) 
https://dart.googlesource.com/sdk.git/+log/ea86103e06b1..f71ddbe0a500

2023-10-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-45.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 19:57:23 +00:00
skia-flutter-autoroll
9844d5c903 Roll Skia from 04449cda5a0a to b540ed3ba8e7 (4 revisions) (flutter/engine#47118) 
https://skia.googlesource.com/skia.git/+log/04449cda5a0a..b540ed3ba8e7

2023-10-19 kjlubick@google.com Add index.d.ts to debugger and jsfiddle images
2023-10-19 kjlubick@google.com Fix IWYU
2023-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 7317f665cc52 to 4759145c009e (8 revisions)
2023-10-19 johnstiles@google.com Fix ClangTidy `performance-unnecessary-value-param` findings.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 19:14:13 +00:00
Jia Hao
0e87f9611e Fix use of nested designators (flutter/engine#45869) 
There was an internal global change which turned `-Wc99-designator`. This causes the following error:

```
error: nested designators are a C99 extension [-Werror,-Wc99-designator]
   65 |       .metal.struct_size = sizeof(FlutterMetalRendererConfig),
      |       ^~~~~~~~~~~~~~~~~~
```

This seems like a trivial (?) fix, so perhaps we can fix it properly and possibly remove b9fbd310d6/build/config/compiler/BUILD.gn (L667) after this PR lands.

*List which issues are fixed by this PR. You must list at least one issue.*

b/300573112

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-19 18:37:32 +00:00
Chris Yang
e559ceb0ac [iOS] Load additional Cupertino system fonts (flutter/engine#46857) 
Manually loads darwin system fonts. Darwin system fonts returns different typeface in different sizes. This PR loads the font in different sizes then register them as different fonts. These new fonts can be access through the framework.

Fixes https://github.com/flutter/flutter/issues/63507

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-19 17:52:31 +00:00
Jia Hao
ff7829558f Add missing import (flutter/engine#47083) 
Fixes the following:

c8aa0844f2 results in the following error appearing internally when compiling for Android:

```
In file included from fml/synchronization/sync_switch.cc:5:
./fml/synchronization/sync_switch.h:74:34: error: implicit instantiation of undefined template 'std::vector<fml::SyncSwitch::Observer *>'
  mutable std::vector<Observer*> observers_;
                                 ^
<...>: note: template is declared here
class _LIBCPP_TEMPLATE_VIS vector;
                           ^
1 error generated.
```

*List which issues are fixed by this PR. You must list at least one issue.*
b/306266542

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-19 16:47:20 +00:00
skia-flutter-autoroll
cd7298b69d Roll Skia from b31b189be018 to 04449cda5a0a (1 revision) (flutter/engine#47105) 
https://skia.googlesource.com/skia.git/+log/b31b189be018..04449cda5a0a

2023-10-19 kjlubick@google.com Remove SkTypeface::UniqueID

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 16:17:24 +00:00
skia-flutter-autoroll
5dda282b51 Roll Dart SDK from 1b425a25a6dd to ea86103e06b1 (1 revision) (flutter/engine#47101) 
https://dart.googlesource.com/sdk.git/+log/1b425a25a6dd..ea86103e06b1

2023-10-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-44.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 13:38:25 +00:00
Jim Graham
5bcbd59138 Revert "[web] Ensure handled key event is not propagated to IME" (flutter/engine#47086) 
Reverts flutter/engine#46829

Fixes https://github.com/flutter/flutter/issues/136857

Speculative fix for The builds breaking on the web text tests as seen
here: https://github.com/flutter/flutter/runs/17840697842
 2023-10-19 09:40:27 +03:00
skia-flutter-autoroll
8a98010f73 Roll Fuchsia Linux SDK from 2HSBpWikGWvPJlHOP... to Z2mOZ5cuPJWvKn22P... (flutter/engine#47094) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 06:16:00 +00:00
skia-flutter-autoroll
62192ae8b7 Roll Skia from 64c5de6663a4 to 62acc1e162cc (1 revision) (flutter/engine#47093) 
https://skia.googlesource.com/skia.git/+log/64c5de6663a4..62acc1e162cc

2023-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0cf4951e9bc0 to 37332ece3fb7 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 06:08:52 +00:00
skia-flutter-autoroll
eb6b2e8da9 Roll Dart SDK from eb3fb9a13e16 to 1b425a25a6dd (1 revision) (flutter/engine#47092) 
https://dart.googlesource.com/sdk.git/+log/eb3fb9a13e16..1b425a25a6dd

2023-10-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-43.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 05:31:11 +00:00
skia-flutter-autoroll
34a2facb87 Roll Dart SDK from d9b1e60fe442 to eb3fb9a13e16 (1 revision) (flutter/engine#47084) 
https://dart.googlesource.com/sdk.git/+log/d9b1e60fe442..eb3fb9a13e16

2023-10-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-42.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-19 01:27:33 +00:00
Chinmay Garde
18dd0095b2 Update buildroot to ab76ccba2ca4ce4. (flutter/engine#47078) 2023-10-18 22:55:31 +00:00
Christopher Fujino
ec4c2c83a6 migrate const_finder to use the implementation from package:kernel (flutter/engine#47077) 
After f0933ab69e, //tools/const_finder/lib/const_finder.dart was copied to the package:kernel source so that internal AST structures could be changed without breaking flutter/engine.

This change deletes that file, and updates //tools/const_finder/bin/main.dart to depend on the package:kernel version instead.

We are still running all the same integration tests we did previously.

FYI @johnniwinther
 2023-10-18 22:36:22 +00:00
Jason Simmons
8307dd2bfb [Impeller] Guard execution of ReactorGLES operations with a mutex (flutter/engine#47068) 
Both the raster and IO threads can flush the ops queue. The reactor must
ensure that execution of queued ops is serialized.

Fixes https://github.com/flutter/flutter/issues/135524
 2023-10-18 15:15:16 -07:00
Chinmay Garde
34497469a9 [Impeller] Document ReactorGLES. (flutter/engine#47070) 2023-10-18 22:13:22 +00:00
Matej Knopp
688a695f2b [web] Ensure handled key event is not propagated to IME (flutter/engine#46829) 
Fixes [136460](https://github.com/flutter/flutter/issues/136460)

Changes:
- Raw keyboard event is handled during capture phase. This is to ensure
that the framework processes the event before reaching to IME text area
and raw keyboard can stop the propagation for handled events.
- `RawKeyboard` event handler is invoked from `KeyboardBinding` event
handler. This is to prevent race condition because both handlers now run
in capture phase and `KeyboardBinding` needs to process the event first.

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-19 00:52:53 +03:00
skia-flutter-autoroll
0ee1ff3a9c Roll Skia from d46a3697d3c5 to d561b276b5d9 (1 revision) (flutter/engine#47074) 
https://skia.googlesource.com/skia.git/+log/d46a3697d3c5..d561b276b5d9

2023-10-18 brianosman@google.com Remove obsolete SkColorSpace deserialization code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 21:51:15 +00:00
skia-flutter-autoroll
85d3ef1233 Roll Dart SDK from b423d5753fdc to d9b1e60fe442 (1 revision) (flutter/engine#47073) 
https://dart.googlesource.com/sdk.git/+log/b423d5753fdc..d9b1e60fe442

2023-10-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-41.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 21:40:46 +00:00
Tong Mu
6584b2c308 Reland 2 (part 1): Enforce the rule of calling FlutterView.Render (flutter/engine#47062) 
This PR relands part of https://github.com/flutter/engine/pull/45300,
which was reverted in https://github.com/flutter/engine/pull/46919 due
to performance regression.

Due to how little and trivial production code the original PR touches, I
really couldn't figure out the exact line that caused it except through
experimentation, which requires changes to be officially landed on the
main branch. After this PR lands, I'll immediately fire a performance
test.

This PR contains the `Shell` refactor of the original PR. I made a
slight change where the isolate snapshot is no longer returned through
return value, but the parameter, in order to avoid the overhead of
assigning.

It is intentional to not contain any unit tests or other changes of the
original PR. They will be landed shortly after this PR.

Part of https://github.com/flutter/flutter/issues/136826.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-18 14:09:01 -07:00
skia-flutter-autoroll
6a9ee650d3 Roll Skia from ef0e93524e7d to d46a3697d3c5 (2 revisions) (flutter/engine#47072) 
https://skia.googlesource.com/skia.git/+log/ef0e93524e7d..d46a3697d3c5

2023-10-18 jvanverth@google.com [graphite] Add PerEdgeAAQuadRenderStep.
2023-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 54c4b89e2ac3 to 4885e1405318 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 21:06:17 +00:00
LongCatIsLooong
fe6ed54c97 [iOS TextInputPlugin] adjust the markedTextRange when replacing text. (flutter/engine#46603) 
Fixes https://github.com/flutter/flutter/issues/130880 , by making sure when the text is cleared the `markedTextRange` is cleared with it. 

`[UITextField replaceRange:withText:]` always sets the selection range to the end of the replacement text, and removes the current `markedTextRange`. This PR makes the input plugin do the same in the `replaceRange:withText:` implementation.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-18 20:33:14 +00:00
Zachary Anderson
70ba5c45fb Reland: Remove the frontend server wrapper (flutter/engine#47010) 
Relands https://github.com/flutter/engine/pull/46440 with https://github.com/flutter/engine/pull/46842
 2023-10-18 20:32:37 +00:00
skia-flutter-autoroll
f696495c9e Roll Skia from 9880c4006735 to ef0e93524e7d (1 revision) (flutter/engine#47069) 
https://skia.googlesource.com/skia.git/+log/9880c4006735..ef0e93524e7d

2023-10-18 jamesgk@google.com Reland "[graphite] Use hardware image tiling when not subsetting"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 20:25:01 +00:00
skia-flutter-autoroll
6b90282a5d Roll Skia from 523f04f1a898 to 9880c4006735 (1 revision) (flutter/engine#47067) 
https://skia.googlesource.com/skia.git/+log/523f04f1a898..9880c4006735

2023-10-18 herb@google.com Introduce EventQueue and SweepLine interfaces

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 19:37:09 +00:00
skia-flutter-autoroll
aeb3c9c46e Roll Skia from b8c989df901a to ccd07c6f5042 (3 revisions) (flutter/engine#47063) 
https://skia.googlesource.com/skia.git/+log/b8c989df901a..ccd07c6f5042

2023-10-18 bungeman@google.com Fix NoDEPS jobs
2023-10-18 johnstiles@google.com Avoid constructing and passing a SkData for each fuzz iteration.
2023-10-18 johnstiles@google.com Remove sk_sp<SkData> from Fuzz helper class.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 18:16:23 +00:00
Matan Lurey
c9c5c52428 Add --lint-all=<regex> as an option for clang_tidy, refactor lint targets (flutter/engine#46522) 
I plan to use this to get reasonable re-lint times locally when
iterating on enabling lints, and finishing
https://github.com/flutter/flutter/issues/134969.

For example:

```shell
$ prebuilts/macos-arm64/dart-sdk/bin/dart tools/clang_tidy/bin/main.dart --lint-regex=".*\/fml\/.*"
┌──────────────────────────┐
│ Engine Clang Tidy Linter │
└──────────────────────────┘
The following errors have been reported by the Engine Clang Tidy Linter.  For
more information on addressing these issues please see:
https://github.com/flutter/flutter/wiki/Engine-Clang-Tidy-Linter

🔶 linting flutter/fml/command_line.cc
🔶 linting flutter/fml/command_line.cc
🔶 linting flutter/fml/ascii_trie.cc
🔶 linting flutter/fml/base32.cc
🔶 linting flutter/fml/concurrent_message_loop.cc
🔶 linting flutter/fml/cpu_affinity.cc
🔶 linting flutter/fml/delayed_task.cc
🔶 linting flutter/fml/endianness.cc
🔶 linting flutter/fml/file.cc
🔶 linting flutter/fml/hex_codec.cc
🔶 linting flutter/fml/icu_util.cc
🔶 linting flutter/fml/log_settings.cc
🔶 linting flutter/fml/log_settings_state.cc
🔶 linting flutter/fml/logging.cc
🔶 linting flutter/fml/mapping.cc
🔶 linting flutter/fml/memory/task_runner_checker.cc
🔶 linting flutter/fml/memory/thread_checker.cc
🔶 linting flutter/fml/memory/weak_ptr_internal.cc
🔶 linting flutter/fml/message_loop.cc
🔶 linting flutter/fml/message_loop_impl.cc
🔶 linting flutter/fml/message_loop_task_queues.cc
🔶 linting flutter/fml/paths.cc
🔶 linting flutter/fml/raster_thread_merger.cc
🔶 linting flutter/fml/shared_thread_merger.cc
🔶 linting flutter/fml/synchronization/count_down_latch.cc
🔶 linting flutter/fml/synchronization/semaphore.cc
🔶 linting flutter/fml/synchronization/sync_switch.cc
🔶 linting flutter/fml/synchronization/waitable_event.cc
🔶 linting flutter/fml/task_runner.cc
🔶 linting flutter/fml/task_source.cc
🔶 linting flutter/fml/thread.cc
🔶 linting flutter/fml/thread_local.cc
🔶 linting flutter/fml/time/time_point.cc
🔶 linting flutter/fml/trace_event.cc
🔶 linting flutter/fml/unique_fd.cc
🔶 linting flutter/fml/backtrace_stub.cc
🔶 linting flutter/fml/platform/darwin/concurrent_message_loop_factory.mm
🔶 linting flutter/fml/platform/posix/shared_mutex_posix.cc
🔶 linting flutter/fml/platform/darwin/cf_utils.cc
🔶 linting flutter/fml/platform/darwin/message_loop_darwin.mm
🔶 linting flutter/fml/platform/darwin/paths_darwin.mm
🔶 linting flutter/fml/platform/darwin/platform_version.mm
🔶 linting flutter/fml/platform/darwin/scoped_block.mm
🔶 linting flutter/fml/platform/darwin/scoped_nsautorelease_pool.cc
🔶 linting flutter/fml/platform/darwin/scoped_nsobject.mm
🔶 linting flutter/fml/platform/darwin/string_range_sanitization.mm
🔶 linting flutter/fml/platform/posix/command_line_posix.cc
🔶 linting flutter/fml/platform/posix/file_posix.cc
🔶 linting flutter/fml/platform/posix/mapping_posix.cc
🔶 linting flutter/fml/platform/posix/native_library_posix.cc
🔶 linting flutter/fml/platform/posix/paths_posix.cc
🔶 linting flutter/fml/platform/posix/posix_wrappers_posix.cc
🔶 linting flutter/fml/ascii_trie.cc
🔶 linting flutter/fml/base32.cc
🔶 linting flutter/fml/concurrent_message_loop.cc
🔶 linting flutter/fml/cpu_affinity.cc
🔶 linting flutter/fml/delayed_task.cc
🔶 linting flutter/fml/endianness.cc
🔶 linting flutter/fml/file.cc
🔶 linting flutter/fml/hex_codec.cc
🔶 linting flutter/fml/icu_util.cc
🔶 linting flutter/fml/log_settings.cc
🔶 linting flutter/fml/log_settings_state.cc
🔶 linting flutter/fml/logging.cc
🔶 linting flutter/fml/mapping.cc
🔶 linting flutter/fml/memory/task_runner_checker.cc
🔶 linting flutter/fml/memory/thread_checker.cc
🔶 linting flutter/fml/memory/weak_ptr_internal.cc
🔶 linting flutter/fml/message_loop.cc
🔶 linting flutter/fml/message_loop_impl.cc
🔶 linting flutter/fml/message_loop_task_queues.cc
🔶 linting flutter/fml/paths.cc
🔶 linting flutter/fml/raster_thread_merger.cc
🔶 linting flutter/fml/shared_thread_merger.cc
🔶 linting flutter/fml/synchronization/count_down_latch.cc
🔶 linting flutter/fml/synchronization/semaphore.cc
🔶 linting flutter/fml/synchronization/sync_switch.cc
🔶 linting flutter/fml/synchronization/waitable_event.cc
🔶 linting flutter/fml/task_runner.cc
🔶 linting flutter/fml/task_source.cc
🔶 linting flutter/fml/thread.cc
🔶 linting flutter/fml/thread_local.cc
🔶 linting flutter/fml/time/time_point.cc
🔶 linting flutter/fml/trace_event.cc
🔶 linting flutter/fml/unique_fd.cc
🔶 linting flutter/fml/backtrace_stub.cc
🔶 linting flutter/fml/platform/darwin/concurrent_message_loop_factory.mm
🔶 linting flutter/fml/platform/posix/shared_mutex_posix.cc
🔶 linting flutter/fml/platform/darwin/cf_utils.cc
🔶 linting flutter/fml/platform/darwin/message_loop_darwin.mm
🔶 linting flutter/fml/platform/darwin/paths_darwin.mm
🔶 linting flutter/fml/platform/darwin/platform_version.mm
🔶 linting flutter/fml/platform/darwin/scoped_block.mm
🔶 linting flutter/fml/platform/darwin/scoped_nsautorelease_pool.cc
🔶 linting flutter/fml/platform/darwin/scoped_nsobject.mm
🔶 linting flutter/fml/platform/darwin/string_range_sanitization.mm
🔶 linting flutter/fml/platform/posix/command_line_posix.cc
🔶 linting flutter/fml/platform/posix/file_posix.cc
🔶 linting flutter/fml/platform/posix/mapping_posix.cc
🔶 linting flutter/fml/platform/posix/native_library_posix.cc
🔶 linting flutter/fml/platform/posix/paths_posix.cc
🔶 linting flutter/fml/platform/posix/posix_wrappers_posix.cc
🔶 linting flutter/fml/message_loop_task_queues_benchmark.cc
🔶 linting flutter/fml/ascii_trie_unittests.cc
🔶 linting flutter/fml/backtrace_unittests.cc
🔶 linting flutter/fml/base32_unittest.cc
🔶 linting flutter/fml/closure_unittests.cc
🔶 linting flutter/fml/command_line_unittest.cc
🔶 linting flutter/fml/container_unittests.cc
🔶 linting flutter/fml/cpu_affinity_unittests.cc
🔶 linting flutter/fml/endianness_unittests.cc
🔶 linting flutter/fml/file_unittest.cc
🔶 linting flutter/fml/hash_combine_unittests.cc
🔶 linting flutter/fml/hex_codec_unittest.cc
🔶 linting flutter/fml/logging_unittests.cc
🔶 linting flutter/fml/mapping_unittests.cc
🔶 linting flutter/fml/math_unittests.cc
🔶 linting flutter/fml/memory/ref_counted_unittest.cc
🔶 linting flutter/fml/memory/task_runner_checker_unittest.cc
🔶 linting flutter/fml/memory/weak_ptr_unittest.cc
🔶 linting flutter/fml/message_loop_impl_unittests.cc
🔶 linting flutter/fml/message_loop_task_queues_merge_unmerge_unittests.cc
🔶 linting flutter/fml/message_loop_task_queues_unittests.cc
🔶 linting flutter/fml/message_loop_unittests.cc
🔶 linting flutter/fml/paths_unittests.cc
🔶 linting flutter/fml/raster_thread_merger_unittests.cc
🔶 linting flutter/fml/string_conversion_unittests.cc
🔶 linting flutter/fml/synchronization/count_down_latch_unittests.cc
🔶 linting flutter/fml/synchronization/semaphore_unittest.cc
🔶 linting flutter/fml/synchronization/sync_switch_unittest.cc
🔶 linting flutter/fml/synchronization/waitable_event_unittest.cc
🔶 linting flutter/fml/task_source_unittests.cc
🔶 linting flutter/fml/thread_local_unittests.cc
🔶 linting flutter/fml/thread_unittests.cc
🔶 linting flutter/fml/time/chrono_timestamp_provider.cc
🔶 linting flutter/fml/time/time_delta_unittest.cc
🔶 linting flutter/fml/time/time_point_unittest.cc
🔶 linting flutter/fml/time/time_unittest.cc
🔶 linting flutter/fml/platform/darwin/cf_utils_unittests.mm
🔶 linting flutter/fml/platform/darwin/string_range_sanitization_unittests.mm
🔶 linting flutter/fml/string_conversion.cc
🔶 linting flutter/fml/string_conversion.cc
🔶 linting flutter/fml/dart/dart_converter.cc
[0:00] Jobs:   0% done,   1/143 completed,  7 in progress, 135 pending,   0 failed.  
```
 2023-10-18 11:06:04 -07:00
skia-flutter-autoroll
d4b98c93a5 Roll Dart SDK from da48c75b73b1 to b423d5753fdc (5 revisions) (flutter/engine#47061) 
https://dart.googlesource.com/sdk.git/+log/da48c75b73b1..b423d5753fdc

2023-10-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-40.0.dev
2023-10-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-39.0.dev
2023-10-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-38.0.dev
2023-10-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-37.0.dev
2023-10-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-36.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 17:33:48 +00:00
skia-flutter-autoroll
03b59204c8 Roll Skia from 5857f5f05b35 to b8c989df901a (5 revisions) (flutter/engine#47060) 
https://skia.googlesource.com/skia.git/+log/5857f5f05b35..b8c989df901a

2023-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 444eb9b78e14 to 0d214ae84fb2
2023-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 84356d9e8452 to bce95eb72596
2023-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 72a86e8cc35e to ead32575e5bc
2023-10-18 jvanverth@google.com [graphite] Loosen up strict Recording order on failure.
2023-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 3605928905e4 to 243e5abc4daa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 17:31:58 +00:00
skia-flutter-autoroll
c47bea859f Roll Fuchsia Linux SDK from OudOcFarQhQQzKDBx... to 2HSBpWikGWvPJlHOP... (flutter/engine#47059) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 17:30:12 +00:00
skia-flutter-autoroll
816d1d71e7 Roll Skia from a52d2a9e2b01 to 5857f5f05b35 (1 revision) (flutter/engine#47057) 
https://skia.googlesource.com/skia.git/+log/a52d2a9e2b01..5857f5f05b35

2023-10-18 armansito@google.com [graphite] Do not atlas large paths with compute

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 16:47:35 +00:00
Jia Hao
717b750145 Add missing source file (flutter/engine#47046) 
Maybe I'm missing something here. It seems like we include this file below:

dae6a4deb4/shell/platform/embedder/pixel_formats.cc (L5)

But it isn't mentioned in the gn file. Not sure how it is actually working today.
 2023-10-18 16:13:12 +00:00
skia-flutter-autoroll
817834ac29 Roll Skia from 8132e3356d63 to 5172e904def7 (4 revisions) (flutter/engine#47052) 
https://skia.googlesource.com/skia.git/+log/8132e3356d63..5172e904def7

2023-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 178effa90318 to c7b6044ad30b (4 revisions)
2023-10-18 kjlubick@google.com Add oss-fuzz harness for SkColorSpace
2023-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 5d5be56d5117 to 54c4b89e2ac3 (6 revisions)
2023-10-18 johnstiles@google.com Fix TArray::emplace_back when pushing refs inside the container.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 15:16:49 +00:00
Zachary Anderson
20d604b8ad Revert "Roll buildroot to pull in removal of //tools." (flutter/engine#47053) 
Reverts flutter/engine#47032

This is causing the Dart -> Engine roll to fail because one of the
removed scripts is used by the autoroller.
 2023-10-18 07:58:26 -07:00
skia-flutter-autoroll
495069c8c5 Roll Skia from fed09695a0b9 to 8132e3356d63 (2 revisions) (flutter/engine#47050) 
https://skia.googlesource.com/skia.git/+log/fed09695a0b9..8132e3356d63

2023-10-18 johnstiles@google.com Add test for push-from-inner-reference in SkTArray.
2023-10-18 kjlubick@google.com Add new SkTypeface APIs which take SkFontMgr

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 14:30:20 +00:00
skia-flutter-autoroll
b80d83c32e Roll Skia from 8796ee7d1c66 to 3d938d4b00ee (3 revisions) (flutter/engine#47042) 
https://skia.googlesource.com/skia.git/+log/8796ee7d1c66..3d938d4b00ee

2023-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 400ac3a175a6 to 91b84ac6d8ea (1 revision)
2023-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d42ad20d2b50 to 0cf4951e9bc0 (8 revisions)
2023-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b665b7fda7cf to 5d5be56d5117 (17 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 05:56:27 +00:00
Matej Knopp
6054dbd0cb [macOS] Fix tests failing on Sonoma (flutter/engine#46461) 
1. Using arbitrary struct passed as const reference  to `OCMStub` now fails in OCMock. Down the line this will result with `object_getClass` being called in [`OCMArg.m`](https://github.com/erikdoe/ocmock/blob/master/Source/OCMock/OCMArg.m#L129-L133) with the address of the reference, which is not a valid class instance. This seems to have worked pre-sonoma, but it seems like a weird thing to rely on.

2. `NSResponder` mock can not be set to view controller anymore. The controller will try to access an ivar of the `NSResponder`, but mocked responder does not have the ivar of original objects which will result on invalid selector being called on a `NSMutableArray` one of the ivar of mock objects. Solution for this is to inherit from `NSResponder` and forward calls to mocked object.

3. Adding `flutter::kModifierFlagShiftLeft` to a modifier flag containing `kCGEventFlagMaskShift`. The assertion was introduced in https://github.com/flutter/engine/pull/46230 but i missed the test failure because of the problems above.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-18 04:52:19 +00:00
skia-flutter-autoroll
0aa1f4977e Roll Fuchsia Linux SDK from VtEx0R7lepGAvwAMU... to OudOcFarQhQQzKDBx... (flutter/engine#47039) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-18 04:46:18 +00:00
Chinmay Garde
09fcf5e4e5 Roll buildroot to pull in removal of //tools. (flutter/engine#47032) 
None of these except remove_stale_pyc_files seems to be used. But we have the
pyc files in the .gitignore and I couldn't find any existing checked in pyc
files. So this check has never made sense for the Flutter. Removing instead of
migrating.

Buildroot patch https://github.com/flutter/buildroot/pull/784
 2023-10-18 00:16:28 +00:00
Jonah Williams
b964d7a907 Disable threading test that fails on CI (flutter/engine#47034) 
This is failing on CI but didn't fail locally on the PR. Not sure why.
 2023-10-17 17:02:48 -07:00
Chris Bracken
401ce5f32e Move imgui from buildroot to flutter third_party (flutter/engine#47031) 
As part of eliminating the Flutter buildroot (#67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

Issue: https://github.com/flutter/flutter/issues/136284

No tests changed because there is no semantic change to this PR. This is
simply relocating a dependency.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-17 16:06:26 -07:00
Jonah Williams
633656df10 [Impeller] Rework Vulkan GPUTracker to decorate existing cmd buffers. (flutter/engine#46963) 
Switches the GPU tracing implementation to work more like the metal version, where we decorate individual cmd buffers with start/end time queries and then min/max the final result. Hopefully this stabilizes the values on CI
 2023-10-17 22:42:00 +00:00
Chris Bracken
6fd06e4039 [fml][embedder] Improve thread-check logging (flutter/engine#47020) 
Developers working their app's runner code or in the native parts of
plugins are often required to call methods from the platform thread, or
face a crash.
Makes a minor improvement to fml::ThreadChecker's
IsCreationThreadCurrent log message.
This patch originally proposed to emit a much more specific error
message when calling methods that must be called on the platform thread
(typically originating in calls from plugins), however, given that we
don't ship debug engines as part of the SDK, this is really only going
to be useful to engine developpers, or people brave enough to run with
their own local engine build, in any case. 

Issue: https://github.com/flutter/flutter/issues/135345

No changed tests since no functional change, just an error message
cleanup.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-17 15:32:50 -07:00
skia-flutter-autoroll
23f95c816d Roll Dart SDK from 99ce477503f8 to da48c75b73b1 (1 revision) (flutter/engine#47027) 
https://dart.googlesource.com/sdk.git/+log/99ce477503f8..da48c75b73b1

2023-10-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-35.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 22:31:36 +00:00
Chinmay Garde
fa5f484e71 Roll buildroot to pull in //gpu removal. (flutter/engine#47014) 
Needs https://github.com/flutter/buildroot/pull/782
 2023-10-17 22:28:07 +00:00
skia-flutter-autoroll
93222a9a42 Roll Skia from b524e0af7d3a to f62b4dce5e55 (4 revisions) (flutter/engine#47029) 
https://skia.googlesource.com/skia.git/+log/b524e0af7d3a..f62b4dce5e55

2023-10-17 johnstiles@google.com Fix MakeClientBasedUnicode when skia_use_client_icu is set.
2023-10-17 herb@google.com Fix Segment intersection calculation
2023-10-17 avi@chromium.org Fix availability macro use
2023-10-17 johnstiles@google.com Fix more ClangTidy `performance-unnecessary-value-param` findings.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 22:28:05 +00:00
Jason Simmons
128b1d06d0 Workaround for a clang-tidy warning in CPUSpeedTracker (flutter/engine#47024) 
The newly rolled version of clang-tidy is warning about some accesses to std::optional values.  The function does a has_value check before accessing the values, but the analyzer does not detect that.
 2023-10-17 21:50:05 +00:00
skia-flutter-autoroll
4ec1df3d9e Roll Skia from a9caf3c19792 to b524e0af7d3a (1 revision) (flutter/engine#47017) 
https://skia.googlesource.com/skia.git/+log/a9caf3c19792..b524e0af7d3a

2023-10-17 armansito@google.com [graphite] Forward-declare VelloRenderer in RendererProvider.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 19:52:01 +00:00
skia-flutter-autoroll
53153bfeaa Roll Skia from 1a332d2b35d9 to a9caf3c19792 (1 revision) (flutter/engine#47013) 
https://skia.googlesource.com/skia.git/+log/1a332d2b35d9..a9caf3c19792

2023-10-17 ccameron@chromium.org Add files for public Exif interface and IFD parsing

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-17 19:07:06 +00:00