Commit Graph

9594 Commits

Author SHA1 Message Date
xster
ec00e974d0 Add long-press-move support for text fields 2 (#28242) 2019-02-25 14:34:54 -08:00
jslavitz
47724f97fa Breaks the moveBy call from drag and dragFrom into two separate calls and changes the default behavior of DragStartBehavior to DragStartBehavior.start (#26438)
* Breaking change which sets the default DragStartBehavior to DragStartBehavior.start and changes WidgetTester.drag and WidgetTester.dragFrom by breaking the moveBy function call into multiple pieces.
2019-02-25 14:15:31 -08:00
stuartmorgan
62e55a45d4 Convert PointerEvent's toString to Diagnosticable (#27904)
Rather than building a description string by hand, use Diagnosticable
properties. Simplifies output, since many fields have uninteresting
default values in many cases, and makes it easier to add more loggable
properties in subclasses.

Issue #28014
2019-02-25 11:42:50 -08:00
Hans Muller
751f119c93 Ensure that the DropdownButton menu respects its parents bounds (#28371) 2019-02-25 10:58:17 -08:00
rami-a
fc6079a24f [Material] Add the ability to theme trailing app bar actions independently from leading (#28214)
* Allow app bar actions to be themed independently if needed

* Update SliverAppBar docs that were out of date

* Clarify fallback behavior in a comment

* Analyzer

* Address PR feedback

* Address PR feedback

* Put back checks on actions icon theme

* Address PR feedback

* Retrigger CI
2019-02-25 13:47:05 -05:00
Brandon Rodriguez
c26a69e9cf [Typo] Update 'use' to 'user' (#28245) 2019-02-25 10:32:23 -08:00
Michael Goderbauer
b7f29f2b32 Add more docs to BackdropFilter (#28017) 2019-02-25 10:27:20 -08:00
Will Larche
57a8b03c5e [Gallery] Fortnightly demo moved from flutter/samples. (#28125)
* [Gallery] Fortnightly demo moved from flutter/samples.

* [Gallery] Fortnightly analysis corrections.

* [Gallery] Minor rename.

* [Gallery] Making floats ints.

* [Gallery] Fortnightly minor visual polish.

* [Gallery] Formatting.

* [Gallery] Upping package version for gallery to support fortnightly demo.

* [Gallery] Fortnightly copy correction.

* [Gallery] Fortnightly study polish.

* [Gallery] Fortnightly polish.

* [Gallery] Fortnightly copy correction.

* [Gallery] Fortnightly copy now held in '''.

* [Gallery] Fortnightly comment.

* [Gallery] Updates necessary when flutter_gallery_assets updates.

* [Gallery] Updating macrobenchmarks because we updated flutter_gallery_assets.

* [Gallery] Moving spaces to beginning of copy lines.

* [Gallery] Copy correction.

* [Gallery] Adding tooltip to satisfy smoke test.

* [Gallery] Minor pr feedback.

* [Gallery] Forced upgrade.
2019-02-24 11:53:43 +01:00
Dan Field
0e984fb237 update packages (#28400) 2019-02-23 10:08:53 -08:00
Dan Field
15f2119f2c Reland "Allow for gradle downloading missing SDK assets" (#28097) (#28355)
* Allow for gradle downloading missing SDK assets if SDK licenses are present.

*  Improvements for windows testing
2019-02-23 09:56:57 -08:00
Dan Field
ad68ba303b fix red build for analysis (#28398) 2019-02-23 09:39:36 -08:00
Gary Qian
7b5a769b31 Force line height in TextFields with strut (#27612) 2019-02-23 03:35:37 -08:00
Jonah Williams
0d6bb6aee8 only perform multi-root mapping if there are multiple roots (#28352) 2019-02-22 19:25:24 -08:00
Stanislav Baranov
7baffa6e72 Dynamic patching support for native code libraries. (#28349) 2019-02-22 17:51:05 -08:00
liyuqian
adc8e159a5 Revert "Shader warm up (#27660)" (#28376)
This reverts commit a44f174efc.

Reason: start_up tests become flaky.

See https://github.com/flutter/flutter/issues/28374

TBR: xster

Merge on red to fix the tree
2019-02-22 17:32:37 -08:00
liyuqian
a44f174efc Shader warm up (#27660)
This patch adds a default shader warm up process which moves shader compilation from the animation time to the startup time. This also provides an extension for `runApp` so developers can customize the warm up process.

This should reduce our worst_frame_rasterizer_time_millis from ~100ms to ~20-30ms for both flutter_gallery and complex_layout benchmarks. Besides, this should also have a significant improvement on 90th and 99th percentile time (50%-100% speedup in some cases, but I haven't tested them thoroughly; I'll let our device lab collect the data afterwards).

The tradeoff the is the startup time (time to first frame). Our `flutter run --profile --trace-startup` seems to be a little noisy and I see about 100ms-200ms increase in that measurement for complex_layout and flutter_gallery. Note that this only happens on the first run after install or data wipe. Later the Skia persistent cache will remove the overhead.

This also adds a cubic_bezier benchmark to test the custom shader warm up process.

This should fix https://github.com/flutter/flutter/issues/813 (either by `defaultShaderWarmUp`, or a `customShaderWarmUp`).
2019-02-22 15:37:02 -08:00
Zachary Anderson
824fe4dfcd [flutter_tool,fuchsia] Add missing dep to flutter_tool (#28346)
Needed for Fuchsia roll.
2019-02-22 14:31:59 -08:00
rami-a
b73dd0e81e [Material] Add ability to set shadow color and selected shadow color for chips and for chip themes (#28163)
* Add ability to set shadow color for chips and for chip themes

* Add selected shadow color as a property as well

* Update phrasing of documentation

* Address PR feedback
2019-02-22 15:50:39 -05:00
ocavue
0f218e427c Make extended FAB's icon optional (#27711) 2019-02-22 12:47:52 -08:00
Zachary Anderson
ea4cffde60 [fuchsia] Fix paths to find and ls (#28280) 2019-02-22 08:38:02 -08:00
xster
d749e0b573 Add some more CupertinoPicker doc (#28166) 2019-02-21 22:16:29 -08:00
Stanislav Baranov
3837ec9e96 Reland #27754, now that bsdiff has moved to flutter/packages. (#28291) 2019-02-21 21:59:41 -08:00
Dan Field
74a9086037 Revert "Allow for gradle downloading missing SDK assets (#28097)" (#28295)
This reverts commit 6f5e88a59f.
2019-02-21 16:53:45 -08:00
xster
98455df459 Add slight clarification to debugDeterministicCursor (#27898) 2019-02-21 16:18:42 -08:00
Hans Muller
617ca62709 [Material] Expand BottomNavigationBar API (reprise) (#28159) 2019-02-21 16:05:36 -08:00
Michael Goderbauer
b96ae03b42 Add backgroundColor argument to TextStyle for convenience (#28172) 2019-02-21 15:58:30 -08:00
Dan Field
6f5e88a59f Allow for gradle downloading missing SDK assets (#28097)
* Allow for gradle downloading missing SDK assets if SDK licenses are present.

* Fix license path for missing sdkmanager

* Cirrus re-run...

* Fix condition check

* rename props, add docs, rename method

* fix tests after param changes

* Fix weird path for flutter run and add tests

* remove print, fix tests
2019-02-21 15:57:20 -08:00
Greg Spencer
b316940051 Fix the length of the valueHelp on the --sample option for the create command, and turn on wrapping. (#28264)
The wrapping for some commands was never actually turned on, so this turns it on.

Also, it shortens the `valueHelp` for the `--sample` option to be just "id" instead of "the sample ID of the desired sample from the API documentation website (http://docs.flutter.io)", which was causing the line to get far too long.

Fixes #23074
2019-02-21 15:56:59 -08:00
Greg Spencer
b45a8f464d Revert "Remove unused --packages argument to gen_snapshot. (#28101)" (#28265)
This reverts commit 1c021506df.

The pre-commit tests never actually ran, so it looked green when it wasn't. This breaks 16 tests that depend on the argument existing, even though it isn't actually used.
2019-02-21 08:47:24 -08:00
Alexandre Ardhuin
5169ab5974 format parameter list (#27261) 2019-02-21 09:27:07 +01:00
Stevie Strickland
1c021506df Remove unused --packages argument to gen_snapshot. (#28101)
This command line argument has already been removed in the main
Dart repository, so building flutter with the latest dart fails.
2019-02-21 09:03:59 +01:00
Jonah Williams
b594cf85fd Remove extra slash from builder that is not handled on windows (#28027) 2019-02-20 19:56:02 -08:00
Jonah Williams
72b6ed35d0 Remove set literal syntax (#28238) 2019-02-20 19:55:10 -08:00
jslavitz
2c558fdb21 Adds fix for NAN value and pressure values outside of device reported min and max (#26659)
* Fix for nan pressure values and values outside min and max pressure ranges
2019-02-20 16:15:53 -08:00
jslavitz
a5820011b3 Adds media query check in editable_text (#27955)
* media query check
2019-02-20 16:14:48 -08:00
Matt Sullivan
088b6062fd Added sample code to AnimatedWidget (#27803)
* Added sample to AnimatedWidget

* Updated AnimatedWidget example to use listenable from parent

* Made progress private and changed widget name
2019-02-20 15:50:34 -08:00
Ali EP
307848953f Fixes crossAxisSpacing overflow in RTL (#27945) 2019-02-20 15:43:01 -08:00
Sander Kersten
d1136e3109 Fix issue where SliverPersistentHeader that is both floating and pinned would scroll down when scrolling past the beginning of the ScrollView (#27433) 2019-02-20 15:42:15 -08:00
Michael Goderbauer
655800260a Add TextOverflow.visible (#28182) 2019-02-20 15:40:25 -08:00
Dan Field
4ed096bd29 Remove json_schema and cli_util deps from flutter_tool (#28040)
* remove json_schema dep

* remove unnecessary pin

* removed unused dep

* remove unused impport

* Fix incorrect condition
2019-02-20 15:38:58 -08:00
xster
e100ddfe26 Rename SuperellipseShare ContinuousRectangleBorder (#28183) 2019-02-20 15:35:22 -08:00
xster
39b1ff1aa3 revert 26001 (#28032) 2019-02-20 15:34:44 -08:00
Kaushik Iska
9931a275b9 Add outer try block for obtainKey errors. Add docs. (#27953)
* Add outer try block for obtainKey errors. Add docs.

* change to // from ///, and do specific error handling

* Add return statement after error

* Add test
2019-02-20 15:31:07 -08:00
Michael Goderbauer
fbafe64fd7 Fix 'to to' (#28216) 2019-02-20 09:57:42 -08:00
Dan Field
dd23be3936 Roll engine to f45572e95f93edb89b6750a4f36ad8ed7c0a2560 (#28178)
* Roll engine to f45572e95f93edb89b6750a4f36ad8ed7c0a2560

* update goldens

* update goldens version
2019-02-19 21:35:31 -08:00
Stanislav Baranov
20d9de58d0 Revert "Add support for binary compression of dynamic patches by the flutter tool. (#27754)" (#28031)
This reverts commit b47da6c2b7.
2019-02-15 18:43:36 -08:00
Dan Field
c90c3a18a2 Reland automatic discovery of observatory port for iOS (#27908)
* Discover port over mDNS 

* Update BUILD.gn for tools
2019-02-15 17:44:55 -08:00
liyuqian
7390cc5cdb Increase our build budget to 16ms (#27709)
Because we now have 2 separate GPU and UI threads.
2019-02-15 16:12:36 -08:00
KyleWong
f9a6090082 Refactor local engine logic (#27765)
* Refactor for iOS.

* For android_xxx_unopt_arm64&ios_xxx_unopt_arm, remove the _arm64/_arm suffix.
dart generated in host_xxx_unopt/host_xxx has an arch of x86_64 which supports arm64/arm.

* Remove suffixes for various archs.
2019-02-15 15:56:49 -08:00
Hans Muller
19f79ac8da Add extendBody parameter to Scaffold, body MediaQuery reflects BAB height (#27973) 2019-02-15 14:48:39 -08:00