Commit Graph

9836 Commits

Author SHA1 Message Date
Nikita
88d50f78f3 Implement compute for async function (#16265) (#30275) 2019-04-04 00:17:26 -07:00
Kate Lovett
0c01a557df Embedding new raised button diagram. (#30398) 2019-04-04 00:14:40 -07:00
Kate Lovett
31086faa28 Updating sample code for BottomNavigationBar class for diagram. (#30453) 2019-04-04 00:14:12 -07:00
Michael Goderbauer
77bbd28c62 Random trivial fixes in the animation packages (#30276) 2019-04-04 00:13:34 -07:00
Michael Goderbauer
3c8dabefe7 Be more explicit when ValueNotifier notifies (#30461) 2019-04-04 00:13:07 -07:00
Zachary Anderson
39ebae2bab [fuchsia] Fix isolate filter (#30458) 2019-04-03 21:14:37 -07:00
liyuqian
16a16e6598 Revert "Error message for setting shaderWarmUp too late (#30145)" (#30463)
This reverts commit ffbb335e35.

Reason for revert: flutter driver tests may have bugs in getting
first frame. Revert this until we figure out what happened.
2019-04-03 15:38:31 -07:00
Michael Goderbauer
5493fe469e Moar Videos (#30452) 2019-04-03 12:49:13 -07:00
Michael Goderbauer
516ffd0c09 Add 29 Widget of the Week videos (#30415) 2019-04-03 12:48:37 -07:00
Vyacheslav Egorov
01e3496ad9 Introduce --report-timings flag for flutter build aot command. (#30032)
This flag makes flutter build aot report timings for substeps (e.g.
frontend compilation and gen_snapshot) in a machine readable form.
2019-04-03 12:12:18 +02:00
Dan Field
069aabfe95 Draggable Scrollable sheet (#30058)
* Draggable Scrollable sheet
2019-04-02 18:07:30 -07:00
Amir Hardon
b6afc16a96 Make sure _handleAppFrame is only registered once per frame (#30346)
There were 2 possible scenarios in which _handleAppFrame is added more than once as a frame callback. When this happens it is possible that the second invocation will try to access _nextFrame.image when _nextFrame is null and crash. The 2 scenarios are:

Scenario 1

A GIF frame is decoded and a Flutter frame is executed before it's time to show the next GIF frame.
The timer that's waiting for enough time to elapse is invoked, and schedules a callback for the next Flutter frame(here).
Before the next Flutter frame is executed, MultiFrameImageStreamCompleter#removeListener is called followed by ``MultiFrameImageStreamCompleter#addListenerthat is invoking_decodeNextFrameAndSchedule` which is adding `_handleAppFrame` again as a next frame callback.
Scenario 2
removeListener and addListener are called multiple times in succession, every call to addListener can result in another registration of _handleAppFrame to the next Flutter frame callbacks list.

This patch fixes the issue by guarding against a second registration of _handleAppFrame.
2019-04-02 12:14:27 -07:00
xster
a83f6eadb8 Add needed singular resources for cupertino_en.arb (#30160) 2019-04-02 11:25:06 -07:00
Jon Tippens
f056ea4e70 Fix minor typo (#30353) 2019-04-02 09:45:04 -07:00
Kate Lovett
add5f2ea76 Updating sample code for raised button to match forthcoming diagram. (#30348) 2019-04-02 09:28:13 -07:00
Michael Goderbauer
7c76dee7a4 Make heroes fly on pushReplacement (#30228) 2019-04-01 18:14:20 -07:00
Shi-Hao Hong
d4c4f563c4 Added assert to prevent complete ListTile trailing/leading horizontal expansion (#30212) 2019-04-01 17:41:56 -07:00
Tong Mu
fbefd6b816 Simplify logic of TapGestureRecognizer (#30227)
Refactors the logic of TapGestureRecognizer, making the calling dependency unidirectional between resolve(accept) and checkUp.
2019-04-01 10:58:30 -07:00
Hans Muller
14aa57b18d Fix OutlineInputBorder crash (#30123) 2019-04-01 09:28:18 -07:00
Zachary Anderson
61b5caff9a [fuchsia_tester] Plumb through the location of icudtl (#30218) 2019-04-01 07:48:50 -07:00
Shi-Hao Hong
4d958ea5b7 Added helpful Material assert message (#30219)
Clarified an assert for when a Material widget's backgroundColor is null when its type isn't MaterialType.transparency
2019-03-30 12:58:58 -07:00
Jonah Williams
c10e7ba6e9 Revert "Ensure that flutter run/drive/test/update_packages only downloads required artifacts (#30075)" (#30232) 2019-03-29 20:41:07 -07:00
Jonah Williams
89807e68d0 Ensure that flutter run/drive/test/update_packages only downloads required artifacts (#30075) 2019-03-29 20:33:37 -07:00
Jonah Williams
b8bcfaa56f make sure flutter test asks for cache upgrades (#30216) 2019-03-29 15:58:16 -07:00
xster
f2d671c15c Cupertino localization step 3: in-place move some material tools around to make room for cupertino (#29644) 2019-03-29 15:57:09 -07:00
xster
d166a8d81e Make sure everything in the Cupertino page transition can be linear when back swiping (#28629) 2019-03-29 15:56:18 -07:00
dacaiguoguo
1c0f82541c Set custom flutter_assets by add FLTAssetsPath to AppFrameworkInfo.plist (#29499)
* Get FLTAssetsPath from AppFrameworkInfo.plist
2019-03-29 15:45:18 -07:00
Jonah Williams
8220f8f4e3 add missing test case and handle wildcard removal (#30205) 2019-03-29 14:26:56 -07:00
Darren Austin
3892a0d96c Made the showMenu() position parameter required (#30206)
Made the showMenu() position parameter required as it doesn't make sense to show a menu without indicating where it should be shown. Also added a test to verify this.
2019-03-29 14:15:03 -07:00
Michael Goderbauer
a3cbe25353 Part 1: Improve Overlay API (#28747) 2019-03-29 14:09:30 -07:00
Shi-Hao Hong
0e2eeb5a48 Set Max Height for ListTile trailing and leading widgets (#29771) 2019-03-29 12:22:31 -07:00
liyuqian
ffbb335e35 Error message for setting shaderWarmUp too late (#30145)
Developers may get confused by setting PaintingBinding.shaderWarmUp in
the wrong place. The added assert and error message help avoid that.
2019-03-29 10:49:07 -07:00
Jonah Williams
1bfa2f2311 Intercept errors thrown by synchronous Completers in image resolution. (#30139) 2019-03-29 10:05:18 -07:00
Shi-Hao Hong
cbe4c9e1d7 Add link to hero animation page (#30059) 2019-03-28 18:14:55 -07:00
Darren Austin
19901f674b Fix a misuse of matchesGoldenFile() in the physical_model_test. (#30141)
Fixed a misuse of matchesGoldenFile() in the physical_model_test so that it correctly reports a failed test on Linux (and skips the other platforms).
2019-03-28 18:08:29 -07:00
Jonah Williams
876b45f64e skip .dart_tool folders when running update-packages (#30082) 2019-03-28 12:15:59 -07:00
Jonah Williams
a813dc559a Add more test coverage to image handling (#30078) 2019-03-28 10:37:49 -07:00
Christopher Fujino
ec93c87c89 Move spinner _defaultSlowWarning message to a new line (#30071)
* write newline before adding slow restart message to spinner
* update existing test
2019-03-28 10:08:44 -07:00
Francisco Magdaleno
b70d260b3c Adds the keyboard mapping for Linux (#29993) 2019-03-28 10:04:23 -07:00
Jonah Williams
557c94ff77 Move binarySearch implementation in animated_list to foundation/collection.dart. (#29860) 2019-03-28 01:00:29 -07:00
Shi-Hao Hong
de6995cfa8 Added Hero zero-frame animation documentation (#30048) 2019-03-27 18:17:12 -07:00
Nizarius
ea343ccc3f CupertinoTextField: added ability to change placeholder color (#28001) 2019-03-27 17:25:29 -07:00
Jonah Williams
3c93b65a9b Update to latest matcher (#30019) 2019-03-27 17:21:10 -07:00
Jonah Williams
99866f4a3d Make timeout durations configurable (#30053) 2019-03-27 16:21:16 -07:00
xster
4b365fb92a Cupertino localization step 1.5: fix a resource mismatch in cupertino_en.arb (#29821) 2019-03-27 15:41:44 -07:00
Kate Lovett
76b9962fdd Embedding new diagrams for API Docs (#29697)
* Embedding new diarams for API docs: Container, ListView, Align.

* Moving the diagrams to be enclosed within the snippet windows.

* Fixed wording for the alt image text.
2019-03-27 14:52:18 -07:00
Jonah Williams
50f1e1822a ensure packages file is updated when using build_runner (#29885) 2019-03-27 14:40:52 -07:00
Chris Yang
3b3f6c7a04 Include platformViewId in semantics tree for iOS (#29304)
Include the platformViewId of PlatformViews in the semantics tree. The accessibility bridge in the engine can use this id to steal the semantics nodes from the actual platform view and stick them into Flutter's semantics tree.

It is the iOS PlatformView counter part of https://github.com/flutter/flutter/pull/28953. It reverts the change in 5b5d6e89ec and 03fd797eb8.

https://github.com/flutter/flutter/issues/29302
2019-03-27 13:56:23 -07:00
Jonah Williams
7d678f2adc Lazy cache 5: The Empire Strikes Back (#29986) 2019-03-27 13:54:09 -07:00
xster
7f3485e388 Let CupertinoPageScaffold have tap status bar to scroll to top (#29946) 2019-03-27 13:52:45 -07:00