Commit Graph

10223 Commits

Author SHA1 Message Date
amirh
7996d7fb82 Initial implementation of BottomAppBar (#14713)
* add a FAB NotchMaker to ScaffoldGeometry

* add a notchMaker to FloatingActionButton

* Initial implementation of BottomAppBar

Mainly includes the notch making logic.
Not yet tested as currently there is no way to make the FAB and the BAB
overlap, once #14368 to lands we could add unit tests to the
BottomAppBar as well.

* use a closeable for clearing the FAB notchmaker
2018-02-21 10:20:58 -08:00
jcollins-g
ca677011f8 Fix flutter tools packages_test when run off bots (#14692)
* Fix packages tests when run off bots

* Tweak dependencies to make bots happy

* Review comment
2018-02-21 09:54:07 -08:00
Hans Muller
24efb55b03 Generalized TabBar selected tab indicator (#14741) 2018-02-21 09:13:45 -08:00
Todd Volkert
21c514fc56 Wire up support for --skia-deterministic-rendering (#14802)
https://github.com/flutter/flutter/issues/14519
2018-02-20 23:22:58 -08:00
Todd Volkert
50b7fad6a3 Mark android_sample_catalog_generator as flaky (#14799)
https://github.com/flutter/flutter/issues/14798
2018-02-20 22:14:33 -08:00
Todd Volkert
22a4a7d9d2 Roll engine to 585610456326bc455ffeb257f6d33d476b4ee3fc (#14788)
Fixes https://github.com/flutter/flutter/issues/14751
2018-02-20 15:52:49 -08:00
xster
4c0cfee3d1 Set encryption compliance in Gallery Info.plist (#14737) 2018-02-20 15:42:28 -08:00
Todd Volkert
eabfd570dd Remove unused parameter to DevFS._scanBundleEntry (#14782) 2018-02-20 12:43:29 -08:00
Alexander Aprelev
45175f5342 Now that we are on dev-23, remove analyzer //ignore (#14780) 2018-02-20 11:20:13 -08:00
Alexander Aprelev
39ddeb52b0 Fix snapshot fingerprint check for --preview-dart-2. (#14775)
* Fix snapshot fingerprint check for --preview-dart-2.

* Remove printTraces
2018-02-20 10:02:00 -08:00
Jason Simmons
494270fe46 Return the result of the operation in ServiceObject.reload (#14755) 2018-02-20 09:45:32 -08:00
Victor Choueiri
4f5f4222e0 Add flutter version to non-verbose doctor output (#14779) 2018-02-20 09:22:49 -08:00
Danny Tuppeny
f914e701c5 Update some http links to https (#14762)
These URLs all automatically redirect HTTP to HTTPS so makes sense to point users at the secure versions.
2018-02-19 21:12:17 +00:00
Mikkel Nygaard Ravn
130dfc87ad Make Podfiles use symlinks to local pods (#14748) 2018-02-19 21:32:13 +01:00
Mikkel Nygaard Ravn
54bf773d37 Fix dartdoc typo (#14772) 2018-02-19 20:35:53 +01:00
Todd Volkert
1363489a86 Add a --just-print flag to roll_dev. (#14766)
This will allow other tools to call into the roll_dev script
to know what version is about to be published without actually
publishing.
2018-02-18 22:27:46 -08:00
Mikkel Nygaard Ravn
1e242ebc7c Mark plugin tests as stable (#14760) 2018-02-17 22:46:29 +01:00
Mikkel Nygaard Ravn
f526805e20 Fix of flutter packages get in plugin project (#14757) 2018-02-17 21:25:13 +01:00
Todd Volkert
d4e973351e Roll engine to e5b72e5f87cae358b457b6c1cb55c4560ce3c46c (#14759)
https://github.com/flutter/flutter/issues/14751
2018-02-17 11:31:34 -08:00
xster
f7f1685cac Make sure broken pod install runs triggers pod install on next flutter build (#14753) 2018-02-16 16:05:16 -08:00
Alexandre Ardhuin
297fd9431f fix potential call on null (#14731)
* fix potential call on null

* review
2018-02-16 22:37:07 +01:00
Todd Volkert
1686b6d56d Remove fixed asset bundles - they're no longer used. (#14729) 2018-02-16 10:22:52 -08:00
Alexander Aprelev
fe00598ab3 Reintroduce engineDartSdkPath artifact. (#14742)
This is needed to support running with local engine's dart sdk.

This is follow-up to https://github.com/flutter/flutter/pull/14702.
2018-02-16 09:20:23 -08:00
Vyacheslav Egorov
aa7e9637ac Fix several Dart 2 issues in the flutter_driver. (#14749)
* All lists produced by JSON parsing are List<dynamic>. If more
speficic type is required then they need to be explicitly cast, e.g.
using castFrom helper;
* Function of type (ByText) -> Finder is not a subtype of
(SerializableFinder) -> Finder because ByText is in the contravariant
position;
* In Dart 2 typed(any) should be used instead of any in mockito based
tests.
2018-02-16 18:01:54 +01:00
Matt Sullivan
2a6ed0a869 Added sample code to AnimatedOpacity API docs (#14730)
* Added sample code to AnimatedOpacity docs
2018-02-16 08:56:44 -08:00
Mikkel Nygaard Ravn
31a0a5f4d0 Remove generated files from repo (#14697) 2018-02-16 12:33:21 +01:00
Mikkel Nygaard Ravn
57779e7e01 Skip new failing test while investigating (#14746)
Merging on red tree to get back to green.
2018-02-16 12:05:37 +01:00
Mikkel Nygaard Ravn
2000435728 Move plugin injection to just after pub get (#14743) 2018-02-16 10:17:28 +01:00
Mikkel Nygaard Ravn
558c753f01 Fix test failure by silencing analyzer preamble and congrats (#14745) 2018-02-16 09:37:48 +01:00
Alexander Aprelev
52abda66ae Ignore 'No analyzer warnings!' stdout line from analyzer (#14744) 2018-02-15 23:58:14 -08:00
Alexandre Ardhuin
fe26c9d87b complete lint list for linter-0.1.43 (#14707) 2018-02-16 07:44:24 +01:00
Alexandre Ardhuin
bd1921ec84 unnecessary parenthesis (#14533) 2018-02-16 07:43:19 +01:00
asiva
a37a8424b3 Update to correct hash value. 2018-02-15 17:45:36 -08:00
asiva
11105bed4d - Roll engine to version 9867298f86a7ccd5f1c07a83796ee21567d37fb0
- Remove redundant strong flag as it is the default for preview-dart-2
now
2018-02-15 17:45:36 -08:00
xster
1e397d3fb7 Break up and show more progression during an Xcode build (#14715)
* Created plumbing but has stream problem

* testing with makePipe

* Trying pipe but not really getting anywhere

* works by repeatedly reading line

* Minor cleanup

* works

* Clean up pipe after use.

* Move the last status forward

* Make sure failed script commands bubble up
2018-02-15 15:16:23 -08:00
Ian Hickson
10393a12fa Add some more documentation. (#14717) 2018-02-15 14:06:25 -08:00
xster
f6fe41f10b Small glow overscroll dartdoc addition (#14579)
* Small glow overscroll dartdoc addition

* Directly specify [MaterialApp]

* review
2018-02-15 14:00:32 -08:00
Mikkel Nygaard Ravn
c2e1bc0322 Revert "Move plugin injection to just after pub get (#14560)" (#14734)
This reverts commit b3e4976ca2.
2018-02-15 22:55:36 +01:00
Mikkel Nygaard Ravn
b3e4976ca2 Move plugin injection to just after pub get (#14560) 2018-02-15 22:17:12 +01:00
Todd Volkert
d260294752 Revert "Add android license verification to doctor and some refactoring" (#14727)
Reports from that commit included:

* Doctor hanging
* Doctor prompting to install JDK
* AnsiStatus.cancel() printing elapsed time and extra newline
* Printing extra spinner character at the end of each line
2018-02-15 09:13:56 -08:00
asiva
615f411da7 - Roll engine to version 0f3a8cef60bfe20afeaebe2945087cec90c65369 to pick
up the latest Dart roll

- Resubmit https://github.com/flutter/flutter/pull/14392 to fix
compilation errors
2018-02-15 08:15:02 -08:00
Vyacheslav Egorov
3932a22cdf When running tests with --preview-dart-2 check for compilation errors. (#14724)
If compiler failed to produce Kernel binary then compile(...) returns
null to the caller. If we don't check for null we end up trying to
run file called "null" which causes a very confusing crash of the
flutter_tester.
2018-02-15 16:57:52 +01:00
Alexander Aprelev
c0c6c60b8f Use already downloaded dart sdk for frontend_server. (#14702)
* Use already downloaded dart sdk for frontend_server.

This is follow-up to https://github.com/flutter/flutter/pull/14610

* Remove reference to engine dart-sdk from artifacts

* Remove unused imports

* WIP to switch back to solution where dart sdk is downloaded into bin/cache/dart-sdk, but it is 'flutter precache -a' that can download all dart sdks for other platforms under bin/cache/artifacts/engine/<platform>/dart-sdk

* Download all dart sdks when 'flutter precache -a'
2018-02-15 07:29:42 -08:00
Vyacheslav Egorov
08db0d83d7 Adjust test/material/popup_menu_test.dart for Dart 2 semantics. (#14644) 2018-02-15 10:31:46 +01:00
Alexandre Ardhuin
b8fcc96265 activate lint prefer_bool_in_asserts (#14708) 2018-02-15 06:14:13 +01:00
najeira
576191792a Add explanation about Navigator to showDialog doc (#14666)
* add explanation about navigator to showDialog doc

* update doc by review
2018-02-14 17:16:34 -08:00
Ian Hickson
b2af326046 Fix boundaries in applyClampedDragUpdate (#14444) 2018-02-14 17:05:24 -08:00
Devon Carew
53b348a50d have flutter analyze support --preview-dart-2 (#14582)
* have flutter analyze support --preview-dart-2

* review comments
2018-02-14 16:00:29 -08:00
jcollins-g
59fe5d0f46 Add android license verification to doctor and some refactoring (#14535)
* Initial version, seems to work

* Unit test for android license checker

* Cleanups

* Windows analyzer wants const.

* Refinements to timeout

* review comments

* Forgot a nit
2018-02-14 15:25:12 -08:00
Michael Goderbauer
e9163a1afe Wire up didGainA11yFocus, didLoseA11yFocus for CustomPainter (#14711) 2018-02-14 15:18:59 -08:00