Commit Graph

10223 Commits

Author SHA1 Message Date
Kevin Moore
13a6d40f90 flutter_tools: ensure the context value passed to pub is consistent (#13366)
Adds a class `PubContext` with a fixed set of allowed values
Make it clear these values should not be changed casually

Fixed one inconsistency already: update_packages vs update_pkgs
Provide more information for verify calls
Eliminate `ctx_` prefix.
2017-12-06 08:10:56 -08:00
Devon Carew
cbcdd03ef0 some wording tweaks to the doctor text (#13356) 2017-12-06 08:05:51 -08:00
Chris Bracken
324ef1d1f6 Apply media bottom padding to CupertinoTabBar (#13372)
This adjusts the CupertinoTabBar height in the presence of bottom
padding. On the iPhone X, this will increase the height to account for
the home indicator widget.
2017-12-05 19:17:58 -08:00
Collin Jackson
10a4f329c3 Finish release of 0.0.19, start dev version of 0.0.20 (#13370) 2017-12-05 17:06:16 -08:00
Yegor
e3cf62bc5b modernize corners & borders in animation demo (#13352) 2017-12-05 16:38:42 -08:00
Collin Jackson
fd7853faad Release 0.0.19 (#13365) 2017-12-05 16:12:55 -08:00
Greg Spencer
f29ecba6de Use .pub-cache from Flutter root, if it exists. (#13358)
The purpose of this PR is to make it so that when the user runs 'flutter', if they have a .pub-cache directory in their flutter root, we use that instead of the default location for the pub cache. Otherwise, it should act as before.

The eventual goal is to support a pre-populated flutter .zip/.tar.gz file that has everything the developer needs in one bundle. In order for that to actually work, we need to have the pub cache be self-contained, and not in the user's home dir.

Another advantage of this is that if you have multiple flutter repos that you're switching between, then the versions in the pub cache will remain static when you switch between them.

This is an attempt to re-land: #13248. Includes a fix for the test that makes it work on bots in the presence of PUB_CACHE being set, and no other changes.
2017-12-05 14:46:39 -08:00
Greg Spencer
c89cf6ccc6 Reverting my .pub-cache change to figure out why it's still failing. (#13355)
* Revert "Add tests."

This reverts commit 31bad961ff2220a2708917ff8f748fed7efa9b51.

* Revert "Use .pub-cache from Flutter root, if it exists. (#13248)"

This reverts commit 72d6bcc3f7.
2017-12-05 12:51:18 -08:00
Greg Spencer
3174443e0e Fix a problem with the flutter_tools/test/dart/pub_get_test.dart test. (#13354)
It turns out that when a PR build clones the flutter repo, it puts it into a directory called "flutter", and when the "real" build clones the flutter repo, it puts it into a directory called "build". This allowed the tests to succeed in my PR, but fail when I committed it.

This fixes the test so it doesn't depend on the cloned directory name.
2017-12-05 12:30:13 -08:00
Greg Spencer
72d6bcc3f7 Use .pub-cache from Flutter root, if it exists. (#13248)
The purpose of this PR is to make it so that when the user runs 'flutter', if they have a .pub-cache directory in their flutter root, we use that instead of the default location for the pub cache. Otherwise, it should act as before.

The eventual goal is to support a pre-populated flutter .zip/.tar.gz file that has everything the developer needs in one bundle. In order for that to actually work, we need to have the pub cache be self-contained, and not in the user's home dir.

Another advantage of this is that if you have multiple flutter repos that you're switching between, then the versions in the pub cache will remain static when you switch between them.
2017-12-05 12:02:14 -08:00
xster
9db8966f94 Make drawer demo header not scroll away (#13337)
* Make drawer demo header not scroll

* Add test for gallery drawer demo and fix user accounts drawer header overflow
2017-12-05 11:58:03 -08:00
Martin Kustermann
3280f23452 Use only one message for NDK discovery, remove accidental newline (#13348) 2017-12-05 18:17:28 +01:00
Sigurd Meldgaard
2352e31f4e Video demo is unsupported on simulator (#13333)
* Video demo is unsupported on simulator

Display a message stating this.

* Address review
2017-12-05 13:39:24 +01:00
Sigurd Meldgaard
b46d79041a Add spinner to loading video (#13330)
* Add spinner to loading video
2017-12-05 10:20:13 +01:00
Yegor
ffb24eda56 Accessibility API for CustomPainter (#13313)
Summary:

- Add `key` field to `SemanticsNode`, while moving key into `foundation` library so it can be used by the render layer.
- Introduce `SemanticsProperties` and move many of the `Semantics` fields into it.
- Introduce `CustomPaintSemantics` - a `SemanticsNode` prototype created by `CustomPainter`.
- Introduce `semanticsBuilder` and `shouldRebuildSemantics` in `CustomerPainter`

**Breaking change**

The default `Semantics` constructor becomes non-const (due to https://github.com/dart-lang/sdk/issues/20962). However, a new `const Semantics.fromProperties` is added that still allowed creating constant `Semantics` widgets ([mailing list announcement](https://groups.google.com/forum/#!topic/flutter-dev/KQXBl2_1sws)).

Fixes https://github.com/flutter/flutter/issues/11791
Fixes https://github.com/flutter/flutter/issues/1666
2017-12-04 19:49:14 -08:00
Alexander Markov
a69af9902c Pass --aot option to front-end server when generating kernel for AOT build (#13342) 2017-12-04 16:57:44 -08:00
Alexander Markov
373e510cbe Roll engine to b57fca02b5b5465b2c553952cccd2b595ace2b65 (with dart-sdk roll) 2017-12-04 15:34:47 -08:00
Alexander Markov
223e5340a1 Roll engine to b5d0a4ac513fab4052aec75004d75f3d0e5c45b4 (before dart-sdk roll) 2017-12-04 15:34:47 -08:00
krisgiesing
898646f0f0 Separate focus management by build owner (#13334)
Separate focus management by build owner

Currently the focus manager is held by the singleton WidgetBinding.
This change places a focus manager in each build owner object,
which allows clients to run offscreen pipelines without disturbing
focus management for the main UI.
2017-12-04 15:04:41 -08:00
Ian Hickson
da5be60130 Fix overlay_geometry manual test. (#13315)
Somehow the test ended up checking for notification messages at the wrong depth.
2017-12-04 13:53:23 -08:00
Ian Hickson
c44f15e6e9 Add a showBottomSheet for consistency with showModalBottomSheet. (#13314)
Also, extra docs.

Fixes https://github.com/flutter/flutter/issues/13279
Fixes https://github.com/flutter/flutter/issues/2115
2017-12-04 13:43:09 -08:00
Ian Hickson
d6f496cab8 Localize the Chip delete button's default tooltip (#13312)
...and document what I did.
2017-12-04 12:59:48 -08:00
Sarah Zakarias
47e490294c Include pod-related build phases in flutter_view project.pbxproj. (#13327) 2017-12-04 10:56:15 +01:00
xster
2d6f268df6 Revert "Let translucent Cupertino bars have its scaffold children automatically pad their heights (#13194)" (#13317)
This reverts commit 5c4ffa13a6.
2017-12-01 21:18:36 -08:00
xster
6db83307e9 Roll to 22e63c3 (#13311) 2017-12-01 16:31:44 -08:00
Kevin Moore
c25608d83b Provide more information in PUB_ENVIRONMENT for pub get/upgrade (#13307)
* Provide more information in PUB_ENVIRONMENT for `pub get/upgrade`

Should help diagnose and fix https://github.com/dart-lang/pub-dartlang-dart/issues/636
2017-12-01 16:20:06 -08:00
Hans Muller
8ebd45d3bd Workaround for TextPainter.computeDistanceToActualBaseline when the text is empty (#13305) 2017-12-01 15:06:03 -08:00
Alexander Aprelev
2135f3c007 Roll engine to dart roll 2017-12-01 13:14:02 -08:00
Alexander Aprelev
5d40ef35c1 Roll engine to pre-dart roll 2017-12-01 13:14:02 -08:00
Phil Quitslund
acbc16afd4 Swift templates tweaks. (#13291)
Dropped optional semicolons.
2017-12-01 10:54:56 -08:00
Phil Quitslund
a4bc470fa5 Tweak access to linter internals in package validation. (#13297)
A more future-proof approach to accessing internal package name lint rule description details.

See: https://github.com/dart-lang/linter/issues/654
2017-12-01 10:54:24 -08:00
Chris Bracken
1d6bb3ccbf Update quiver dependency to 0.26.2 (#13299)
Updates quiver from 0.26.0 to 0.26.2 to pick up strong-mode fixes.
2017-12-01 10:28:59 -08:00
Sigurd Meldgaard
3a393249dc Gallery video demo (#13195) 2017-12-01 18:28:36 +01:00
Zachary Anderson
1bd8ffbc46 Roll engine to 619f452ece9b8fec405c9b1c499f2509caaa79da (#13278) 2017-12-01 09:10:51 -08:00
Sarah Zakarias
f90be214fb Run pod install in flutter_view_ios__start_up test. (#13296) 2017-12-01 16:30:27 +01:00
Jakob Andersen
71ff10ee7e Moved repackage_gradle_wrapper.sh to dev/tools/. (#13294) 2017-12-01 12:26:59 +01:00
Jakob Andersen
5174dbaff5 Download our own copy of gradle wrapper. (#13267)
Rather than depending on android.googlesource.com for hosting the gradle
wrapper, host our own copy on storage.googleapis.com (along with our
other artifacts).

Also added a script to repackage AOSP's version into ours, in case we
ever need to update it.

Addresses the gradle wrapper part of #11681.
2017-12-01 09:39:13 +01:00
Mikkel Nygaard Ravn
19136c283e Bump versions following alpha roll (#13284) 2017-12-01 06:20:05 +01:00
Chris Bracken
7a4df90bfb Extract Cupertino chat row class (#13288)
Extracts Tab2ConversationRow class that consolidates widget tree for a
chat message in the Cupertino navagation chat demo. This refactoring
simplifies adding SafeArea support to handle iOS 11 safe areas in a
followup patch.
2017-11-30 18:47:57 -08:00
Chris Bracken
3efbe00fa6 Correct handling for alwaysUse24HourFormat in MediaQuery (#13287)
1. Ensure that this value is defaulted to the value associated with the
   context rather than re-defaulted to false.
2. Add this value to operator==, hashCode, toString methods.
2017-11-30 18:26:07 -08:00
Chris Bracken
a1b22b17de Don't remove view insets in removePadding ctor (#13286)
This will be followed by a patch that supports independently removing
padding and view insets.
2017-11-30 17:41:09 -08:00
Alexander Aprelev
5a1dcdb427 Fix --preview-dart2 option handling for ios profile/release. (#13285)
* Fix --preview-dart2 option handling for ios profile/release.

* Remove unused parameter
2017-11-30 17:17:39 -08:00
Yegor
e809511682 remove dependency on package:quiver/iterables.dart (#13281) 2017-11-30 15:09:39 -08:00
Ian Hickson
920a726003 Mark good devicelab tests as non-flaky (#13271) 2017-11-30 14:32:49 -08:00
xster
5c4ffa13a6 Let translucent Cupertino bars have its scaffold children automatically pad their heights (#13194)
* Let lists automatically add sliver padding from media query. Translucent nav and tab bars leave behind media query paddings in scaffolds.

* tests

* const lint

* Rename base abstract class to generalized ObstructingPreferredSizeWidget
2017-11-30 13:55:30 -08:00
Chris Bracken
d957c8f040 Add EdgeInsets, MediaQuery support for view insets (#13272)
* Add MediaQuery support for view insets

Also updates EdgeInsets documentation to reflect WindowPadding's use for
both padding and view insets.

See engine commits:
  flutter/engine#4403
  flutter/engine#4406
2017-11-30 13:29:59 -08:00
Chris Bracken
f5ef16df2e Roll engine to 77d8acb9be65e6725c7c4292fe2e3b1159c0aeb9 (#13275) 2017-11-30 13:02:13 -08:00
Ian Hickson
4a4fa2a7c7 Cupertino RTL (#13273)
Fixes the remaining known issues with widgets supporting RTL.
2017-11-30 12:24:40 -08:00
Michael Goderbauer
6493c8b43d Adapt markNeedsSemanticsUpdate algorithm to new semantics tree compiler (#13274)
* ensures that only semantics boundaries will be added to owner._nodesNeedingSemantics as expected by compiler.
* no longer throws assert if markNeedsSemanticsUpdate is called on non-semantic-boundary render object with a non-semantic-boundary parent.
* Fixes #13109.
* removes onlyLocalUpdates from markNeedsSemanticsUpdate as its no longer needed.
2017-11-30 12:18:33 -08:00
Yegor
a78c9f70da remove the unused dispatchDidChangeDependencies (#13224) 2017-11-30 12:17:25 -08:00