Commit Graph

2420 Commits

Author SHA1 Message Date
Chris Bracken
eaa9848fd4 Improve error message for missing 32-bit libstc++ (#15004)
Adds more actionable error messages for users of the most common Linux
distributions. We could improve this by checking the current
distribution and emitting only the appropriate error message. We could
further improve that by only emitting the install instructions if we
determine the appropriate package is not installed.

See: https://github.com/flutter/flutter/issues/6207
2018-02-28 17:53:38 -08:00
Alexander Aprelev
9a9aed191d When doing flutter test use batch compiler and link platform in. (#14983)
This is to fix #14931.
2018-02-28 12:54:30 -08:00
jcollins-g
614df6949c Android license detector in doctor, take two (#14783)
* Revert "Revert "Add android license verification to doctor and some refactoring" (#14727)"

This reverts commit d260294752.

* Add tests, fix sdkManagerEnv and use it consistently, and rearrange Status object model

* AnsiSpinner needs to leave the cursor where it found it.

* fix tests

* Const constructor warning only shows up on windows...?

* Avoid crash if we can't find the home directory

* Make pathVarSeparator return a string in the mock

* Implement review comments

* Fix out-of-order problem on stop
2018-02-28 12:09:52 -08:00
Todd Volkert
97091f513a Fix create template for "package" (#14976)
Fixes https://github.com/flutter/flutter/issues/14975
2018-02-28 11:53:03 -08:00
Mikkel Nygaard Ravn
465478dac4 Update google repo url (#14958) 2018-02-28 13:34:45 +01:00
Chris Bracken
ae6ac2ca74 Add .dart_tool to gitignore (#14932)
Dart is migrating to .dart_tool/ as the location for cached artifacts
and other temporary files generated by tooling in the SDK. As part of
this, pub will be migrating from .pub to .dart_tool/pub.

In future, this path will also be used for other tooling, such as package:build.
2018-02-27 15:29:31 -08:00
Victor Choueiri
9c895fabf2 Add intelliJ path to doctor output (#14795) 2018-02-27 15:19:32 -08:00
Todd Volkert
91a85ac249 Fetch upstream refs before checking out branch in ChannelCommand (#14896)
https://github.com/flutter/flutter/issues/14893
2018-02-26 15:55:28 -08:00
Ryan Macnak
a0ffe87bc3 Use fx get-build-dir and fx netaddr --fuchsia to make fuchsia_reload more convenient. (#14854) 2018-02-26 15:14:09 -08:00
Devon Carew
761cb82c6d update the IntelliJ metadata templates (#14867)
* update the IntelliJ metedata templates

* fix test expectation
2018-02-26 07:38:22 -08:00
Alexander Aprelev
c3bbcb6f91 Add --preview-dart-2 to 'flutter drive' (#14858)
* Add --preview-dart-2 to 'flutter drive'

* Run driver side in --preview-dart-2 mode.

* Fix test
2018-02-24 09:28:58 -08:00
Jason Simmons
7f03b9e41b Upgrade to test package version 0.12.30+4 (#14853)
30+4 has made some changes to the remoting protocol that are incompatbile
with a test harness running 30+3 (e.g. adding a type='initial' field to the
first message)
2018-02-23 12:49:57 -08:00
Vyacheslav Egorov
1f6b9471a8 Fix snapshot fingerprinting in --preview-dart-2 mode. (#14843)
* Fix snapshot fingerprinting in --preview-dart-2 mode.

This is a follow up to PR #14775 - instead of treating dill file
as an input treat as intermediate file and don't fingerprint it.

Make sure to always use original main Dart file as an entry
point for fingerprint calculation.

This fixes an issue that AOT snapshot would not be recompiled in
the preview-dart-2 mode if entry point changes, e.g.

$ flutter build aot -t t/x.dart --preview-dart-2
$ flutter build aot -t t/y.dart --preview-dart-2

The second invocation would not build AOT snapshot.

(This issue is visible on the microbencmarks bot)
2018-02-23 21:40:19 +01:00
Michael Thomsen
382ee4baa4 Detail number of available devices in doctor summary (#14781) 2018-02-22 17:40:56 +01:00
Michael Thomsen
b6d8615aed No longer gitignore pubspec.lock (#14768) 2018-02-22 10:11:09 +01:00
Todd Volkert
37ffb2d730 Make the isRunningOnBot getter more robust. (#14811)
It was failing in the case of an AppContext being in scope
but not having a `BotDetector` seeded in it.
2018-02-21 15:01:46 -08:00
Mikkel Nygaard Ravn
681192a042 Fix test that makes assumptions about the impl of async method (#14804) 2018-02-21 20:47:26 +01:00
Victor Choueiri
3f884661bd Skip upgrade check on upgrade (#14797) 2018-02-21 11:34:36 -08:00
jcollins-g
ca677011f8 Fix flutter tools packages_test when run off bots (#14692)
* Fix packages tests when run off bots

* Tweak dependencies to make bots happy

* Review comment
2018-02-21 09:54:07 -08:00
Todd Volkert
21c514fc56 Wire up support for --skia-deterministic-rendering (#14802)
https://github.com/flutter/flutter/issues/14519
2018-02-20 23:22:58 -08:00
Todd Volkert
eabfd570dd Remove unused parameter to DevFS._scanBundleEntry (#14782) 2018-02-20 12:43:29 -08:00
Alexander Aprelev
45175f5342 Now that we are on dev-23, remove analyzer //ignore (#14780) 2018-02-20 11:20:13 -08:00
Alexander Aprelev
39ddeb52b0 Fix snapshot fingerprint check for --preview-dart-2. (#14775)
* Fix snapshot fingerprint check for --preview-dart-2.

* Remove printTraces
2018-02-20 10:02:00 -08:00
Jason Simmons
494270fe46 Return the result of the operation in ServiceObject.reload (#14755) 2018-02-20 09:45:32 -08:00
Victor Choueiri
4f5f4222e0 Add flutter version to non-verbose doctor output (#14779) 2018-02-20 09:22:49 -08:00
Danny Tuppeny
f914e701c5 Update some http links to https (#14762)
These URLs all automatically redirect HTTP to HTTPS so makes sense to point users at the secure versions.
2018-02-19 21:12:17 +00:00
Mikkel Nygaard Ravn
130dfc87ad Make Podfiles use symlinks to local pods (#14748) 2018-02-19 21:32:13 +01:00
Mikkel Nygaard Ravn
f526805e20 Fix of flutter packages get in plugin project (#14757) 2018-02-17 21:25:13 +01:00
xster
f7f1685cac Make sure broken pod install runs triggers pod install on next flutter build (#14753) 2018-02-16 16:05:16 -08:00
Todd Volkert
1686b6d56d Remove fixed asset bundles - they're no longer used. (#14729) 2018-02-16 10:22:52 -08:00
Alexander Aprelev
fe00598ab3 Reintroduce engineDartSdkPath artifact. (#14742)
This is needed to support running with local engine's dart sdk.

This is follow-up to https://github.com/flutter/flutter/pull/14702.
2018-02-16 09:20:23 -08:00
Mikkel Nygaard Ravn
57779e7e01 Skip new failing test while investigating (#14746)
Merging on red tree to get back to green.
2018-02-16 12:05:37 +01:00
Mikkel Nygaard Ravn
2000435728 Move plugin injection to just after pub get (#14743) 2018-02-16 10:17:28 +01:00
Alexandre Ardhuin
bd1921ec84 unnecessary parenthesis (#14533) 2018-02-16 07:43:19 +01:00
asiva
11105bed4d - Roll engine to version 9867298f86a7ccd5f1c07a83796ee21567d37fb0
- Remove redundant strong flag as it is the default for preview-dart-2
now
2018-02-15 17:45:36 -08:00
xster
1e397d3fb7 Break up and show more progression during an Xcode build (#14715)
* Created plumbing but has stream problem

* testing with makePipe

* Trying pipe but not really getting anywhere

* works by repeatedly reading line

* Minor cleanup

* works

* Clean up pipe after use.

* Move the last status forward

* Make sure failed script commands bubble up
2018-02-15 15:16:23 -08:00
Mikkel Nygaard Ravn
c2e1bc0322 Revert "Move plugin injection to just after pub get (#14560)" (#14734)
This reverts commit b3e4976ca2.
2018-02-15 22:55:36 +01:00
Mikkel Nygaard Ravn
b3e4976ca2 Move plugin injection to just after pub get (#14560) 2018-02-15 22:17:12 +01:00
Todd Volkert
d260294752 Revert "Add android license verification to doctor and some refactoring" (#14727)
Reports from that commit included:

* Doctor hanging
* Doctor prompting to install JDK
* AnsiStatus.cancel() printing elapsed time and extra newline
* Printing extra spinner character at the end of each line
2018-02-15 09:13:56 -08:00
Vyacheslav Egorov
3932a22cdf When running tests with --preview-dart-2 check for compilation errors. (#14724)
If compiler failed to produce Kernel binary then compile(...) returns
null to the caller. If we don't check for null we end up trying to
run file called "null" which causes a very confusing crash of the
flutter_tester.
2018-02-15 16:57:52 +01:00
Alexander Aprelev
c0c6c60b8f Use already downloaded dart sdk for frontend_server. (#14702)
* Use already downloaded dart sdk for frontend_server.

This is follow-up to https://github.com/flutter/flutter/pull/14610

* Remove reference to engine dart-sdk from artifacts

* Remove unused imports

* WIP to switch back to solution where dart sdk is downloaded into bin/cache/dart-sdk, but it is 'flutter precache -a' that can download all dart sdks for other platforms under bin/cache/artifacts/engine/<platform>/dart-sdk

* Download all dart sdks when 'flutter precache -a'
2018-02-15 07:29:42 -08:00
Devon Carew
53b348a50d have flutter analyze support --preview-dart-2 (#14582)
* have flutter analyze support --preview-dart-2

* review comments
2018-02-14 16:00:29 -08:00
jcollins-g
59fe5d0f46 Add android license verification to doctor and some refactoring (#14535)
* Initial version, seems to work

* Unit test for android license checker

* Cleanups

* Windows analyzer wants const.

* Refinements to timeout

* review comments

* Forgot a nit
2018-02-14 15:25:12 -08:00
Alexander Aprelev
a11da23852 Put generated kernel files into <build> folder (#14693)
* Put generated kernel files into <build> directory

* USe default value for kernel file
2018-02-14 12:59:42 -08:00
Justin
ec76c652bd Add support for assets in Fuchsia packages (#14654)
Pull code out of flx.dart:assemble() to make flx.dart:buildAssets
which creates the AssetBundle. This will allow us to create just
this instead of an entire FLX.
2018-02-14 08:05:05 -08:00
Alexander Aprelev
a448994543 Use the Dart SDK built from Flutter engine rather than from dartlang.org (#14610)
* Use engine-built dart sdk

* Download dart-sdk from engine

* Move up deps to fix dart sdk constraint problem

* Update update_dart_sdk.ps1 for Windows

* Fix tests so they pass analysis

* More types for tests

* Roll engine

* Update dart sdk stamp location in flutter.bat

* Add newline
2018-02-14 07:18:25 -08:00
Sarah Zakarias
3723ec0383 Add static framework verification override in swift podfile (#14667) 2018-02-14 10:24:08 +01:00
Todd Volkert
3023fe2046 Add map-specific catch block in run_hot (#14689)
Fixes #14688
2018-02-13 21:08:33 -08:00
xster
80c10bc431 Work around xcodebuild's undocumented freeze when -showBuildSettings is used with -allowProvisioning* (#14684) 2018-02-13 16:49:01 -08:00
Mikkel Nygaard Ravn
8507b72af5 Fix xcode build settings parsing (#14672) 2018-02-13 22:19:03 +01:00