Justin McCandless
dfd4147cea
Fix stuck predictive back platform channel calls ( #133368 )
...
Fix a Google test flakiness increase.
2023-08-28 09:23:52 -07:00
Salmanul Farisi.M
69f61a289e
added option to change color of heading row(flutter#132428) ( #132728 )
...
Paginated datatable widget cannot give color to table header
fixes #132428
---------
Co-authored-by: Hans Muller <hansmuller@google.com >
2023-08-28 08:51:56 -07:00
Polina Cherkasova
2ea5296616
PlatformRouteInformationProvider should dispatch creation in constructor. ( #133353 )
2023-08-28 08:46:10 -07:00
Polina Cherkasova
343000b6e9
_SelectableFragment should dispatch creation in constructor. ( #133351 )
2023-08-25 17:03:47 -07:00
Chinmoy
347f7bac94
Adds callback onWillAcceptWithDetails in DragTarget. ( #131545 )
...
This PR adds onWillAcceptWithDetails callback to DragTarget to get information about offset.
Fixes : #131378
This PR is subject to changes based on #131542
2023-08-25 21:24:05 +00:00
Kate Lovett
72bd36026f
Remove deprecated onPlatformMessage from TestWindow and TestPlatformDispatcher ( #133183 )
2023-08-25 15:46:11 -05:00
Kate Lovett
721016c1db
Remove deprecated androidOverscrollIndicator from ScrollBehaviors ( #133181 )
2023-08-25 15:13:42 -05:00
gmilou
40af7db6bb
Add an example showing how to use a MatrixTransition. ( #132874 )
2023-08-25 15:09:58 -05:00
Kenzie Davisson
61d9f55665
Update flutter packages to pick up latest vm_service ( #133335 )
...
Generated by running `flutter update-packages --force-upgrade`
2023-08-25 11:03:35 -07:00
Taha Tesser
ea00521939
Fix PopupMenuItem with a ListTile doesn't use the correct style. ( #133141 )
...
fixes [`PopupMenuItem` with a `ListTile` doesn't use the correct text style.](https://github.com/flutter/flutter/issues/133138 )
### Description
This fixes an issue text style issue for `PopupMenuItem` with a `ListTile` (for an elaborate popup menu)
https://api.flutter.dev/flutter/material/PopupMenuItem-class.html
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
/// Flutter code sample for [PopupMenuButton].
// This is the type used by the popup menu below.
enum SampleItem { itemOne, itemTwo, itemThree }
void main() => runApp(const PopupMenuApp());
class PopupMenuApp extends StatelessWidget {
const PopupMenuApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
useMaterial3: true,
textTheme: const TextTheme(
labelLarge: TextStyle(
fontStyle: FontStyle.italic,
fontWeight: FontWeight.bold,
),
),
),
home: const PopupMenuExample(),
);
}
}
class PopupMenuExample extends StatefulWidget {
const PopupMenuExample({super.key});
@override
State<PopupMenuExample> createState() => _PopupMenuExampleState();
}
class _PopupMenuExampleState extends State<PopupMenuExample> {
SampleItem? selectedMenu;
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: SizedBox(
width: 300,
height: 130,
child: Align(
alignment: Alignment.topLeft,
child: PopupMenuButton<SampleItem>(
initialValue: selectedMenu,
// Callback that sets the selected popup menu item.
onSelected: (SampleItem item) {
setState(() {
selectedMenu = item;
});
},
itemBuilder: (BuildContext context) =>
<PopupMenuEntry<SampleItem>>[
const PopupMenuItem<SampleItem>(
value: SampleItem.itemOne,
child: Text('PopupMenuItem'),
),
const CheckedPopupMenuItem<SampleItem>(
checked: true,
value: SampleItem.itemTwo,
child: Text('CheckedPopupMenuItem'),
),
const PopupMenuItem<SampleItem>(
value: SampleItem.itemOne,
child: ListTile(
leading: Icon(Icons.cloud),
title: Text('ListTile'),
contentPadding: EdgeInsets.zero,
trailing: Icon(Icons.arrow_right_rounded),
),
),
],
),
),
),
),
);
}
}
```
</details>
### Before
### After
2023-08-25 14:49:04 +00:00
Taha Tesser
612117a690
Fix Chip.shape's side is not used when provided in Material 3 ( #132941 )
...
fixes [Chip border side color not working in Material3](https://github.com/flutter/flutter/issues/132922 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
useMaterial3: true,
chipTheme: const ChipThemeData(
// shape: RoundedRectangleBorder(
// side: BorderSide(color: Colors.amber),
// borderRadius: BorderRadius.all(Radius.circular(12)),
// ),
// side: BorderSide(color: Colors.red),
),
),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return const Scaffold(
body: Center(
child: RawChip(
shape: RoundedRectangleBorder(
side: BorderSide(color: Colors.amber),
borderRadius: BorderRadius.all(Radius.circular(12)),
),
// side: BorderSide(color: Colors.red),
label: Text('Chip'),
),
),
);
}
}
```
</details>
---
### Before
When `RawChip.shape` is provided with a `BorderSide`.
```dart
body: Center(
child: RawChip(
shape: RoundedRectangleBorder(
side: BorderSide(color: Colors.amber),
borderRadius: BorderRadius.all(Radius.circular(12)),
),
label: Text('Chip'),
),
),
```
When `RawChip.shape` is provided with a `BorderSide` and also `RawChip.side` is provided. The `RawChip.side` overrides the shape's side.
```dart
body: Center(
child: RawChip(
shape: RoundedRectangleBorder(
side: BorderSide(color: Colors.amber),
borderRadius: BorderRadius.all(Radius.circular(12)),
),
side: BorderSide(color: Colors.red),
label: Text('Chip'),
),
),
```
---
### After
When `RawChip.shape` is provided with a `BorderSide`.
```dart
body: Center(
child: RawChip(
shape: RoundedRectangleBorder(
side: BorderSide(color: Colors.amber),
borderRadius: BorderRadius.all(Radius.circular(12)),
),
label: Text('Chip'),
),
),
```
When `RawChip.shape` is provided with a `BorderSide` and also `RawChip.side` is provided. The `RawChip.side` overrides the shape's side.
```dart
body: Center(
child: RawChip(
shape: RoundedRectangleBorder(
side: BorderSide(color: Colors.amber),
borderRadius: BorderRadius.all(Radius.circular(12)),
),
side: BorderSide(color: Colors.red),
label: Text('Chip'),
),
),
```
---
2023-08-25 14:47:08 +00:00
Tomasz Gucio
5c17a37b0b
Dispose overlay entries ( #132826 )
2023-08-25 14:35:49 +02:00
Lau Ching Jun
22a61b947f
Allow passing verbose log from flutter daemon. ( #132828 )
...
It would be helpful for debugging if we can choose to also receive remote verbose logs.
2023-08-25 04:26:56 +00:00
Ian Hickson
d6bf1447f4
Update the tool to know about all our new platforms ( #132423 )
...
...and add a test so we remember to keep it in sync.
2023-08-24 21:54:59 +00:00
Ian Hickson
5fa8de05ee
l10n-related documentation improvements ( #133114 )
2023-08-24 21:54:56 +00:00
Henry Riehl
b211891876
Add hover duration for Inkwell widget ( #132176 )
...
Adds a `hoverDuration` property to the `Inkwell` widget. This allows the user to customise how long the change in colour animates between the default colour and the hovered colour.
https://github.com/flutter/flutter/assets/73116038/2e7c5ccb-8651-4e08-8c7b-225cc005d594
Fixes #132170
2023-08-24 21:45:21 +00:00
Polina Cherkasova
afa37891cf
Users of ChangeNotifier should dispatch event of object creation in constructor. ( #133210 )
2023-08-24 13:41:57 -07:00
LongCatIsLooong
b4f4ece40d
Remove ImageProvider.load, DecoderCallback and PaintingBinding.instantiateImageCodec ( #132679 )
...
~The failing plugin tests should pass once
https://github.com/flutter/packages/pull/4725 lands and rolls into
flutter/flutter~
google tests are migrated.
Part of https://github.com/flutter/flutter/issues/133171
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-24 12:38:27 -07:00
Andrew Kolos
e1967ecabf
handle exceptions raised while searching for configured android studio ( #133180 )
...
Fixes #133055
2023-08-24 17:36:19 +00:00
Christopher Fujino
12cf9de68b
Fix mac tool_integration_tests with Xcode 15 ( #133217 )
...
Fixes https://github.com/flutter/flutter/issues/132990
2023-08-24 17:03:17 +00:00
Kate Lovett
87c1a461e1
Remove deprecated PlatformViewsService.synchronizeToNativeViewHierarchy ( #133175 )
...
Part of https://github.com/flutter/flutter/issues/133171
2023-08-23 23:52:19 +00:00
Kate Lovett
8c69fd550c
Remove deprecated MaterialButtonWithIconMixin ( #133173 )
...
Part of https://github.com/flutter/flutter/issues/133171
2023-08-23 23:06:14 +00:00
Polina Cherkasova
89907f6da3
Enable ChangeNotifier clients to dispatch event of object creation in constructor. ( #133060 )
2023-08-23 15:55:28 -07:00
Michael Goderbauer
382ceb5707
Enable literal_only_boolean_expressions ( #133186 )
...
Blocking issue (https://github.com/dart-lang/linter/issues/453 ) for this lint has been resolved.
2023-08-23 21:35:54 +00:00
chunhtai
4930613999
Add android analyzer commands for applinks ( #131009 )
...
Since applink validation tool is going to be a static tool, It won't have access to vmservices.
[flutter.dev/go/static-tooling-in-devtools](http://flutter.dev/go/static-tooling-in-devtools )
I remove the vm services and also update the deeplink task to also include path pattern and custom scheme
http://go/android-applink-apis (internal only)
2023-08-23 21:11:51 +00:00
Christopher Fujino
9e59a68c98
[flutter_tools] Fix legacy version file not being ensured ( #133097 )
...
Fixes https://github.com/flutter/flutter/issues/133093
When I introduced the new, more robust version file `//flutter/bin/cache/version.json` in https://github.com/flutter/flutter/pull/124558 , I changed `class FlutterVersion` into an abstract interface, implemented by `_FlutterVersionFromGit` (which is essentially the previous behavior) and `_FlutterVersionFromFile`, which merely reads the data it would have computed via git from `//flutter/bin/cache/version.json`.
While doing this, I made `_FlutterVersionFromGit.ensureVersionFile()` to be a no-op, since I assumed this would not be necessary since we already had a version file in the cache. However, this method was what was previously responsible for ensuring `//flutter/version` existed on disk. This means that if, for whatever reason, the user had `//flutter/bin/cache/flutter.version.json` present but NOT `//flutter/version`, the tool would have never created that file, and they would hit the tool crash seen in https://github.com/flutter/flutter/issues/133093 .
This fixes the tool by ensuring `//flutter/version` exists regardless of if we're hydrating `FlutterVersion` from `//flutter/bin/cache/flutter.version.json` or not.
2023-08-23 18:31:06 +00:00
Michael Goderbauer
ad78cf3506
Remove deprecated *TestValues from TestWindow ( #131098 )
...
Part of https://github.com/flutter/flutter/issues/133171 .
Removes from `TestWindow`:
* `localeTestValue`
* `clearLocaleTestValue`
* `localesTestValue`
* `clearLocalesTestValue`
* `initialLifecycleStateTestValue`
* `alwaysUse24HourFormatTestValue`
* `clearAlwaysUse24HourTestValue`
* `brieflyShowPasswordTestValue`
* `defaultRouteNameTestValue`
* `clearDefaultRouteNameTestValue`
* `semanticsEnabledTestValue`
* `clearSemanticsEnabledTestValue`
* `accessibilityFeaturesTestValue`
* `clearAccessibilityFeaturesTestValue`
These properties have reached the end of their deprecation period.
2023-08-23 18:31:04 +00:00
Jackson Gardner
d8b1e81c1f
Add --experimental-wasm-type-reflection and support newer emscripten builds. ( #133084 )
...
This makes two changes to prepare for incoming changes to skwasm in the web engine:
* We will (at least for now) be depending on the `WebAssembly.Function` constructor in `skwasm`, which is hidden behind the `--experimental-wasm-type-reflection` flag. We need to pass that when running skwasm benchmarks.
* We are going to be upgrading the skwasm build to a newer version of emscripten, which exposes the wasm exports via the `wasmExports` property instead of the `asm` property. Make sure to support either, if passed.
2023-08-23 17:07:41 +00:00
Ian Hickson
88290989a1
Reference AppLifecycleListener from widgets library ( #132995 )
2023-08-23 04:13:15 +00:00
Ian Hickson
487bd69078
Support disabling animations in the CLI ( #132239 )
2023-08-23 03:35:22 +00:00
Polina Cherkasova
2afded6170
Add test to mark recording as leaking. ( #133073 )
2023-08-23 00:06:05 +00:00
Taha Tesser
1bc791697c
Update default menu text styles for Material 3 ( #131930 )
...
Related https://github.com/flutter/flutter/issues/131676
## Description
#### Fix default input text style for `DropdownMenu`
### Fix default text style for `MenuAnchor`'s menu items (which `DropdownMenu` uses for menu items)
### Default `DropdownMenu` Input text style
### Default `DropdownMenu` menu item text style
### Default `MenuAnchor` menu item text style
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
/// Flutter code sample for [DropdownMenu]s. The first dropdown menu has an outlined border.
void main() => runApp(const DropdownMenuExample());
class DropdownMenuExample extends StatefulWidget {
const DropdownMenuExample({super.key});
@override
State<DropdownMenuExample> createState() => _DropdownMenuExampleState();
}
class _DropdownMenuExampleState extends State<DropdownMenuExample> {
final TextEditingController colorController = TextEditingController();
final TextEditingController iconController = TextEditingController();
ColorLabel? selectedColor;
IconLabel? selectedIcon;
@override
Widget build(BuildContext context) {
final List<DropdownMenuEntry<ColorLabel>> colorEntries =
<DropdownMenuEntry<ColorLabel>>[];
for (final ColorLabel color in ColorLabel.values) {
colorEntries.add(
DropdownMenuEntry<ColorLabel>(
value: color, label: color.label, enabled: color.label != 'Grey'),
);
}
final List<DropdownMenuEntry<IconLabel>> iconEntries =
<DropdownMenuEntry<IconLabel>>[];
for (final IconLabel icon in IconLabel.values) {
iconEntries
.add(DropdownMenuEntry<IconLabel>(value: icon, label: icon.label));
}
return MaterialApp(
theme: ThemeData(
useMaterial3: true,
colorSchemeSeed: Colors.green,
// textTheme: const TextTheme(
// bodyLarge: TextStyle(
// fontWeight: FontWeight.bold,
// fontStyle: FontStyle.italic,
// decoration: TextDecoration.underline,
// ),
// ),
),
home: Scaffold(
body: SafeArea(
child: Column(
children: <Widget>[
const Text('DropdownMenus'),
Padding(
padding: const EdgeInsets.symmetric(vertical: 20),
child: Row(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
DropdownMenu<ColorLabel>(
controller: colorController,
label: const Text('Color'),
dropdownMenuEntries: colorEntries,
onSelected: (ColorLabel? color) {
setState(() {
selectedColor = color;
});
},
),
const SizedBox(width: 20),
DropdownMenu<IconLabel>(
controller: iconController,
enableFilter: true,
leadingIcon: const Icon(Icons.search),
label: const Text('Icon'),
dropdownMenuEntries: iconEntries,
inputDecorationTheme: const InputDecorationTheme(
filled: true,
contentPadding: EdgeInsets.symmetric(vertical: 5.0),
),
onSelected: (IconLabel? icon) {
setState(() {
selectedIcon = icon;
});
},
),
],
),
),
const Text('Plain TextFields'),
Padding(
padding: const EdgeInsets.symmetric(vertical: 20),
child: Row(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
SizedBox(
width: 150,
child: TextField(
controller: TextEditingController(text: 'Blue'),
decoration: const InputDecoration(
suffixIcon: Icon(Icons.arrow_drop_down),
labelText: 'Color',
border: OutlineInputBorder(),
)),
),
const SizedBox(width: 20),
SizedBox(
width: 150,
child: TextField(
controller: TextEditingController(text: 'Smile'),
decoration: const InputDecoration(
prefixIcon: Icon(Icons.search),
suffixIcon: Icon(Icons.arrow_drop_down),
filled: true,
labelText: 'Icon',
)),
),
],
),
),
if (selectedColor != null && selectedIcon != null)
Row(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Text(
'You selected a ${selectedColor?.label} ${selectedIcon?.label}'),
Padding(
padding: const EdgeInsets.symmetric(horizontal: 5),
child: Icon(
selectedIcon?.icon,
color: selectedColor?.color,
),
)
],
)
else
const Text('Please select a color and an icon.')
],
),
),
),
);
}
}
enum ColorLabel {
blue('Blue', Colors.blue),
pink('Pink', Colors.pink),
green('Green', Colors.green),
yellow('Yellow', Colors.yellow),
grey('Grey', Colors.grey);
const ColorLabel(this.label, this.color);
final String label;
final Color color;
}
enum IconLabel {
smile('Smile', Icons.sentiment_satisfied_outlined),
cloud(
'Cloud',
Icons.cloud_outlined,
),
brush('Brush', Icons.brush_outlined),
heart('Heart', Icons.favorite);
const IconLabel(this.label, this.icon);
final String label;
final IconData icon;
}
```
</details>
2023-08-22 22:21:00 +00:00
Taha Tesser
db89df51c3
Fix FlexibleSpaceBar.title doesn't respect the leading widget ( #132573 )
...
fixes [Long `FlexibleSpaceBar.title` doesn't respect the leading widget
](https://github.com/flutter/flutter/issues/132030 )
### Description
- This adds `FlexibleSpaceBarSettings.hasLeading` for the `FlexibleSpaceBar`'s title to respect the leading widget.
- Use the new `FlexibleSpaceBarSettings.hasLeading` property in the `SliverAppBar` for its `FlexibleSpaceBar`.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
useMaterial3: true,
brightness: Brightness.dark,
),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
body: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: [
const Text('TargetPlatform.Android'),
Theme(
data: Theme.of(context).copyWith(
platform: TargetPlatform.android,
),
child: Container(
height: 250,
padding: const EdgeInsets.all(8),
decoration: BoxDecoration(
border: Border.all(
color: Colors.amber,
width: 4,
),
),
child: const AppBarLeading(
showLeading: true,
showTitle: false,
),
),
),
const Text('TargetPlatform.iOS'),
Theme(
data: Theme.of(context).copyWith(
platform: TargetPlatform.iOS,
),
child: Container(
height: 250,
padding: const EdgeInsets.all(8),
decoration: BoxDecoration(
border: Border.all(
color: Colors.amber,
width: 2,
),
),
child: const AppBarLeading(
showLeading: true,
showTitle: false,
),
),
),
],
),
);
}
}
class AppBarLeading extends StatelessWidget {
const AppBarLeading({
super.key,
required this.showLeading,
required this.showTitle,
});
final bool showLeading;
final bool showTitle;
@override
Widget build(BuildContext context) {
return Scaffold(
drawer: const Drawer(),
body: CustomScrollView(
slivers: [
SliverAppBar(
automaticallyImplyLeading: showLeading,
iconTheme: const IconThemeData(
color: Colors.amber,
),
title: showTitle ? const Text('AppBar') : null,
flexibleSpace: FlexibleSpaceBar(
title: Text('Title ' * 15),
// centerTitle: true,
),
toolbarHeight: showTitle ? 170 : 100,
),
],
),
);
}
}
```
</details>
### Before
### After
2023-08-22 20:47:05 +00:00
Ivan Inozemtsev
5665655d39
Add support for Future<List<int>?> to MatchesGoldenFile ( #132965 )
...
Otherwise when tests use `expectLater(getBytesOrNull(), matchesGoldenFile(...))`, they may fail in sound null safety mode and pass in weak null safety mode.
Fixes https://github.com/flutter/flutter/issues/132964
2023-08-22 19:40:18 +00:00
Justin McCandless
0278671bda
Fix memory leak in Form ( #132987 )
...
Diposes some restorable variables that weren't disposed before.
2023-08-22 10:23:13 -07:00
Polina Cherkasova
4e6da2dcc7
Cover more tests with leak tracking. ( #132806 )
...
This PR replaces some `testWidgets` with `testWidgestsWithLeakTracking`.
2023-08-22 15:50:48 +00:00
Kate Lovett
a5b06f15a0
Fix visual overflow for SliverMainAxisGroup ( #132989 )
...
Fixes https://github.com/flutter/flutter/issues/132788
The SliverGeometry was not set properly for SliverMainAxisGroup. Omitting hasVisualOverflow affected the Viewport's choice to apply a clip, leading to the sliver being rendered outside of the bounds of the viewport.
2023-08-22 01:46:23 +00:00
Matan Lurey
a021015ef6
Always require --local-engine-host if --local-engine ( #133003 )
...
Closes #132245 .
2023-08-22 01:32:14 +00:00
Angelo Silvestre
f9b91734a1
Add deleteBackwardByDecomposingPreviousCharacter mapping for tests ( #132919 )
...
In `MacOSTestTextInputKeyHandler`, there are some mappings from shortcuts to generate macOS selectors. However, `ctrl + backspace` isn't mapped to `deleteBackwardByDecomposingPreviousCharacter:`.
This PR adds the mapping for `deleteBackwardByDecomposingPreviousCharacter:`.
Fixes: https://github.com/flutter/flutter/issues/132917
2023-08-21 23:27:19 +00:00
Justin McCandless
8e95ee2e96
Docs on iOS's directional quote characters ( #132869 )
...
When you type a single or double quote character on the default iOS keyboard, it doesn't actually insert the usual `'` or `"`. Instead, it inserts a directional version that tries to match with others. This is very tricky when allow/deny-listing characters, so I've added a section about this to the docs.
Fixes https://github.com/flutter/flutter/issues/132232
2023-08-21 19:02:33 +00:00
fzyzcjy
aeddab428d
When resized network image has error, all future unrelated images using the same url will fail, even if the network becomes OK ( #127456 )
...
Close #127265
The CI fails because of simple analyzer errors. Thus, I would like to hear your opinions first!
2023-08-21 17:12:06 +00:00
Jackson Gardner
6f227c0784
Space character should be optional when tree shaking fonts ( #132880 )
...
Addresses the other part of https://github.com/flutter/flutter/issues/132711
2023-08-19 02:04:15 +00:00
Renzo Olivares
2ecb8866a2
SelectionArea on iOS should toggle the context menu when tapping on the previous selection ( #132851 )
...
https://github.com/flutter/flutter/assets/948037/210fdee4-d922-422b-a257-4ee586a3814f
Related: https://github.com/flutter/flutter/issues/129583
2023-08-18 23:45:16 +00:00
chunhtai
61242fa13b
Updates app link gradle tasks and remove vm services ( #131805 )
...
1. Remove vm service registration
2. combine print<variant>ApplicationId and print<variant>AppLinkDomain into one task dump<variant>AppLinkSettings, which dump all the data in a json file
The deeplink validation tool will be a static app in devtool instead of regular app. A Static app doesn't require a running app; therefore, we can't call these API through vmservices. I decided to convert these API into flutter analyzer command, which will be done in a separate PR https://github.com/flutter/flutter/pull/131009 .
The reason these print tasks are converted into file dumps is to reduce the amount of data encoding and decoding. Instead of passing data through stdout, the devtool can read the files generated by gradle tasks instead.
2023-08-18 18:42:58 +00:00
Mustafa Ateş Uzun
6875827f46
doc: add flag params ( #132485 )
...
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-08-18 17:48:05 +00:00
gmilou
58019b3428
Add a new MatrixTransition and refactor ScaleTransition and RotationT… ( #131084 )
...
â¦ransition to derive from it.
The MatrixTransition class uses a callback to handle any value => Matrix animation.
The alignment and filterQuality logic that was in ScaleTransition and RotationTransition is now factored in MatrixTransition.
The ScaleTransition.scale and RotationTransition.turns getters had to be kept because they're still referenced in https://github.com/flutter/packages/tree/main/packages/animations , and https://github.com/flutter/packages/flutter/test/ . I plan to remove the references there, once this PR is generally available, and then remove the getters here.
A RotationTransition test was updated to use matrixMoreOrLessEquals because using Matrix4.rotationZ doesn't have the special cases Transform.Rotation had, and zeroes in matrix weren't exactly zeroes.
fixes #130946
2023-08-18 16:50:06 +00:00
Andrey Suvorov
1cfba2620a
fixes l10n for CupertinoDatePicker in monthYear mode ( #130934 )
...
This PR fixes l10n issue when months names are being used in incorrect form in CupertinoDatePicker in CupertinoDatePickerMode.yearMonth (#130930 ).
The idea of this proposal is to add an optional parameter `standalone` for `CupertinoLocalizations.datePickerMonth` to be able to choose when to use months names in base form (intl DateSymbols.STANDALONEMONTHS) and when in day-dependent form (intl DateSymbols.MONTHS)
<details>
<summary>Before</summary>
<img width="366" alt="image" src="https://github.com/flutter/flutter/assets/32621121/1dd54fa7-6dd9-4053-889b-57134c145432 ">
<img width="387" alt="image" src="https://github.com/flutter/flutter/assets/32621121/c176070e-73e4-49d3-883b-ba31eca6d1d7 ">
</details>
<details>
<summary>After</summary>
<img width="369" alt="image" src="https://github.com/flutter/flutter/assets/32621121/255594f1-219d-4bd4-9b75-1012912f8ab0 ">
<img width="378" alt="image" src="https://github.com/flutter/flutter/assets/32621121/16bbb41f-3f62-4446-bf41-e27140b649a9 ">
</details>
2023-08-18 16:38:54 +00:00
Victoria Ashworth
b52297da06
Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR ( #132803 )
...
Starting in Xcode 15, when building macOS, DT_TOOLCHAIN_DIR cannot be used to evaluate LD_RUNPATH_SEARCH_PATHS or LIBRARY_SEARCH_PATHS. `xcodebuild` error message recommend using TOOLCHAIN_DIR instead.
Since Xcode 15 isn't in CI, I tested it in a one-off `led` test:
* [Pre-fix failure](04e485a0b1/+/build.protod454a3e181/+/build.protohttps://github.com/flutter/flutter/issues/132755 .
2023-08-18 15:24:55 +00:00
Tae Hyung Kim
312ef54115
[flutter_tools] Generate localizations on flutter pub get ( #132172 )
...
Currently, flutter pub get generates localizations if there exists an l10n.yaml file where synthetic-package is not false. However, for any user who needs to turn off synthetic-package, their localizations are not generated. This PR should make the behavior more consistent. (Also it seems good to make it so that running flutter pub get once resolves all the dependencies so that people can get to work without running flutter gen-l10n manually.)
Fixes https://github.com/flutter/flutter/issues/84979 .
2023-08-18 15:01:09 +00:00
Navaron Bracke
03664d0acb
Fix description in index.html / manifest.json getting double quoted ( #131842 )
...
This PR adjusts the quoting of the project description not not apply twice in the index.html / manifest.json of web builds.
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/131834
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-08-18 02:58:20 +00:00
