Commit Graph

3389 Commits

Author SHA1 Message Date
Jason Simmons
ed7261c110 Fixes related to usage of std::weak_ptr to hold PlatformViews (flutter/engine#3949)
* Call weak_ptr.lock(), which returns a null shared_ptr and does not throw
* IsViewInvalid was inverted
2017-08-03 10:53:17 -07:00
Vyacheslav Egorov
e2889dacca hide Symbol exported from dart:_internal (flutter/engine#3861)
Both dart:core and dart:_internal export Symbol. 

This is silently ignored by the VM but some tools (e.g. fasta) report a warning when processing dart:ui sources.

See https://github.com/dart-lang/sdk/issues/30127 for more details.
2017-08-02 16:55:10 -07:00
Chinmay Garde
e94546d547 On emulators, render onscreen (with warnings) if any of the MakeS32 based SkSurface creation calls fail. (flutter/engine#3947) 2017-08-02 14:29:29 -07:00
Michael Goderbauer
a8ea6bd4af Mention Goma for Googlers in CONTRIBUTING.md (flutter/engine#3946)
* Mention Goma for Googlers in CONTRIBUTING.md

* review comments
2017-08-02 13:49:27 -07:00
Gary Qian
3ba1087025 Use serif font on kerning tests and white bg for increased test clarity.
Change-Id: If9a0063d854a277ea3023e44558ee443602cf467
2017-08-01 16:48:33 -07:00
Gary Qian
4a5e0222a3 Change handling of large y coord in GetGlyphPositionAtCoordinate() to match blink.
Change-Id: I6db6d5e98a0ef63e29cc4aac9a3aa38dfb18e59d
2017-08-01 16:48:33 -07:00
Gary Qian
a28fbd2e74 Correct name of def font on Android and fix bug with coords-to-glyphpos method.
Change-Id: Ib9d2a0a1a54f14c4725e47e00fb547df0a91cd40
2017-08-01 16:48:33 -07:00
Gary Qian
1fd69f9824 Refactor FontCollection to allow for adding in new font managers, and initial android font loading.
Change-Id: I719b14a515aabf5d6b3894f79ca64ea20ef5625d
2017-08-01 16:48:33 -07:00
Abhishek Amit
5ec8f6d9f2 Fix android-cpu flag reference (flutter/engine#3943) 2017-08-01 14:02:28 -07:00
Jason Simmons
e5fed53de7 fix sRGB typo (flutter/engine#3942) 2017-07-31 17:12:45 -07:00
Jason Simmons
521031a50c Support sendKeyEvent for arrow keys (flutter/engine#3940)
Fixes https://github.com/flutter/flutter/issues/11352
2017-07-31 16:52:34 -07:00
Carlo Bernaschina
94f1311b9e Roll Dart to a67d798841ec6379c39c6cd20e9b867689df0e64 (flutter/engine#3936)
The new `dart_observatory_pub_packages_rev` dependent on the rolled `dart_revision` required the update of the licensing files
2017-07-31 16:26:06 -07:00
Chinmay Garde
6d71aee780 Update buildroot to account for stricter warning flags. (flutter/engine#3939) 2017-07-31 16:22:15 -07:00
Jason Simmons
dc8f103ca8 Check for an empty selection in deleteSurroundingText (flutter/engine#3938)
Fixes https://github.com/flutter/flutter/issues/11437
2017-07-31 16:18:27 -07:00
Chinmay Garde
62108dc53e Always consume items from the pipeline in the null rasterizer. (flutter/engine#3937)
Now, frame requests past the pipeline depth will never be deferred due
to back pressure. This backend is only used in the test runner.
2017-07-31 15:16:48 -07:00
xster
62ee1c8b95 Extend iOS's drawing time to viewWillAppear <-> viewDidDisappear (flutter/engine#3934)
* fix (with squashed debug stuff)

* clean up
2017-07-31 15:12:32 -07:00
Chinmay Garde
a8b230ae6c Update the Vulkan backend to account for GPUSurface API updates. (flutter/engine#3933) 2017-07-28 18:25:13 -07:00
Ian Hickson
a802c739ee More documentation, mainly around saveLayer. (flutter/engine#3932) 2017-07-28 14:38:42 -07:00
Chinmay Garde
7314a7e0bc When the surface does not support SRGB, render to an offscreen texture. (flutter/engine#3930) 2017-07-28 12:48:32 -07:00
Gary Qian
d09bbdfd37 Check if width is different before skipping Layout().
Change-Id: Ie5a99f39cf462c42ed1e484afc90a61e7567bdc3
2017-07-27 17:54:27 -07:00
Jason Simmons
9b6a2dc616 Simplify a license script regex that was not completing on a Skia source file (flutter/engine#3929)
See https://github.com/flutter/engine/pull/3881
2017-07-27 15:28:05 -07:00
Gary Qian
95bda714a0 Support handling '\n' characters.
Change-Id: I9d8c25df97e600ee3679f0bf31b0a4bb8df9eb6d
2017-07-27 13:44:19 -07:00
Gary Qian
8a5babb292 Custom width tracking for accurate and consistent underlines and decorations.
Change-Id: I8ea703321cefc5cc402bf6d4247cd45eb3e085b2
2017-07-27 09:58:41 -07:00
Gary Qian
476860da54 Default decoration color to text color.
Change-Id: I74f1ffc6372ccf952232e9dcbba66029c31a7088
2017-07-27 09:57:59 -07:00
Gary Qian
d447e4de83 Make decorations respect proper SkPaint::FontMetrics positioning and
thickness and improve overall decoration visual quality.

Change-Id: Icb5e64a80fbe8a04106125c2dc41e60459b944c0
2017-07-27 09:57:59 -07:00
Gary Qian
e2c9992638 API comments and reorder vars.
Change-Id: I9f73047bc5ad453b05083f019623f553d13bbba4
2017-07-27 09:57:46 -07:00
Jason Simmons
dc5ae3c20f Do not send messages if the platform view has been detached (flutter/engine#3927) 2017-07-26 20:04:31 -07:00
Ian McKellar
4ab42e4358 Use the tonic::HandleTable (flutter/engine#3924) 2017-07-26 12:19:34 -07:00
Gary Qian
1946e649c7 Add middle-of-glyph bounding for coord-to-index system and fix alignment bug.
Change-Id: I1f772886949131468407bdc12f1dc6e0ba03b68e
2017-07-25 15:40:09 -07:00
Gary Qian
a537b6cea6 Fix coord to glyph position function and glyph position tracking.
Change-Id: Ib031e9c46b5622a5ff830b602c1fa2fe037ea7f5
2017-07-25 12:31:36 -07:00
Jeff Brown
adef60fe5a Use metrics provided by scene events. (flutter/engine#3922)
Compute the necessary texture resolution using more accurate scaling
information provided by Mozart scene node metrics events instead of the
device pixel ratio provided by the Mozart view properties (which we
might remove in the future).

This allows us to allocate smaller textures when a Flutter view is
being scaled down.
2017-07-24 19:17:55 -07:00
Gary Qian
13af3dc89c Add basecase checking to prevent segfault in GetWordBoundary().
Change-Id: I5ca93c0c15ef5dd3dbc6a5937f8b21338acf884d
2017-07-24 18:24:55 -07:00
Gary Qian
20914d0e91 Fix GetCoordinatesForGlyphPosition() and adjust other methods to match. Tests to back it up.
Change-Id: I2ea9065f043c752bebc1a16e1e0c2c2fec59d87c
2017-07-24 16:36:25 -07:00
Gary Qian
1ccc959d00 Add unittests for kerning.
Change-Id: I494bbd3993cde76cabc9dfc042dcee4b0fb6af4d
2017-07-24 15:24:35 -07:00
Jason Simmons
2afa2eefd9 Incorporate the device pixel ratio when drawing shadows (flutter/engine#3919) 2017-07-24 12:01:43 -07:00
Alexander Aprelev
5bc3ac48a3 Update Flutter engine kernel-loading logic. (flutter/engine#3886)
* Fix Flutter loading from dill files.

* Remove disable of causal async stacks.

* Include mirrors patch files as they are needed for release/profile gen_snapshot

* Free the bytes

* Add FTL_DCHECK
2017-07-24 09:47:23 -07:00
Gary Qian
34dfd6c602 Add support for multiple break strategies to better support edge case situations.
Change-Id: I61fc4d95a57b34f59073e99ad834c9a0d7ec7c76
2017-07-21 16:19:44 -07:00
Gary Qian
09d3505e3b Switch to using minikin letter spacing.
Change-Id: I0e0908eea3f79bf0a6a5eb9842956d4077bb9dd3
2017-07-21 12:08:17 -07:00
Gary Qian
1fca345a77 Benchmark improvements and additions. Document n^2 benchmark findings.
Change-Id: I697acad51082151e6614abffe6bebbbe73f31a75
2017-07-20 16:50:18 -07:00
Gary Qian
264a66f3f3 Do not pass full buffer to minikin for big performance improvements.
Change-Id: I411d6168e45204774d4776aa241feeaf19dad818
2017-07-20 13:10:35 -07:00
Gary Qian
85bd669eac Benchmark rework to better reflect real usage and slight performance improvements.
Change-Id: I3979c725ff9058fc208626ffb5fce95c2e03ac19
2017-07-20 12:19:57 -07:00
xster
b355dec44a Always schedule a frame on app did become active (flutter/engine#3910) 2017-07-20 10:54:08 -07:00
Gary Qian
4025267537 Use SkCanvasAutoRestore.
Change-Id: I35a7c65303e17132af86f552a657d226d9576850
2017-07-19 17:50:22 -07:00
Chinmay Garde
929da4904d Reduce layer tree pipeline depth to 2. (flutter/engine#3909) 2017-07-19 17:47:44 -07:00
Jason Simmons
7d72fbe1c5 Add an RRect.isRect property (flutter/engine#3908) 2017-07-19 17:30:31 -07:00
Chinmay Garde
79a8d775b6 Visualize image decoding and texture upload using trace flows. (flutter/engine#3907) 2017-07-19 16:22:06 -07:00
Carlo Bernaschina
e7cd520490 Add waitUIThreadIdle service RPC (flutter/engine#3898)
In https://github.com/flutter/engine/pull/3833 the `_flutter.listViews` RPC moved from thread based to lock based synchronization.
The thread based synchronization side effect was used by flutter benchmarks in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/vmservice.dart#L1223 and
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/run_hot.dart#L156 to ensure the completeness of the restart/reload and so correct timing.

A new RPC `_flutter.flushUIThreadTasks` is introduced to allow the flutter benchmarks to reintroduce thread based synchronization.

Related https://github.com/flutter/flutter/issues/11241
2017-07-19 15:48:32 -07:00
Ian Hickson
eb44210a77 Cleaner RRect.toString (flutter/engine#3906)
Will make debugging layer trees with PhysicalLayers easier.
2017-07-19 14:41:07 -07:00
Ryan Macnak
d07c9b42f2 [fuchsia] Make it easy to flip the whole system between flutter_jit_app and flutter_aot_app. (flutter/engine#3873) 2017-07-19 14:21:02 -07:00
Ryan Macnak
ce4229482c Speculatively disable GN argument 'enable_profiling' to test its effect on benchmarks. (flutter/engine#3905) 2017-07-19 12:52:53 -07:00