Commit Graph

658 Commits

Author SHA1 Message Date
Jonah Williams
fff8ecfb94 [flutter] reject mouse drags by default in scrollables (#81569) 2021-05-03 16:54:02 -07:00
Ian Hickson
ec91c6582b Update documentation for scrollUntilVisible and friends. (#81497) 2021-05-01 18:29:03 -07:00
Angjie Li
cbdd9c4787 Revert "Refactor text editing test APIs (Mark III) (#80003)" (#81316)
This reverts commit 285b475124.
2021-04-27 11:34:36 -07:00
Angjie Li
b74df388e1 Revert "Migrate to ChannelBuffers.push (#76288)" (#81226)
This reverts commit c26ed03c8a.
2021-04-26 12:57:17 -07:00
Ian Hickson
c26ed03c8a Migrate to ChannelBuffers.push (#76288)
* Migrate to ChannelBuffers.push

* Move TestDefaultBinaryMessenger to its own file

* Apply deprecations and fix usages
2021-04-23 15:39:34 -07:00
Ian Hickson
285b475124 Refactor text editing test APIs (Mark III) (#80003) 2021-04-21 18:29:04 -07:00
Phil Quitslund
61c30c41b2 fix sort_directives violations (#80817) 2021-04-21 13:49:03 -07:00
Tong Mu
eb73516739 Shortcut activator (#78522)
This PR introduced a new class, ShortcutActivator, and refactored the the definition and lookup system of shortcuts, in order to solve a few issues of the previous algorithm.
2021-04-15 01:42:49 -07:00
Justin McCandless
0efb28d706 Revert "Fix a legacy TODO (#77454) (#79061)" (#79959)
This reverts commit b070ed3c04.
2021-04-07 12:24:22 -07:00
Ian Hickson
b070ed3c04 Fix a legacy TODO (#77454) (#79061) 2021-04-02 22:39:03 -07:00
LongCatIsLooong
c1c5b492be Reland 79654 (#79656) 2021-04-02 15:44:02 -07:00
LongCatIsLooong
bf6e38db2b Revert "enterText to move the caret to the end (#79506)" (#79654)
This reverts commit 67d8556baa.
2021-04-02 10:57:14 -07:00
LongCatIsLooong
67d8556baa enterText to move the caret to the end (#79506) 2021-04-01 20:29:03 -07:00
Tong Mu
dbcac7f177 Reland Make LogicalKeyboardKey.keyLabel a getter and better #79100 (#79302) 2021-04-01 16:39:02 -07:00
Chris Bracken
3e7e06512c Correct misspellings throughout the codebase (#79500) 2021-04-01 10:04:03 -07:00
Alexander Brusher
beb62a663d Rolls isKeyboardKey engine change with fix (#79407)
* Adds a semantics node flag to identify sliders.

* [fuchsia] Fix roll of engine PR #25167

This changes fixes tests failing due to new isKeyboardKey semantics
flag.

* Fix typo

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2021-03-31 10:43:58 -07:00
Michael Bui
39499bd2bf make showKeyboard respect finder's skipOffstage value (#79034) 2021-03-29 18:19:03 -07:00
Tong Mu
a603714610 Revert "Make LogicalKeyboardKey.keyLabel a getter and better (#79100)" (#79217) 2021-03-28 03:54:02 -07:00
Tong Mu
b60c855af5 Make LogicalKeyboardKey.keyLabel a getter and better (#79100) 2021-03-26 22:14:01 -07:00
Alexandre Ardhuin
e384ca7979 use null aware operators for function invocations (#79049) 2021-03-26 09:34:03 -07:00
Tong Mu
eb6e56761e Revert "Remove keyLabel and debugName from Logical/PhysicalKeyboardKey (#78263)" (#79005)
This reverts commit 515ef91ba1.
2021-03-24 13:31:02 -07:00
Tong Mu
515ef91ba1 Remove keyLabel and debugName from Logical/PhysicalKeyboardKey (#78263)
- Remove `LogicalKeyboardKey.keyLabel`
- Make `Physical/LogicalKeyboardKey.debugName` getters
- Make `Physical/LogicalKeyboardKey()` factory constructors, which cache non-predefined instances.
2021-03-24 04:59:57 -07:00
Shi-Hao Hong
7a88eb97ea Typo fixes (#78755) 2021-03-23 09:23:43 +08:00
Michael Goderbauer
a7e3b1a35d Clean up ignores that are not ignoring anything (#78493) 2021-03-19 15:32:46 -07:00
Angjie Li
6515806717 Revert "Fix a legacy TODO (#77454)" (#78584)
This reverts commit 5e4e530e93.
2021-03-19 10:08:12 -07:00
Ian Hickson
f3c25fa07a Align more closely with package:test (#77118) (#78343) 2021-03-16 13:58:02 -07:00
Ian Hickson
5e4e530e93 Fix a legacy TODO (#77454) 2021-03-16 10:48:02 -07:00
Zachary Anderson
e7e1a04aa3 Revert "Align more closely with package:test (#77118)" (#78329)
This reverts commit 0cbe597540.
2021-03-16 09:26:34 -07:00
Ian Hickson
0cbe597540 Align more closely with package:test (#77118) 2021-03-15 16:28:02 -07:00
Michael Goderbauer
d637b1874f non-breaking changes for prefer_mixin lint (#77837) 2021-03-11 19:50:03 -08:00
Kate Lovett
9840d65943 Make LocalFileComparator.compare easier to override (#77825) 2021-03-10 12:20:04 -08:00
Michael Goderbauer
cb867bbedc Enable unnecessary_await_in_return lint (#77434) 2021-03-05 18:38:15 -08:00
Michael Goderbauer
807bb29888 enable prefer_function_declarations_over_variables lint (#77398) 2021-03-05 18:29:04 -08:00
Chris Bracken
565e48777a Roll Engine from 299eb3e710c1 to 67abe7f9a9e4 (13 revisions) (#77386)
This is a manual roll since it requires adding a new SemanticsAction to
an element in the flutter_test SemanticsAction matchers test which was
added as part of https://github.com/flutter/engine/pull/24734.

299eb3e710...67abe7f9a9

2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter/engine#24812)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b321d01eec78 to 4693d6d4f88e (1 revision) (flutter/engine#24811)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 835da00aa6b5 to b321d01eec78 (1 revision) (flutter/engine#24808)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter/engine#24806)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter/engine#24805)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter/engine#24804)
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b674d73af53 to 835da00aa6b5 (1 revision) (flutter/engine#24803)
2021-03-05 chris@bracken.jp Update cppwinrt to build 2.0.210304.5 (flutter/engine#24801)
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter/engine#24799)
2021-03-05 47866232+chunhtai@users.noreply.github.com Adds set text action for voice access (flutter/engine#24734)
2021-03-04 jason-simmons@users.noreply.github.com SkParagraph: support multiple default font families (flutter/engine#24662)
2021-03-04 skia-flutter-autoroll@skia.org Roll Clang Mac from MQQ43_LGr... to MRLGJYv8V... (flutter/engine#24794)
2021-03-04 jason-simmons@users.noreply.github.com Allow calls to legacyMakeTypeface in the AssetFontManager (flutter/engine#24612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2021-03-05 10:10:32 -08:00
Michael Goderbauer
7b251f5f37 Enable use_function_type_syntax_for_parameters lint (#77163) 2021-03-04 08:59:17 -08:00
Kate Lovett
6ec9014298 Expose the diff from ComparisonResult (#77014) 2021-03-02 10:09:03 -08:00
Ferhat
cc9b78fc5c [web] Treeshake keymaps for web (4% code size reduction in hello world) (#75945) 2021-02-25 13:26:03 -08:00
Jason Simmons
6757c7dd47 Use a null default skip value in testWidgets so it can inherit the group's skip flag (#76174) 2021-02-17 14:31:03 -08:00
Sam Rawlins
fcad4e2efe Remove "unnecessary" imports in flutter_test (#76157) 2021-02-16 16:01:05 -08:00
Todd Volkert
835c7fab45 Fix FocusManager constructor (#75894)
The FocusManager constructor was registering global event handlers
on the shared RawKeyboard instance and the global pointer router.
This posed a few problems: (1) there was no way to unregister these
handlers, and (2) instantiating a second FocusManager would overwrite
the existing focus manager's RawKeyboard handler. This was manifesting
in unexpected ways, such as the fact that constructing a second
BuildOwner (for a parallel tree, for instance) was obliterating the
event handler for the main BuildOwner's focus manager, thus messing
with focus.

This change separates those global event registrations into a
dedicated method, registerGlobalHandlers(), and overrides dispose()
to properly unregister those handlers.
2021-02-12 17:19:20 -08:00
Ian Hickson
824042f9b2 Catch cases in tests where people try to tap on widgets that aren't reachable. (#74798) 2021-02-03 16:11:02 -08:00
Anas35
091a74dab6 removed new keyword (#75049) 2021-02-01 09:59:53 -08:00
Yegor
791edc230d always pass filterQuality specified in the Image widget to canvas (#74854) 2021-01-28 21:54:03 -08:00
Ian Hickson
37a0189773 Don't leak exceptions thrown by message channels (#74446) 2021-01-27 11:19:04 -08:00
Jia Hao
8a5ace25a5 Improve performance of Widget Tests (#70730) 2021-01-12 17:29:03 -08:00
creativecreatorormaybenot
508c4b4d29 Correct flutter_test flutter_test_configuration.dart documentation (#70862) 2020-11-25 13:38:05 -08:00
Greg Spencer
2d836a99b6 Remove some unnecessary casts, now that changes have rolled from the engine (#70491) 2020-11-13 16:28:06 -08:00
Michael Goderbauer
cca1215939 Properly initialize RestorationManager in the TestBinding (#70398) 2020-11-12 13:59:05 -08:00
Greg Spencer
86f9ab511e Revert usages of the binding's platformDispatcher to use window instead (#70319)
This reverts usages of the binding's platformDispatcher to use window again temporarily, because there isn't a TestPlatformDispatcher yet, and so some tests were failing because they mocked the TestWindow to return certain things (locales) that were returning the real values instead of the test values.

Once I've created a TestPlatformDispatcher to allow fake data to be passed to it, we can go back to using the platformDispatcher in all of these places
2020-11-12 11:17:00 -08:00
Greg Spencer
0937207f5b Fix Platform channel errors in web tests (#70252) 2020-11-12 10:24:07 -08:00