Commit Graph

24470 Commits

Author SHA1 Message Date
Alexander Aprelev
c01cad3491 Fix flutter test --preview-dart-2 following last dart roll. (#15233)
* Fix `flutter test --preview-dart-2`  following last dart roll.

Incremental compiler maintains single incremental dill file, so for every test compilation that dill file has to be copied away for execution.

* Fix lints
2018-03-07 06:27:58 -08:00
Siva
9c38d6bb35 Fix some of the generic types specified to avoid runtime errors in --preview-dart-2 (#15166)
* Fix some of the generic types specified to avoid runtime errors in
--preview-dart-2

  type 'YamlMap' is not a subtype of type 'Map<String, dynamic>' where
    YamlMap is from package:yaml/src/yaml_node.dart
    Map is from dart:core
    String is from dart:core

  package:flutter_devicelab/framework/manifest.dart 17:36       loadTaskManifest
  test/manifest_test.dart 14:33                                 main.<fn>.<fn>
  package:test/src/backend/declarer.dart 161:27                 Declarer.test.<fn>.<fn>.<fn>

* Add dynamic generic types to keep the analyer happy.

* Address code review comment.
2018-03-07 00:33:21 -08:00
Mikkel Nygaard Ravn
0d59679624 Make Flutter tooling work on Android without Xcode being installed (#15161) 2018-03-07 08:41:23 +01:00
Josh Soref
c5a5945e92 Spelling (#15229)
* spelling: accommodate

* spelling: allotted

* spelling: anonymous

* spelling: artificial

* spelling: associated

* spelling: asset

* spelling: button

* spelling: canvas

* spelling: compatibility

* spelling: coverage

* spelling: condition

* spelling: decoration

* spelling: deferring

* spelling: diameter

* spelling: direction

* spelling: displacement

* spelling: dropdown

* spelling: needing

* spelling: environment

* spelling: exited

* spelling: expansion

* spelling: explore

* spelling: families

* spelling: horizontal

* spelling: increment

* spelling: indices

* spelling: internationalization

* spelling: labrador

* spelling: localizations

* spelling: midflight

* spelling: milliseconds

* spelling: minimum

* spelling: multiple

* spelling: multiplication

* spelling: navigator

* spelling: overridden

* spelling: package

* spelling: performance

* spelling: platform

* spelling: porsche

* spelling: position

* spelling: preceded

* spelling: precede

* spelling: precedence

* spelling: print

* spelling: property

* spelling: readily

* spelling: reproducibility

* spelling: rounded

* spelling: scroll

* spelling: separate

* spelling: separator

* spelling: services

* spelling: specific

* spelling: specify

* spelling: synchronously

* spelling: through

* spelling: timeout

* spelling: triangle

* spelling: trivial

* spelling: unusual

* spelling: then

* spelling: vertically

* spelling: visible

* spelling: visited

* spelling: voice
2018-03-06 21:36:03 -08:00
Todd Volkert
d0cbbd5394 Fail if precompiled test entry point is specified, but more than one test suite is run (#15208) 2018-03-06 21:28:52 -08:00
Alexander Markov
602e6d74b5 Pass entry points JSON files to front-end server, take 2 (#15227)
* Pass entry points JSON files to front-end server (#15180)

* Fix ios/debug build which uses 'flutter build aot': do not require entry points files and disable AOT transformations in this mode
2018-03-06 18:45:45 -08:00
Hans Muller
e1c38aa024 Enable aligning a dropdown button's width with its menu's width (#14849) 2018-03-06 17:37:27 -08:00
Alexander Markov
01d8e0a143 Revert "Pass entry points JSON files to front-end server" (#15223)
* Revert "Pass entry points JSON files to front-end server (#15180)"

This reverts commit 0edea88745.

Reason: buildbot failures on Mac.
2018-03-06 16:08:37 -08:00
xster
f048023638 Cupertino picker haptic (#14831)
* Add selection haptic feedback to Cupertino Pickers

* review

* don't haptic on android
2018-03-06 15:38:00 -08:00
Michael Goderbauer
86be138d9c Make BottomNavBar accessible (#15211) 2018-03-06 15:08:39 -08:00
Alexander Markov
0edea88745 Pass entry points JSON files to front-end server (#15180) 2018-03-06 14:50:22 -08:00
Keerti Parthasarathy
0263394028 Adding back commit #e0f6e62 with fix to test failures (#15212)
* Add to Artifacts, and add optional arguments to entry points for flut… (#15185)

Add to Artifacts, and add optional arguments to entry points for flutter run and test to allow for wiring up the same with preview-dart-2 internally

* Changing packages uri here is not necessary
2018-03-06 14:41:50 -08:00
Alexander Aprelev
758b302c8d Add --preview-dart-2 relaunch test. (#15117)
* Add a test that measures/verifies start from warm state(app was previously compiled).

* Remove json file from the first run.
2018-03-06 14:33:26 -08:00
Jason Simmons
85412d8b7c Roll engine to 24cf8ebd8621713a6936df783dad5019f52bc85e (#15213) 2018-03-06 14:06:36 -08:00
Keerti Parthasarathy
7066cd7b88 Revert "Add to Artifacts, and add optional arguments to entry points for flut… (#15185)" (#15210)
This reverts commit e0f6e626e9.
2018-03-06 11:55:39 -08:00
Keerti Parthasarathy
e0f6e626e9 Add to Artifacts, and add optional arguments to entry points for flut… (#15185)
Add to Artifacts, and add optional arguments to entry points for flutter run and test to allow for wiring up the same with preview-dart-2 internally
2018-03-06 10:03:42 -08:00
Alexander Markov
dba9584ba1 Pass extra front-end and gen_snapshot options to GenerateDependencies gradle task, as it also runs 'flutter build aot' (#14980) 2018-03-06 09:19:30 -08:00
Sarah Zakarias
3ecc2a4ed2 Url encode asset lookup key (#15171) 2018-03-06 09:24:31 +01:00
Todd Volkert
545c292cb8 Pass --trace to pub when in verbose mode (#15169)
https://github.com/dart-lang/pub/issues/1812
2018-03-05 20:01:30 -08:00
P.Y. Laligand
8709e5e71f [fuchsia] Add explicit sources to a few targets. (#15182) 2018-03-05 18:03:09 -08:00
Yegor
e9c982c39f [semantics]: minor docs & style clean-up (#15181)
* [semantics]: minor docs & style clean-up

* remove a
2018-03-05 17:01:42 -08:00
Jonah Williams
419fef3f8b Check that State.initState and State.didUpdateWidget don't return Futures (#15183)
* add a debug check that the returned Type of State.initState and State.didUpdateWidget are not Futures

* add test to verify that async lifecycles throw FlutterErrors

* address some feedback, match implementation of setState check

* address feedback from hixie

* fix odd spacing in test
2018-03-05 15:59:18 -08:00
Sarah Zakarias
f8ac23cd86 Roll engine to a00f8e8bc0f3d08ec0c0ca24b01226441bcaf03a (#15172) 2018-03-05 23:27:57 +01:00
Alexander Aprelev
70f60b17d7 Run dev/bots/test's flutter drive test in preview-dart-2 (#15090)
* Run dev/bots/test's flutter drive test in preview-dart-2

* Fix extension callback type

* More type fixes
2018-03-05 08:55:10 -08:00
Todd Volkert
c885015934 Fix download Dart DK step to work for paths with apostrophes (#15137)
Fixes https://github.com/flutter/flutter/issues/15136
2018-03-04 12:15:22 -08:00
Ian Hickson
fe334e1652 More quoting in Bash (#15087)
Someone ended up with STAMP_PATH containing a blank line.

Also, replace [ with [[.
2018-03-02 17:54:51 -08:00
Hans Muller
6e13128f45 OutlineButton doc fixes (#15092) 2018-03-02 17:43:22 -08:00
Yegor
905f9acf90 [tools] consolidate "preview Dart 2" option in BuildInfo (#15083)
* [tools] consolidate "preview Dart 2" option in BuildInfo

* format BuildInfo constructor
2018-03-02 15:45:55 -08:00
Yegor
973742fe96 [flutter_test] more docs, tests for within; simpler _sizeDistance (#15084)
Document missing value types supported by `within`. Add missing tests. Simplify _sizeDistance implementation.
2018-03-02 15:44:58 -08:00
Siva
beffcf1ba1 Fix incorrect generic type specification, causes a compilation error (#15049)
when a hot reload is done after modifying a component in the flutter
package.
2018-03-02 15:43:40 -08:00
Alexander Aprelev
65731f75bd Attempt to fix flutter drive --preview-dart-2 errors. (#14897) 2018-03-02 15:16:46 -08:00
Alexander Aprelev
673c5485ae Generate and use dep-file for --preview-dart-2 (#15077)
* Use depfile in --preview-dart-2 mode.

* Generate and use frontend_server.d to guard against reusing outdated dill files when frontend_server changes.
2018-03-02 11:33:13 -08:00
jcollins-g
bcdbed9628 Add upgrade locking for macs (#15038) 2018-03-02 09:52:14 -08:00
Alexander Aprelev
1a7eeb34da Roll engine to 97b22348c8d5cba471418dc94f9e384e384e796f. (#15069)
Changes since last roll:
  - Leave only widget creation tracker kernel pass in flutter frontend server. (#4727).
2018-03-02 09:51:48 -08:00
Hans Muller
c4e8438046 Added Material OutlineButton (#14939) 2018-03-02 08:26:23 -08:00
Alexander Aprelev
da24ad0b33 Roll engine to c88ba37c794f57982374bb53a694301198cad593 (#15053)
* Roll engine to c88ba37c794f57982374bb53a694301198cad593.

Changes since last roll:
  - move generated entry points JSON out of flutter_patched_sdk
  - List missing core lib bigint_patch.dart source for new Bigint implementation (#4735)
  - Skip over .emf-files. (#4739)
  - Roll dart to ee15c8eb689791f6777eb3f6b0a1e9c58ff0671b.

* defaultValue -> orElse
2018-03-02 06:23:59 -08:00
Chris Bracken
73a1a74ba1 Eliminate RenderView orientation, timeForRotation (#15044)
Orientation, and by extension time for rotation between orientations,
was aspirational and never used.

While this is technically a breaking change, this code never actually
did anything. If you were setting either orientation or timeForRotation,
simply delete those parameters and the code will continue to behave
identically to how it had been.
2018-03-01 18:34:15 -08:00
Greg Spencer
a1d2443e7b Fix render problem on Slider (#15039)
Fixes a small rendering problem when dragging the slider, as well as a couple of small bugs (de-duping of value changes, and actually using a parameter passed to _unlerp).
2018-03-01 16:25:21 -08:00
Chris Bracken
b90659cd30 Roll engine to 269bab73b6ad8f0e54fcd2b84f278ba857baf4af (#15036)
Includes:
* Add nil check for country code and language code (flutter/engine#4732)
2018-03-01 15:10:22 -08:00
jcollins-g
050ee9d180 Improve robustness of --version parsing for sdkmanager (#15029) 2018-03-01 14:25:03 -08:00
Greg Spencer
701eff4ac5 Slider Visual Update (#14901)
This implements an update to the look of the Slider widget.

Specifically, it does the following:

* Adds the ability to customize the colors of all components of the slider
* Adds the ability to customize the shape of the slider thumb and value indicator
* Adds the ability to show the value indicator on continuous sliders
* Updates the default value indicator to be a "paddle" shape with new animations.
* Changes the tick marks to be visible all the time on discrete sliders
* Fixes a memory leak of an animation controller.
* Removes "thumbOpenAtMin" flag, which is no longer needed, and can be emulated by the
custom thumb shape support. It was not widely used.
* Adds tests for all of the new features.
2018-03-01 13:03:20 -08:00
Todd Volkert
d2dcec22ce Provide a more helpful error message when we detect the user is tryin… (#15032)
Fixes https://github.com/flutter/flutter/issues/14950
2018-03-01 12:24:25 -08:00
Todd Volkert
621a963e8b Fix call to git checkout (#15026)
In the case of "dev", `git checkout dev` could be miconstrued
as checking out the dev _directory_ rather than the branch...

https://github.com/flutter/flutter/issues/14865
2018-03-01 09:28:15 -08:00
Danny Tuppeny
db1a942479 Show 32/64bit in VS Code headings on Windows (#15018)
* Show 32/64bit in VS Code headings on Windows

Fixes #14949.
2018-03-01 17:19:06 +00:00
Alexander Aprelev
d3797628ca Run flutter tests in preview-dart-2 mode on travis flutter builds. (#14728)
* Run flutter tests in preview-dart-2 mode on travis flutter builds.

* Run dart2 tests on osx. Run dart tests in dart2.

* Fix name camelCase

* Default options to empty array, rather than null

* Troubleshoot failures

* More logging

* Troubleshoot: run single test

* Troubleshoot: run 15 tests

* Troubleshoot: run 15 tests with fix

* Try limit concurrency to 1

* Limit concurrency for preview-dart-2 tests to 4

* Move dart2 tests to allow_failures section

* Reinstate tests_dart_2 shard

* Raise concurrency to 8

* Reuse compiler across multiple test runs

* Allow to switch entry points when recompiling.

Actually use single compiler to incrementally recompile all tests executed by 'flutter test'.

* Remove leftover commented code

* Fix comment

* Lints
2018-03-01 09:04:26 -08:00
Alexander Aprelev
e8d5667a0a Roll engine to a4b1fccdaa0b2ae8ecaad5f04ae70d2c2403b060. (#15024)
Changes since the last roll:
  - Specify sdkSummary when compiling via frontend server (#4733).
  - Fix traversal order for a11y scrolling (#4726)
2018-03-01 08:06:27 -08:00
Jacob Richman
7dbe9e7bcd Fix cases where previewDart2 and trackWidgetCreation were (#14994)
accidentally missed due to named parameters being omitted.
2018-03-01 07:19:21 -08:00
Chris Bracken
eaa9848fd4 Improve error message for missing 32-bit libstc++ (#15004)
Adds more actionable error messages for users of the most common Linux
distributions. We could improve this by checking the current
distribution and emitting only the appropriate error message. We could
further improve that by only emitting the install instructions if we
determine the appropriate package is not installed.

See: https://github.com/flutter/flutter/issues/6207
2018-02-28 17:53:38 -08:00
xster
a8e0f76873 Don't push again on beta branch commit (#15001) 2018-02-28 17:06:54 -08:00
Ian Hickson
b9a7f1b915 Add a hasListeners to ChangeNotifier (#14946)
I found that some ValueListeners want to know when they should start
doing work (e.g. if the value comes from polling a network resource).
2018-02-28 16:37:36 -08:00