In order for this to take effect, https://skia-review.googlesource.com/c/buildbot/+/167200
needs to be landed and deployed.
The /bin/internal/engine.merge_method file controls how we merge a pull
request created by the engine auto-roller. If it's squash, there's only one
commit for a pull request no matter how many engine commits there are inside
that pull request. If it's rebase, the number of commits in the framework is
equal to the number of engine commits in the pull request. The latter method is
easier to detect regressions but cost more test resources.
Should fix#22226.
Code introduced in #20890 caused a regression that broke color flooding animations in a BottomNavigationBar that has BottomNavigationBarType.shifting.
The original issue (#19653) dealt with background color changes not occurring until another tab was selected. The result is that the background color instantly changes whenever the state changes and when the widget changes, instead of allowing a new widget to animate the background color change.
When converting all of the samples to use the snippet tool, I encountered some bugs/shortcomings:
1. The document production took 90 minutes, since the snippet tool was being invoked from the command line each time. I fixed this by snapshotting the executable before running, so it's down to 7 minutes.
2. The sample code was not being properly escaped by the snippet tool, so generics were causing issues in the HTML output. It is now quoted.
3. Code examples that used languages other than Dart were not supported. Anything that highlight.js was compiled for dartdoc with is now supported.
4. The comment color for highlight.js was light grey on white, which was pretty unreadable. It's now dark green and bold.
dda667f8f Roll update to harfbuzz to 2.1.0 (#6760)
e8f0c08c9 Add instructions to download the full license log diff. (#6771)
5077e95f1 Roll src/third_party/skia f2b35e4fb8cc..2aa9a22fe159 (7 commits) (#6770)
5006ce574 fix type in embedded views preview flag name (flutter/engine#6767)
eec27fc8a Roll src/third_party/skia e70c6b13dd55..f2b35e4fb8cc (6 commits) (flutter/engine#6768)
aea7071e2 Roll src/third_party/skia e6c85755832b..e70c6b13dd55 (1 commits) (flutter/engine#6766)
1132d6c42 Roll src/third_party/skia 11407e56f277..e6c85755832b (2 commits) (flutter/engine#6765)
b5758d0d38...3374f4cce0
git log b5758d0d3848..3374f4cce045 --no-merges --oneline
3374f4cce Roll src/third_party/skia 8b35379ae1f1..32262da42bed (8 commits) (flutter/engine#6752)
61dbcdadf Roll src/third_party/skia e71e9ef311ba..8b35379ae1f1 (6 commits) (flutter/engine#6751)
c9b36fa11 Roll src/third_party/skia 51916083e752..e71e9ef311ba (1 commits) (flutter/engine#6750)
1a5a083de Roll src/third_party/skia 0a8b4e1acbd6..51916083e752 (2 commits) (flutter/engine#6749)
551d7f133 Roll src/third_party/skia 16d91aaf44fa..0a8b4e1acbd6 (1 commits) (flutter/engine#6748)
86feaccbf Roll src/third_party/skia 99485ace81ac..16d91aaf44fa (1 commits) (flutter/engine#6747)
4453e42ab Roll src/third_party/skia 2b21e88ed6dd..99485ace81ac (1 commits) (flutter/engine#6746)
fafef227a Roll src/third_party/skia 7e4081554d06..2b21e88ed6dd (1 commits) (flutter/engine#6745)
5d57e8af4 Roll src/third_party/skia b5ae3b5afc29..7e4081554d06 (1 commits) (flutter/engine#6744)
0e6b1e618 Roll src/third_party/skia e1b1d056fed9..b5ae3b5afc29 (3 commits) (flutter/engine#6743)
3429791c5 Roll src/third_party/skia f1ec3918534f..e1b1d056fed9 (1 commits) (flutter/engine#6742)
c5fa47a3c Roll src/third_party/skia 5d5de8bc79aa..f1ec3918534f (3 commits) (flutter/engine#6741)
be97304da Roll src/third_party/skia 1edff303fddb..5d5de8bc79aa (4 commits) (flutter/engine#6740)
731045e83 Roll freetype2 to a10b062df0c8958d69377aa04ea6554a9961a111 (flutter/engine#6738)
dd32b3fbc Roll src/third_party/skia 13245412d49e..1edff303fddb (6 commits) (flutter/engine#6739)
50ecdf965 Roll src/third_party/skia 3bfe9665aabc..13245412d49e (15 commits) (flutter/engine#6737)
96f7f344f Update scene_update_context to match recent PaintContext changes. (flutter/engine#6736)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well.
It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions.
I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error.
For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
This stops reading from pipe-to-file log after the build is completed. Attempting to read from pipe-to-file keeps open blocked because nobody is going to write into that pipe.
It's not usual for this not to be set, but it affected at least one user (#23909) and there are a non-zero number of people online saying it's not set. It's better that we don't crash.
Fixes#23909.
`RenderEditable.paint` assumes that if the length of the text fits within the
visible region, then the text will be rendered at the start of the region and be
completely visible. This is not always true, since the text may still be
rendered at an offset if an animation is ongoing when the text begins to fit.
This fixes#22288 and #14121
