Commit Graph

24470 Commits

Author SHA1 Message Date
Jonah Williams
e3ee5c6bbb Add better handling of JSON-RPC exception (#36082) 2019-07-13 16:02:09 -07:00
Ian Hickson
d919e694b8 Move tools tests into a general.shard directory in preparation to changing how we shard tools tests (#36108) 2019-07-13 11:51:44 -07:00
Hey24sheep
bec1b9a15c Optimize gesture recognizer instantiation (#35979) 2019-07-13 10:33:21 -07:00
Zachary Anderson
13382f41c0 [flutter_tool] Catch a yaml parse failure during project creation (#36105) 2019-07-12 23:24:04 -07:00
Ian Hickson
aa6cc07164 Be clearer about errors in customer testing script (#36098) 2019-07-12 17:10:13 -07:00
engine-flutter-autoroll
bade97c405 Roll engine d1dcd1848633..919e3532368f (3 commits) (#36099)
d1dcd18486...919e353236

git log d1dcd1848633c5764e23313823445cbcba451a59..919e3532368fa1924614272b8dc88874c603fcff --no-merges --oneline
919e35323 Only release the image data in the unit-test once Skia has accepted ownership of it. (flutter/engine#9816)
b42450f2b Document //flutter/shell/common/engine. (flutter/engine#9769)
f3edc41e6 Update buildroot to c4df4a7b to pull in MSVC 2017 Update 9 on Windows. (flutter/engine#9799)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-07-12 18:54:27 -04:00
Jonah Williams
9d31c2a0a7 dont require diffs to have a percentage coverage greater than the previous diff (#36090) 2019-07-12 15:10:41 -07:00
Jonah Williams
7056214151 Handle google3 version of pb (#36084) 2019-07-12 13:45:26 -07:00
Jonah Williams
0a97553e5e Revert "Merge branches 'master' and 'master' of github.com:flutter/flutter into timsneath-precache2" (#36096) 2019-07-12 13:42:32 -07:00
Kate Lovett
8809f698cb Revert "Part 1: Skia Gold Testing (#33688)" (#36094)
This reverts commit eb0b179028.
Skia Gold post-submit test were failing due to the service account not being found on Cirrus.
2019-07-12 13:35:36 -07:00
Tim Sneath
67ab890b60 Merge branches 'master' and 'master' of github.com:flutter/flutter into timsneath-precache2 2019-07-12 12:59:08 -07:00
Tim Sneath
7349970462 Update comments to match precache help 2019-07-12 12:59:01 -07:00
Tim Sneath
b322fdd518 Update precache help 2019-07-12 12:57:28 -07:00
Kate Lovett
eb0b179028 Part 1: Skia Gold Testing (#33688)
* Fresh PR for Gold integration.

* Nits

* WIP

* Artifacts from merge

* Changed some platform dependencies for web, added library prefix notation for Skia Gold test names.

* Updating for CI implementation

* Write out service account

* Writing to skip out

* WIP

* ++

* Fixing depot tools deps

* Windows depot_tools

* Fixing setup scripts

* ++

* depot tools

* ++

* WIP

* Tracing depot_tools clone

* WIP

* ++

* analyzer

* WIP

* chrome typo

* copy artifact

* Working on tests

* Code cleanup

* ++

* Code cleanup, updated tests

* ++ review feedback

* Review

* Analyzer

* Review feedback

* Nits from review

* PRogress

* ++

* Fixing tests

* ++

* Testing repo route

* Just needing documention around new structures.

* cleanup

* Analyzer

* Documentation updates

* Documentation updates

* Cirrus updates

* cirrus nit

* Review feedback

* Review feedback

* Fixing skip comparator

* Fix base directory for Skia Gold case

* ++

* Feedback

* ++

* Fixed uri assertion

* Made GoldensClient abstract, altered SkiaGoldClient constructor

* Analyzer
2019-07-12 12:23:04 -07:00
chunhtai
fc7bd6ad24 refactor out selection handlers (#35207) 2019-07-12 12:13:50 -07:00
Christopher Fujino
e91822da24 Revert "Bundle ios dependencies (#34669)" (#36071)
This reverts commit 14d489adc5.
2019-07-12 09:03:34 -07:00
Jonah Williams
7b150f81c5 move reload and restart handling into terminal (#35846) 2019-07-12 08:48:14 -07:00
Christopher Fujino
14d489adc5 Bundle ios dependencies (#34669)
This updates the flutter tool to cache binary files for ideviceinstaller, ios-deploy, libimobiledevice, and dynamically linked dependencies from Flutter's GCP bucket.
2019-07-12 08:36:18 -07:00
Anoop B
90326b6184 [ImgBot] Optimize images (#35971) 2019-07-11 21:16:48 -07:00
engine-flutter-autoroll
ab0f54e7bc d1dcd1848 Remove breaking asserts (flutter/engine#9797) (#36033)
55a2b81e40...d1dcd18486

git log 55a2b81e40bf91f73a8265b54b73a2d62197d024..d1dcd1848633c5764e23313823445cbcba451a59 --no-merges --oneline
d1dcd1848 Remove breaking asserts (flutter/engine#9797)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-07-11 23:01:27 -04:00
engine-flutter-autoroll
aa2de3eb4e Roll engine bcde838d778e..55a2b81e40bf (3 commits) (#36029)
bcde838d77...55a2b81e40

git log bcde838d778eecd39282cfb84ebba1d484bb7515..55a2b81e40bf91f73a8265b54b73a2d62197d024 --no-merges --oneline
55a2b81e4 Roll src/third_party/skia 7825d4983f90..c3f28e3cf0d4 (9 commits) (flutter/engine#9794)
84fd7eb06 Fix typo in PlaceholderAlignment docs (flutter/engine#9793)
4b11df89d Update flutter_web to latest (flutter/engine#9792)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-07-11 21:21:27 -04:00
engine-flutter-autoroll
028b4e5273 Roll engine 3b944102a56e..bcde838d778e (6 commits) (#36020)
3b944102a5...bcde838d77

git log 3b944102a56e8f4182e6601113fc36538edf3de9..bcde838d778eecd39282cfb84ebba1d484bb7515 --no-merges --oneline
bcde838d7 Roll Wuffs and buildroot (flutter/engine#9791)
3b75979d3 fix ColorFilter.matrix constness (flutter/engine#9789)
3c9a22c77 Fall back to a fully qualified path to libapp.so if the library can not be loaded by name (flutter/engine#9762)
298a610c7 Roll fuchsia/sdk/core/mac-amd64 from XOXaWqvr4OuJ6O3uPefSwSFjZMaEmDHy5JQm3Q8Oc0wC to CDbRdGJ3bu-aWMCZqN5VzfQqIBwDGL2wfFodWABKdCIC (flutter/engine#9790)
833f6b4fc Roll src/third_party/skia f9fcf7ffa89a..7825d4983f90 (6 commits) (flutter/engine#9788)
1250c3773 Add comments to differentiate two cache paths (flutter/engine#9721)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-07-11 19:55:27 -04:00
Jonah Williams
e91b98a41f Add initial implementation of flutter assemble (#32816) 2019-07-11 16:53:17 -07:00
Jonah Williams
fb9ff9296e fix linesplitter (#36006) 2019-07-11 16:52:14 -07:00
Ben Konyi
8d81c30a7c [WIP] Use public _registerService RPC 2019-07-11 16:01:07 -07:00
Dan Field
7a20148548 Add colorFilterLayer/Widget (#35468) 2019-07-11 15:49:51 -07:00
LongCatIsLooong
539f09f801 Remove _debugWillReattachChildren assertions from _TableElement (#34202) 2019-07-11 13:54:51 -07:00
engine-flutter-autoroll
b1a8637028 Roll engine 0f6229ab1d39..3b944102a56e (3 commits) (#36000)
0f6229ab1d...3b944102a5

git log 0f6229ab1d3915bac6967f08a8074d58ebfeb656..3b944102a56e8f4182e6601113fc36538edf3de9 --no-merges --oneline
3b944102a Un-deprecated FlutterViewController's binaryMessenger. (flutter/engine#9767)
7e65b81cc Roll src/third_party/dart 09fc76bc51..24725a8559 (43 commits)
a03e74743 Add hooks for InputConnection lock and unlocking (flutter/engine#9727)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-07-11 16:37:27 -04:00
Dan Field
735352a8c0 Deflake ImageProvider.evict test (#35999) 2019-07-11 13:09:30 -07:00
Matt Carroll
7ea7f1c62b Upgraded framework packages with 'flutter update-packages --force-upgrade'. (#35932) 2019-07-11 12:04:10 -07:00
engine-flutter-autoroll
d7f01757f8 Roll engine 49445ce4949b..0f6229ab1d39 (6 commits) (#35990)
49445ce494...0f6229ab1d

git log 49445ce4949bf0d28506a6b22e28b4264f624e5f..0f6229ab1d3915bac6967f08a8074d58ebfeb656 --no-merges --oneline
0f6229ab1 Roll fuchsia/sdk/core/mac-amd64 from lKQ0yBPnk1oXLyNM7XhqSDl5llP6Cx2GWkQjS0ExozcC to XOXaWqvr4OuJ6O3uPefSwSFjZMaEmDHy5JQm3Q8Oc0wC (flutter/engine#9786)
e40149eaf Roll src/third_party/skia af4e7b6cf616..f9fcf7ffa89a (33 commits) (flutter/engine#9784)
009b1d5a9 Roll fuchsia/sdk/core/mac-amd64 from 1F71B9KuZAVZz0LDQW_g0bbfWsxEgQkDpHPKrkc97xYC to lKQ0yBPnk1oXLyNM7XhqSDl5llP6Cx2GWkQjS0ExozcC (flutter/engine#9779)
fbe50c6a6 Roll fuchsia/sdk/core/mac-amd64 from bYFmlYp6Mc82r7dw58IaEny3_mnq-yZW06Ccr19j0lIC to 1F71B9KuZAVZz0LDQW_g0bbfWsxEgQkDpHPKrkc97xYC (flutter/engine#9778)
51c3c11b8 fix objcdoc generation (flutter/engine#9772)
f076a60c9 Roll fuchsia/sdk/core/mac-amd64 from EYnRdXFT9l-d8Qkz4zeTRXnqfV3KQzpQhoPs1r0-740C to bYFmlYp6Mc82r7dw58IaEny3_mnq-yZW06Ccr19j0lIC (flutter/engine#9771)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-07-11 14:29:27 -04:00
Jonah Williams
ae8ff41abf Revert "Keep LLDB connection to iOS device alive while running from CLI. (#35731)" (#35996)
This reverts commit d200dc150b.
2019-07-11 10:44:41 -07:00
sjindel-google
d200dc150b Keep LLDB connection to iOS device alive while running from CLI. (#35731) 2019-07-11 18:56:48 +02:00
Greg Spencer
e8fbdd85f0 Add example showing how to move from one field to the next. (#35926)
This adds an example of how to move to the "next" field when using TextInputAction.next. This is all that is needed to have "next field" functionality in a field. I thought about making it the default when handling the "next" or "previous" actions, but it's better that the developer has control over whether or not they actually move to the next field, and within which scope.
2019-07-11 07:56:30 -07:00
engine-flutter-autoroll
b69feb5340 Roll engine 75387dbc147d..49445ce4949b (32 commits) (#35952)
75387dbc14...49445ce494

git log 75387dbc147d1cee8164f5d61582eab8ba1e5058..49445ce4949bf0d28506a6b22e28b4264f624e5f --no-merges --oneline
49445ce49 FLEViewController/Engine API changes (flutter/engine#9750)
2a79462fd Add Fuchsia build CI presubmit steps (flutter/engine#9736)
67cebdb92 Roll fuchsia/sdk/core/linux-amd64 from KGmm_RIJoXS19zTm2crjM3RYpmp5Y03-fLUeVdylbTYC to ehWVT9QJbC-vFMM6SkkQM9HJ9oITFCws7FC9JnrFq2gC (flutter/engine#9765)
089c74084 Roll fuchsia/sdk/core/mac-amd64 from lCQWEeR_Ert7t_qAbMRycwrRyZC-dIprYPyPJzwPmg4C to EYnRdXFT9l-d8Qkz4zeTRXnqfV3KQzpQhoPs1r0-740C (flutter/engine#9759)
b22410ef6 Include SkParagraph headers only when the enable-skshaper flag is on (flutter/engine#9758)
2cd650d26 Minimal integration with the Skia text shaper module (flutter/engine#9556)
f775f5e4d Re-enable the Wuffs GIF decoder (flutter/engine#9466)
aca048236 Make all shell unit tests use the OpenGL rasterizer. (flutter/engine#9746)
bc57291ff Make FLEViewController's view an internal detail (flutter/engine#9741)
9776043ea Synchronize main thread and gpu thread for first render frame (flutter/engine#9506)
f600ae830 Use libc++ variant of string view and remove the FML variant. (flutter/engine#9737)
564f53f0a Revert "Improve caching limits for Skia (#9503)" (flutter/engine#9740)
b453d3c3d libtxt: fix reference counting of SkFontStyleSets held by font asset providers (flutter/engine#9561)
fa7627d17 Fix backspace crash on Chinese devices (flutter/engine#9734)
56885f79b Let pushColorFilter accept all types of ColorFilters (flutter/engine#9641)
6dccb21e6 Roll src/third_party/skia 96fdfe0fe88e..af4e7b6cf616 (1 commits) (flutter/engine#9735)
8511d9b47 Roll fuchsia/sdk/core/mac-amd64 from byM-kyxL4bemlTYNqhKUfJfZoIUrCSzS6XzsFr4n9-MC to lCQWEeR_Ert7t_qAbMRycwrRyZC-dIprYPyPJzwPmg4C (flutter/engine#9742)
b3bf0a182 Roll fuchsia/sdk/core/linux-amd64 from I2Qe1zxgckzIzMBTztvzeWYsDgcb9Fw-idSI16oIlx8C to KGmm_RIJoXS19zTm2crjM3RYpmp5Y03-fLUeVdylbTYC (flutter/engine#9743)
7e568232a Fix windows test by not attempting to open a directory as a file. (flutter/engine#9745)
6cf0d1350 Roll src/third_party/skia a3ffaabcc4f2..96fdfe0fe88e (5 commits) (flutter/engine#9731)
49a00aed8 Fix Fuchsia build. (flutter/engine#9730)
b3bb39b0b Roll src/third_party/dart 06c3d7ad3a...09fc76bc51 (flutter/engine#9728)
2284210f4 Make the license script compatible with recently changed Dart I/O stream APIs (flutter/engine#9725)
ad582b508 Rework image & texture management to use concurrent message queues. (flutter/engine#9486)
1dcd5f52b Roll src/third_party/skia 6b82cf638682..a3ffaabcc4f2 (24 commits) (flutter/engine#9726)
129979cab Revert "Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits)" (flutter/engine#9724)
8020d7e43 Roll src/third_party/skia 56065d9b875f..6b82cf638682 (3 commits) (flutter/engine#9718)
e24bd7846 Roll src/third_party/dart 06c3d7ad3a..7acecda2cc (12 commits)
3d2668c35 Reland isolate group changes
802bd1518 iOS platform view opacity (flutter/engine#9667)
3b6265b74 Roll src/third_party/dart b5aeaa6796..06c3d7ad3a (44 commits)
887e05233 Refactor ColorFilter to have a native wrapper (flutter/engine#9668)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.
2019-07-11 01:56:27 -04:00
Jenn Magder
0a39d8d92e Use test instead of test_api package in platform_channel_swift example tests (#35942) 2019-07-10 19:17:14 -07:00
Greg Spencer
3b945da00d Change focus example to be more canonical (and correct), listening to the focus node for changes. (#35913)
This changes the example for FocusNode to be more correct, listening to the focus node for changes, instead of assuming that it is the only one doing the changing.
2019-07-10 16:49:32 -07:00
Greg Spencer
67ee3e191e Add anchors to samples (#35906)
This adds an "anchor button" to each of the samples so that the user can link to individual samples instead of having to link to just the page. Clicking on the anchor button jumps to the anchor, as well as copying the anchor URL to the clipboard.

There is some oddness in the implementation: because dartdoc uses a <base> tag, the href for the link can't just be "#id", it has to calculate the URL from the current window href. I do that in the onmouseenter and onclick because onload doesn't get triggered for <a> tags (and onmouseenter doesn't get triggered for mobile platforms), but I still want the href to be updated before someone right-clicks it to copy the URL.
2019-07-10 16:48:20 -07:00
Jenn Magder
b5c1b61c73 Add platform_interaction_test_swift to devicelab (#35775) 2019-07-10 14:13:01 -07:00
Justin McCandless
ff53fbe194 Text selection menu show/hide cases (#35219)
Show and hide the text selection menu at the correct time with various gestures in the text field.
2019-07-10 14:08:14 -07:00
Tom Robinson
ef42c36ab0 Cleanup widgets/sliver_persistent_header.dart with resolution of dart-lang/sdk#31543 (#35828)
* Remove extra classes.

Now that https://github.com/dart-lang/sdk/issues/31543 is fixed, we
can remove extra classes.

* Add snapConfiguration to parameters for _RenderSliverFloatingPersistentHeaderForWidgets and _RenderSliverFloatingPinnedPersistentHeaderForWidgets constructors.
2019-07-10 13:54:27 -07:00
gaaclarke
3122786ad5 Fixed build of example code to use new binary messenger API. (#35825)
Fixed build of example code to use new binary messenger API.
2019-07-10 13:10:05 -07:00
rami-a
70bb5d1d5a Add flag to use root navigator for showModalBottomSheet (#35878)
* Add flag to use root navigator for showModalBottomSheet

* Add documentation

* Add tests

* Address feedback and fix analyzer issues

* Address feedback

* Update comments
2019-07-10 16:07:15 -04:00
Kate Lovett
14e4565fa4 Doc fixes (#35892)
* Fixed assets embedding

* ++

* Completed snippet audit

* Analyzer
2019-07-10 12:40:35 -07:00
Ian Hickson
176ebfd53e flutter/tests support (#33140)
This introduces a script that implements the conventions described in https://github.com/flutter/tests/pull/1.
2019-07-10 12:10:28 -07:00
Jenn Magder
ec2c3f2116 Disable CocoaPods input and output paths in Xcode build phase for ephemeral add2app (#35833) 2019-07-10 10:40:15 -07:00
Shi-Hao Hong
e7ef75680e Update Dark Theme disabledColor to White38 (#35136)
* Add Colors.white38

* Update ThemeData.disabledColor and ButtonThemeData.disabledColor to Colors.white38

* Update pre-existing tests to expect Colors.white38 instead of Colors.white30

* Update API documentation to reflect these changes
2019-07-10 08:50:24 -07:00
Jonah Williams
2b20345bb8 use pub run for create test and remove [INFO] logs (#35839) 2019-07-10 08:48:01 -07:00
Greg Spencer
e3a08d2392 Remove reverseDuration from implicitly animated widgets, since it's ignored. (#35785)
When I added reverseDuration to animation controllers in #32730, I also added it to the implicit animations that Flutter has. However, as @efortuna pointed out to me, it doesn't actually do anything there, since all of the intrinsic animations run forwards, not in the reverse direction, and there's no way to reverse them.

So, this PR removes the reverseDuration argument from the implicit animations to avoid confusion.

Fixes #35769
2019-07-10 08:18:26 -07:00
Jenn Magder
2ad5376a06 Build all example projects in CI build smoke test (#35778) 2019-07-09 16:00:33 -07:00