Commit Graph

24470 Commits

Author SHA1 Message Date
Ian Hickson
97495d8938 Simplify logging code in flutter_driver (#45945)
* Simplify logging code in flutter_driver

It appears nobody is benefitting from this logic, so we may as well not pay the cost.

* Make all of the driver interface public.

This is the second attempt at this; it should be better than before because the Logger interface, which conflicted in various places, no longer exists.

See #45733 for original attempt.

This reverts commit 0ce9206ef4 (PR #45924).
2019-12-03 17:14:43 -08:00
Ian Hickson
2991dc28a5 Update PULL_REQUEST_TEMPLATE.md (#45944)
Update for recent changes to policies.
2019-12-03 14:19:29 -08:00
Dan Field
b61dec79c7 Start fixing docs (#45977) 2019-12-03 13:59:19 -08:00
Jonah Williams
b96d818c19 Remove record/replay/bug report functionality from the tool (#45999) 2019-12-03 13:24:45 -08:00
engine-flutter-autoroll
a484db665a 1a9608774 Update to newer path fill-type API in Skia (flutter/engine#14070) (#46002)
git@github.com:flutter/engine.git/compare/faa11214c09b...1a96087747ac

git log faa11214c09b..1a96087747ac --first-parent --oneline
2019-12-03 brianosman@google.com Update to newer path fill-type API in Skia (#14070)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-03 15:17:09 -05:00
Sahand Akbarzadeh
f68cdacdd5 Add clip behaviour to Container (#44971) 2019-12-03 10:13:01 -08:00
Jonah Williams
c95dafc4c6 Add printTrace when vscode package.json parsing fails (#45998) 2019-12-03 09:56:04 -08:00
Jonah Williams
0dace48932 Add comments to package scheme fix (#45997) 2019-12-03 09:55:50 -08:00
Jonah Williams
0b2bf99491 Reland: Update macOS configuration settings (#45966) 2019-12-03 08:13:08 -08:00
engine-flutter-autoroll
8e92ba07ce Roll engine 8672e79af873..faa11214c09b (7 commits) (#45986)
git@github.com:flutter/engine.git/compare/8672e79af873...faa11214c09b

git log 8672e79af873..faa11214c09b --first-parent --oneline
2019-12-03 liyuqian@google.com Run benchmarks in Cirrus (#13950)
2019-12-03 stuartmorgan@google.com Report backing store changes in the macOS view (#13933)
2019-12-03 franciscojma@google.com Listen to keyUp event on meta modified keys (#13984)
2019-12-02 dnfield@google.com Fix live region logic (#14081)
2019-12-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia e8c96d8e6116..2792515dab7c (1 commits) (#14069)
2019-12-02 bkonyi@google.com Roll src/third_party/dart 3f32196958..e4344a568f (1 commits) (#14073)
2019-12-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from aVdHP... to 6QxEZ... (#14080)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-03 10:01:09 -05:00
engine-flutter-autoroll
7ea0d4d8e3 Roll engine 6c605f8a9624..8672e79af873 (2 commits) (#45918)
git@github.com:flutter/engine.git/compare/6c605f8a9624...8672e79af873

git log 6c605f8a9624..8672e79af873 --first-parent --oneline
2019-11-28 skia-flutter-autoroll@skia.org Roll src/third_party/skia c96f5108df28..73beaaa48fcc (2 commits) (#14065)
2019-11-28 hterkelsen@users.noreply.github.com Fallback to Roboto if no suitable font is found (#14061)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-12-03 09:14:04 -05:00
Alexandre Ardhuin
1ae5d676e5 implicit-casts:false in flutter/lib/src/scheduler (#45721) 2019-12-03 09:32:03 +01:00
XinLei
9d574d2c22 Remove canTransitionFrom override from Material/CupertinoPageRoute (#45750) 2019-12-02 23:23:53 -08:00
Jonah Williams
8a9897c84c Revert "update macOS configuration settings (#45920)" (#45965)
This reverts commit 3b2042a028.
2019-12-02 21:34:41 -08:00
Jonah Williams
9708e7d16a use package-scheme imports for generated web entrypoint (#45934) 2019-12-02 21:10:08 -08:00
Jonah Williams
3b2042a028 update macOS configuration settings (#45920) 2019-12-02 21:06:38 -08:00
godofredoc
4c4cdbfc2b Move dartdocs to devicelab vm. (#45952)
We added support linux VMs to devicelab and we will be moving some of
the machine independent benchmarks there.
2019-12-02 19:45:04 -08:00
Dan Field
c0283d85f5 Deprecate UpdateLiveRegionEvent (#45940) 2019-12-02 19:08:01 -08:00
Jonah Williams
df0b3fed7b fix lint applied after PR was opened (#45953) 2019-12-02 17:31:11 -08:00
Greg Spencer
37f86c3195 Clean up some things I noticed while doing another change (#45658)
This fixes some minor things I noticed while doing another change.

- Uncomments an old test that wants to be run, but can't be, and marked it as "skipped", so that the code won't rot anymore.
- Added the focus state to the short string version of a FocusNode
- Added a missing piece of information to findAncestorWidgetOfExactType
2019-12-02 17:10:09 -08:00
Kate Lovett
2a5e528a18 Fixing SliverOverlapAbsorber & SliverOverlapInjector child property (#44283) 2019-12-02 17:08:02 -08:00
Jonah Williams
b63683b6cd Update configuration for flutter features (#45914) 2019-12-02 17:06:41 -08:00
Jonah Williams
8cf20f3be7 Dont crash on malformed packages.json (#45786) 2019-12-02 17:04:37 -08:00
Kate Lovett
0ce9206ef4 Revert "Make all of the driver interface public. (#45733)" (#45924)
This reverts commit f2445002b2.
2019-12-02 17:02:59 -08:00
Kate Lovett
cd052a56cb Revert "Re-land "Add option to delay rendering the first frame (#45135)" (#45588)" (#45939)
This reverts commit c59151b1cd.
2019-12-02 15:08:35 -08:00
Emmanuel Garcia
8c25328014 Handle case where lastLogcatTimestamp is null (#45937) 2019-12-02 15:02:11 -08:00
Michael Goderbauer
c59151b1cd Re-land "Add option to delay rendering the first frame (#45135)" (#45588) 2019-12-02 13:33:45 -08:00
Dan Field
088fa24463 Set the LANG when invoking cocoapods (#45710) 2019-12-02 13:26:32 -08:00
Tong Mu
afb8f38211 Improve MouseTracker lifecycle: Move checks to post-frame (#44631)
This PR rewrites MouseTracker's lifecycle, so that mouse callbacks are all triggered in post frame, instead of the current one where some are triggered during the build phase. This PR also changes the onExit callback to MouseRegion, RenderMouseRegion, and MouseTrackerAnnotation, so that it is no longer triggered on dispose.
2019-12-02 13:00:48 -08:00
Michael Goderbauer
8954ee85dd Add Sliver video to RenderSliver (#45708) 2019-12-02 12:58:04 -08:00
Kaushik Iska
3994872073 Sample driver test working on Fuchsia (#45652)
* [flutter_driver] [fuchsia] Validate existance of cmx for driver tests

Also added an example driver test that can run on Fuchsia devices.

Fixes: https://github.com/flutter/flutter/issues/45624

* update packages for stock example

* fix licenses
2019-12-02 12:56:16 -08:00
Zachary Anderson
02bca1342d Revert "Roll engine 6c605f8a9624..8672e79af873 (2 commits) (#45817)" (#45916)
This reverts commit b9a56b9f48.
2019-12-02 11:13:19 -08:00
engine-flutter-autoroll
b9a56b9f48 Roll engine 6c605f8a9624..8672e79af873 (2 commits) (#45817)
* 8d6fa7e85 Fallback to Roboto if no suitable font is found (flutter/engine#14061)

* 8672e79af Roll src/third_party/skia c96f5108df28..73beaaa48fcc (2 commits) (flutter/engine#14065)
2019-11-29 20:40:44 -05:00
engine-flutter-autoroll
1e50db60ad Roll engine 4bdd15cd5438..6c605f8a9624 (3 commits) (#45746)
* a86ef9465 Dynamically determine whether to use offscreen surface based on need (flutter/engine#13976)

* 0fc7867ae Roll src/third_party/dart 96e7a4ff30..73fdf19b56 (3 commits) (flutter/engine#14063)

* 6c605f8a9 Fix fml_unittests (flutter/engine#14062)
2019-11-29 09:17:52 -05:00
Gary Qian
d345a3b303 Revert "Track and use fallback TextAffinity for null affinity platform TextSelections. (#44622)" (#45698)
This reverts commit 6b66d79436.
2019-11-28 19:42:06 +09:00
engine-flutter-autoroll
714650d7e4 Roll engine 35937eb31240..4bdd15cd5438 (5 commits) (#45741)
* 29b2e91f1 Include uncommitted files when checking for code format issues. (flutter/engine#14035)

* 7a7118d0a Roll src/third_party/skia 861ac61cb1a9..c96f5108df28 (10 commits) (flutter/engine#14059)

* bc07e6a23 [web] Initial support for LineMetrics (flutter/engine#13985)

* bcb826759 Revert "Do not default to downstream affinity on iOS insertText (#13852)" (flutter/engine#14053)

* 4bdd15cd5 more tests for enabling semantics (flutter/engine#14060)
2019-11-27 20:54:32 -05:00
Emmanuel Garcia
475ee89879 Make Android log reader read any recent logs (#45743) 2019-11-27 17:52:36 -08:00
Jenn Magder
e2642fd6c0 Do not delete output directory during flutter build ios-framework (#45740) 2019-11-27 17:48:19 -08:00
Ian Hickson
f2445002b2 Make all of the driver interface public. (#45733)
We keep finding things that we've accidentally not made public. The
pattern we use elsewhere in the platform is to just export everything,
to avoid encouraging people from importing `src/` files directly.
2019-11-27 16:26:05 -08:00
Ian Hickson
a78fb87dfe Relicense Shrine demo to match rest of repository (#45718)
* Relicense Shrine demo to match rest of repository

The Shrine demo was Apache-licensed. The code was mostly
Google-written, with contributions from:

 - Michelle Dudley (@michdud)

 - Abhijeeth Padarthi <rkinabhi@gmail.com> (@rkinabhi)

 - @a14n

I contacted all three, and they confirmed their approval for this
change, as described below.

Abhijeeth Padarthi said by e-mail on Thu, Nov 21, 2019 at 5:48 PM:

> hi Ian,
>
> sure :)
>
> let me know if I need to do anything on my end..

Michelle Dudley wrote by e-mail on Sun, Nov 24, 2019 at 2:07 PM:

> Hi Ian,
>
> That would be ok with me.
>
> Thanks,
>
> Michelle

@a14n said on Discord's Flutter server in the #hackers channel at 10:44PM on Thursday, November 21, 2019:

> @Hixie no problem I agree with this relicensing

* Remove shrine loophole from license checker.
2019-11-27 16:25:56 -08:00
engine-flutter-autoroll
3cacad5b5e Roll engine fad1b23c42b9..35937eb31240 (3 commits) (#45725)
* f61bec846 Pass "null" when copy data is null to iOS pasteboard.string (flutter/engine#14046)

* 268107d2f fixing the method call for testing semantics (flutter/engine#14056)

* 35937eb31 Roll src/third_party/dart 134e0e28cd..96e7a4ff30 (38 commits) (flutter/engine#14058)
2019-11-27 19:12:20 -05:00
Ian Hickson
449f4a6673 License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Chris Bracken
dc49fa2140 Eliminate commented-out code (#45726)
This appears to have been inadvertently added in #37497 (333c961).

The code in question already exists in `_PlatformViewGestureMixin`, which
`PlatformViewRenderBox` (where it was added) mixes in.
2019-11-27 14:50:15 -08:00
Ian Hickson
f87c5102af Add more documentation around layers. (#45648) 2019-11-27 14:22:48 -08:00
Jonah Williams
59ca523b2c Support web-server/profile/release mode with incremental compiler support for web (#45713) 2019-11-27 13:32:45 -08:00
Jonah Williams
598f2ab0fb Cleanups to resident runner and flutter device classes (#45673) 2019-11-27 13:11:04 -08:00
Chris Bracken
b39949ff09 Fix parameter name: handlePointerEvent (#45717)
Removes an unnecessary leading underscore from a parameter name. The
parameter type is library private, but parameters cannot be 'private'.
2019-11-27 12:48:43 -08:00
liyuqian
264082f34f Print clipBehavior while debugging ClipXXXLayer (#45716)
Fixes https://github.com/flutter/flutter/issues/45587
2019-11-27 12:48:03 -08:00
Alexandre Ardhuin
5ccd4f3430 implicit-casts:false in flutter/lib/src/physics (#45622) 2019-11-27 21:28:45 +01:00
LongCatIsLooong
37f9c54116 Use RenderSliverPadding to inset SliverFillViewport (#45432) 2019-11-27 11:33:38 -08:00