firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
32,265 Commits 1 Branch 0 Tags
ae5444ffdadce6d07f9f83de58e10a2e99012eae
Commit Graph

24476 Commits

Author SHA1 Message Date
skia-flutter-autoroll
ae5444ffda Roll Fuchsia Linux SDK from uW96BsI9g7PF2on-4... to 7Cq6zmNZ_1UTJoQUE... (flutter/engine#47245) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-24 04:26:06 +00:00
skia-flutter-autoroll
1b2d90d25f Roll Skia from fd557c42e44c to 6711d27055e8 (1 revision) (flutter/engine#47244) 
https://skia.googlesource.com/skia.git/+log/fd557c42e44c..6711d27055e8

2023-10-24 michaelludwig@google.com [graphite] Write depth*w for text and cover bounds VS functions

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-24 01:35:33 +00:00
Tong Mu
87171e7339 Reland 2: Multiview Pipeline (flutter/engine#47239) 
The last attempt https://github.com/flutter/engine/pull/47234 was reverted because there was another test merged in the meantime that violates the rule added in this PR.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-23 23:46:25 +00:00
skia-flutter-autoroll
cb37a61dae Roll Skia from fcad7b2b0027 to fd557c42e44c (2 revisions) (flutter/engine#47238) 
https://skia.googlesource.com/skia.git/+log/fcad7b2b0027..fd557c42e44c

2023-10-23 johnstiles@google.com Simplify compile-time negation logic.
2023-10-23 johnstiles@google.com Implement compile-time simplification of bitwise-not.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 23:34:32 +00:00
skia-flutter-autoroll
a89e5779c3 Roll Skia from 73e9879f06e7 to fcad7b2b0027 (1 revision) (flutter/engine#47236) 
https://skia.googlesource.com/skia.git/+log/73e9879f06e7..fcad7b2b0027

2023-10-23 lovisolo@google.com [bazel] Fix //src/base:base under Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 22:49:06 +00:00
Zachary Anderson
d549483298 Revert "Reland: Multiview pipeline " (flutter/engine#47237) 
Reverts flutter/engine#47234

Failures like
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/186568/overview
making the tree red.
 2023-10-23 15:17:36 -07:00
skia-flutter-autoroll
1046338386 Roll Dart SDK from 53fee35b299f to 901e92d10627 (5 revisions) (flutter/engine#47235) 
https://dart.googlesource.com/sdk.git/+log/53fee35b299f..901e92d10627

2023-10-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-53.0.dev
2023-10-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-52.0.dev
2023-10-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-51.0.dev
2023-10-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-50.0.dev
2023-10-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-49.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 21:38:38 +00:00
Tong Mu
9ed503a734 Reland: Multiview pipeline (flutter/engine#47234) 
This PR relands https://github.com/flutter/engine/pull/44473.

The previous PR was immediately reverted after merging because we found that the PR could cause illegal renders to be skipped on debug builds but crash the app on release builds. This PR makes the `Animator::Render` skip illegal renders as well. This should not be the final shape of this feature, and thus a TODO is added.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-23 21:35:04 +00:00
gaaclarke
7068f3757d [Impeller] Added tests to assert empty saveLayer behaviors. (flutter/engine#47138) 
fixes: https://github.com/flutter/flutter/issues/126391

It turns out certain cases listed in the issue already render correctly.
This adds tests to assert that we maintain that behavior.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-23 14:13:45 -07:00
Chinmay Garde
eb3e4ac1c5 Add missing headers to the fml source_set. (flutter/engine#47232) 
These being missing came up when internal build rules were being derived from the ones here.
 2023-10-23 20:45:23 +00:00
Jonah Williams
3493faeaf4 [Impeller] Vk query cleanups. (flutter/engine#47208) 
Use RAII to more accurately capture cmd buffer start/end, with additional protections for early frame ending. This also allows us to capture the execution time of the final cmd buffer, which should fix https://github.com/flutter/flutter/issues/136971
 2023-10-23 20:29:52 +00:00
skia-flutter-autoroll
3d74c28628 Roll Skia from 8a0324990bf5 to 4976279e4441 (1 revision) (flutter/engine#47230) 
https://skia.googlesource.com/skia.git/+log/8a0324990bf5..4976279e4441

2023-10-23 jvanverth@google.com Add some checks in GrDrawOpAtlas.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 19:47:35 +00:00
Nate Bosch
fbb4b6abd9 Update to the latest package:test (flutter/engine#46592) 
- Update the pinned version of `test` to the latest published.
- Add support for reading the `source.location` of messages to the JS
  interop library.
- Update `host.dart` to support the new communication pattern with the
  test frame. See https://github.com/dart-lang/test/issues/2065
- Use `Runtime.edge` for the edge browser. We may deprecate or remove
  the constant. Edge is a more appropriate value for this usage.
 2023-10-23 19:08:10 +00:00
skia-flutter-autoroll
83084cf3f2 Roll Skia from d27ff651a99b to 8a0324990bf5 (1 revision) (flutter/engine#47229) 
https://skia.googlesource.com/skia.git/+log/d27ff651a99b..8a0324990bf5

2023-10-23 nscobie@google.com 2nd SkCodecPrintf compilation fix for SkTiffUtility.cpp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 19:04:16 +00:00
Jonah Williams
fd07a6783b [Impeller] remove image upload workarounds. (flutter/engine#47209) 
Testing locally I cant see any impact from this. Its possible the problem this "fixed" was instead fixed by affinity changes and now its no longer necessary.

See https://github.com/flutter/engine/pull/43493 .
 2023-10-23 18:53:56 +00:00
Jonah Williams
063c7f54f4 [Impeller] Disable raster stats service protocol. (flutter/engine#47206) 
As far as I can tell, this functionality has _always_ been falling back to software rendering with Skia when Impeller was enabled. This is at best extremely misleading. Since I started putting Impeller specific objects in the display list it introduced crashes, and must be disabled.

Fixes https://github.com/flutter/flutter/issues/136847
 2023-10-23 18:45:18 +00:00
skia-flutter-autoroll
06c9608c35 Roll Skia from 49fa29c8b153 to d27ff651a99b (1 revision) (flutter/engine#47227) 
https://skia.googlesource.com/skia.git/+log/49fa29c8b153..d27ff651a99b

2023-10-23 nscobie@google.com Fix SkCodecPrintf compilation failure in SkTiffUtility.cpp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 17:47:57 +00:00
skia-flutter-autoroll
9de0432614 Roll Skia from acbc278f7600 to 49fa29c8b153 (1 revision) (flutter/engine#47226) 
https://skia.googlesource.com/skia.git/+log/acbc278f7600..49fa29c8b153

2023-10-23 johnstiles@google.com Simplify lighting filter slightly.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 17:03:12 +00:00
skia-flutter-autoroll
f97059638a Roll Skia from 47c408712efd to acbc278f7600 (3 revisions) (flutter/engine#47223) 
https://skia.googlesource.com/skia.git/+log/47c408712efd..acbc278f7600

2023-10-23 johnstiles@google.com Fix fuzzer-discovered assertion with WGSL interface-block out arrays.
2023-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d01276172017 to 0118db714186 (2 revisions)
2023-10-23 jvanverth@google.com [graphite] Don't store inversion state in RasterPathAtlas key.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 16:03:36 +00:00
skia-flutter-autoroll
3785908d82 Roll Skia from 90658830b8ce to 47c408712efd (1 revision) (flutter/engine#47221) 
https://skia.googlesource.com/skia.git/+log/90658830b8ce..47c408712efd

2023-10-23 johnstiles@google.com Fix fuzzer-discovered assertion with atomic arrays.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 15:14:59 +00:00
skia-flutter-autoroll
41efbaeb1b Roll Skia from bce627e38d25 to 90658830b8ce (3 revisions) (flutter/engine#47220) 
https://skia.googlesource.com/skia.git/+log/bce627e38d25..90658830b8ce

2023-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 4ebfec0b5f53 to d01276172017 (7 revisions)
2023-10-23 ccameron@chromium.org SkCodec: Consolidate Tiff parsing functions
2023-10-23 egdaniel@google.com Reland "When waiting on client provided semaphores, only block fragment stage work."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 14:29:39 +00:00
skia-flutter-autoroll
1491dfc214 Roll Skia from a0515f94dfee to 3f7302e44c94 (3 revisions) (flutter/engine#47214) 
https://skia.googlesource.com/skia.git/+log/a0515f94dfee..3f7302e44c94

2023-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 7923feb1aa82 to 1d90f548f72f
2023-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 68aac47724f2 to e7c82ebc0260 (15 revisions)
2023-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from acdd164d51ed to 7923feb1aa82 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-23 06:10:00 +00:00
skia-flutter-autoroll
99d3c2488f Roll Fuchsia Linux SDK from 00DU5P-zlAl6661kG... to V4q-PLgyTbkCdf8Zo... (flutter/engine#47202) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-22 14:16:11 +00:00
skia-flutter-autoroll
15a28705f7 Roll Fuchsia Linux SDK from 2vdBWAlJ_jVZXn8sK... to 00DU5P-zlAl6661kG... (flutter/engine#47198) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-22 01:30:41 +00:00
skia-flutter-autoroll
c5f6bb1de3 Roll Fuchsia Linux SDK from vlmJ760j9c7Ng4Psy... to 2vdBWAlJ_jVZXn8sK... (flutter/engine#47196) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-21 12:40:04 +00:00
Jonah Williams
afe55da595 [Impeller] Fix cmd pool reset from background thread. (flutter/engine#47184) 
Make sure to clear the buffers before assigning to the recycler, as the dtor was racing with the raster thread usage.
 2023-10-21 00:19:24 +00:00
skia-flutter-autoroll
a6be8601ec Roll Fuchsia Linux SDK from tcVA-iW-vOHPnwh_P... to vlmJ760j9c7Ng4Psy... (flutter/engine#47181) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 23:52:35 +00:00
gaaclarke
2cb41967e7 [Impeller] increased padding for blurs (flutter/engine#47176) 
fixes https://github.com/flutter/flutter/issues/119974

This duplicates the math found in skia at
https://skia.googlesource.com/skia/+/cf2131f85d57f938472e50b6643c3c2348709a55/gm/blurrect.cpp#484

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-20 16:40:06 -07:00
skia-flutter-autoroll
9d7b5e8bb9 Roll Skia from ca69b04f7dd2 to cf2131f85d57 (2 revisions) (flutter/engine#47173) 
https://skia.googlesource.com/skia.git/+log/ca69b04f7dd2..cf2131f85d57

2023-10-20 nicolettep@google.com [graphite] Add transfer dst buffer usage flag for gpu-only buffers
2023-10-20 jvanverth@google.com [graphite] Don't try to draw empty paths.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 21:21:42 +00:00
auto-submit[bot]
47c3403c39 Reverts "Multiview pipeline" (flutter/engine#47174) 
Reverts flutter/engine#44473
Initiated by: dkwingsmt
This change reverts the following previous change:
Original Description:
This PR makes `Animator` able to handle multiple views, and updates unit tests accordingly.

Before:
<img width="543" alt="image" src="https://github.com/flutter/engine/assets/1596656/f7d0e0e4-cc85-4a6e-b516-1896ac3c1b35">

After:
<img width="614" alt="image" src="https://github.com/flutter/engine/assets/1596656/68106301-66ef-4cd1-aeaf-d9c6127ccec2">

Now `Animator::Render` must be called during `Animator::BeginFrame`, which is split into `BeginFrame` and `EndFrame`. This requirement is made possible by https://github.com/flutter/engine/pull/45555. The reason to split is to allow `ShellTest::PumpOneFrame` to insert a render from C++ code.

`ShellTest::PumpOneFrame` is also refactored to allow pumping a frame without any views.

A few unit tests are tweaked to resolve racing condition.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-20 20:57:08 +00:00
Tong Mu
1cfde62821 Multiview pipeline (flutter/engine#44473) 
This PR makes `Animator` able to handle multiple views, and updates unit tests accordingly.

Before:
<img width="543" alt="image" src="https://github.com/flutter/engine/assets/1596656/f7d0e0e4-cc85-4a6e-b516-1896ac3c1b35">

After:
<img width="614" alt="image" src="https://github.com/flutter/engine/assets/1596656/68106301-66ef-4cd1-aeaf-d9c6127ccec2">

Now `Animator::Render` must be called during `Animator::BeginFrame`, which is split into `BeginFrame` and `EndFrame`. This requirement is made possible by https://github.com/flutter/engine/pull/45555. The reason to split is to allow `ShellTest::PumpOneFrame` to insert a render from C++ code.

`ShellTest::PumpOneFrame` is also refactored to allow pumping a frame without any views.

A few unit tests are tweaked to resolve racing condition.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-20 20:38:23 +00:00
skia-flutter-autoroll
1109abdf2e Roll Skia from 9ffd5ef9a9ed to ca69b04f7dd2 (1 revision) (flutter/engine#47171) 
https://skia.googlesource.com/skia.git/+log/9ffd5ef9a9ed..ca69b04f7dd2

2023-10-20 johnstiles@google.com Fix fuzzer-discovered assertion with WGSL interface-block arrays.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 20:22:28 +00:00
John McCutchan
5f0a787cdf Lower the severity of a log message (flutter/engine#47172) 
This log message can print on the first frame of a platform view and is
not an error.
 2023-10-20 13:11:59 -07:00
Mouad Debbar
e55aecc152 [web] Remove workaround for safely removing slots on Safari (flutter/engine#47169) 
Now that we want to support multi-view, we need to either:
1. Remove the workaround to safely remove slot elements in Safari, or
2. Fix it to support multi-view (can't use `flutterViewEmbedder.glassPaneShadow` anymore).

According to [this comment](https://github.com/flutter/flutter/issues/85816#issuecomment-1122638147), this is the right time to remove the workaround 😄 I tested on Desktop Safari and iOS Safari and wasn't able to reproduce the crash reported in https://github.com/flutter/flutter/issues/84832.

Fixes https://github.com/flutter/flutter/issues/85816
Part of https://github.com/flutter/flutter/issues/134443
 2023-10-20 19:51:22 +00:00
chunhtai
bcbf0887b9 Add link support in web accessibility (flutter/engine#46117) 
fixes https://github.com/flutter/flutter/issues/134795

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-20 12:20:08 -07:00
Mouad Debbar
92eac4f833 [web] Support flutterViewId in platform view messages (flutter/engine#46891) 
- Accept a new `flutterViewId` field in platform view messages.
- Keep transitory support for legacy platform view messages that don't contain `flutterViewId`.
- Default view factories set `width:100%` and `height:100%`.
 2023-10-20 19:17:36 +00:00
Jackson Gardner
38b42c9f14 Fix async image loading issues in skwasm. (flutter/engine#47117) 
This fixes https://github.com/flutter/flutter/issues/134045

There were a few different issues here:
* We need to do our own message passing for rendering pictures. The async methods provided by emscripten have their own queue that can drain synchronously, so basically it's not guaranteed to be FIFO with other messages sent to the web worker or main thread.
* When we drop frames, we should only drop intermediate frames, so that when the rendering flurry stops that the frame that is displayed is the last one that was actually requested.
* We need to reset the GL context after lazy image creation, otherwise skia's renderer gets into a bad state for that frame.
 2023-10-20 18:30:33 +00:00
Jim Graham
076895a3e6 Add option to save Impeller failure images in rendertests (flutter/engine#47142) 
The rendering tests currently always save the impeller failure images into a temporary directory in /tmp which is out of the way and might accumulate over time.

The images are now only saved when `--save-impeller-failures` is specified on the command line and they are now saved into a local sub-directory with multiple runs saving into new sub-directories to keep the failure images from getting confused with each other over time. The new image directories are named `./impeller_failure_images/NNNN/*.png`
 2023-10-20 18:27:19 +00:00
skia-flutter-autoroll
ea20e39ff4 Roll Skia from b960e9140f56 to 9ffd5ef9a9ed (3 revisions) (flutter/engine#47167) 
https://skia.googlesource.com/skia.git/+log/b960e9140f56..9ffd5ef9a9ed

2023-10-20 lehoangquyen@chromium.org GraphiteDawn: don't set active render encoder if BlitWithDraw fails.
2023-10-20 briansalomon@gmail.com [graphite] Make RecorderOptions::kDefaultRecorderBudget a static member
2023-10-20 johnstiles@google.com Remove staging flag SK_IMPROVE_RASTER_PIPELINE_PRECISION.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 17:57:18 +00:00
Chris Bracken
acdd5bb936 [macOS] Eliminate extraneous loadView calls (flutter/engine#47166) 
Eliminate unnecessary calls to [NSViewController loadView]. To quote the [documentation][loadview] for this method: "Do not call this method. If you require this method to be called, access the view property."

In several of the existing tests, we do read viewController.view, and the other tests pass without this line regardless.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-20 17:30:16 +00:00
skia-flutter-autoroll
698ad78ecd Roll Dart SDK from ba96a157a8eb to 53fee35b299f (1 revision) (flutter/engine#47165) 
https://dart.googlesource.com/sdk.git/+log/ba96a157a8eb..53fee35b299f

2023-10-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-48.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 17:26:15 +00:00
Jonah Williams
8031a09e17 [Impeller] GPU Tracer for GLES. (flutter/engine#47080) 
Trace GPU execution time on GLES using GL_EXT_disjoint_timer_query. This requires a per-app opt in from the Android Manifest with the key `"io.flutter.embedding.android.EnableOpenGLGPUTracing` set to true.
 2023-10-20 17:20:43 +00:00
skia-flutter-autoroll
3d9bc06e13 Roll Skia from de628929015d to b960e9140f56 (2 revisions) (flutter/engine#47164) 
https://skia.googlesource.com/skia.git/+log/de628929015d..b960e9140f56

2023-10-20 armansito@google.com Add Graphite Vello Test jobs to CQ
2023-10-20 herb@google.com Add point_less_than_segment_in_x

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 17:12:17 +00:00
skia-flutter-autoroll
7c32d09946 Roll Skia from 461218cee44c to de628929015d (1 revision) (flutter/engine#47161) 
https://skia.googlesource.com/skia.git/+log/461218cee44c..de628929015d

2023-10-20 lehoangquyen@chromium.org GraphiteDawn: return error when BlitWithDrawn pipeline creation fails.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 16:31:19 +00:00
Mouad Debbar
b743fa9f2e [web] Make HotRestartCacheHandler standalone (flutter/engine#46906) 
- `EmbeddingStrategy` shouldn't own the creation of `HotRestartCacheHandler`.
- Simplify `HotRestartCacheHandler`'s JS-interop by using a `JSArray` directly instead of going through a Dart `List`.
 2023-10-20 16:05:14 +00:00
Mouad Debbar
d11e7434ff [web] Attach pointer event listeners in the bubble phase (flutter/engine#47121) 
There's no reason (that we know of) to listen to pointer events during the capture phase, so let's listen on the bubble phase.

I couldn't find a reason for listening to pointer events during the capture phase. So let's listen on the bubble phase which is more natural and allows platform views to `stopPropagation` in order to prevent Flutter from receiving an event.
 2023-10-20 16:03:15 +00:00
skia-flutter-autoroll
01e977bdb9 Roll Skia from 04a9f72abd87 to 461218cee44c (1 revision) (flutter/engine#47160) 
https://skia.googlesource.com/skia.git/+log/04a9f72abd87..461218cee44c

2023-10-20 egdaniel@google.com Add swiftshader workaround to resolve full MSAA image in dmsaa RenderPass.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 15:47:15 +00:00
skia-flutter-autoroll
0f03937049 Roll Skia from 24abc105675c to 04a9f72abd87 (1 revision) (flutter/engine#47159) 
https://skia.googlesource.com/skia.git/+log/24abc105675c..04a9f72abd87

2023-10-20 johnstiles@google.com Fix ClangTidy `performance-unnecessary-value-param` findings.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 15:06:27 +00:00
skia-flutter-autoroll
588d90e2b1 Roll Skia from e836c3aa2b98 to 24abc105675c (1 revision) (flutter/engine#47156) 
https://skia.googlesource.com/skia.git/+log/e836c3aa2b98..24abc105675c

2023-10-20 michaelludwig@google.com Revert "Re-enable invsqrt usage for normalize() in SkRP."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 14:21:14 +00:00
skia-flutter-autoroll
2c0dd1e18a Roll Skia from 17f05db514c3 to e836c3aa2b98 (1 revision) (flutter/engine#47154) 
https://skia.googlesource.com/skia.git/+log/17f05db514c3..e836c3aa2b98

2023-10-20 kjlubick@google.com Move font/typeface related functions out of ToolUtils.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-20 12:26:17 +00:00