firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
39,022 Commits 1 Branch 0 Tags
aaa3eba12d035d43d5e6b98e2dbecd93e04cd708
Commit Graph

68 Commits

Author SHA1 Message Date
David Iglesias
703e12f524 [ci] Adds test for web hot restart with const App. (#141824) 
This PR adds a test that reproduces the problem described in the linked issue: hot restart on the web seems to not update if the app being run is `const`.

The new test is expected to fail, until the `const` issue with hot restart in the web is resolved.

Expected failure mode is a 15s timeout in the following test:

```
02:31 +3 ~1 -1: Hot reload (index.html: Default) (with `const MyApp()`)): newly added code executes during hot restart [E]
  TimeoutException after 0:00:15.000000: Future not completed
  dart:async  _startMicrotaskLoop
  ...
```

(And then a bunch of output that I'm not 100% sure is intended :))

## Issues

* #141588
 2024-01-25 01:49:08 +00:00
Zachary Anderson
d773c5a9ea [flutter_tool] Delete skipped tests (#136364) 
These tests have been skipped due to flakiness for a long time.

Closes https://github.com/dart-lang/webdev/issues/1562
Closes https://github.com/flutter/flutter/issues/124214
 2023-10-11 10:24:14 -07:00
Yegor
371aadd822 [tool] fallback to sigkill when closing Chromium (#135521) 
This implements https://github.com/flutter/flutter/issues/132654#issuecomment-1738221257, namely:

Make `Chromium.close` more robust:

* Send `SIGTERM` and wait up to 5 seconds, if the process exited, great! Return from the function.
* If the process has not exited, then send a `SIGKILL`, which is a much firmer way to exit a process. Same as before, wait up to 5 seconds, if the process exited, great! Return from the function.
* If it still hasn't exited then give up trying to exit Chromium, just print a warning to the console and return from the function.

Bonus: a few nullability fixes and extra `-v` logging.

Fixes https://github.com/flutter/flutter/issues/132654
 2023-09-28 22:28:31 +00:00
Yegor
d6d2e89fc8 finer grained logging of Chromium launch sequence (#135078) 
Log the details of how Chromium is about to be launched prior to running
the Chromium command, as well as the path to the Chromium executable.

This should improve our understanding of what's happening here:
https://github.com/flutter/flutter/issues/132654#issuecomment-1726630123
 2023-09-20 15:20:16 -07:00
chunhtai
55502fc36a Add vmservice for android build options (#123034) 
https://github.com/flutter/flutter/issues/120408
 2023-04-18 18:16:09 +00:00
Bartek Pacia
e99eb40222 Update usage of standalonepub executable in flutter_tools testing docs (#124898) 
Just found this while trying to run the integration test shard of `flutter_tools` locally :)
 2023-04-17 23:34:23 +00:00
Kevin Moore
3bc07c1cef flutter-tool, web: update HTML template serviceWorkerVersion to be const (#124826) 
flutter-tool, web: update HTML template serviceWorkerVersion to be const
 2023-04-14 02:01:21 +00:00
Elliott Brooks
a3b85ba9a9 [flutter_tools] Disable flaky output_web_test test case (#124257) 
[flutter_tools] Disable flaky `output_web_test` test case
 2023-04-13 20:38:07 +00:00
Christopher Fujino
6b7c60d69a manual pub roll (#123071) 
manual pub roll
 2023-03-21 01:08:51 +00:00
Zachary Anderson
e6e99e2df5 Skip web hot restart tests (#123019) 
Related https://github.com/flutter/flutter/issues/123018
 2023-03-20 10:08:00 -07:00
Christopher Fujino
69921495eb Revert "Fix hot restart flake" (#122855) 
Landing revert on red to fix the build.
 2023-03-16 22:40:42 -07:00
Anna Gringauze
62171dfe38 Fix hot restart flake (#122776) 2023-03-16 13:11:55 -07:00
Anna Gringauze
d76860ad60 Add printing on failure to web hotrestart tests (#122115) 2023-03-07 15:35:00 -08:00
Flutter GitHub Bot
cf4ef28b94 Roll pub packages (#121569) 
Roll pub packages
 2023-02-28 03:10:07 +00:00
Pascal Welsch
25c2c22d29 Delete Chrome temp cache after closing (#119062) 
* Delete Chrome temp cache after closeing

* Update packages/flutter_tools/lib/src/web/chrome.dart

Co-authored-by: Christopher Fujino <fujino@google.com>

---------

Co-authored-by: Christopher Fujino <fujino@google.com>
 2023-02-10 17:39:58 +00:00
Christopher Fujino
d820aec786 Manual pub roll with dwds fix (#119575) 
* roll packages

* fix dwds

* empty

---------

Co-authored-by: fluttergithubbot <fluttergithubbot@gmail.com>
 2023-02-02 21:38:08 +00:00
Jackson Gardner
db1c3e208d Platform binaries reland (#115502) 
You can now specify a --local-web-sdk flag to point to a wasm_release folder. This will make it so that only artifacts that pertain to the web sdk are overridden to point to the wasm_release folder. Other artifacts (such as impellerc) will pull from the cache, or from the --local-engine path if that is specified.

This also uses precompiled platform kernel files for both ddc and dart2js
 2022-12-02 14:13:40 -08:00
Liam Appelbe
c0354999a7 Migrate packages/flutter_tools/test/web.shard (#110713) 2022-09-06 11:05:41 -07:00
Anna Gringauze
3292f89764 Update issue reference for skipped hot restart tests (#110881) 2022-09-02 14:38:24 -07:00
David Iglesias
9cb9f6bca4 [tool] Fix flutter.js regression with hot-reload on promise-based init. (#110805) 2022-09-01 22:25:16 +00:00
Zachary Anderson
c6ec84e978 [flutter_tools] Pull more arm64 artifacts on Apple Silicon (#110291) 2022-08-29 10:33:24 -07:00
Anna Gringauze
3b6e3a6938 Temporarily remove a bogus warning until fixed by dwds update (#109793) 
* Temporarily remove a bogus warning until fixed by dwds update

* Addressed CR feedback
 2022-08-19 11:06:53 -07:00
Gustl22
47f54ace45 feat(tools): Arbitrary browser flags (closes #65575) (#104935) 2022-06-24 10:14:08 -07:00
Jonah Williams
dfaec11ba5 migrate web integration tests to null safety (#106231) 2022-06-21 11:19:09 -07:00
Elliott Brooks (she/her)
fe57704594 Enable skipped test for Dart URI logs from DWDS (#105274) 2022-06-09 15:03:11 -07:00
Anna Gringauze
5cd979e441 Retry getting tabs in chrome launcher on ConnectionException (#104218) 2022-05-26 15:20:11 -07:00
Jenn Magder
a56c5e51ae Migrate some test files to null safety (#104469) 2022-05-24 16:53:08 -07:00
Anna Gringauze
29fecb5980 Provide flutter sdk kernel files to dwds launcher instead of dart ones (#103436) 
* Provide flutter sdk kernel files to dwds launcher instead of dart ones

* Update log test to report all warnings

* Update licences for new files

* Addressed CR comments

* Addressed CR comments
 2022-05-11 08:52:43 -07:00
Alexandre Ardhuin
07f1c20474 add missing trailing commas in list/set/map literals (#102585) 2022-04-27 09:15:35 +02:00
Elliott Brooks (she/her)
5414ef4c86 Hide unresolved DartUri log messages (#102338) 2022-04-22 12:43:39 -07:00
Anna Gringauze
74944d528f Run update-packages (#101450) 
* Run update-packages

* Update DwdsLauncher, disable failing test

* Fix analyze error

Co-authored-by: Jenn Magder <magder@google.com>
 2022-04-07 17:07:05 -07:00
keyonghan
c178cf859f Skip can validate flutter version in parallel test in Linux web_tool_tests (#99017) 2022-02-23 14:19:20 -08:00
Christopher Fujino
081d960237 [flutter_tools] remove flaky web vm service test (#98540) 2022-02-18 11:54:23 -08:00
Michael Goderbauer
5684b9f69e Enable no_leading_underscores_for_local_identifiers (#96422) 2022-01-21 14:43:59 -08:00
Anna Gringauze
ca62470796 De-flake web tool tests (#93948) 2021-11-30 17:39:05 -08:00
Ian Hickson
2f4e3ce5b0 Improve error message for when you're not running chromedriver (#91789) 2021-10-14 22:38:05 -07:00
Ian Hickson
61a0add286 Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0 Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461) 
This reverts commit 5fd259be24.
 2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24 Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Ian Hickson
f25b833f27 Enable avoid_print lint. (#91444) 2021-10-07 16:48:04 -07:00
Mouad Debbar
c2ea78d231 Revert "Enable avoid_print lint. (#91332)" (#91438) 
This reverts commit cb378edc9e.
 2021-10-07 16:16:17 -04:00
Ian Hickson
cb378edc9e Enable avoid_print lint. (#91332) 2021-10-07 09:53:03 -07:00
Ian Hickson
4315cdcf76 Some test cleanup for flutter_tools. (#90227) 2021-10-01 10:38:02 -07:00
Nicholas Shahan
3074c9e04b Add tests for web library platform defines (#90620) 2021-09-28 22:08:04 -07:00
Anna Gringauze
a511c436c9 Fix web_tool_tests failure on dart roll (#88914) 
Helps: https://github.com/flutter/flutter/issues/88911
 2021-08-25 18:22:21 -07:00
Anna Gringauze
831d82c8ea Fix race conditions in test_driver for tool tests (#88322) 2021-08-17 18:37:04 -07:00
Darren Austin
b08366ce7b Updated skipped tests for flutter_tools. (#87925) 
* Updated skipped tests for flutter_tools.

* Turned the flaky overall_experience test off as it was still failing on CI.
 2021-08-10 22:22:08 -07:00
Anna Gringauze
33fd4f15a9 Fix race causing null dereference on getStack in web_tool_tests and CI flakes (#87278) 2021-07-29 16:59:02 -07:00
Zachary Anderson
10e53e9981 Skip "newly added code executes during hot restart - canvaskit" (#86885) 
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20web_tool_tests/2880/overview
 2021-07-22 10:55:18 -07:00
Anna Gringauze
84c3b56877 Update dwds (and other packages) (#86832) 
* Upgrade all packages

In particular, bring in dwds with latest fixes for flakes.

Closes: https://github.com/flutter/flutter/issues/85043
Related: https://github.com/flutter/flutter/issues/85575

* Re-enable fixed tests

* Disable failing test due to DDS issue
 2021-07-21 21:47:10 -07:00