Andrew Kolos
f8b9748661
Restore and fix flavors_test_macos ( #139841 )
...
Partially resolves[^1] https://github.com/flutter/flutter/issues/139774 .
Effectively reverts https://github.com/flutter/flutter/pull/125581 .
The main change here is that I deleted and recreated the macos Xcode project for this integration test (hence the large diff). I tried fixing the existing project first, but it was set up quite differently, andâfor whatever reasonâthe integration test would get stuck trying to load `dev/integration_tests/flavors/integration_test/integration_test.dart`.
I verified that this works locally, but I don't know if it's possible to run this on the devicelab try pool to verify that it works on devicelab hardware.
[^1]: I would not close the issue until 1) this PR lands, 2) the integration test consistently passes on CI, and 3) macOS support for flavors is publicly documented.
2023-12-18 08:52:22 +00:00
Chris Bracken
e5fc6f65b9
[macOS] Remigrate principal class to NSApplication ( #124173 )
...
In #122336 we migrated the principal class from NSApplication to
FlutterApplication in the app Info.plist. We removed the need for
FlutterApplication in https://github.com/flutter/engine/pull/40929 . This
reverses the migration for anyone who previously upgraded on the Flutter
master branch.
Issue: https://github.com/flutter/flutter/issues/30735
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-05 09:05:37 -07:00
Chris Bracken
b0ad7c456e
[macOS] Eliminate explicit main window init() ( #123571 )
...
[macOS] Eliminate explicit main window init()
2023-03-28 01:35:00 +00:00
Greg Spencer
7a859f7760
Revert unintentional changes to Info.plist files ( #122896 )
...
Revert unintentional changes to Info.plist files
2023-03-17 18:18:43 +00:00
Greg Spencer
bcdab118ba
Add support for application exit requests ( #121378 )
...
Add support for application exit requests
2023-03-17 15:35:55 +00:00
Greg Spencer
c2f5bf99f1
Add macos project auto migration code for FlutterApplication ( #122336 )
...
Add macos project auto migration code for FlutterApplication
2023-03-16 01:01:03 +00:00
Alex Wallen
3348987546
Add new macos target configured for flavors ( #117352 )
...
Co-authored-by: Jenn Magder <magder@google.com >
Co-authored-by: a-wallen <stephenwallen@google.com >
2023-01-18 07:50:25 -08:00
