firka/flutter
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
29,153 Commits 1 Branch 0 Tags
a88e4cd7cbb401ed1394de5cb5ffce193f33de97
Commit Graph

29153 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Bracken
30f3a896e6 Roll engine to f306a6f7011244e5b5c7470e178760bf87560e4b (#8044) 2017-02-09 16:00:54 -08:00
Ian Hickson
581b929bc7 Actually fix the memory_nav benchmark (#8041) 2017-02-09 15:35:22 -08:00
Ian Hickson
473b67ef19 Trivial style nits (#8042) 2017-02-09 15:31:21 -08:00
Alexandre Ardhuin
00cbdb3800 prefer const constructor (#8031) 2017-02-09 15:18:49 -08:00
Alexandre Ardhuin
e151a1a438 prefer_contains (#8040) 2017-02-09 15:17:55 -08:00
Alexandre Ardhuin
60f5cbbad2 no const contructor for GlobalKey (#8038) 2017-02-09 15:17:45 -08:00
Chris Bracken
490a897382 Add quotes to example Xcode projects (#8035) 
Required to support Flutter SDK paths with spaces.
 2017-02-09 15:11:06 -08:00
Chris Bracken
3449545e80 Quote all paths in Xcode build backend (#8039) 
Required to handle Flutter SDK (and other) paths that include spaces.

Also includes general cleanup:
* Declare explicitly that we use /bin/bash, since we rely on its
  features.
* Add -- where possible, to avoid interpreting files starting in - as
  options.
* Suppress output of pushd/popd.
* Avoid stringifying arrays.
 2017-02-09 15:08:33 -08:00
Ian Hickson
9a0a69ee63 Git ignore new temporary files in dev/bots (#8033) 2017-02-09 14:29:19 -08:00
Chris Bracken
0294cf863e Improve file/dir existence check for Xcode backend (#8037) 2017-02-09 13:45:39 -08:00
Chris Bracken
5e672cbe64 Update Xcode project templates to handle paths with spaces (#8034) 2017-02-09 13:25:29 -08:00
Adam Barth
c9e4541c02 Port LazyBlock tests to ListView (#8026) 2017-02-09 10:35:24 -08:00
Adam Barth
1a61a76e21 Port scrollable_lazy_list_test.dart to ListView (#8025) 
We call the builder in slightly different ways, but the new results
seem reasonable.
 2017-02-09 10:05:00 -08:00
Mehmet Fidanboylu
ca2c54bac2 Support changing the dismissable threshold (#8007) 
* Support changing the dismissable threshold for any direction for dismissable widget.

* Fixing review comments.
 2017-02-09 09:46:43 -08:00
Alexandre Ardhuin
d1d1c50cbe prefer const constructors (#8024) 2017-02-09 00:57:38 -08:00
Adam Barth
3ca921610c Remove ScrollableGrid (#8020) 
All the clients have migrated to GridView.  Also, remove RenderGrid,
which isn't needed by GridView.
 2017-02-08 22:08:56 -08:00
Michael Goderbauer
a49c854f67 Exit Code Fixes for Windows (#8006) 
* return 1 when checks in `flutter.bat` fail
* don't assume file extension of git (depending on the system it can be `git.exe` or `git.bat`)
 2017-02-08 21:51:11 -08:00
Ian Hickson
3c065ad20f Also fix the memory_nav test... (#8023) 2017-02-08 21:51:00 -08:00
Ian Hickson
ba9d5e9248 Add tests for Baseline. (#8021) 2017-02-08 21:43:22 -08:00
Adam Barth
f68343eeec Sync CONTRIBUTING.md text with engine.git (#8004) 
* Sync CONTRIBUTING.md text with engine.git

Turns out we had very similar text in engine.git.  This patch makes the text the same by adopting the text in engine.git.

* Update CONTRIBUTING.md
 2017-02-08 20:50:29 -08:00
Adam Barth
311e77ab7c Fix main stocks screen (#8008) 
We weren't triggering a relayout when the number of children changed.

Fixes #8001
 2017-02-08 20:40:07 -08:00
Chris Bracken
2ec6b31aac Fix potential NPE in iOS doctor check (#8016) 
* Fix potential NPE in iOS doctor check

In case Xcode is not installed, the xcode-select path may be null.

* fixup! Fix potential NPE in iOS doctor check
 2017-02-08 20:04:39 -08:00
Devon Carew
b180caae4a change a few more places to use the seconds display for log output (#7995) 2017-02-08 19:47:12 -08:00
Ian Hickson
36c63e7024 Align the flutter_gallery test to the middle for better results (#8015) 2017-02-08 19:45:41 -08:00
Chris Bracken
4f05643cac Support flutter install paths containing spaces (#8014) 2017-02-08 19:27:11 -08:00
Chris Bracken
4d8395e177 Improve doctor output when Xcode installation is incomplete (#8012) 
If the developer has only installed the Xcode command-line tools,
xcode-select and some other tools may be present, but xcodebuild will be
missing. In this case, output a slightly improved message indicating
that the installation is incomplete rather than missing.
 2017-02-08 18:56:08 -08:00
xster
1cc78145fe Add logger indent option and indent nested xcode command outputs (#7867) 
* Add indent option to logger and indent non-flutter nested output

* Add a missed override

* Formatting
 2017-02-08 18:27:47 -08:00
Ian Hickson
83a4cf269f Port AppBar to Scrollable2 (#7996) 
Move the back button and drawer opening logic into the app bar.

Move the tap-status-bar-to-scroll-to-top logic to using
ScrollControllers. Provide a PrimaryScrollController and a `primary`
flag on scroll views.

Make it possible to track when a route becomes or stops being poppable.
 2017-02-08 18:16:19 -08:00
David Yang
8838a8fbfa Allow for customization of hintText style in InputField (#7942) 
* Allow for customization of hintText in InputField

* Adding tests.
 2017-02-08 17:50:53 -08:00
Michael Goderbauer
723489de02 Make dev/bots/test.dart pass on Windows (#7998) 
* disables all `flutter test` and `flutter drive` tests on Windows as those two commands are not fully implemented on Windows yet
* fixes other failures on Windows
 2017-02-08 15:57:31 -08:00
Adam Barth
1ec625ffad Remove PageableList (#7997) 
All clients have moved to PageView.
 2017-02-08 15:50:30 -08:00
Adam Barth
b4ec00c2d4 Rename manual_tests/pageable_list.dart to page_view.dart (#7986) 
This manual test has used the PageView widget for a while already.
 2017-02-08 15:23:16 -08:00
Ian Hickson
761cf15c2b Fix the SliverPadding debugPaint (#7989) 
...for the case where there's no right or bottom padding.
 2017-02-08 15:22:20 -08:00
Adam Barth
4e95701541 Switch TabBarView to PageView (#7982) 
Tabs are now fully driven by slivers.
 2017-02-08 14:55:18 -08:00
Michael Goderbauer
6d41c704b9 Preserve exit code on Windows (#7987) 2017-02-08 14:46:47 -08:00
Ian Hickson
f17e3f45a5 Fix the 'p' command in hot reload. (#7969) 
Turns out when I added tests, I broke the actual underlying functionality.
 2017-02-08 14:24:25 -08:00
Chris Bracken
ecdf99c326 Revert "Make the text shorter so that it doesn't overflow (#7970)" (#7984) 
This reverts commit ea21d0c542 which
didn't resolve the pagination control overflow issue. Commit
7425940d5b replaces this as an alternate
workaround. Once flutter/flutter#7980 is resolved, we should revert
7425940d5b and scroll instead.
 2017-02-08 13:10:01 -08:00
Michael Goderbauer
32271e9f3b Remove deprecated setup.sh and test.sh (#7976) 2017-02-08 13:00:44 -08:00
Chris Bracken
1a741cdbbe Roll engine to 4baeae886a42ca4056a3af8cd498903482b25ddf (#7961) 2017-02-08 12:51:29 -08:00
Chris Bracken
7425940d5b Prevent overflow of pagination bar with Ahem font (#7977) 
Once engine commit d49a6b110bced49fa318b0dd45bf409218df9ee5 rolls into
Flutter rolls in, we get correct font metrics for the Ahem font, used in
headless sky_shell test runs. Ahem has much wider glyphs than the system
font, which causes the PaginatedDataTable bottom bar to be much wider
and overflow the previous and next controls offscreen.

This commit reduces the number of rows such that the prev/next controls
are still just barely onscreen.
 2017-02-08 12:29:15 -08:00
Adam Barth
428023ceeb Clarify that Atom is needed only for visualizing lcov data (#7973) 
Fixes #7119
 2017-02-08 10:56:03 -08:00
Ian Hickson
ea21d0c542 Make the text shorter so that it doesn't overflow (#7970) 
The Ahem font has a much wider average text width than most fonts.
 2017-02-08 10:44:54 -08:00
Adam Barth
2116f00b5f Switch TabBar to sliver-based scrolling (#7964) 2017-02-08 10:34:15 -08:00
Adam Barth
1a066c8404 Use ListView in text_field_demo.dart (#7965) 
Now that ensureVisible works, we can use ListView instead of Block in
this demo.
 2017-02-08 10:33:49 -08:00
Alexandre Ardhuin
28defe5053 use const constructor (#7968) 2017-02-08 10:33:31 -08:00
Michael Goderbauer
be99a04dac Make bot tests portable to also run on Windows (#7954) 2017-02-08 10:05:36 -08:00
Devon Carew
d89f438699 improve the logger ui a bit for elapsed times (#7960) 
* improve the logger ui a bit for elapsed times

* invert param

* update daemon.dart
 2017-02-08 08:25:36 -08:00
Adam Barth
d29a94c379 Deploy Scrollable2.ensureVisible (#7951) 
Also, switch Stepper over to using sliver-based scrolling.
 2017-02-07 22:18:25 -08:00
Chris Bracken
2432b5205b Improve flutter doctor messages for ios-deploy (#7962) 
Differentiate between the not-installed and the out-of-date scenario.
 2017-02-07 18:52:50 -08:00
Devon Carew
f1f53460a4 remove sdk summaries (#7957) 2017-02-07 17:59:10 -08:00