Commit Graph

18842 Commits

Author SHA1 Message Date
Shi-Hao Hong
7b0f38b117 Remove intl_translation from tool integration test (#69155) 2020-10-29 14:05:39 -07:00
Shi-Hao Hong
a2b93b86f6 [gen_l10n] Add base method code comments for improved discoverability (#69016) 2020-10-29 14:03:05 -07:00
Greg Spencer
fa3d2e2116 Remove nullOk parameter from Focus.of, FocusTraversalOrder.of, and FocusTraversalGroup.of (#68917)
This removes the nullOk parameter from Focus.of, FocusTraversalOrder.of and FocusTraversalGroup.of, and creates maybeOf equivalents for each. The of methods now return non-nullable values, and the maybeOf equivalents return nullable values.
2020-10-29 14:02:09 -07:00
Greg Spencer
4fa5fe5f0b Remove nullOk from Scaffold.of and ScaffoldMessenger.of, create maybeOf for both (#68908) 2020-10-29 14:01:32 -07:00
Greg Spencer
e5f7726c7b Remove nullOk parameter from AnimatedList.of and SliverAnimatedList.of (#68925)
This removes the nullOk parameter from AnimatedList.of and SliverAnimatedList.of, and creates maybeOf equivalents for each. The of methods now return non-nullable values, and the maybeOf equivalents return nullable values.
2020-10-29 14:01:05 -07:00
Greg Spencer
85a252569b Remove nullOk parameter from Router.of and make it return a non-nullable value (#68910)
This removes the nullOk parameter from Router.of, and createsRouter.maybeOf. Router.ofnow returns a non-nullable value, and the Router.maybeOf returns a nullable value.
2020-10-29 14:00:47 -07:00
Greg Spencer
4f586fa355 Remove nullOk parameter from Shortcuts.of, Actions.find, and Actions.handler (#68921)
This removes the nullOk parameter from Shortcuts.of, Actions.find and Actions.handler and created Shortcuts.maybeOf and Actions.maybeFind. Shortcuts.of and Actions.find now return non-nullable values, and the maybe versions return a nullable value. I didn't create a non-nullable version of Actions.handler, since it needs to be able to return null if an action is not enabled, but I did remove the nullOk parameter, effectively setting it to true permanently, since setting it to false doesn't make much sense if the function can still return null when the action is not enabled.
2020-10-29 13:59:36 -07:00
Mateus Felipe C. C. Pinto
70d253b9a6 Remove references to CupertinoDialog (#68508) 2020-10-29 13:58:04 -07:00
Ian Hickson
5317330904 Remove the defaults for textBaseline (#68646) 2020-10-29 13:13:06 -07:00
Jonah Williams
246bf60fb3 [flutter_tools] allow default driver log to fail due to IO error (#69316) 2020-10-29 12:52:30 -07:00
Jonah Williams
470346f775 [flutter_tools] Reland: Stage web tests (#69264)
Enable web tool integration tests: expression evaluation, stepping, and basic hot restart
2020-10-29 09:56:28 -07:00
Jonah Williams
f68911ee1d [framework] increase threshold for compute to 50Kb (#69307) 2020-10-29 09:34:33 -07:00
Yegor
46b1b67797 fix stack frame parser (#69253) 2020-10-28 19:27:04 -07:00
Sarbagya Dhaubanjar
e5c4c4b27a replaced null check with hasContentDimensions (#69164) 2020-10-28 19:22:03 -07:00
Jonah Williams
2ceb34e6fb Revert "[flutter_tools] enable web integration tests (#69114)" (#69261)
This reverts commit d0cdfa4176.
2020-10-28 18:22:41 -07:00
Jonah Williams
7629758ed7 [flutter_tools] measure driver success and failure (#69226)
Currently we only have a test that measures if flutter drive can fail. Unfortunately it has been failing for multiple years based on the fact that the error is due to a missing Gradle config.

Add a smoke success test case, and update both tests to use the test API and the tester-device.
2020-10-28 18:15:23 -07:00
Darren Austin
69d7637796 Revert "Updated SearchDelegate to follow custom InputDecorationTheme (#55209)" (#69241) 2020-10-28 17:52:05 -07:00
Sam Rawlins
68a87ee791 Ignore "unused" analysis for dart:ui imports for web-only API. (#68814) 2020-10-28 17:47:04 -07:00
Danny Lin
62741337b8 Fix links to GitHub bug template (#68374) 2020-10-28 17:42:05 -07:00
Ian Hickson
01201b5faf Add documentation talking about ScrollPhysics.applyTo(null) (#67585) 2020-10-28 17:37:06 -07:00
Michael Goderbauer
396cd24770 Allow adding/removing onTap/onDismiss to Semantics (#69230) 2020-10-28 17:32:12 -07:00
Angjie Li
2bbd004682 Support --web-renderer options which would allow user to specify which rendering backend to use. (#68848) 2020-10-28 17:32:09 -07:00
Jonah Williams
ed5d8718c4 [flutter_tools] conditionally invoke pub run test for drive scripts based on presence of dependency (#69246)
* [flutter_tools] conditionally invoke pub run test for drive scripts based on presence of dependency
2020-10-28 17:32:05 -07:00
Jonah Williams
d0cdfa4176 [flutter_tools] enable web integration tests (#69114)
* [flutter_tools] stage web integration tests
2020-10-28 17:31:44 -07:00
Jonah Williams
735f6eec2c [flutter_tools] support ws scheme in use-existing-app (#69244) 2020-10-28 15:09:46 -07:00
David Reveman
4aad058a49 Improve resampling of up and remove events. (#69096)
* Improve resampling of up and remove events.

This improves resampling of these events by searching
for them until the next approximate sample time.

Co-authored-by: David Reveman <reveman@google.com>
2020-10-28 17:02:37 -04:00
Jonah Williams
d306c37bc4 [flutter_tools] fix --use-existing-app (#69237) 2020-10-28 13:55:29 -07:00
xubaolin
58a74af8a6 Revert "Revert "change TextEditingController.clear() behavior (#68775)" (#68920)" (#69156)
(Reland) Fixes a bug where keyboard capitalization behavior was reset by TextEditingController.clear.
2020-10-28 13:51:21 -07:00
Jacob MacDonald
506d0f09c0 opt out the listener.dart generated file (#69223) 2020-10-28 12:52:04 -07:00
Jonah Williams
8b9e9680d2 [flutter_tools] use throwToolExit in flutter drive (#69220)
* [flutter_tools] use throwToolExit

* Update drive.dart
2020-10-28 11:40:39 -07:00
xubaolin
91ab73ab23 Mouse drag should not show selection handles (#69101)
Fixes a bug where selection handles sometimes showed on web.
2020-10-28 11:24:46 -07:00
Per Classon
5434dd59a7 [Material] Add splash radius property to selection controls (#69197) 2020-10-28 11:22:04 -07:00
Michael Goderbauer
8cbc849222 Fix dropdown crash (#69211) 2020-10-28 11:17:53 -07:00
Danny Tuppeny
e71655b7e9 Include VS Code + Android Studio URLs in the No IDE message (#69194) 2020-10-28 11:17:06 -07:00
Per Classon
92d9630eaf Add side property to Chips, and resolve it and the state of Chips to be MaterialState aware (#68596) 2020-10-28 11:12:09 -07:00
Anurag Roy
f03caeafa7 Add useDeleteButtonTooltip property for Chip (#68237) 2020-10-28 11:07:04 -07:00
Konstantin Scheglov
7b86be228e Use runZonedGuarded() instead of deprecated onError. (#69160) 2020-10-28 08:43:31 -07:00
Greg Spencer
55289324c6 Remove nullOk in MediaQuery.of (#68736)
Adds MediaQuery.maybeOf to replace calling MediaQuery.of(context, nullOk: true), and removes the nullOk parameter. Also changes MediaQuery.of to return a non-nullable value, and removes many instances of the ! operator, reducing the possible places where a null dereference could occur.
2020-10-28 07:56:41 -07:00
Daniel Edrisian
35a94f70e1 Adaptive progress indicator (#69143) 2020-10-27 23:47:04 -07:00
Jacob MacDonald
fb508db94d allow 2.12 prerelease sdks in flutter_goldens[_client] (#69148) 2020-10-27 17:16:24 -07:00
Kate Lovett
b86fa13235 Add horizontal gesture support for CupertinoScrollbar (#69063) 2020-10-27 15:57:03 -07:00
Daniel Edrisian
d3a8b03574 Adaptive TextField (#68918) 2020-10-27 15:27:03 -07:00
Jonah Williams
9e5e763ebe [flutter_tools] document flutter root initialization (#67884)
Moves the flutter root initialization to a static method on the cache. This is a small step towards making this functionality non-static and instead injected like normal members - however, completely removing all of the static-ness at once was too large of a change.

Instead document and add unit tests and change existing code as little as possible.

#47161
2020-10-27 15:20:07 -07:00
Michael Goderbauer
f5ce638959 Add Directionality.maybeOf (#69117) 2020-10-27 14:44:50 -07:00
Gildásio Filho
48a9fc13d5 Updated SearchDelegate to follow custom InputDecorationTheme (#55209)
Updated SearchDelegate to follow InputDecorationTheme
2020-10-27 14:08:43 -07:00
Anurag Roy
cd690f9559 [flutter_tools] Add --verify-only flag to flutter upgrade (#68866)
* Add --verify-only flag for flutter upgrade
2020-10-27 14:06:39 -07:00
Jonah Williams
18f0a2288e [flutter_tools] update to vm_service 5.2.0, update to dwds 7.0.0 (#69067)
Rolls in several fixes to web tooling, including better handling of absolute file imports. Updates to latest vm service to unblock null safety mode query

Co-authored-by: Gary Roumanis <grouma@google.com>
Co-authored-by: Anna Gringauze <annagrin@google.com>
2020-10-27 13:55:32 -07:00
Dan Field
36f9af3f55 reland driver vm_service migration (#69126)
* One more reland of "Driver vm service (#68654)" (#69074)" (#69077)" (#69089)"

This reverts commit e5814756a2.

* pub run test
2020-10-27 11:30:24 -07:00
Justin McCandless
09dc5599dd Selecting spaces (#68227)
When attempting to select a space on mobile, Flutter will try to select the word before the space too, if one exists.
2020-10-27 11:30:07 -07:00
Yuqian Li
891bd95e1a Add clipBehavior to BoxFit doc (#68662) 2020-10-27 11:07:04 -07:00