Commit Graph

18842 Commits

Author SHA1 Message Date
Jenn Magder
3f380ca544 Swap mockito import for test/fake (#74847) 2021-01-27 16:02:44 -08:00
Greg Spencer
c05f623c6b Remove FocusTraversalGroups from the final sorted list of descendants. (#74758)
This fixes a subtle bug in the focus traversal that would leave unfocusable FocusTraversalGroup nodes in the list of sorted nodes to be traversed, causing an assert to fire if you nested a FocusTraversalGroup in another one and made its children unfocusable.
2021-01-27 15:58:08 -08:00
Jonah Williams
74bd7b6f6d [flutter_tools] opt all flutter tool libraries and tests out of null safety. (#74832)
* opt out the flutter tool

* oops EOF

* fix import

* Update tool_backend.dart

* Update daemon_client.dart

* fix more
2021-01-27 15:17:53 -08:00
Sam Rawlins
8043d6723e Remove "unnecessary" imports. (#74821) 2021-01-27 15:09:04 -08:00
Pedro Massango
a2ce206695 expose clipBehavior (#74046) 2021-01-27 14:54:46 -08:00
Phil Quitslund
4fa250f3f7 title format tweaks (#74747) 2021-01-27 14:54:05 -08:00
Michael Goderbauer
63267e9016 Make flutter create --smaple null-safe (#74844) 2021-01-27 14:44:03 -08:00
Jenn Magder
2bf560b481 Replace MockProcessManager with FakeProcessManager in process_test where possible (#74834) 2021-01-27 13:25:30 -08:00
Dan Field
1747adb630 Drop mockito for flutter_goldens (#74782) 2021-01-27 13:09:46 -08:00
Jenn Magder
fe921211df Replace MockXcode with Xcode.test in more unit tests (#74827) 2021-01-27 13:07:07 -08:00
Jonah Williams
91437a0641 [flutter_tools] delete old directories when unzipping ontop of them (#74818)
Fixes #74772

stale files from previous SDKs were getting left in the cache, confusing the analyzer.
2021-01-27 12:56:21 -08:00
Dan Field
a204f038fc Null safe migration for fuchsia_remote_debug_protocol (#74762) 2021-01-27 11:44:51 -08:00
Alexandre Ardhuin
d546e1d311 fix for upcoming lint use_named_constants (#74788) 2021-01-27 20:20:44 +01:00
Ian Hickson
37a0189773 Don't leak exceptions thrown by message channels (#74446) 2021-01-27 11:19:04 -08:00
Jenn Magder
1ad6edb8d5 Remove MockProcessManager from channel_test and other tests (#74780) 2021-01-27 11:17:29 -08:00
Jenn Magder
675fd5540e Replace MockXcode with Xcode.test in unit tests (#74777) 2021-01-27 11:04:03 -08:00
Shi-Hao Hong
c6a428d500 [State Restoration] CupertinoModalPopupRoute (#74805)
* Expose CupertinoModalPopupRoute for state restoration

* Add state restoration test, expose kCupertinoModalBarrierColor
2021-01-28 03:00:01 +08:00
Hans Muller
2d9fad09ba Added ButtonStyle.fixedSize (#74773) 2021-01-27 10:54:06 -08:00
Mouad Debbar
7f4bb1eea9 Use the shortcuts temporary solution only on web (#74768) 2021-01-27 10:49:04 -08:00
Jonah Williams
7c0300a358 [flutter] throw more specific error messages if a lerp'd type does not conform to Tween API (#74684) 2021-01-27 09:20:56 -08:00
Jonah Williams
4a1445bb1d [flutter_tools] handle further devtools NPE (#74764) 2021-01-27 09:11:26 -08:00
Dan Field
71aec53acb roll packages (#74781) 2021-01-26 21:53:04 -08:00
Jenn Magder
bf37a3964b Rename setUpMockXcodeBuildHandler -> setUpFakeXcodeBuildHandler in tests (#74778) 2021-01-26 21:19:02 -08:00
Dan Field
9eacc9ef62 drop mockito for integration_test (#74770) 2021-01-26 18:24:03 -08:00
Darren Austin
7db172b24d Added a ReorderableListView.builder constructor (#74697)
Added constructor parameters to the ReorderableList that were missing from ScrollView. Also replace a lot of doc comments with macro templates to reduce duplication.
2021-01-26 17:18:40 -08:00
Todd Volkert
5584fce36e Switch global key registry to be owned by the build owner. (#74701)
This gets away from the extra static map for global key registrations
in favor of the data structures being instance properties of the build
owner. This still allows for semantically-equivalent static access through
the binding (which in turn gives access to the build owner).

This also adds a `BuildOwner.globalKeyCount` getter to get the count
of global keys associated with widgets currently in the tree.
2021-01-26 14:28:58 -08:00
Dan Field
e4c8498795 no more mockito for fuchsia remote debug protocol (#74755) 2021-01-26 13:44:03 -08:00
Jonah Williams
fa8bf67cb6 [flutter_tools] catch errors when getting cwd (#74744) 2021-01-26 12:49:03 -08:00
xster
00143388a2 default CupertinoSliverNavigationBar's stretch to false (#74669) 2021-01-26 09:24:04 -08:00
Dan Field
d1538320d2 Roll packages to null safe (vm_service, test, etc.) (#74671) 2021-01-26 09:15:54 -08:00
Jia Hao
22f1700427 [flutter_tools] Make setting of CWD consistent for flutter test (#74622) 2021-01-25 22:34:03 -08:00
Greg Spencer
2eeeba9c09 Remove nullOk from Actions.invoke, add Actions.maybeInvoke (#74680)
This removes the nullOk parameter from Actions.invoke, and adds an Actions.maybeInvoke function. The difference is that invoke will now always (in debug mode) throw if an enabled action isn't found, and maybeInvoke will return null if an enabled action isn't found. The invoke function can still return null as the result of the invocation, though, so I purposely didn't change the return value to Object from Object?.
2021-01-25 20:52:30 -08:00
Daniel
fbc3683b18 ChoiceChip's default "selected" style in dark mode theme is unreadable #49984 (#74610) 2021-01-25 20:04:03 -08:00
Yurii Cherniavskyi
6d9e3c3fa9 Expose insetPadding and clipBehavior in SimpleDialog (#73571) 2021-01-25 19:44:05 -08:00
Jenn Magder
754bc4a594 Move android_plugin_example_app_build_test from devicelab to tool integration tests (#74685) 2021-01-25 19:23:53 -08:00
Mouad Debbar
47f8e956d3 Swap the Shortcuts widget with its child in TextField (#74683) 2021-01-25 19:19:04 -08:00
Alexandre Ardhuin
bd69fa5935 use predefined constants (#74627) 2021-01-25 18:59:05 -08:00
Darren Austin
efe8a397a8 Added some tests and comments from Shi-Hao for the ReorderableLists. (#74689) 2021-01-25 18:54:10 -08:00
xubaolin
1e7f3955ce fix a RenderBox.size access exception (#74402) 2021-01-25 18:54:05 -08:00
Greg Spencer
8f10a262c9 Remove vestigal nullOk parameter from Localizations.localeOf (#74657)
This removes the nullOk parameter on the Localizations.localeOf method. This was already changed to have a maybeLocaleOf method, but the nullOk parameter wasn't removed because some third party tests failed. Those have been updated, so this can go in now.
2021-01-25 15:04:47 -08:00
Shi-Hao Hong
c17be7194e Update localizations (#74635) 2021-01-25 14:46:07 -08:00
Jonah Williams
efcf2c664e [flutter_tools] check if process manager can find adb (#74672) 2021-01-25 14:15:23 -08:00
Jenn Magder
35000147e6 Re-add tool test general per-test timeout (#74531) 2021-01-25 12:47:01 -08:00
Ben Konyi
92427f260a Handle 'Existing VM service clients' error from old VM service instances (#74665) 2021-01-25 12:29:05 -08:00
Romain Rastel
30cf0d4a16 [integration_test] fix zip command (#74473) 2021-01-25 12:16:06 -08:00
Jonah Williams
9ba06b4d3b [flutter_tools] handle waitForExtension having no isolates (#74664) 2021-01-25 11:54:03 -08:00
Ian Hickson
5d8dfa44b6 Don't crash on narrow window widths (#74365) 2021-01-25 11:39:45 -08:00
Michael Goderbauer
b400534dc7 remove some stray nullOK mentions from docs (#74661) 2021-01-25 11:34:04 -08:00
Jenn Magder
c8e8d55365 Allow tests to override _DevFSHttpWriter._startWrite throttle time (#74545) 2021-01-25 10:58:26 -08:00
Jenn Magder
9baca0c3d7 Fail ColdRunner.attach() eagerly when device connection fails (#74543) 2021-01-25 10:54:05 -08:00